)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5481161e8a75b7371a53639d8d6e8fb914c32017","unresolved":false,"context_lines":[{"line_number":10,"context_line":"kick-start and test-init, we should throw an error and provide"},{"line_number":11,"context_line":"guidance on what to do."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also adds the argument information in print_usage."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5d4f73ff891df948f95f8dc2e3faae7c93a9f247"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_d6536e37","line":13,"updated":"2016-11-02 14:12:25.000000000","message":"this is inconsistent with other error situations and makes the output harder to read. there\u0027s a single line of error and reams of usage","commit_id":"bea3050b51882a1065c23eb85b93bcb7c4a21473"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"77e6d3fd9ae3418b6a7a4137b7a6e0d633419151","unresolved":false,"context_lines":[{"line_number":10,"context_line":"kick-start and test-init, we should throw an error and provide"},{"line_number":11,"context_line":"guidance on what to do."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also adds the argument information in print_usage."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5d4f73ff891df948f95f8dc2e3faae7c93a9f247"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_c4a9947d","line":13,"in_reply_to":"ba5da102_d6536e37","updated":"2016-11-04 15:58:14.000000000","message":"Done","commit_id":"bea3050b51882a1065c23eb85b93bcb7c4a21473"}],"integration/scripts/trovestack":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"8d16b3c10889f9c0d0ca76c54373a551c0f59a9e","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    if [ ! -f $DATASTORE_CONF ]; then"},{"line_number":677,"context_line":"        exclaim \"Datastore configuration file ${DATASTORE_CONF} not found\""},{"line_number":678,"context_line":"        DATASTORE_CONF\u003d$TROVESTACK_SCRIPTS/conf/"},{"line_number":679,"context_line":"        echo \"Choose one of the following names to be the first positional argument for kick-start and try again.\""},{"line_number":680,"context_line":"        find $DATASTORE_CONF -name *.conf | while read DATASTORE; do basename $DATASTORE .conf; done"},{"line_number":681,"context_line":"        exit 1"},{"line_number":682,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa6399be_4aa61454","line":679,"range":{"start_line":679,"start_character":13,"end_line":679,"end_character":114},"updated":"2016-10-19 17:18:34.000000000","message":"The following are the allowed names to be the first positional argument for kick-start or test-init. If your datastore name does appear in this list, add your .conf file to $TROVESTACK_SCRIPTS/conf/ directory with the appropriate name.","commit_id":"4b885a1ddd44f79a9d0712ae60e699616d2e4b20"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"7dfea51133131b50082169ddaf5f17ddc4331c5b","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    if [ ! -f $DATASTORE_CONF ]; then"},{"line_number":677,"context_line":"        exclaim \"Datastore configuration file ${DATASTORE_CONF} not found\""},{"line_number":678,"context_line":"        DATASTORE_CONF\u003d$TROVESTACK_SCRIPTS/conf/"},{"line_number":679,"context_line":"        echo \"Choose one of the following names to be the first positional argument for kick-start and try again.\""},{"line_number":680,"context_line":"        find $DATASTORE_CONF -name *.conf | while read DATASTORE; do basename $DATASTORE .conf; done"},{"line_number":681,"context_line":"        exit 1"},{"line_number":682,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa6399be_d4ae4d97","line":679,"updated":"2016-10-19 16:22:39.000000000","message":"Well the real problem is that there is not config file for a given datastore.\n\nI don\u0027t think telling the user to choose one from the existing name is necessarily a good advice. What if they added a new datastore and just forgot to create a conf for it?\n\nI think that the correct solution (not sure how well it is going to go) would be to swap the order of \u0027cmd_test_init\u0027 and \u0027cmd_build_and_upload_image\u0027 in \u0027cmd_kick_start\u0027. The build image call already detects unknown datastore names.","commit_id":"4b885a1ddd44f79a9d0712ae60e699616d2e4b20"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e131035064c77add1770ca7059e2d60e030e1575","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    if [ ! -f $DATASTORE_CONF ]; then"},{"line_number":677,"context_line":"        exclaim \"Datastore configuration file ${DATASTORE_CONF} not found\""},{"line_number":678,"context_line":"        DATASTORE_CONF\u003d$TROVESTACK_SCRIPTS/conf/"},{"line_number":679,"context_line":"        echo \"Choose one of the following names to be the first positional argument for kick-start and try again.\""},{"line_number":680,"context_line":"        find $DATASTORE_CONF -name *.conf | while read DATASTORE; do basename $DATASTORE .conf; done"},{"line_number":681,"context_line":"        exit 1"},{"line_number":682,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa6399be_8c0cc995","line":679,"range":{"start_line":679,"start_character":13,"end_line":679,"end_character":114},"in_reply_to":"fa6399be_4aa61454","updated":"2016-10-19 17:38:37.000000000","message":"As you realize, mod_confs() can be called from one of two places and therefore making a message that only talks about one is not good.\n\nSecondarily, telling the user to pick one that exists is not necessarily the right thing; rather one has to assume that the person kind-of knows what the \u0027first positional argument to kick-start\u0027 is.\n\nSo the old message was actually better because it told the person that a configuration file was in fact missing.","commit_id":"4b885a1ddd44f79a9d0712ae60e699616d2e4b20"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"edac714f7e34341ce48cf868aa008db5063681ab","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        echo \"\""},{"line_number":681,"context_line":"        find $DATASTORE_CONF -name *.conf | while read DATASTORE; do basename $DATASTORE .conf; done"},{"line_number":682,"context_line":"        exit 1"},{"line_number":683,"context_line":"    fi"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    # Append datastore specific configuration file"},{"line_number":686,"context_line":"    DATASTORE_CONF\u003d$TROVESTACK_SCRIPTS/conf/$DATASTORE_TYPE.conf"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da6895a0_eb6e0b95","line":683,"updated":"2016-10-25 18:50:49.000000000","message":"I agree with Amrith that this is too much information.  Just print a message that the datastore is required and print usage info.  Put this check at the start of the function.  Also, you said in the commit message that you added something to print_usage, but I don\u0027t see that.","commit_id":"c7d418296e7c6db94716366c625b2ea6d4a0c795"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"d6dafd3486ed76274d6f36141934101326d16e93","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        echo \"\""},{"line_number":681,"context_line":"        find $DATASTORE_CONF -name *.conf | while read DATASTORE; do basename $DATASTORE .conf; done"},{"line_number":682,"context_line":"        exit 1"},{"line_number":683,"context_line":"    fi"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    # Append datastore specific configuration file"},{"line_number":686,"context_line":"    DATASTORE_CONF\u003d$TROVESTACK_SCRIPTS/conf/$DATASTORE_TYPE.conf"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba5da102_7c648a48","line":683,"in_reply_to":"da6895a0_eb6e0b95","updated":"2016-10-31 17:33:02.000000000","message":"Done","commit_id":"c7d418296e7c6db94716366c625b2ea6d4a0c795"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5481161e8a75b7371a53639d8d6e8fb914c32017","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    if [ -z $DATASTORE_TYPE ]; then"},{"line_number":670,"context_line":"        exclaim \"Datastore argument was not specified.\""},{"line_number":671,"context_line":"        print_usage"},{"line_number":672,"context_line":"        exit 1"},{"line_number":673,"context_line":"    fi"},{"line_number":674,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ba5da102_967656d5","line":671,"updated":"2016-11-02 14:12:25.000000000","message":"this is inconsistent with the other validations; they don\u0027t print usage when there\u0027s an error.","commit_id":"bea3050b51882a1065c23eb85b93bcb7c4a21473"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"77e6d3fd9ae3418b6a7a4137b7a6e0d633419151","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    if [ -z $DATASTORE_TYPE ]; then"},{"line_number":670,"context_line":"        exclaim \"Datastore argument was not specified.\""},{"line_number":671,"context_line":"        print_usage"},{"line_number":672,"context_line":"        exit 1"},{"line_number":673,"context_line":"    fi"},{"line_number":674,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ba5da102_a4aca08d","line":671,"in_reply_to":"ba5da102_967656d5","updated":"2016-11-04 15:58:14.000000000","message":"Done","commit_id":"bea3050b51882a1065c23eb85b93bcb7c4a21473"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a5c5f48c4b260a2eca917c0b3f79671bd196e4c6","unresolved":false,"context_lines":[{"line_number":666,"context_line":"    DATASTORE_TYPE\u003d$1"},{"line_number":667,"context_line":"    exclaim \"Running mod_confs ...\""},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    if [ -z $DATASTORE_TYPE ]; then"},{"line_number":670,"context_line":"        exclaim \"Datastore argument was not specified.\""},{"line_number":671,"context_line":"        exit 1"},{"line_number":672,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7a77a97e_6109812c","line":669,"updated":"2016-11-15 13:06:21.000000000","message":"i submit to you that this is the wrong place to have this error check. Rather it should happen in cmd_test_ci and cmd_kick_start; higher up in the chain. Yes, this is a convenient place to log the error but really what you are seeing here is a failure to parse command line arguments and that should be done (I believe) much earlier.\n\nIn theory, with this change, and subsequent changes, we could end up with a half configured system which has to be ripped down and setup again, all because we had an error in the midst of processing a command.","commit_id":"39ade4c7e50fb28999428b8e68da02315484499d"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"706215212f7a3de66cefd28e23b7412bfa61baf5","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    add_flavor \u0027fault_2\u0027 31 131072 5 1"},{"line_number":765,"context_line":"}"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"function cmd_test_init() {"},{"line_number":768,"context_line":"    exclaim \u0027Initializing Configuration for Running Tests...\u0027"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    exclaim \"Installing python test packages.\""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"7a77a97e_81678be9","line":767,"updated":"2016-11-21 16:23:43.000000000","message":"Why don\u0027t we just do the test here? That should cover both cases.","commit_id":"826d4a11b9329062a46668d81f17a2e56c8d623b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6edc241247052e8477e0c9037f60f7c0b5831031","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    add_flavor \u0027fault_2\u0027 31 131072 5 1"},{"line_number":765,"context_line":"}"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"function cmd_test_init() {"},{"line_number":768,"context_line":"    exclaim \u0027Initializing Configuration for Running Tests...\u0027"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    exclaim \"Installing python test packages.\""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a74a57a_b69f5402","line":767,"in_reply_to":"7a77a97e_81678be9","updated":"2016-11-23 22:29:38.000000000","message":"today it would ... better to test higher in the stack (was my suggestion) which trevor implemented.","commit_id":"826d4a11b9329062a46668d81f17a2e56c8d623b"}]}