)]}'
{"integration/scripts/files/elements/ubuntu-guest/pre-install.d/01-trim-pkgs":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"508390e90c87f91e66e3fc5417d4d1e3d4b40868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7a77a97e_df9b1e71","updated":"2016-11-21 17:33:42.000000000","message":"Two thoughts on this - If we were to switch to using ubuntu-minimal rather than ubuntu this script would be unnecessary since -minimal wouldnt come with these packages pre-installed.\n\nIf we want to continue using ubuntu (because we want to be based on upstream cloud images, for example) we could convert this to use package-installs (http://docs.openstack.org/developer/diskimage-builder/elements/package-installs/README.html) and pkg-map (http://docs.openstack.org/developer/diskimage-builder/elements/package-installs/README.html) which would allow us to specify the various packages to uninstall based on distro/release.","commit_id":"9ee2f559223a2aa13c705c1e3fb663948d002d75"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"cfb6512fcbf581731a51508dba65c39e75db27fa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"                 apport\\"},{"line_number":12,"context_line":"                 apport-symptoms\\"},{"line_number":13,"context_line":"                 apt-transport-https\\"},{"line_number":14,"context_line":"                 apt-xapian-index\\"},{"line_number":15,"context_line":"                 aptitude\\"},{"line_number":16,"context_line":"                 at\\"},{"line_number":17,"context_line":"                 bash-completion\\"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5a74a57a_69c2d135","side":"PARENT","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":29},"updated":"2016-11-27 16:13:49.000000000","message":"hmm. so, since this file is not release dependent, it means that the ubuntu image will be bloated? does it make sense to split along release lines?","commit_id":"731ca1bdfd870a7e5cfe5112c497b1fa0795e863"}],"integration/scripts/files/elements/ubuntu-trusty-guest/install.d/20-etc":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d1fae705fea2d520b14f8d031eaa600b40bea8e1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# CONTEXT: GUEST during CONSTRUCTION as ROOT"},{"line_number":4,"context_line":"# PURPOSE: take \"staged\" trove-guest.conf file and put it in the init directory on guest image"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"dd if\u003d/tmp/in_target.d/trove-guest.service of\u003d/etc/systemd/system/trove-guest.service"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"systemctl enable trove-guest.service"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a629dbe_37cb7874","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":36},"updated":"2016-11-07 09:11:33.000000000","message":"trusty still uses upstart; this needs to be reverted","commit_id":"97b46ab40809b2fd9fec4373cb9fce510063ae47"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"9f131e3b369c2cabd3f8459923f126fe8424fba7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# CONTEXT: GUEST during CONSTRUCTION as ROOT"},{"line_number":4,"context_line":"# PURPOSE: take \"staged\" trove-guest.conf file and put it in the init directory on guest image"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"dd if\u003d/tmp/in_target.d/trove-guest.service of\u003d/etc/systemd/system/trove-guest.service"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"systemctl enable trove-guest.service"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a629dbe_3cfede6b","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":36},"in_reply_to":"9a629dbe_37cb7874","updated":"2016-11-07 19:00:26.000000000","message":"Good catch - this was a bad copy/paste...should be fixed now","commit_id":"97b46ab40809b2fd9fec4373cb9fce510063ae47"}],"integration/scripts/files/elements/ubuntu-xenial-guest/install.d/20-etc":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"508390e90c87f91e66e3fc5417d4d1e3d4b40868","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"dd if\u003d/tmp/in_target.d/trove-guest.service of\u003d/etc/systemd/system/trove-guest.service"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"systemctl enable trove-guest.service"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a77a97e_7a3e982a","line":8,"updated":"2016-11-21 17:33:42.000000000","message":"As I think you all have found out, this makes the element depend on a systmed build host.\n\nThere is an alternative way to do this which doesnt require systemd on the build host:\n\nln -s /etc/systemd/system/trove-guest.service /etc/systemd/system/multi-user.target.wants/trove-guest.service","commit_id":"9ee2f559223a2aa13c705c1e3fb663948d002d75"}],"integration/scripts/files/elements/ubuntu-xenial-mysql/install.d/30-mysql":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"508390e90c87f91e66e3fc5417d4d1e3d4b40868","unresolved":false,"context_lines":[{"line_number":34,"context_line":"_EOF_"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"rm /etc/init/mysql.conf"},{"line_number":37,"context_line":"systemctl daemon-reload"},{"line_number":38,"context_line":"systemctl enable mysql"},{"line_number":39,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a77a97e_fa10e8ad","line":37,"updated":"2016-11-21 17:33:42.000000000","message":"this shouldnt be needed when using a symlink","commit_id":"9ee2f559223a2aa13c705c1e3fb663948d002d75"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"508390e90c87f91e66e3fc5417d4d1e3d4b40868","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"rm /etc/init/mysql.conf"},{"line_number":37,"context_line":"systemctl daemon-reload"},{"line_number":38,"context_line":"systemctl enable mysql"},{"line_number":39,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a77a97e_ba4830ce","line":38,"updated":"2016-11-21 17:33:42.000000000","message":"see previous comment about using a symlink","commit_id":"9ee2f559223a2aa13c705c1e3fb663948d002d75"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"cdaef2c5e29a4d9f8f7456c64d42b9f1398284ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"add-apt-repository \u0027deb http://archive.ubuntu.com/ubuntu trusty universe\u0027"},{"line_number":12,"context_line":"apt-get -y  update"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# The fix to make versions of percona-xtrabackup \u003e v2.2 work with Trove"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5a74a57a_6bc6339b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":73},"updated":"2016-11-28 11:18:55.000000000","message":"this should be \"xenial universe\"","commit_id":"f1404703a9626614ed57d622a915289038c85616"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d1c89eb0a811d15ca31b7703a75dfe8b7e4c0754","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"add-apt-repository \u0027deb http://archive.ubuntu.com/ubuntu trusty universe\u0027"},{"line_number":12,"context_line":"apt-get -y  update"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# The fix to make versions of percona-xtrabackup \u003e v2.2 work with Trove"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5a74a57a_05420368","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":73},"in_reply_to":"5a74a57a_6bc6339b","updated":"2016-11-28 14:18:57.000000000","message":"actually scratch this, xenial repo supports only 5.7","commit_id":"f1404703a9626614ed57d622a915289038c85616"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bfec0cb6a0257dc3428a01f8890b50e179db092e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# was put into the mysql guestagent code for Mitaka. There are no current"},{"line_number":16,"context_line":"# plans to backport so we need to make sure the guest generated when the"},{"line_number":17,"context_line":"# tests are run for Kilo or Liberty get the 2.2 verson of PXB"},{"line_number":18,"context_line":"if [[ $BRANCH_OVERRIDE \u003d\u003d \"stable/kilo\" || $BRANCH_OVERRIDE \u003d\u003d \"stable/liberty\" ]]; then"},{"line_number":19,"context_line":"    PXB_VERSION_OVERRIDE\u003d\"-22\""},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"apt-get -y install mysql-client-5.6 mysql-server-5.6 percona-xtrabackup${PXB_VERSION_OVERRIDE}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"cat \u003e/etc/mysql/conf.d/no_perf_schema.cnf \u003c\u003c_EOF_"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5a74a57a_66602a02","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":2},"updated":"2016-11-28 11:50:21.000000000","message":"and this code can go; since this is a new element, I\u0027d suggest not carrying the cruft forward.","commit_id":"f1404703a9626614ed57d622a915289038c85616"}],"integration/scripts/functions":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d1fae705fea2d520b14f8d031eaa600b40bea8e1","unresolved":false,"context_lines":[{"line_number":192,"context_line":"# Sets ``DISTRO`` from the ``os_*`` values"},{"line_number":193,"context_line":"function GetDistro() {"},{"line_number":194,"context_line":"    GetOSVersion"},{"line_number":195,"context_line":"    if [[ \"$os_VENDOR\" \u003d~ (Ubuntu) || \"$os_VENDOR\" \u003d~ (Debian) ]]; then"},{"line_number":196,"context_line":"        DISTRO_NAME\u003dubuntu"},{"line_number":197,"context_line":"        DISTRO_RELEASE\u003d$os_CODENAME"},{"line_number":198,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Fedora) ]]; then"},{"line_number":199,"context_line":"        DISTRO_NAME\u003dfedora"},{"line_number":200,"context_line":"        DISTRO_RELEASE\u003d$os_RELEASE"},{"line_number":201,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (openSUSE) ]]; then"},{"line_number":202,"context_line":"        DISTRO_NAME\u003dopensuse"},{"line_number":203,"context_line":"        DISTRO_RELEASE\u003d$os_RELEASE"},{"line_number":204,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (SUSE LINUX) ]]; then"},{"line_number":205,"context_line":"        DISTRO_NAME\u003dsle"},{"line_number":206,"context_line":"        # For SLE, also use the service pack"},{"line_number":207,"context_line":"        if [[ -z \"$os_UPDATE\" ]]; then"},{"line_number":208,"context_line":"            DISTRO_RELEASE\u003d$os_RELEASE"},{"line_number":209,"context_line":"        else"},{"line_number":210,"context_line":"            DISTRO_RELEASE\u003d\"${os_RELEASE}sp${os_UPDATE}\""},{"line_number":211,"context_line":"        fi"},{"line_number":212,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Red Hat) || \"$os_VENDOR\" \u003d~ (CentOS) ]]; then"},{"line_number":213,"context_line":"        # Drop the . release as we assume it\u0027s compatible"},{"line_number":214,"context_line":"        DISTRO_NAME\u003drhel"},{"line_number":215,"context_line":"        DISTRO_RELEASE\u003d${os_RELEASE::1}"},{"line_number":216,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (XenServer) ]]; then"},{"line_number":217,"context_line":"        DISTRO_NAME\u003dxs"},{"line_number":218,"context_line":"        DISTRO_RELEASE\u003d$os_RELEASE"},{"line_number":219,"context_line":"    else"},{"line_number":220,"context_line":"        # Catch-all for now is Vendor + Release + Update"},{"line_number":221,"context_line":"        DISTRO_NAME\u003d$os_VENDOR"},{"line_number":222,"context_line":"        DISTRO_RELEASE\u003d$os_RELEASE.$os_UPDATE"},{"line_number":223,"context_line":"    fi"},{"line_number":224,"context_line":"    export DISTRO_NAME"},{"line_number":225,"context_line":"    export DISTRO_RELEASE"},{"line_number":226,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a629dbe_b7f2286e","line":223,"range":{"start_line":195,"start_character":0,"end_line":223,"end_character":6},"updated":"2016-11-07 09:11:33.000000000","message":"just wondering if this should be converted to a case statement instead of nested if; less confusion, more clear","commit_id":"97b46ab40809b2fd9fec4373cb9fce510063ae47"}],"integration/scripts/functions_qemu":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"cfb6512fcbf581731a51508dba65c39e75db27fa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    if [ $DISTRO \u003d\u003d \u0027ubuntu\u0027 ]; then"},{"line_number":22,"context_line":"        export DIB_RELEASE\u003d$RELEASE"},{"line_number":23,"context_line":"        export DIB_CLOUD_IMAGES\u003dcloud-images.ubuntu.com"},{"line_number":24,"context_line":"        # Use the apt sources.list on the build host, its almost always preferred"},{"line_number":25,"context_line":"        #if [ -f /etc/apt/sources.list ]; then"},{"line_number":26,"context_line":"        #    export DIB_APT_SOURCES\u003d/etc/apt/sources.list"},{"line_number":27,"context_line":"        #    EXTRA_ELEMENTS\u003d\"apt-sources apt-conf-dir\""},{"line_number":28,"context_line":"        #fi"},{"line_number":29,"context_line":"    fi"},{"line_number":30,"context_line":"    if [ $DISTRO \u003d\u003d \u0027fedora\u0027 ]; then"},{"line_number":31,"context_line":"        EXTRA_ELEMENTS\u003dselinux-permissive"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5a74a57a_09015d6a","line":28,"range":{"start_line":24,"start_character":0,"end_line":28,"end_character":11},"updated":"2016-11-27 16:13:49.000000000","message":"we c(sh)ould delete this block.","commit_id":"f1404703a9626614ed57d622a915289038c85616"}]}