)]}'
{"tools/trove-pylint.py":[{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"10c22422cc7bd90b45804a407e4326d9552d46b9","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        try:"},{"line_number":317,"context_line":"            self.config.load()"},{"line_number":318,"context_line":"        except Exception:"},{"line_number":319,"context_line":"            print(\"An error occured while loading configuration, failing.\")"},{"line_number":320,"context_line":"            exit(1)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        (files_processed,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_e75a0e50","line":319,"updated":"2016-11-14 15:48:13.000000000","message":"Is that all the information we plan to return? Wouldn\u0027t the json lib exception distinguish between file access, existence, format, etc and shouldn\u0027t the error message reflect that?","commit_id":"a2f94797f3c65cfcb2b880943d203a44cf170c4d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"63f070c0546079a8761fef155d4ed341fae65002","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        try:"},{"line_number":317,"context_line":"            self.config.load()"},{"line_number":318,"context_line":"        except Exception:"},{"line_number":319,"context_line":"            print(\"An error occured while loading configuration, failing.\")"},{"line_number":320,"context_line":"            exit(1)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        (files_processed,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_683b2b9d","line":319,"in_reply_to":"9a629dbe_e75a0e50","updated":"2016-11-14 16:33:14.000000000","message":"sure, we can do that also ...","commit_id":"a2f94797f3c65cfcb2b880943d203a44cf170c4d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e1f9f69abe50627918f2c3d2552f3fb6167025c2","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            self.config.load()"},{"line_number":318,"context_line":"        except Exception:"},{"line_number":319,"context_line":"            print(\"An error occured while loading configuration, failing.\")"},{"line_number":320,"context_line":"            exit(1)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        (files_processed,"},{"line_number":323,"context_line":"         files_with_errors,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_82e6a0e6","line":320,"range":{"start_line":320,"start_character":12,"end_line":320,"end_character":19},"updated":"2016-11-14 16:05:41.000000000","message":"return 1 instead of exit(1). Delaying the call to the global check is what I meant because those functions are already expected to call exit. That way when LintRunner.check fails we know we will have a non-zero integer to handle the call better. But... it\u0027s an internal tool, so whatever works for us I guess right?","commit_id":"a2f94797f3c65cfcb2b880943d203a44cf170c4d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"63f070c0546079a8761fef155d4ed341fae65002","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            self.config.load()"},{"line_number":318,"context_line":"        except Exception:"},{"line_number":319,"context_line":"            print(\"An error occured while loading configuration, failing.\")"},{"line_number":320,"context_line":"            exit(1)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        (files_processed,"},{"line_number":323,"context_line":"         files_with_errors,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_485d87eb","line":320,"range":{"start_line":320,"start_character":12,"end_line":320,"end_character":19},"in_reply_to":"9a629dbe_82e6a0e6","updated":"2016-11-14 16:33:14.000000000","message":"sure, can do that too ...","commit_id":"a2f94797f3c65cfcb2b880943d203a44cf170c4d"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"efff71b4e2ec562e41d47eb71bf56b2b0a976203","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            json.dump(self.sort_config(), fp, encoding\u003d\"utf-8\","},{"line_number":79,"context_line":"                      indent\u003d2, separators\u003d(\u0027,\u0027, \u0027: \u0027))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def load(self, filename\u003dDEFAULT_CONFIG_FILE):"},{"line_number":82,"context_line":"        with open(filename) as fp:"},{"line_number":83,"context_line":"            self.config \u003d json.load(fp, encoding\u003d\"utf-8\")"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_39a472b8","line":81,"updated":"2016-11-18 16:44:00.000000000","message":"This was returning self before but the value does not seem to be used anywhere so it should be fine.","commit_id":"da2dc0afac6dd2acd498f4c650669af08fb179dd"}]}