)]}'
{"trove/tests/int_tests.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e69b6d608671b835f1e6d61d9d4be9d69c405511","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    [\"redis_supported\"],"},{"line_number":334,"context_line":"    single\u003d[common_groups,"},{"line_number":335,"context_line":"            backup_groups,"},{"line_number":336,"context_line":"            replication_promote_groups, ],"},{"line_number":337,"context_line":"    multi\u003d[cluster_actions_groups, ]"},{"line_number":338,"context_line":")"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_d00cd896","line":336,"range":{"start_line":336,"start_character":12,"end_line":336,"end_character":40},"updated":"2016-11-23 21:14:03.000000000","message":"this should be in multi","commit_id":"062c1c039368f3291e251597ed41011f99f39a01"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cf70f409d9e689a05a6d63604f07adf45922a926","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    return out"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register(datastores, *test_groups, **kwargs):"},{"line_number":73,"context_line":"    if kwargs:"},{"line_number":74,"context_line":"        register(datastores, kwargs.values())"},{"line_number":75,"context_line":"        for suffix, grp_set in kwargs.items():"},{"line_number":76,"context_line":"            register([ds + \u0027_\u0027 + suffix for ds in datastores], *grp_set)"},{"line_number":77,"context_line":"        return"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    proboscis.register(groups\u003dbuild_group(datastores),"},{"line_number":80,"context_line":"                       depends_on_groups\u003dbuild_group(*test_groups))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_d5273862","line":77,"range":{"start_line":72,"start_character":0,"end_line":77,"end_character":14},"updated":"2016-11-24 18:41:03.000000000","message":"Looking at the gate jobs, it might be better to support \u0027-\u0027 as well as \u0027_\u0027 in the names.  How about doing something like:\n\n    def register(group_names, *test_groups, **kwargs):\n        if kwargs:\n            register(group_names, kwargs.values())\n            for suffix, grp_set in kwargs.items():\n                # Recursively call without the kwargs\n                register([name + \u0027_\u0027 + suffix for name in group_names], *grp_set)\n            return\n\n        # Do the actual registration here\n        proboscis.register(groups\u003dbuild_group(group_names),\n                           depends_on_groups\u003dbuild_group(*test_groups))\n        # Now register the same groups with \u0027-\u0027 instead of \u0027_\u0027\n        proboscis.register(groups\u003dbuild_group(\n                           [name.replace(\u0027_\u0027, \u0027-\u0027) for name in group_names]),\n                           depends_on_groups\u003dbuild_group(*test_groups))","commit_id":"4f8364b0fcc1a79e252b4e522d43f2c6129c903e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"0b77fd01bbf21b29a6bac77896bd86a0935afc4a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            register([name + \u0027_\u0027 + suffix for name in group_names], *grp_set)"},{"line_number":78,"context_line":"        return"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # Do the actual registration here"},{"line_number":81,"context_line":"    proboscis.register(groups\u003dbuild_group(group_names),"},{"line_number":82,"context_line":"                       depends_on_groups\u003dbuild_group(*test_groups))"},{"line_number":83,"context_line":"    # Now register the same groups with \u0027-\u0027 instead of \u0027_\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_4af9be4c","line":80,"updated":"2016-11-24 22:52:50.000000000","message":"this restructuring is confusing because it is a recursive call now.","commit_id":"93f1ae8f09cf68cec62459822dfe39baf43a37a8"}]}