)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"42ce4f55d4d988f0569c3773e3f093ff1a6d9bd9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"files in the trove/integration folder."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I292b6760e96e71abd7019881b95926cba7ce09fe"},{"line_number":20,"context_line":"Closes-Bug: #1642554"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_f6546c55","line":20,"updated":"2016-11-23 22:27:50.000000000","message":"Partial-Bug:","commit_id":"77ac7ada5c2cb77895655c73937f301828f0e7bd"}],"integration/tests/integration/int_tests.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7b220e18ba4d52d626ff14e4a5e2e7bbc8fc16f9","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        elif arg[:14] \u003d\u003d \"--config-file\u003d\":"},{"line_number":170,"context_line":"            rdl_config_file \u003d arg[14:]"},{"line_number":171,"context_line":"        elif arg[:13] \u003d\u003d \"--nova-flags\u003d\":"},{"line_number":172,"context_line":"            # TODO(lamt): nova_flag_file is not used anywhere, may be"},{"line_number":173,"context_line":"            # we can remove this flag?"},{"line_number":174,"context_line":"            nova_flag_file \u003d arg[13:]  # noqa"},{"line_number":175,"context_line":"        elif arg.startswith(\u0027--hide-elapsed\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_2d4d7c6c","line":172,"updated":"2016-11-24 23:18:12.000000000","message":"if we aren\u0027t using the flag, for the purpose of this change I\u0027d either (a) add a warning and ignore it, or (b) bomb out. Either way, if someone is specifying it, we\u0027ll know about it.\n\npersonally, I\u0027d do (b) and see if it passed the CI. If it does, then I\u0027d submit a change with (a) for posterity.","commit_id":"7e7bb449662f1a6abcad4947ab812fdf02d7e869"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"695c7fb64699fdc1a6c8ba06ca8c6ca9df9e4d05","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        elif arg[:14] \u003d\u003d \"--config-file\u003d\":"},{"line_number":170,"context_line":"            rdl_config_file \u003d arg[14:]"},{"line_number":171,"context_line":"        elif arg[:13] \u003d\u003d \"--nova-flags\u003d\":"},{"line_number":172,"context_line":"            # TODO(lamt): nova_flag_file is not used anywhere, may be"},{"line_number":173,"context_line":"            # we can remove this flag?"},{"line_number":174,"context_line":"            nova_flag_file \u003d arg[13:]  # noqa"},{"line_number":175,"context_line":"        elif arg.startswith(\u0027--hide-elapsed\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_f96986bf","line":172,"in_reply_to":"5a74a57a_2d4d7c6c","updated":"2016-11-25 03:29:42.000000000","message":"Removed ``nova_flag_file`` and raise an exception to see if CI will fail.  I will submit a final change to (a) if it passes.","commit_id":"7e7bb449662f1a6abcad4947ab812fdf02d7e869"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2f550e34495a93b2b2d6b5d5eadf6857cf44c751","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    # run its functional tests only."},{"line_number":124,"context_line":"    ADD_DOMAINS \u003d os.environ.get(\"ADD_DOMAINS\", \"False\") \u003d\u003d \u0027True\u0027"},{"line_number":125,"context_line":"    if not ADD_DOMAINS:"},{"line_number":126,"context_line":"        from tests.api import delete_all"},{"line_number":127,"context_line":"        from tests.api import instances_pagination"},{"line_number":128,"context_line":"        from tests.api import instances_quotas"},{"line_number":129,"context_line":"        from tests.api import instances_states"},{"line_number":130,"context_line":"        from tests.dns import dns"},{"line_number":131,"context_line":"        from tests import initialize"},{"line_number":132,"context_line":"        from tests.smoke import instance"},{"line_number":133,"context_line":"        from tests.volumes import driver"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # Groups that exist as core int-tests are registered from the"},{"line_number":136,"context_line":"        # trove.tests.int_tests module"},{"line_number":137,"context_line":"        from trove.tests import int_tests"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Groups defined in trove/integration, or any other externally"},{"line_number":140,"context_line":"        # defined groups can be registered here"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_39b400f1","side":"PARENT","line":137,"range":{"start_line":126,"start_character":1,"end_line":137,"end_character":41},"updated":"2016-12-08 18:12:03.000000000","message":"this is bad bad bad bad bad bad bad bad and bad","commit_id":"47fafc69f4e4452b34dd21f5d10caea504186250"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"9882ce0cc48edc9d313ae44833a912cfb936f5c2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    # run its functional tests only."},{"line_number":124,"context_line":"    ADD_DOMAINS \u003d os.environ.get(\"ADD_DOMAINS\", \"False\") \u003d\u003d \u0027True\u0027"},{"line_number":125,"context_line":"    if not ADD_DOMAINS:"},{"line_number":126,"context_line":"        from tests.api import delete_all"},{"line_number":127,"context_line":"        from tests.api import instances_pagination"},{"line_number":128,"context_line":"        from tests.api import instances_quotas"},{"line_number":129,"context_line":"        from tests.api import instances_states"},{"line_number":130,"context_line":"        from tests.dns import dns"},{"line_number":131,"context_line":"        from tests import initialize"},{"line_number":132,"context_line":"        from tests.smoke import instance"},{"line_number":133,"context_line":"        from tests.volumes import driver"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # Groups that exist as core int-tests are registered from the"},{"line_number":136,"context_line":"        # trove.tests.int_tests module"},{"line_number":137,"context_line":"        from trove.tests import int_tests"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Groups defined in trove/integration, or any other externally"},{"line_number":140,"context_line":"        # defined groups can be registered here"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_dc721a11","side":"PARENT","line":137,"range":{"start_line":126,"start_character":1,"end_line":137,"end_character":41},"in_reply_to":"3a71b18c_39b400f1","updated":"2016-12-08 18:36:44.000000000","message":"Interesting.  I will reinclude this with a #noqa for this pep8 exericse so the int test is included via the import.","commit_id":"47fafc69f4e4452b34dd21f5d10caea504186250"}],"integration/tests/integration/tests/dns/concurrency.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7b220e18ba4d52d626ff14e4a5e2e7bbc8fc16f9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"if CONFIG.white_box:"},{"line_number":52,"context_line":"    from nova import flags"},{"line_number":53,"context_line":"    from nova import utils"},{"line_number":54,"context_line":"    from trove.dns.rsdns.driver import RsDnsInstanceEntryFactory"},{"line_number":55,"context_line":"    FLAGS \u003d flags.FLAGS"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_6d9cd4c0","line":54,"updated":"2016-11-24 23:18:12.000000000","message":"wow, this is still around?","commit_id":"7e7bb449662f1a6abcad4947ab812fdf02d7e869"}],"integration/tests/integration/tests/util/report.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7b220e18ba4d52d626ff14e4a5e2e7bbc8fc16f9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    self.log(\"ERROR logging %s for instance id %s! : %s\""},{"line_number":60,"context_line":"                             % (path, id, err))"},{"line_number":61,"context_line":"            else:"},{"line_number":62,"context_line":"                # TODO(name): Can we somehow capture these (maybe SSH to"},{"line_number":63,"context_line":"                # the VM)?"},{"line_number":64,"context_line":"                pass"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_ada6ec0d","line":62,"range":{"start_line":62,"start_character":23,"end_line":62,"end_character":27},"updated":"2016-11-24 23:18:12.000000000","message":"yes?","commit_id":"7e7bb449662f1a6abcad4947ab812fdf02d7e869"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2f8c49d7102e26cdf5a360c822685f25fb83e170","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    self.log(\"ERROR logging %s for instance id %s! : %s\""},{"line_number":60,"context_line":"                             % (path, id, err))"},{"line_number":61,"context_line":"            else:"},{"line_number":62,"context_line":"                # TODO(name): Can we somehow capture these (maybe SSH to"},{"line_number":63,"context_line":"                # the VM)?"},{"line_number":64,"context_line":"                pass"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_62accda0","line":62,"range":{"start_line":62,"start_character":23,"end_line":62,"end_character":27},"in_reply_to":"5a74a57a_193e42b8","updated":"2016-11-25 13:15:44.000000000","message":"not really; if you want to know what (name) should be you can go look at git logs. But, I couldn\u0027t care less about that. Even if you remove the TODO(name) and just leave the rest of the comment, it should suffice. No one would have looked at that todo anyway and this is a purely internal file.\n\nThe value in the rest of your commit far outweighs this little nit so take the most expedient path forward.","commit_id":"7e7bb449662f1a6abcad4947ab812fdf02d7e869"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"004859cbea6453a4c32cb6cc7c51cf66e74a69a8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    self.log(\"ERROR logging %s for instance id %s! : %s\""},{"line_number":60,"context_line":"                             % (path, id, err))"},{"line_number":61,"context_line":"            else:"},{"line_number":62,"context_line":"                # TODO(name): Can we somehow capture these (maybe SSH to"},{"line_number":63,"context_line":"                # the VM)?"},{"line_number":64,"context_line":"                pass"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_dfabb373","line":62,"range":{"start_line":62,"start_character":23,"end_line":62,"end_character":27},"in_reply_to":"5a74a57a_62accda0","updated":"2016-11-25 15:36:36.000000000","message":"Done","commit_id":"7e7bb449662f1a6abcad4947ab812fdf02d7e869"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"695c7fb64699fdc1a6c8ba06ca8c6ca9df9e4d05","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    self.log(\"ERROR logging %s for instance id %s! : %s\""},{"line_number":60,"context_line":"                             % (path, id, err))"},{"line_number":61,"context_line":"            else:"},{"line_number":62,"context_line":"                # TODO(name): Can we somehow capture these (maybe SSH to"},{"line_number":63,"context_line":"                # the VM)?"},{"line_number":64,"context_line":"                pass"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_193e42b8","line":62,"range":{"start_line":62,"start_character":23,"end_line":62,"end_character":27},"in_reply_to":"5a74a57a_ada6ec0d","updated":"2016-11-25 03:29:42.000000000","message":"Changed the TODO message from a question to a statement.  I can open a bug in l-pad to track this if you like - since it is outside the scope of this patch set.","commit_id":"7e7bb449662f1a6abcad4947ab812fdf02d7e869"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"bda8a1f5750805809690a924d45d897aa0eb077c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                    self.log(\"ERROR logging %s for instance id %s! : %s\""},{"line_number":50,"context_line":"                             % (path, id, err))"},{"line_number":51,"context_line":"            else:"},{"line_number":52,"context_line":"                #TODO: Can we somehow capture these (maybe SSH to the VM)?"},{"line_number":53,"context_line":"                pass"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        save_file(\"/var/log/firstboot\", \"firstboot\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_26baf40a","side":"PARENT","line":52,"range":{"start_line":52,"start_character":17,"end_line":52,"end_character":22},"updated":"2016-12-09 15:25:52.000000000","message":"so this case you delete the TODO and  everywhere else it is changed to \"TODO(name)\" can we decide if we want TODOs or not and if we decide to delete the TODO part is the whole comment still necessary? I remember that the common opinion is that we DON\u0027T want TODOs but instead to report bugs for those TODOs if necessary.","commit_id":"47fafc69f4e4452b34dd21f5d10caea504186250"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"02baca596808508dfbaf0fe6e63ee91dfd5f35f2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    self.log(\"ERROR logging %s for instance id %s! : %s\""},{"line_number":60,"context_line":"                             % (path, id, err))"},{"line_number":61,"context_line":"            else:"},{"line_number":62,"context_line":"                # Can we somehow capture these (maybe SSH to the VM)?"},{"line_number":63,"context_line":"                pass"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        save_file(\"/var/log/firstboot\", \"firstboot\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_27474e4c","line":62,"updated":"2016-12-09 16:07:16.000000000","message":"Re-raising this, will leave it up to others opinion.\n\n\u003e so this case you delete the TODO and  everywhere else it is changed to \"TODO(name)\" can we decide if we want TODOs or not and if we decide to delete the TODO part is the whole comment still necessary? I remember that the common opinion is that we DON\u0027T want TODOs but instead to report bugs for those TODOs if necessary.","commit_id":"1248a50fcbdf0e7d343663699e996483560e7f8b"}],"integration/tests/integration/tests/volumes/driver.py":[{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"daff0de496315d16c1706b14a3095b08727d4d85","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        info \u003d self.story.api.get_storage_device_info(self.story.context)"},{"line_number":298,"context_line":"        print(\"device_info : %r\" % info)"},{"line_number":299,"context_line":"        self.assertNotEqual(info, None,"},{"line_number":300,"context_line":"                            \"the storage device information should exist\")"},{"line_number":301,"context_line":"        self.assertEqual(self.story.original_device_info[\u0027raw_total\u0027],"},{"line_number":302,"context_line":"                         info[\u0027raw_total\u0027])"},{"line_number":303,"context_line":"        volume_size \u003d int(self.story.volume[\u0027size\u0027]) * (1024 ** 3) * 2"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_a3fec2ab","side":"PARENT","line":300,"range":{"start_line":300,"start_character":28,"end_line":300,"end_character":73},"updated":"2016-11-28 02:43:56.000000000","message":"Looks good, only a small question, these outputs message do not need?","commit_id":"47fafc69f4e4452b34dd21f5d10caea504186250"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"994a2d3eb854f950e5718a487a7c029e82fc94b3","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        info \u003d self.story.api.get_storage_device_info(self.story.context)"},{"line_number":298,"context_line":"        print(\"device_info : %r\" % info)"},{"line_number":299,"context_line":"        self.assertNotEqual(info, None,"},{"line_number":300,"context_line":"                            \"the storage device information should exist\")"},{"line_number":301,"context_line":"        self.assertEqual(self.story.original_device_info[\u0027raw_total\u0027],"},{"line_number":302,"context_line":"                         info[\u0027raw_total\u0027])"},{"line_number":303,"context_line":"        volume_size \u003d int(self.story.volume[\u0027size\u0027]) * (1024 ** 3) * 2"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_8fd9d224","side":"PARENT","line":300,"range":{"start_line":300,"start_character":28,"end_line":300,"end_character":73},"in_reply_to":"5a74a57a_a3fec2ab","updated":"2016-11-28 13:41:03.000000000","message":"Good catch.  Adding the msg to the assert in the next patch.","commit_id":"47fafc69f4e4452b34dd21f5d10caea504186250"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"bda8a1f5750805809690a924d45d897aa0eb077c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        story_context \u003d self.story.context"},{"line_number":151,"context_line":"        device_info \u003d self.story.api.get_storage_device_info(story_context)"},{"line_number":152,"context_line":"        print(\"device_info : %r\" % device_info)"},{"line_number":153,"context_line":"        self.assertIsNotNone("},{"line_number":154,"context_line":"            device_info, msg\u003d\"the storage device information should exist\")"},{"line_number":155,"context_line":"        self.story.original_device_info \u003d device_info"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @time_out(60)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_8682e8fe","line":154,"range":{"start_line":153,"start_character":8,"end_line":154,"end_character":29},"updated":"2016-12-09 15:25:52.000000000","message":"Usage of assertIsNotNone is not required by pep8. Although I\u0027m not against the change, you may want to leave these the way they were to respect the scope of the patch. Typically we require a hacking rule for these kind of changes.","commit_id":"18ce832727cf28c51ed806c7e65e9545c1a7110a"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"1d540a4aaac5bc49cddb25501f1ef7b64cdd6b34","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        story_context \u003d self.story.context"},{"line_number":151,"context_line":"        device_info \u003d self.story.api.get_storage_device_info(story_context)"},{"line_number":152,"context_line":"        print(\"device_info : %r\" % device_info)"},{"line_number":153,"context_line":"        self.assertIsNotNone("},{"line_number":154,"context_line":"            device_info, msg\u003d\"the storage device information should exist\")"},{"line_number":155,"context_line":"        self.story.original_device_info \u003d device_info"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @time_out(60)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_4c74719b","line":154,"range":{"start_line":153,"start_character":8,"end_line":154,"end_character":29},"in_reply_to":"3a71b18c_017882f1","updated":"2016-12-09 15:51:47.000000000","message":"If you leave it the way it is, it passes pep8 even with H203 enabled in tox.ini","commit_id":"18ce832727cf28c51ed806c7e65e9545c1a7110a"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6067e38499ca632b7b868a96dde4a208f6416c5a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        story_context \u003d self.story.context"},{"line_number":151,"context_line":"        device_info \u003d self.story.api.get_storage_device_info(story_context)"},{"line_number":152,"context_line":"        print(\"device_info : %r\" % device_info)"},{"line_number":153,"context_line":"        self.assertIsNotNone("},{"line_number":154,"context_line":"            device_info, msg\u003d\"the storage device information should exist\")"},{"line_number":155,"context_line":"        self.story.original_device_info \u003d device_info"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @time_out(60)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_0c0439be","line":154,"range":{"start_line":153,"start_character":8,"end_line":154,"end_character":29},"in_reply_to":"3a71b18c_4c74719b","updated":"2016-12-09 15:52:36.000000000","message":"wait, I meant to say I had assertIsNotEqual. This change is fine.","commit_id":"18ce832727cf28c51ed806c7e65e9545c1a7110a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"030eb349762b37e90b799f4bcd0ec23d56fa6bd6","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        story_context \u003d self.story.context"},{"line_number":151,"context_line":"        device_info \u003d self.story.api.get_storage_device_info(story_context)"},{"line_number":152,"context_line":"        print(\"device_info : %r\" % device_info)"},{"line_number":153,"context_line":"        self.assertIsNotNone("},{"line_number":154,"context_line":"            device_info, msg\u003d\"the storage device information should exist\")"},{"line_number":155,"context_line":"        self.story.original_device_info \u003d device_info"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @time_out(60)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_017882f1","line":154,"range":{"start_line":153,"start_character":8,"end_line":154,"end_character":29},"in_reply_to":"3a71b18c_8682e8fe","updated":"2016-12-09 15:40:59.000000000","message":"It is not required by pep8, but it will violate hacking checks H203.  https://github.com/openstack-dev/hacking/blob/08782af8691594b3c90540f45ce015932b7c0968/hacking/checks/except_checks.py#L105-L135","commit_id":"18ce832727cf28c51ed806c7e65e9545c1a7110a"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"bda8a1f5750805809690a924d45d897aa0eb077c","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    def test_20_initialize_the_second_time_will_not_format(self):"},{"line_number":492,"context_line":"        \"\"\"If initialize is called but a UUID exists, it should not format.\"\"\""},{"line_number":493,"context_line":"        old_uuid \u003d self.story.get_volume()[\u0027uuid\u0027]"},{"line_number":494,"context_line":"        self.assertIsNotNone(old_uuid)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        class VolumeClientNoFmt(volume.Client):"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_66f14c6a","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":38},"updated":"2016-12-09 15:25:52.000000000","message":"Same point here about assertIsNotNone. I\u0027m not against the change but some consistency would be nice. So you change this one but not the one on Line 478? I think we should just stick to changing pep8 errors only to get this merged faster.","commit_id":"18ce832727cf28c51ed806c7e65e9545c1a7110a"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"1d540a4aaac5bc49cddb25501f1ef7b64cdd6b34","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    def test_20_initialize_the_second_time_will_not_format(self):"},{"line_number":492,"context_line":"        \"\"\"If initialize is called but a UUID exists, it should not format.\"\"\""},{"line_number":493,"context_line":"        old_uuid \u003d self.story.get_volume()[\u0027uuid\u0027]"},{"line_number":494,"context_line":"        self.assertIsNotNone(old_uuid)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        class VolumeClientNoFmt(volume.Client):"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_6c3a0d9a","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":38},"in_reply_to":"3a71b18c_611bf680","updated":"2016-12-09 15:51:47.000000000","message":"assertTrue is not in the list of checks for H203, no need for this change.","commit_id":"18ce832727cf28c51ed806c7e65e9545c1a7110a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"9b5ee5dff0027abb6b6eec84ad26e0c45fc9578e","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    def test_20_initialize_the_second_time_will_not_format(self):"},{"line_number":492,"context_line":"        \"\"\"If initialize is called but a UUID exists, it should not format.\"\"\""},{"line_number":493,"context_line":"        old_uuid \u003d self.story.get_volume()[\u0027uuid\u0027]"},{"line_number":494,"context_line":"        self.assertIsNotNone(old_uuid)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        class VolumeClientNoFmt(volume.Client):"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_611bf680","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":38},"in_reply_to":"3a71b18c_66f14c6a","updated":"2016-12-09 15:47:10.000000000","message":"Re: 478, a new patch will be submitted.","commit_id":"18ce832727cf28c51ed806c7e65e9545c1a7110a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"030eb349762b37e90b799f4bcd0ec23d56fa6bd6","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    def test_20_initialize_the_second_time_will_not_format(self):"},{"line_number":492,"context_line":"        \"\"\"If initialize is called but a UUID exists, it should not format.\"\"\""},{"line_number":493,"context_line":"        old_uuid \u003d self.story.get_volume()[\u0027uuid\u0027]"},{"line_number":494,"context_line":"        self.assertIsNotNone(old_uuid)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        class VolumeClientNoFmt(volume.Client):"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_e14f06bc","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":38},"in_reply_to":"3a71b18c_66f14c6a","updated":"2016-12-09 15:40:59.000000000","message":"ditto.","commit_id":"18ce832727cf28c51ed806c7e65e9545c1a7110a"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"efe10ad2c1b62034b7ece96f1ea480264f75fbba","unresolved":false,"context_lines":[{"line_number":475,"context_line":"    @time_out(300)"},{"line_number":476,"context_line":"    def test_10_initialize_will_format(self):"},{"line_number":477,"context_line":"        \"\"\"initialize will setup, format, and store the UUID of a volume\"\"\""},{"line_number":478,"context_line":"        self.assertIsNone(self.story.get_volume()[\u0027uuid\u0027])"},{"line_number":479,"context_line":"        self.story.client.initialize(self.story.context, self.story.volume_id,"},{"line_number":480,"context_line":"                                     self.story.host)"},{"line_number":481,"context_line":"        volume \u003d self.story.get_volume()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_0c77d93a","line":478,"range":{"start_line":478,"start_character":8,"end_line":478,"end_character":58},"updated":"2016-12-09 15:59:49.000000000","message":"change is not required.","commit_id":"1248a50fcbdf0e7d343663699e996483560e7f8b"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"efe10ad2c1b62034b7ece96f1ea480264f75fbba","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    def test_20_initialize_the_second_time_will_not_format(self):"},{"line_number":492,"context_line":"        \"\"\"If initialize is called but a UUID exists, it should not format.\"\"\""},{"line_number":493,"context_line":"        old_uuid \u003d self.story.get_volume()[\u0027uuid\u0027]"},{"line_number":494,"context_line":"        self.assertIsNotNone(old_uuid)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        class VolumeClientNoFmt(volume.Client):"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_4c88f122","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":38},"updated":"2016-12-09 15:59:49.000000000","message":"change is not required","commit_id":"1248a50fcbdf0e7d343663699e996483560e7f8b"}],"tox.ini":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"42ce4f55d4d988f0569c3773e3f093ff1a6d9bd9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"show-source \u003d True"},{"line_number":72,"context_line":"# H301 is ignored on purpose."},{"line_number":73,"context_line":"# The rest of the ignores are TODOs."},{"line_number":74,"context_line":"# TODO(lamt): F401 added for bug/1642554 - will remove in future patchset"},{"line_number":75,"context_line":"# TODO(lamt): F841 added for bug/1642554 - will remove in future patchset"},{"line_number":76,"context_line":"# TODO(lamt): H101 added for bug/1642554 - will remove in future patchset"},{"line_number":77,"context_line":"ignore \u003d F821,H301,H404,H405,H501,F401,F841,H101"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5a74a57a_b65af481","line":74,"updated":"2016-11-23 22:27:50.000000000","message":"clearly this means you haven\u0027t closed the bug in question.","commit_id":"77ac7ada5c2cb77895655c73937f301828f0e7bd"}]}