)]}'
{"trove/datastore/models.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"586ed1e54584f341c4b64ecf1a47f2ff5ea30595","unresolved":false,"context_lines":[{"line_number":519,"context_line":"    return (datastore, datastore_version)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"def get_datastore_or_version(datastore\u003dNone, datastore_version\u003dNone):"},{"line_number":523,"context_line":"    \"\"\""},{"line_number":524,"context_line":"    Validate that the specified datastore/version exists, and return the"},{"line_number":525,"context_line":"    corresponding ids.  This differs from \u0027get_datastore_version\u0027 in that"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_0fbffe60","line":522,"range":{"start_line":522,"start_character":18,"end_line":522,"end_character":28},"updated":"2017-01-10 16:15:12.000000000","message":"Just by looking at the return statement, I think the \"or\" in the method name could be replaced with an \"and\"","commit_id":"c8c82c8e7d94c7f5fc225561cddd9bb485988ca4"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"586ed1e54584f341c4b64ecf1a47f2ff5ea30595","unresolved":false,"context_lines":[{"line_number":519,"context_line":"    return (datastore, datastore_version)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"def get_datastore_or_version(datastore\u003dNone, datastore_version\u003dNone):"},{"line_number":523,"context_line":"    \"\"\""},{"line_number":524,"context_line":"    Validate that the specified datastore/version exists, and return the"},{"line_number":525,"context_line":"    corresponding ids.  This differs from \u0027get_datastore_version\u0027 in that"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_1dd1f7cd","line":522,"updated":"2017-01-10 16:15:12.000000000","message":"Mentioning this change in the commit message may be a good idea.","commit_id":"c8c82c8e7d94c7f5fc225561cddd9bb485988ca4"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"586ed1e54584f341c4b64ecf1a47f2ff5ea30595","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            datastore_id \u003d ds.id"},{"line_number":547,"context_line":"    elif datastore_version:"},{"line_number":548,"context_line":"        # Cannot specify version without datastore."},{"line_number":549,"context_line":"        raise exception.DatastoreNoVersion("},{"line_number":550,"context_line":"            datastore\u003ddatastore, version\u003ddatastore_version)"},{"line_number":551,"context_line":"    return datastore_id, datastore_version_id"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_4f5ae62b","line":549,"range":{"start_line":549,"start_character":24,"end_line":549,"end_character":42},"updated":"2017-01-10 16:15:12.000000000","message":"This would be better if the error said what is in the comment above it, \"Cannot specify version without datastore.\". What it is now can be misleading, \"Datastore \u0027\u0027 has no version \u00275.6\u0027.\"","commit_id":"c8c82c8e7d94c7f5fc225561cddd9bb485988ca4"}],"trove/module/models.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"c1536794d20c6b0510c0168339e0f632726bc094","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            auto_apply\u003dauto_apply,"},{"line_number":191,"context_line":"            visible\u003dvisible,"},{"line_number":192,"context_line":"            live_update\u003dlive_update,"},{"line_number":193,"context_line":"            priority_apply\u003dpriority_apply,"},{"line_number":194,"context_line":"            apply_order\u003dapply_order,"},{"line_number":195,"context_line":"            is_admin\u003dis_admin,"},{"line_number":196,"context_line":"            md5\u003dmd5)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_76d58fb7","line":193,"range":{"start_line":193,"start_character":12,"end_line":193,"end_character":41},"updated":"2017-01-04 16:30:51.000000000","message":"yeah this hasn\u0027t merged yet. https://review.openstack.org/#/c/348743/16/trove/module/models.py@172","commit_id":"3209358287702bdfddcf0037487a1e4e8fef83c3"}],"trove/module/service.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"586ed1e54584f341c4b64ecf1a47f2ff5ea30595","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        module \u003d models.Module.load(context, id)"},{"line_number":179,"context_line":"        self.authorize_module_action(context, \u0027instances\u0027, module)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        count_only \u003d req.GET.get(\u0027count_only\u0027, \u0027\u0027).lower() \u003d\u003d \u0027true\u0027"},{"line_number":182,"context_line":"        include_clustered \u003d ("},{"line_number":183,"context_line":"            req.GET.get(\u0027include_clustered\u0027, \u0027\u0027).lower() \u003d\u003d \u0027true\u0027)"},{"line_number":184,"context_line":"        if count_only:"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_05d35d60","line":181,"range":{"start_line":181,"start_character":34,"end_line":181,"end_character":45},"updated":"2017-01-10 16:15:12.000000000","message":"should this be exposed as an option in the client?","commit_id":"c8c82c8e7d94c7f5fc225561cddd9bb485988ca4"}],"trove/module/views.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"07f75c15cab80790e0528d03917d876534732cf8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            datastore_id\u003dself.module.datastore_id,"},{"line_number":34,"context_line":"            datastore_version_id\u003dself.module.datastore_version_id,"},{"line_number":35,"context_line":"            auto_apply\u003dself.module.auto_apply,"},{"line_number":36,"context_line":"            priority_apply\u003dself.module.priority_apply,"},{"line_number":37,"context_line":"            apply_order\u003dself.module.apply_order,"},{"line_number":38,"context_line":"            is_admin\u003dself.module.is_admin,"},{"line_number":39,"context_line":"            md5\u003dself.module.md5,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_13053579","line":36,"range":{"start_line":36,"start_character":12,"end_line":36,"end_character":54},"updated":"2017-01-04 16:03:16.000000000","message":"error on this line","commit_id":"3209358287702bdfddcf0037487a1e4e8fef83c3"}]}