)]}'
{"trove/guestagent/datastore/experimental/postgresql/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"8a21781388d1acc7c444b9bbe8319adcd839c414","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                                  force\u003dTrue, as_root\u003dTrue)"},{"line_number":562,"context_line":"            operating_system.remove(upgrade_info[\u0027save_etc\u0027], force\u003dTrue,"},{"line_number":563,"context_line":"                                    as_root\u003dTrue)"},{"line_number":564,"context_line":"        self.configuration_manager.refresh_cache()"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"class PgSqlAppStatus(service.BaseDbStatus):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_84ad229d","line":564,"updated":"2016-11-28 20:39:13.000000000","message":"not indented? i.e. you do this even if you have not restored config directory?","commit_id":"74b7adf58d17ecb9626811c03183793278b59710"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"a0b56e79f6df4b09f54c321deb697e9c8202cf75","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                                  force\u003dTrue, as_root\u003dTrue)"},{"line_number":562,"context_line":"            operating_system.remove(upgrade_info[\u0027save_etc\u0027], force\u003dTrue,"},{"line_number":563,"context_line":"                                    as_root\u003dTrue)"},{"line_number":564,"context_line":"        self.configuration_manager.refresh_cache()"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"class PgSqlAppStatus(service.BaseDbStatus):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_cfac938e","line":564,"in_reply_to":"5a74a57a_84ad229d","updated":"2016-11-28 21:01:09.000000000","message":"It should not really matter. I think it is safer to always do it just in case somebody later extends this method. This is something that will need to be done by all guests that use the config-manager (\u003d\u003d all guests) and support upgrade.\n\nSeems like this may be a good candidate for promotion into the base post_restore (base manager already has the config_manager property), well but we do not have the base App class...","commit_id":"74b7adf58d17ecb9626811c03183793278b59710"}],"trove/guestagent/datastore/mysql_common/manager.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"20fc665f5bbe01d4ce23ac7fe4b30b5e4095c2f3","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        operating_system.copy(\"%s/.\" % upgrade_info[\u0027home_save\u0027],"},{"line_number":291,"context_line":"                              os.path.expanduser(\u0027~\u0027),"},{"line_number":292,"context_line":"                              preserve\u003dTrue, as_root\u003dTrue)"},{"line_number":293,"context_line":"        self.configuration_manager.refresh_cache()"},{"line_number":294,"context_line":"        app.start_mysql()"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def restart(self, context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_35663a51","line":293,"updated":"2016-11-28 21:56:03.000000000","message":"BTW, MySQL unlike all other datastores always builds a new App object on every call (see line 70) so it should not need the refresh at all.","commit_id":"74b7adf58d17ecb9626811c03183793278b59710"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"6814c6cca3d98fd3b92f869e284024e27e64e50a","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        operating_system.copy(\"%s/.\" % upgrade_info[\u0027home_save\u0027],"},{"line_number":291,"context_line":"                              os.path.expanduser(\u0027~\u0027),"},{"line_number":292,"context_line":"                              preserve\u003dTrue, as_root\u003dTrue)"},{"line_number":293,"context_line":"        self.configuration_manager.refresh_cache()"},{"line_number":294,"context_line":"        app.start_mysql()"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def restart(self, context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_109eacb8","line":293,"in_reply_to":"5a74a57a_35663a51","updated":"2016-11-28 22:03:14.000000000","message":"OK, I found the explanation. MySQL stores the config-manager in a static class variable (BaseMySqlApp) which gets initialized only once for the class. That\u0027s why it still requires the refresh.","commit_id":"74b7adf58d17ecb9626811c03183793278b59710"}]}