)]}'
{"tools/trove-pylint.config":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9cdf0a54412a23c2c67dbacad06f06e7a0804190","unresolved":false,"context_lines":[{"line_number":370,"context_line":"      null"},{"line_number":371,"context_line":"    ],"},{"line_number":372,"context_line":"    ["},{"line_number":373,"context_line":"      \"trove/common/strategies/cluster/experimental/couchbase/api.py\","},{"line_number":374,"context_line":"      \"E1101\","},{"line_number":375,"context_line":"      \"Instance of \u0027list\u0027 has no \u0027split\u0027 member\","},{"line_number":376,"context_line":"      \"CouchbaseCluster.get_instance_types\""}],"source_content_type":"text/x-ini","patch_set":5,"id":"ba5201f7_c8958833","line":373,"updated":"2017-01-05 18:08:47.000000000","message":"this is odd ...","commit_id":"ba52a1284c04aec1bbdfca541c667fa6504d9c43"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"9e47af80dd7f6531bd199b14f010c31f9782518d","unresolved":false,"context_lines":[{"line_number":370,"context_line":"      null"},{"line_number":371,"context_line":"    ],"},{"line_number":372,"context_line":"    ["},{"line_number":373,"context_line":"      \"trove/common/strategies/cluster/experimental/couchbase/api.py\","},{"line_number":374,"context_line":"      \"E1101\","},{"line_number":375,"context_line":"      \"Instance of \u0027list\u0027 has no \u0027split\u0027 member\","},{"line_number":376,"context_line":"      \"CouchbaseCluster.get_instance_types\""}],"source_content_type":"text/x-ini","patch_set":5,"id":"9a57fde8_f08c8c37","line":373,"in_reply_to":"ba5201f7_c8958833","updated":"2017-01-12 15:17:42.000000000","message":"pylint doesn\u0027t take into account that this value might be a string and being split into a list.  It just sees that default_services has \u0027[]\u0027 as a default and there\u0027s no \u0027split\u0027 command on a list.  It misses the \u0027if isinstance(default_services, six.string_types):\u0027 part.","commit_id":"ba52a1284c04aec1bbdfca541c667fa6504d9c43"}],"trove/common/strategies/cluster/experimental/mongodb/api.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"9e47af80dd7f6531bd199b14f010c31f9782518d","unresolved":false,"context_lines":[{"line_number":477,"context_line":"        replicas \u003d []"},{"line_number":478,"context_line":"        query_routers \u003d []"},{"line_number":479,"context_line":"        for item in instances:"},{"line_number":480,"context_line":"            if \u0027replica\u0027 in item[\u0027instance_type\u0027]:"},{"line_number":481,"context_line":"                replica_requirements \u003d [\u0027related_to\u0027, \u0027name\u0027]"},{"line_number":482,"context_line":"                if not all(key in item for key in replica_requirements):"},{"line_number":483,"context_line":"                    raise exception.TroveError("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_f04e4c95","line":480,"range":{"start_line":480,"start_character":12,"end_line":480,"end_character":50},"updated":"2017-01-12 15:17:42.000000000","message":"I\u0027m not sure I agree with this change.  If a new type call \u0027read_replica\u0027 were added, this code would still run now","commit_id":"ba52a1284c04aec1bbdfca541c667fa6504d9c43"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"d762291626e72df999cdc0118a64b2d5481fdcc3","unresolved":false,"context_lines":[{"line_number":477,"context_line":"        replicas \u003d []"},{"line_number":478,"context_line":"        query_routers \u003d []"},{"line_number":479,"context_line":"        for item in instances:"},{"line_number":480,"context_line":"            if \u0027replica\u0027 in item[\u0027instance_type\u0027]:"},{"line_number":481,"context_line":"                replica_requirements \u003d [\u0027related_to\u0027, \u0027name\u0027]"},{"line_number":482,"context_line":"                if not all(key in item for key in replica_requirements):"},{"line_number":483,"context_line":"                    raise exception.TroveError("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_8a3f8c24","line":480,"range":{"start_line":480,"start_character":12,"end_line":480,"end_character":50},"in_reply_to":"9a57fde8_0add5c14","updated":"2017-01-12 16:00:49.000000000","message":"Oops, right.  I think I made that change, my bad!","commit_id":"ba52a1284c04aec1bbdfca541c667fa6504d9c43"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"4fc200668b684147dedbc9e9e8e411af86eab555","unresolved":false,"context_lines":[{"line_number":477,"context_line":"        replicas \u003d []"},{"line_number":478,"context_line":"        query_routers \u003d []"},{"line_number":479,"context_line":"        for item in instances:"},{"line_number":480,"context_line":"            if \u0027replica\u0027 in item[\u0027instance_type\u0027]:"},{"line_number":481,"context_line":"                replica_requirements \u003d [\u0027related_to\u0027, \u0027name\u0027]"},{"line_number":482,"context_line":"                if not all(key in item for key in replica_requirements):"},{"line_number":483,"context_line":"                    raise exception.TroveError("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_0add5c14","line":480,"range":{"start_line":480,"start_character":12,"end_line":480,"end_character":50},"in_reply_to":"9a57fde8_f04e4c95","updated":"2017-01-12 15:59:32.000000000","message":"This was changed to a list in order to support multiple instance types.","commit_id":"ba52a1284c04aec1bbdfca541c667fa6504d9c43"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"9e47af80dd7f6531bd199b14f010c31f9782518d","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                          \u0027%s.\u0027) % replica_requirements"},{"line_number":486,"context_line":"                    )"},{"line_number":487,"context_line":"                replicas.append(item)"},{"line_number":488,"context_line":"            elif \u0027query_router\u0027 in item[\u0027instance_type\u0027]:"},{"line_number":489,"context_line":"                query_routers.append(item)"},{"line_number":490,"context_line":"            else:"},{"line_number":491,"context_line":"                raise exception.TroveError("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_3b0ef534","line":488,"range":{"start_line":488,"start_character":17,"end_line":488,"end_character":35},"updated":"2017-01-12 15:17:42.000000000","message":"ditto - you could change the direction of the two checks though. i.e.:\n\n  elif \u0027query_router\u0027 \u003d\u003d item[\u0027instance_type\u0027]:","commit_id":"ba52a1284c04aec1bbdfca541c667fa6504d9c43"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"4fc200668b684147dedbc9e9e8e411af86eab555","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                          \u0027%s.\u0027) % replica_requirements"},{"line_number":486,"context_line":"                    )"},{"line_number":487,"context_line":"                replicas.append(item)"},{"line_number":488,"context_line":"            elif \u0027query_router\u0027 in item[\u0027instance_type\u0027]:"},{"line_number":489,"context_line":"                query_routers.append(item)"},{"line_number":490,"context_line":"            else:"},{"line_number":491,"context_line":"                raise exception.TroveError("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_4ae764e4","line":488,"range":{"start_line":488,"start_character":17,"end_line":488,"end_character":35},"in_reply_to":"9a57fde8_3b0ef534","updated":"2017-01-12 15:59:32.000000000","message":"ditto","commit_id":"ba52a1284c04aec1bbdfca541c667fa6504d9c43"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"d762291626e72df999cdc0118a64b2d5481fdcc3","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                          \u0027%s.\u0027) % replica_requirements"},{"line_number":486,"context_line":"                    )"},{"line_number":487,"context_line":"                replicas.append(item)"},{"line_number":488,"context_line":"            elif \u0027query_router\u0027 in item[\u0027instance_type\u0027]:"},{"line_number":489,"context_line":"                query_routers.append(item)"},{"line_number":490,"context_line":"            else:"},{"line_number":491,"context_line":"                raise exception.TroveError("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_ca4994d2","line":488,"range":{"start_line":488,"start_character":17,"end_line":488,"end_character":35},"in_reply_to":"9a57fde8_4ae764e4","updated":"2017-01-12 16:00:49.000000000","message":":)","commit_id":"ba52a1284c04aec1bbdfca541c667fa6504d9c43"}]}