)]}'
{"integration/scripts/files/elements/ubuntu-postgresql/install.d/30-postgresql":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"73c45dea54b3ad5f717c7971d60d5c9c32a0546f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_EOF_"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"apt-get --allow-unauthenticated -y install postgresql-${VERSION} postgresql-contrib-${VERSION}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"if [[ \"$VERSION\" \u003d\u003d \"9.4\" ]]; then"},{"line_number":39,"context_line":"    apt-get --allow-unauthenticated -y install postgresql-server-dev-9.4"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7f96bb07_c13b0e9a","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":31},"updated":"2018-01-11 10:14:10.000000000","message":"Since you change ubuntu install script, you should update fedora too.\nhttps://github.com/openstack/trove/blob/master/integration/scripts/files/elements/fedora-postgresql/install.d/10-postgresql","commit_id":"5f55eaffdf0008b9d8d00f76426f8ea22ea0747b"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"c9ee10803cb3ad5b3016965400a8a062d6dca0e2","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_EOF_"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"apt-get --allow-unauthenticated -y install postgresql-${VERSION} postgresql-contrib-${VERSION}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"if [[ \"$VERSION\" \u003d\u003d \"9.4\" ]]; then"},{"line_number":39,"context_line":"    apt-get --allow-unauthenticated -y install postgresql-server-dev-9.4"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7f96bb07_31c1d655","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":31},"in_reply_to":"7f96bb07_c13b0e9a","updated":"2018-01-17 15:41:30.000000000","message":"\u003e Since you change ubuntu install script, you should update fedora\n \u003e too.\n \u003e https://github.com/openstack/trove/blob/master/integration/scripts/files/elements/fedora-postgresql/install.d/10-postgresql","commit_id":"5f55eaffdf0008b9d8d00f76426f8ea22ea0747b"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"73c45dea54b3ad5f717c7971d60d5c9c32a0546f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"else"},{"line_number":82,"context_line":"    # We need to create a symlink from the installed version of"},{"line_number":83,"context_line":"    # pg_rewind to /usr/bin (The assumption is that this will"},{"line_number":84,"context_line":"    # only be done for versions \u003e9.4 i.e. I don\u0027t believe we"},{"line_number":85,"context_line":"    # support 9.3 anymore.)"},{"line_number":86,"context_line":"    ln -s /usr/lib/postgresql/${VERSION}/bin/pg_rewind /usr/bin/pg_rewind"},{"line_number":87,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7f96bb07_41f5beca","line":84,"range":{"start_line":84,"start_character":42,"end_line":84,"end_character":43},"updated":"2018-01-11 10:14:10.000000000","message":"Is there a releasenotes  that ever told user trove not support \u003c9.4 anymore.","commit_id":"5f55eaffdf0008b9d8d00f76426f8ea22ea0747b"}],"trove/guestagent/datastore/experimental/postgresql/service.py":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"73c45dea54b3ad5f717c7971d60d5c9c32a0546f","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            \u0027wal_keep_segments\u0027: 8,"},{"line_number":288,"context_line":"            \u0027archive_command\u0027: arch_cmd"},{"line_number":289,"context_line":"        }"},{"line_number":290,"context_line":"        if not self.pg_version[1] in (\u00279.3\u0027):"},{"line_number":291,"context_line":"            opts[\u0027wal_log_hints\u0027] \u003d \u0027on\u0027"},{"line_number":292,"context_line":"        if self.pg_version[1] in (\u00279.4\u0027):"},{"line_number":293,"context_line":"            opts[\u0027checkpoint_segments\u0027] \u003d 8"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_61b55aee","line":290,"range":{"start_line":290,"start_character":42,"end_line":290,"end_character":45},"updated":"2018-01-11 10:14:10.000000000","message":"If you assume trove not support \u003c9.4 anymore, you should delete this line.","commit_id":"5f55eaffdf0008b9d8d00f76426f8ea22ea0747b"}],"trove/guestagent/strategies/replication/experimental/postgresql_impl.py":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"73c45dea54b3ad5f717c7971d60d5c9c32a0546f","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        opts \u003d {\u0027hot_standby\u0027: \u0027on\u0027,"},{"line_number":287,"context_line":"                \u0027wal_level\u0027: \u0027hot_standby\u0027}"},{"line_number":288,"context_line":"        # wal_log_hints for pg_rewind is only supported in 9.4+"},{"line_number":289,"context_line":"        if not service.pg_version[1] in (\u00279.3\u0027):"},{"line_number":290,"context_line":"            opts[\u0027wal_log_hints\u0027] \u003d \u0027on\u0027"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        service.configuration_manager.\\"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_01c6d668","line":289,"range":{"start_line":289,"start_character":45,"end_line":289,"end_character":48},"updated":"2018-01-11 10:14:10.000000000","message":"the same.","commit_id":"5f55eaffdf0008b9d8d00f76426f8ea22ea0747b"}],"trove/templates/postgresql/9.4/config.template":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"73c45dea54b3ad5f717c7971d60d5c9c32a0546f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Pre-compute values used by the template expressions."},{"line_number":2,"context_line":"# Note: The variables have to be in lists due to how scoping works in JINJA templates."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# The recommended amount for \u0027shared_buffers\u0027 on a dedicated database server is 25% of RAM."}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7f96bb07_a18e0225","line":1,"range":{"start_line":1,"start_character":29,"end_line":1,"end_character":32},"updated":"2018-01-11 10:14:10.000000000","message":"Just an advise, is there a more beautiful way to handle this change. I am not sure add a 648-lines file for one parameters difference.","commit_id":"5f55eaffdf0008b9d8d00f76426f8ea22ea0747b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"765604369d523707e305542ccf5f7ae3cea62eaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Pre-compute values used by the template expressions."},{"line_number":2,"context_line":"# Note: The variables have to be in lists due to how scoping works in JINJA templates."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# The recommended amount for \u0027shared_buffers\u0027 on a dedicated database server is 25% of RAM."}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7f96bb07_1ee45edf","line":1,"range":{"start_line":1,"start_character":29,"end_line":1,"end_character":32},"in_reply_to":"7f96bb07_a18e0225","updated":"2018-01-17 07:04:33.000000000","message":"This may be copied from official config file. :)","commit_id":"5f55eaffdf0008b9d8d00f76426f8ea22ea0747b"}],"trove/templates/postgresql/config.template":[{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"765604369d523707e305542ccf5f7ae3cea62eaf","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"# - Checkpoints -"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"checkpoint_segments \u003d {{ (shared_buffers_mb[0] / 16 + 1)|int }}\t\t# in logfile segments, min 1, 16MB each"},{"line_number":222,"context_line":"\t\t\t\t\t\t\t\t# Each segment is normally 16MB long."},{"line_number":223,"context_line":"\t\t\t\t\t\t\t\t# The number of segments should be enough to"},{"line_number":224,"context_line":"\t\t\t\t\t\t\t\t# span the \u0027shared_buffers\u0027 size."}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7f96bb07_defa7673","side":"PARENT","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":20},"updated":"2018-01-17 07:04:33.000000000","message":"If checkpoint_segments is removed from 9.4, then this default config.template should keep this item for database version \u003c\u003d9.3.","commit_id":"5ec6236bae859f0d82c2715e23b06060446b38ed"}]}