)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"5d10fb3c58ef7483ab0405b64ff3ed867153c70a","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# tweak_nova() - update the nova hypervisor configuration if possible"},{"line_number":104,"context_line":"function tweak_nova {"},{"line_number":105,"context_line":"    if [ -e /sys/module/kvm_*/parameters/nested ]; then"},{"line_number":106,"context_line":"        reconfigure_nova\u003d\"F\""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_198cf0d8","line":104,"range":{"start_line":104,"start_character":9,"end_line":104,"end_character":19},"updated":"2016-12-17 15:32:59.000000000","message":"how about configure_nova_for_kvm - tweak sounds too muck like hack","commit_id":"59f309ff386be0d1cba5fe299c73a379792b7b39"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d33899e386b359af4c4ded53ee9f0fb327b6b492","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# tweak_nova() - update the nova hypervisor configuration if possible"},{"line_number":104,"context_line":"function tweak_nova {"},{"line_number":105,"context_line":"    if [ -e /sys/module/kvm_*/parameters/nested ]; then"},{"line_number":106,"context_line":"        reconfigure_nova\u003d\"F\""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_f4b1fbe0","line":104,"range":{"start_line":104,"start_character":9,"end_line":104,"end_character":19},"in_reply_to":"1a6eadb0_198cf0d8","updated":"2016-12-17 17:10:32.000000000","message":"because this is a hack","commit_id":"59f309ff386be0d1cba5fe299c73a379792b7b39"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"5d10fb3c58ef7483ab0405b64ff3ed867153c70a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            if [[ \"$(cat /sys/module/kvm_*/parameters/nested)\" \u003d\u003d \"Y\" ]]; then"},{"line_number":110,"context_line":"                reconfigure_nova\u003d\"Y\""},{"line_number":111,"context_line":"            else"},{"line_number":112,"context_line":"                echo_summary \"Found Intel with no support for nested KVM.\""},{"line_number":113,"context_line":"            fi"},{"line_number":114,"context_line":"        elif [ -e /sys/module/kvm_amd/parameters/nested ]; then"},{"line_number":115,"context_line":"            if [[ \"$(cat /sys/module/kvm_*/parameters/nested)\" \u003d\u003d \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_79f6c45d","line":112,"range":{"start_line":112,"start_character":16,"end_line":112,"end_character":28},"updated":"2016-12-17 15:32:59.000000000","message":"This should probably be a simple echo, not a summary","commit_id":"59f309ff386be0d1cba5fe299c73a379792b7b39"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d33899e386b359af4c4ded53ee9f0fb327b6b492","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            if [[ \"$(cat /sys/module/kvm_*/parameters/nested)\" \u003d\u003d \"Y\" ]]; then"},{"line_number":110,"context_line":"                reconfigure_nova\u003d\"Y\""},{"line_number":111,"context_line":"            else"},{"line_number":112,"context_line":"                echo_summary \"Found Intel with no support for nested KVM.\""},{"line_number":113,"context_line":"            fi"},{"line_number":114,"context_line":"        elif [ -e /sys/module/kvm_amd/parameters/nested ]; then"},{"line_number":115,"context_line":"            if [[ \"$(cat /sys/module/kvm_*/parameters/nested)\" \u003d\u003d \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_34c8d354","line":112,"range":{"start_line":112,"start_character":16,"end_line":112,"end_character":28},"in_reply_to":"1a6eadb0_79f6c45d","updated":"2016-12-17 17:10:32.000000000","message":"no, I want it to be in the summary file, not the big messy file.","commit_id":"59f309ff386be0d1cba5fe299c73a379792b7b39"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"5d10fb3c58ef7483ab0405b64ff3ed867153c70a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            if [[ \"$(cat /sys/module/kvm_*/parameters/nested)\" \u003d\u003d \"1\" ]]; then"},{"line_number":116,"context_line":"                reconfigure_nova\u003d\"Y\""},{"line_number":117,"context_line":"            else"},{"line_number":118,"context_line":"                echo_summary \"Found AMD with no support for nested KVM.\""},{"line_number":119,"context_line":"            fi"},{"line_number":120,"context_line":"        fi"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_999720eb","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":63},"updated":"2016-12-17 15:32:59.000000000","message":"ditto","commit_id":"59f309ff386be0d1cba5fe299c73a379792b7b39"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d33899e386b359af4c4ded53ee9f0fb327b6b492","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            if [[ \"$(cat /sys/module/kvm_*/parameters/nested)\" \u003d\u003d \"1\" ]]; then"},{"line_number":116,"context_line":"                reconfigure_nova\u003d\"Y\""},{"line_number":117,"context_line":"            else"},{"line_number":118,"context_line":"                echo_summary \"Found AMD with no support for nested KVM.\""},{"line_number":119,"context_line":"            fi"},{"line_number":120,"context_line":"        fi"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_54c38f37","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":63},"in_reply_to":"1a6eadb0_999720eb","updated":"2016-12-17 17:10:32.000000000","message":"no","commit_id":"59f309ff386be0d1cba5fe299c73a379792b7b39"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"5d10fb3c58ef7483ab0405b64ff3ed867153c70a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            iniset $NOVA_CONF libvirt virt_type \"kvm\""},{"line_number":129,"context_line":"        else"},{"line_number":130,"context_line":"            virt_type\u003d$(iniget $NOVA_CONF libvirt virt_type)"},{"line_number":131,"context_line":"            echo_summary \"Nested hypervisor not supported, using ${virt_type}.\""},{"line_number":132,"context_line":"        fi"},{"line_number":133,"context_line":"    else"},{"line_number":134,"context_line":"        virt_type\u003d$(iniget $NOVA_CONF libvirt virt_type)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_d99d180b","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":24},"updated":"2016-12-17 15:32:59.000000000","message":"It might make sense to put something in the main output too (using echo) since that\u0027s typically where you look when things go wrong.","commit_id":"59f309ff386be0d1cba5fe299c73a379792b7b39"}]}
