)]}'
{"trove/guestagent/volume.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9bab5b4815766de6dfcc1bcaca23fd9608fef948","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def mount_points(self, device_path):"},{"line_number":176,"context_line":"        \"\"\"Returns a list of mount points on the specified device.\"\"\""},{"line_number":177,"context_line":"        stdout, stderr \u003d utils.execute("},{"line_number":178,"context_line":"            \"grep \u0027^%s \u0027 /etc/mtab\" % device_path,"},{"line_number":179,"context_line":"            shell\u003dTrue, check_exit_code\u003d[0, 1])"},{"line_number":180,"context_line":"        return [entry.strip().split()[1] for entry in stdout.splitlines()]"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_a14ffc90","line":178,"updated":"2016-12-22 18:02:02.000000000","message":"two spaces?","commit_id":"7cff447ab76cf1952416a98bac9f9c1f14b80f56"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"00654e19f29cdcf9eb140bfd5698d022a36bdd49","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def mount_points(self, device_path):"},{"line_number":176,"context_line":"        \"\"\"Returns a list of mount points on the specified device.\"\"\""},{"line_number":177,"context_line":"        stdout, stderr \u003d utils.execute("},{"line_number":178,"context_line":"            \"grep \u0027^%s \u0027 /etc/mtab\" % device_path,"},{"line_number":179,"context_line":"            shell\u003dTrue, check_exit_code\u003d[0, 1])"},{"line_number":180,"context_line":"        return [entry.strip().split()[1] for entry in stdout.splitlines()]"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_0ac29d85","line":178,"in_reply_to":"da4df55a_a14ffc90","updated":"2016-12-22 19:04:44.000000000","message":"Do you mean in the quotes? - \u0027^%s \u0027 \u003c-- there\u0027s only one space there.","commit_id":"7cff447ab76cf1952416a98bac9f9c1f14b80f56"}],"trove/tests/unittests/guestagent/test_volume.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"a49633f49b1f7a00ce5507fe503612ad199bd538","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                              self.volumeDevice.resize_fs, \u0027/mnt/volume\u0027)"},{"line_number":140,"context_line":"            self.assertEqual(1,"},{"line_number":141,"context_line":"                             self.volumeDevice._check_device_exists.call_count)"},{"line_number":142,"context_line":"            self.assertEqual(2, self.mock_ismount.call_count)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_unmount_positive(self):"},{"line_number":145,"context_line":"        self._test_unmount()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_a711daae","line":142,"range":{"start_line":142,"start_character":29,"end_line":142,"end_character":30},"updated":"2016-12-22 14:36:52.000000000","message":"This is now 2 because we are unmounting before we mount. nice.","commit_id":"25d384ba979cbeee3d3566bce7d48f627b64ed55"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"a49633f49b1f7a00ce5507fe503612ad199bd538","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_mount_points(self):"},{"line_number":160,"context_line":"        self.mock_exec.return_value \u003d ("},{"line_number":161,"context_line":"            (\"/dev/vdb /var/lib/mysql xfs rw 0 0\", \"\"))"},{"line_number":162,"context_line":"        mount_point \u003d self.volumeDevice.mount_points(\u0027/dev/vdb\u0027)"},{"line_number":163,"context_line":"        self.assertEqual([\u0027/var/lib/mysql\u0027], mount_point)"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_41c73e12","line":161,"updated":"2016-12-22 14:36:52.000000000","message":"I think there is room for improvement here (and a few others I see). You could assert the calls made to mock_exec like all the functions below this one.\n\n\u003e self.assertEqual(1, self.mock_exec.call_count)\n        calls \u003d [\n            call(\"grep \u0027^/dev/vdb \u0027 /etc/mtab\", check_exit_code\u003d[0, 1], shell\u003dTrue)\n        ]\n        self.mock_exec.assert_has_calls(calls)","commit_id":"25d384ba979cbeee3d3566bce7d48f627b64ed55"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8546ec8b265a1788e40ead01a2f229d496897161","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_mount_points(self):"},{"line_number":160,"context_line":"        self.mock_exec.return_value \u003d ("},{"line_number":161,"context_line":"            (\"/dev/vdb /var/lib/mysql xfs rw 0 0\", \"\"))"},{"line_number":162,"context_line":"        mount_point \u003d self.volumeDevice.mount_points(\u0027/dev/vdb\u0027)"},{"line_number":163,"context_line":"        self.assertEqual([\u0027/var/lib/mysql\u0027], mount_point)"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_bb82cdfe","line":161,"in_reply_to":"da4df55a_2526bdba","updated":"2016-12-22 17:02:49.000000000","message":"Done","commit_id":"25d384ba979cbeee3d3566bce7d48f627b64ed55"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8546ec8b265a1788e40ead01a2f229d496897161","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_mount_points(self):"},{"line_number":160,"context_line":"        self.mock_exec.return_value \u003d ("},{"line_number":161,"context_line":"            (\"/dev/vdb /var/lib/mysql xfs rw 0 0\", \"\"))"},{"line_number":162,"context_line":"        mount_point \u003d self.volumeDevice.mount_points(\u0027/dev/vdb\u0027)"},{"line_number":163,"context_line":"        self.assertEqual([\u0027/var/lib/mysql\u0027], mount_point)"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_8fdb08ed","line":161,"in_reply_to":"da4df55a_41c73e12","updated":"2016-12-22 17:02:49.000000000","message":"Done","commit_id":"25d384ba979cbeee3d3566bce7d48f627b64ed55"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"f8793f0de0c5c52bdd10ea3718c1fdb8bd26fceb","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_mount_points(self):"},{"line_number":160,"context_line":"        self.mock_exec.return_value \u003d ("},{"line_number":161,"context_line":"            (\"/dev/vdb /var/lib/mysql xfs rw 0 0\", \"\"))"},{"line_number":162,"context_line":"        mount_point \u003d self.volumeDevice.mount_points(\u0027/dev/vdb\u0027)"},{"line_number":163,"context_line":"        self.assertEqual([\u0027/var/lib/mysql\u0027], mount_point)"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_2526bdba","line":161,"in_reply_to":"da4df55a_41c73e12","updated":"2016-12-22 16:02:38.000000000","message":"In this case it would probably make even more sense to use mock.assert_called_once_with(...) and mock.assert_not_called()","commit_id":"25d384ba979cbeee3d3566bce7d48f627b64ed55"}]}