)]}'
{"trove/tests/api/instances.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"9a21169d366ef5520980ded02306288fe371cd43","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"            CheckInstance(None).contains_allowed_attrs("},{"line_number":1106,"context_line":"                hwinfo._info, allowed_attrs,"},{"line_number":1107,"context_line":"                msg\u003d\"Hardware information\")"},{"line_number":1108,"context_line":"            assert_true(isinstance(hwinfo.hwinfo[\u0027mem_total\u0027], int))"},{"line_number":1109,"context_line":"            assert_true(isinstance(hwinfo.hwinfo[\u0027num_cpus\u0027], int))"},{"line_number":1110,"context_line":"            assert (hwinfo.hwinfo[\u0027mem_total\u0027], flavors.ram)"},{"line_number":1111,"context_line":"            assert (hwinfo.hwinfo[\u0027num_cpus\u0027], flavors.cpus)"},{"line_number":1112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_0a1eb75e","line":1109,"range":{"start_line":1108,"start_character":12,"end_line":1109,"end_character":67},"updated":"2017-02-14 13:58:04.000000000","message":"These won\u0027t be necessary anymore if you are comparing ints below.","commit_id":"5d3d8fe4d0a49c7b3afce326674714f0c8bb4502"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"9a21169d366ef5520980ded02306288fe371cd43","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"                msg\u003d\"Hardware information\")"},{"line_number":1108,"context_line":"            assert_true(isinstance(hwinfo.hwinfo[\u0027mem_total\u0027], int))"},{"line_number":1109,"context_line":"            assert_true(isinstance(hwinfo.hwinfo[\u0027num_cpus\u0027], int))"},{"line_number":1110,"context_line":"            assert (hwinfo.hwinfo[\u0027mem_total\u0027], flavors.ram)"},{"line_number":1111,"context_line":"            assert (hwinfo.hwinfo[\u0027num_cpus\u0027], flavors.cpus)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    @test"},{"line_number":1114,"context_line":"    def grab_diagnostics_before_tests(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_ca001f04","line":1111,"range":{"start_line":1110,"start_character":12,"end_line":1111,"end_character":60},"updated":"2017-02-14 13:58:04.000000000","message":"This doesn\u0027t look correct. The second argument is supposed to be an optional message.\n\nWhat you want here is probably to use assert_true(..)\nand inside have hwinfo.hwinfo[\u0027mem_total\u0027] \u003d\u003d flavors.ram","commit_id":"5d3d8fe4d0a49c7b3afce326674714f0c8bb4502"},{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"78271623825560361aea6320eff78b0670cdfcd5","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"            CheckInstance(None).contains_allowed_attrs("},{"line_number":1099,"context_line":"                hwinfo._info, allowed_attrs,"},{"line_number":1100,"context_line":"                msg\u003d\"Hardware information\")"},{"line_number":1101,"context_line":"            # TODO(pdmars): instead of just checking that these are int\u0027s, get"},{"line_number":1102,"context_line":"            # the instance flavor and verify that the values are correct for"},{"line_number":1103,"context_line":"            # the flavor"},{"line_number":1104,"context_line":"            assert_true(isinstance(hwinfo.hwinfo[\u0027mem_total\u0027], int))"},{"line_number":1105,"context_line":"            assert_true(isinstance(hwinfo.hwinfo[\u0027num_cpus\u0027], int))"},{"line_number":1106,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_e8d4efec","side":"PARENT","line":1103,"range":{"start_line":1101,"start_character":12,"end_line":1103,"end_character":24},"updated":"2017-02-15 02:43:21.000000000","message":"here","commit_id":"3d3181f56fd3137883ef166f5a8b46dbf23118c1"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"500ff1d731601672e92b32b5909b48822a5ca960","unresolved":false,"context_lines":[{"line_number":1091,"context_line":""},{"line_number":1092,"context_line":"    @test"},{"line_number":1093,"context_line":"    def check_hwinfo_before_tests(self):"},{"line_number":1094,"context_line":"        if CONFIG.test_mgmt:"},{"line_number":1095,"context_line":"            if EPHEMERAL_SUPPORT:"},{"line_number":1096,"context_line":"                flavor_name \u003d CONFIG.values.get(\u0027instance_eph_flavor_name\u0027,"},{"line_number":1097,"context_line":"                                                \u0027eph.rd-tiny\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_2d951532","line":1094,"range":{"start_line":1094,"start_character":11,"end_line":1094,"end_character":27},"updated":"2017-02-15 17:42:11.000000000","message":"Is there a test where this is true? I only see it set to false in the gate runs.","commit_id":"5c0cc87ea5266e1a300514525bdc086697a82c6e"}]}