)]}'
{"trove/common/context.py":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"54e1cf2424f1715de7f575b0b7fc6f623594276a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                realvalues[dict_key] \u003d values.get(dict_key)"},{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                LOG.warning(_(\"Argument being removed before instantiating \""},{"line_number":86,"context_line":"                              \"TroveContext object - %(key)s \u003d %(value)s\") % {"},{"line_number":87,"context_line":"                                  \u0027key\u0027: dict_key,"},{"line_number":88,"context_line":"                                  \u0027value\u0027: values.get(dict_key)})"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_aa826cfe","line":86,"range":{"start_line":86,"start_character":74,"end_line":86,"end_character":76},"updated":"2017-02-04 11:14:09.000000000","message":"nit: Use a comma, see http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages\n\nAnd you should use _LW for warnings.","commit_id":"7a70632c3ea9e2bd9404105c325fa72a1129dd05"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2640af81ad67c17723e02c2bd9cf099b850f380f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                realvalues[dict_key] \u003d values.get(dict_key)"},{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                LOG.warning(_(\"Argument being removed before instantiating \""},{"line_number":86,"context_line":"                              \"TroveContext object - %(key)s \u003d %(value)s\") % {"},{"line_number":87,"context_line":"                                  \u0027key\u0027: dict_key,"},{"line_number":88,"context_line":"                                  \u0027value\u0027: values.get(dict_key)})"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_8a305058","line":86,"range":{"start_line":86,"start_character":74,"end_line":86,"end_character":76},"in_reply_to":"1a430d35_aa826cfe","updated":"2017-02-04 11:47:53.000000000","message":"fixed the translation \",\" vs \"%\". Trove hasn\u0027t used _LW in general so in keeping with that, I\u0027m sticking with _ which is still OK per the style guide.\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function\n\nRecall that in trove, translated strings are sometimes sent across the wire from guest to the control plane and therefore using _LW is not preferred.","commit_id":"7a70632c3ea9e2bd9404105c325fa72a1129dd05"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"73f54d38a337d24fa6f64cb759436013be01cc68","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def _remove_incompatible_context_args(cls, values):"},{"line_number":72,"context_line":"        realvalues \u003d {}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if platform.python_version_tuple()[0] \u003d\u003d \u00273\u0027:"},{"line_number":75,"context_line":"            args \u003d (inspect.getfullargspec(context.RequestContext.__init__)[0]"},{"line_number":76,"context_line":"                    + inspect.getfullargspec(TroveContext.__init__)[0])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_601265b6","line":73,"updated":"2017-02-04 18:18:11.000000000","message":"Might as well use the following if u really want to do this :-P\n\nhttps://github.com/openstack/oslo.utils/blob/master/oslo_utils/reflection.py#L199","commit_id":"df174d8dcc3c8f48f27b888920ac90f5ab22fc8e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"cd4829649390e205c432c34a7edc62588381d74d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def _remove_incompatible_context_args(cls, values):"},{"line_number":72,"context_line":"        realvalues \u003d {}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if platform.python_version_tuple()[0] \u003d\u003d \u00273\u0027:"},{"line_number":75,"context_line":"            args \u003d (inspect.getfullargspec(context.RequestContext.__init__)[0]"},{"line_number":76,"context_line":"                    + inspect.getfullargspec(TroveContext.__init__)[0])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_9e588efc","line":73,"in_reply_to":"1a430d35_601265b6","updated":"2017-02-04 23:09:44.000000000","message":"hokey dokey","commit_id":"df174d8dcc3c8f48f27b888920ac90f5ab22fc8e"}]}