)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e65452a8c970ad33591447effbd7019480800231","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use more specific asserts in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of assertTrue and assertFalse use more specific asserts."},{"line_number":10,"context_line":"They are compatible with Python 2.7[1] and 3.4[2]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: https://docs.python.org/2.7/library/unittest.html"},{"line_number":13,"context_line":"[2]: https://docs.python.org/3.4/library/unittest.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_ef06551f","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":46},"updated":"2017-02-10 13:42:16.000000000","message":"most projects are transitioning to 3.5, i suspect we\u0027ll follow shortly.","commit_id":"738244c1a699253ab083e9d26860a2028df8e762"}],"trove/tests/unittests/api/test_versions.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"da867b33fe2b15e7e71c3343d2cfed858f4029a6","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def test_data_for_json(self):"},{"line_number":154,"context_line":"        json_data \u003d self.version_data_view.data_for_json()"},{"line_number":155,"context_line":"        self.assertIsNotNone(json_data, \"JSON data was None\")"},{"line_number":156,"context_line":"        self.assertIs(type(json_data), dict,"},{"line_number":157,"context_line":"                      \"JSON version data is not a dict\")"},{"line_number":158,"context_line":"        self.assertIsNotNone(json_data.get(\u0027version\u0027),"},{"line_number":159,"context_line":"                             \"Dict json_data has no key \u0027version\u0027\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_2ac6064a","line":156,"updated":"2017-05-31 07:46:10.000000000","message":"Why not simply use self.assertIsInstance instead? e.g.\n\u003e self.assertIsInstance(json_data, dict, \"JSON version data is not a dict\")","commit_id":"126b422a1be1fe3d0fd3b2f39b81cc8234ed8769"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"da867b33fe2b15e7e71c3343d2cfed858f4029a6","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    def test_data_for_json(self):"},{"line_number":188,"context_line":"        json_data \u003d self.versions_data_view.data_for_json()"},{"line_number":189,"context_line":"        self.assertIsNotNone(json_data, \"JSON data was None\")"},{"line_number":190,"context_line":"        self.assertIs(type(json_data), dict,"},{"line_number":191,"context_line":"                      \"JSON versions data is not a dict\")"},{"line_number":192,"context_line":"        self.assertIsNotNone(json_data.get(\u0027versions\u0027, None),"},{"line_number":193,"context_line":"                             \"Dict json_data has no key \u0027versions\u0027\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_eaddae14","line":190,"updated":"2017-05-31 07:46:10.000000000","message":"Same as above ^ use self.assertIsInstance instead.","commit_id":"126b422a1be1fe3d0fd3b2f39b81cc8234ed8769"}]}
