)]}'
{"trove/guestagent/backup/backupagent.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2b116ca9c345475d0afa3f5965e6cb5a6dc7b70c","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        except Exception:"},{"line_number":116,"context_line":"            LOG.exception("},{"line_number":117,"context_line":"                _(\"Error saving backup: %(backup_id)s.\"), backup_state)"},{"line_number":118,"context_line":"            backup_state.update({\u0027state\u0027: BackupState.FAILED})"},{"line_number":119,"context_line":"            raise"},{"line_number":120,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_ed0eb88a","line":117,"updated":"2017-02-24 14:26:44.000000000","message":"this doesn\u0027t make sense. exceptions will always be logged.","commit_id":"8827cba15e2ca7fba61b9805e6fbb22f50451def"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"765bc1f53ef4053b57b5d23fccabe263373f4ee9","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        except Exception:"},{"line_number":116,"context_line":"            LOG.exception("},{"line_number":117,"context_line":"                _(\"Error saving backup: %(backup_id)s.\"), backup_state)"},{"line_number":118,"context_line":"            backup_state.update({\u0027state\u0027: BackupState.FAILED})"},{"line_number":119,"context_line":"            raise"},{"line_number":120,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_12bbe973","line":117,"in_reply_to":"da36d5c6_ed0eb88a","updated":"2017-03-01 13:49:00.000000000","message":"That\u0027s sure. But if we want to enable H904, we must modify this in order to be able to run H904 correctly. See [1].\n\n[1]: https://review.openstack.org/#/c/343824/2/hacking/checks/other.py","commit_id":"8827cba15e2ca7fba61b9805e6fbb22f50451def"}],"trove/guestagent/datastore/experimental/couchbase/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2b116ca9c345475d0afa3f5965e6cb5a6dc7b70c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            message \u003d _(\"An error occurred in saving password \""},{"line_number":254,"context_line":"                        \"(%(errno)s). %(strerror)s.\")"},{"line_number":255,"context_line":"            err_dict \u003d {\"errno\": err.errno, \"strerror\": err.strerror}"},{"line_number":256,"context_line":"            LOG.exception(message, err_dict)"},{"line_number":257,"context_line":"            raise RuntimeError(message % err_dict)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        operating_system.move(tempname, system.pwd_file, as_root\u003dTrue)"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_2d7610d7","line":257,"range":{"start_line":256,"start_character":12,"end_line":257,"end_character":50},"updated":"2017-02-24 14:26:44.000000000","message":"this is backwards ... you are going to cause the message to get rendered twice rather than once!","commit_id":"8827cba15e2ca7fba61b9805e6fbb22f50451def"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"c5c48af82ed69d3c0b849304a21836f5e716159c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            message \u003d _(\"An error occurred in saving password \""},{"line_number":254,"context_line":"                        \"(%(errno)s). %(strerror)s.\")"},{"line_number":255,"context_line":"            err_dict \u003d {\"errno\": err.errno, \"strerror\": err.strerror}"},{"line_number":256,"context_line":"            LOG.exception(message, err_dict)"},{"line_number":257,"context_line":"            raise RuntimeError(message % err_dict)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        operating_system.move(tempname, system.pwd_file, as_root\u003dTrue)"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_1093b65c","line":257,"range":{"start_line":256,"start_character":12,"end_line":257,"end_character":50},"in_reply_to":"da36d5c6_2d7610d7","updated":"2017-03-01 14:44:38.000000000","message":"I have not answered to your comments, but you are absolutely right!","commit_id":"8827cba15e2ca7fba61b9805e6fbb22f50451def"}],"trove/guestagent/datastore/experimental/db2/manager.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"c62caed91aae4d98f735beccca5809fe0254bf6e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.app.stop_db(do_not_start_on_reboot\u003ddo_not_start_on_reboot)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def create_database(self, context, databases):"},{"line_number":92,"context_line":"        LOG.debug(\"Creating database(s).\", databases)"},{"line_number":93,"context_line":"        with EndNotification(context):"},{"line_number":94,"context_line":"            self.admin.create_database(databases)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_1fea1edb","line":92,"range":{"start_line":92,"start_character":36,"end_line":92,"end_character":39},"updated":"2017-03-06 16:21:03.000000000","message":"Can you fix this to look like the one on L97? \n\nIt should say \"Creating database(s) %s.\"\n\nThis causes an error for me.\n\n\u003e \u003e\u003e\u003e s \u003d \u0027asdf(s)\u0027 % \u0027asdf\u0027\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nTypeError: not all arguments converted during string formatting\n\u003e\u003e\u003e s \u003d \u0027asdf %s\u0027 % \u0027asdf\u0027","commit_id":"530692f75c28bf4aa04857c0d4b10ac676d7a669"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"88a5ffe66d7903eec5c255ea93704b5060ee154b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.app.stop_db(do_not_start_on_reboot\u003ddo_not_start_on_reboot)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def create_database(self, context, databases):"},{"line_number":92,"context_line":"        LOG.debug(\"Creating database(s).\", databases)"},{"line_number":93,"context_line":"        with EndNotification(context):"},{"line_number":94,"context_line":"            self.admin.create_database(databases)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_ab2e35f8","line":92,"range":{"start_line":92,"start_character":36,"end_line":92,"end_character":39},"in_reply_to":"ba2be162_1fea1edb","updated":"2017-03-06 16:47:42.000000000","message":"Sure, great catch! :)","commit_id":"530692f75c28bf4aa04857c0d4b10ac676d7a669"}],"trove/guestagent/datastore/experimental/postgresql/manager.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"c62caed91aae4d98f735beccca5809fe0254bf6e","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            self.app.set_current_admin_user(os_admin)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if snapshot:"},{"line_number":237,"context_line":"            LOG.info(_(\"Found snapshot info: \") + str(snapshot))"},{"line_number":238,"context_line":"            self.attach_replica(context, snapshot, snapshot[\u0027config\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        self.app.start_db()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_9ad53c1d","line":237,"range":{"start_line":237,"start_character":48,"end_line":237,"end_character":63},"updated":"2017-03-06 16:21:03.000000000","message":"what do you think about changing this one?","commit_id":"530692f75c28bf4aa04857c0d4b10ac676d7a669"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"88a5ffe66d7903eec5c255ea93704b5060ee154b","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            self.app.set_current_admin_user(os_admin)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if snapshot:"},{"line_number":237,"context_line":"            LOG.info(_(\"Found snapshot info: \") + str(snapshot))"},{"line_number":238,"context_line":"            self.attach_replica(context, snapshot, snapshot[\u0027config\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        self.app.start_db()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_6e51abd8","line":237,"range":{"start_line":237,"start_character":48,"end_line":237,"end_character":63},"in_reply_to":"ba2be162_9ad53c1d","updated":"2017-03-06 16:47:42.000000000","message":"Done","commit_id":"530692f75c28bf4aa04857c0d4b10ac676d7a669"}]}
