)]}'
{"trove/guestagent/datastore/mysql_common/service.py":[{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"15011289159f23de9d563c6ba1621ea1cfc75c87","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        \"\"\"Clear old configs, which can be incompatible with new version.\"\"\""},{"line_number":742,"context_line":"        LOG.debug(\"Clearing old MySQL config.\")"},{"line_number":743,"context_line":"        random_uuid \u003d str(uuid.uuid4())"},{"line_number":744,"context_line":"        configs \u003d [\"/etc/my.cnf\", \"/etc/mysql/conf.d\", \"/etc/mysql/my.cnf\"]"},{"line_number":745,"context_line":"        for config in configs:"},{"line_number":746,"context_line":"            try:"},{"line_number":747,"context_line":"                old_conf_backup \u003d \"%s_%s\" % (config, random_uuid)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_b644e9b8","line":744,"range":{"start_line":744,"start_character":35,"end_line":744,"end_character":52},"updated":"2017-11-09 22:01:11.000000000","message":"Seems like if the goal is to consolidate the common constant, then this would be updated also. Any reason not to?\n\nSeems like it should be:\nconfigs \u003d [MYSQL_CONFIG, CNF_INCLUDE_DIR]\n\n...but I\u0027m not at all familiar with this code.","commit_id":"e3fd8c682f9a7179b4fa2fc3a0436cc45954263b"},{"author":{"_account_id":23565,"name":"Tomasz Nowak","email":"nowak2000@poczta.onet.pl","username":"tnowak"},"change_message_id":"9a783419baa194031e95cd6b87efbbab29143d2e","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        \"\"\"Clear old configs, which can be incompatible with new version.\"\"\""},{"line_number":742,"context_line":"        LOG.debug(\"Clearing old MySQL config.\")"},{"line_number":743,"context_line":"        random_uuid \u003d str(uuid.uuid4())"},{"line_number":744,"context_line":"        configs \u003d [\"/etc/my.cnf\", \"/etc/mysql/conf.d\", \"/etc/mysql/my.cnf\"]"},{"line_number":745,"context_line":"        for config in configs:"},{"line_number":746,"context_line":"            try:"},{"line_number":747,"context_line":"                old_conf_backup \u003d \"%s_%s\" % (config, random_uuid)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_2a4cfbc5","line":744,"range":{"start_line":744,"start_character":35,"end_line":744,"end_character":52},"in_reply_to":"1f485f77_b644e9b8","updated":"2017-11-10 23:13:24.000000000","message":"This is a list of possible configuration directories possibly (pre-)installed by database engine packages; we want to purge everything before installing guest agent\u0027s files.\nCNF_INCLUDE_DIR is the target location for the new configuration and we need to create this directory; I would make it a guest\u0027s configuration option one day to be easily adjusted to a specific MySQL compilation in use...\nI wouldn\u0027t replace this occurrence, because even if we wanted to create configuration in a different directory, all of these should be cleared.","commit_id":"e3fd8c682f9a7179b4fa2fc3a0436cc45954263b"}]}