)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"5fcb47915831b00143a1eff28b0c41e3ee8a8641","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yu Chaochao \u003cccyu@fiberhome.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-25 00:03:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug#1672263 which table configurations.value affects cmd output show"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"update the two columns from migrate_repo"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1f013ff3_614b052b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"updated":"2017-05-16 20:45:30.000000000","message":"no need for this in the header, we know which bug you are working on by setting the topic to bug/1672263 and also more useful by linking it with the closes-bug tag.\n\nPut a summary of your change on this line. Plain simple english, nothing code specific unless it is a code specific bug. The fix you are describing here is an incompatibility between trove and the version of mysql you are using. Try something like \"make mysql user configuration compatible\"\n\n\u0027which table configurations.value affects cmd output show\u0027 can be interpreted in many ways.\n\nTake a look at this link for a way to write a good commit message https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"ad280226e74ad7bbee5564cde81b93ec7be8cff1"}],"trove/db/sqlalchemy/migrate_repo/versions/020_configurations.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5c31e8c9595c7bf6cd55cfe73da4106eaa57d7c5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    Column(\u0027configuration_id\u0027, String(36), ForeignKey(\"configurations.id\"),"},{"line_number":45,"context_line":"           nullable\u003dFalse, primary_key\u003dTrue),"},{"line_number":46,"context_line":"    Column(\u0027configuration_key\u0027, String(128), nullable\u003dFalse, primary_key\u003dTrue),"},{"line_number":47,"context_line":"    Column(\u0027configuration_value\u0027, String(128)),"},{"line_number":48,"context_line":"    Column(\u0027deleted\u0027, Boolean(), nullable\u003dFalse, default\u003dFalse),"},{"line_number":49,"context_line":"    Column(\u0027deleted_at\u0027, DateTime()),"},{"line_number":50,"context_line":")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_0c6e292f","line":47,"updated":"2017-03-20 10:26:53.000000000","message":"why?","commit_id":"694837c99cea8db8007f016a8238e4ff02fbba3d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"f4f18ede784b6bdfe627f72b0f64d9d7765464ac","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    Column(\u0027configuration_id\u0027, String(36), ForeignKey(\"configurations.id\"),"},{"line_number":45,"context_line":"           nullable\u003dFalse, primary_key\u003dTrue),"},{"line_number":46,"context_line":"    Column(\u0027configuration_key\u0027, String(128), nullable\u003dFalse, primary_key\u003dTrue),"},{"line_number":47,"context_line":"    Column(\u0027configuration_value\u0027, String(128)),"},{"line_number":48,"context_line":"    Column(\u0027deleted\u0027, Boolean(), nullable\u003dFalse, default\u003dFalse),"},{"line_number":49,"context_line":"    Column(\u0027deleted_at\u0027, DateTime()),"},{"line_number":50,"context_line":")"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_22acb733","line":47,"updated":"2017-03-20 19:37:13.000000000","message":"Just leave this file the way it is. The upgrade should make this change for you.\n\nI know you want 512 and you are just undoing your change but on the repository you can see this is still 128[1] your parent is something you created in review[2] and this is bad. You can fix this by using the git rebase --onto command. \n\nTry this:\n\n\u003e git rebase --onto origin/master \u003cold-parent\u003e\nThat will move everything after \u003cold-parent\u003e in the current branch to sit on top of origin/master instead. \u003cold-parent\u003e will be the parent of this patch, which is a62abd10a058594bdb73298dd0a0a97379cdb4b6\n\n[1] http://git.openstack.org/cgit/openstack/trove/tree/trove/db/sqlalchemy/migrate_repo/versions/020_configurations.py#n46\n[2] https://review.openstack.org/gitweb?p\u003dopenstack/trove.git;a\u003dcommitdiff;h\u003da62abd10a058594bdb73298dd0a0a97379cdb4b6\n\nadditional reading http://stackoverflow.com/questions/3810348/setting-git-parent-pointer-to-a-different-parent","commit_id":"822359deb3a6713ee82a0b67f3d5de9c70d18e6d"}],"trove/db/sqlalchemy/migrate_repo/versions/043_change_configuration.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5c31e8c9595c7bf6cd55cfe73da4106eaa57d7c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Tesora, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_8c605937","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":29},"updated":"2017-03-20 10:26:53.000000000","message":"that\u0027s nice, but no. you can\u0027t do that ...","commit_id":"694837c99cea8db8007f016a8238e4ff02fbba3d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5c31e8c9595c7bf6cd55cfe73da4106eaa57d7c5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":27,"context_line":"    # Load \u0027configurations\u0027 table to MetaData."},{"line_number":28,"context_line":"    instances \u003d Table(\u0027configurations\u0027, meta, autoload\u003dTrue)"},{"line_number":29,"context_line":"    instances.c.value.alter(type\u003dString(512))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_8cc77911","line":29,"updated":"2017-03-20 10:26:53.000000000","message":"how do we know that this is enough?","commit_id":"694837c99cea8db8007f016a8238e4ff02fbba3d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"f4f18ede784b6bdfe627f72b0f64d9d7765464ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Tesora, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_a2ac27a1","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"updated":"2017-03-20 19:37:13.000000000","message":"This should be removed completely or replaced with your copyright information.","commit_id":"822359deb3a6713ee82a0b67f3d5de9c70d18e6d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"f4f18ede784b6bdfe627f72b0f64d9d7765464ac","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    # Drop the column and create again with String(512)"},{"line_number":32,"context_line":"    instances.create_column(Column(\u0027configuration_value\u0027, String(512)))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def downgrade(migrate_engine):"},{"line_number":35,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_62894f26","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":8},"updated":"2017-03-20 19:37:13.000000000","message":"downgrade is no longer supported so this can be removed.","commit_id":"822359deb3a6713ee82a0b67f3d5de9c70d18e6d"}],"trove/db/sqlalchemy/migrate_repo/versions/044_change_datastore_version_metadata.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5c31e8c9595c7bf6cd55cfe73da4106eaa57d7c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Tesora, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_cc5a5183","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":29},"updated":"2017-03-20 10:26:53.000000000","message":"that\u0027s nice, but no. you can\u0027t do that ...","commit_id":"694837c99cea8db8007f016a8238e4ff02fbba3d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5c31e8c9595c7bf6cd55cfe73da4106eaa57d7c5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":26,"context_line":"    # Load \u0027datastore_version_metadata\u0027 table to MetaData."},{"line_number":27,"context_line":"    instances \u003d Table(\u0027datastore_version_metadata\u0027, meta, autoload\u003dTrue)"},{"line_number":28,"context_line":"    instances.c.value.alter(type(String(512))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_4c4f41bd","line":28,"updated":"2017-03-20 10:26:53.000000000","message":"how do we know that this is enough?","commit_id":"694837c99cea8db8007f016a8238e4ff02fbba3d"}]}