)]}'
{"trove/cluster/models.py":[{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"ad8d427cbfd1cb20d255fdaab5fcedbdca3f23d4","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def validate_cluster_available(self, valid_states\u003d[ClusterTasks.NONE]):"},{"line_number":273,"context_line":"        if self.db_info.task_status not in valid_states:"},{"line_number":274,"context_line":"            msg \u003d (\"This action cannot be performed on the cluster while \""},{"line_number":275,"context_line":"                   \"the current cluster task is \u0027%s\u0027.\" %"},{"line_number":276,"context_line":"                   self.db_info.task_status.name)"},{"line_number":277,"context_line":"            LOG.error(msg)"},{"line_number":278,"context_line":"            raise exception.UnprocessableEntity(msg)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def delete(self):"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_4dba976e","line":278,"range":{"start_line":274,"start_character":11,"end_line":278,"end_character":52},"updated":"2018-01-23 07:03:23.000000000","message":"1. If a string is being used to generate an exception, it will still be translated. Still Trove used both _LE and _ for these translations,there are some cases where _LE has been simply changed to _, and not removed.\n\n\nFor this purpose, should we keep the translation of msg in raise?","commit_id":"56b4c30a8c4be202311b8086e1e9a9a31f15e0ca"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"1c013ed6193dce0286037d08a086c6bc7b0afe9d","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def validate_cluster_available(self, valid_states\u003d[ClusterTasks.NONE]):"},{"line_number":273,"context_line":"        if self.db_info.task_status not in valid_states:"},{"line_number":274,"context_line":"            msg \u003d (\"This action cannot be performed on the cluster while \""},{"line_number":275,"context_line":"                   \"the current cluster task is \u0027%s\u0027.\" %"},{"line_number":276,"context_line":"                   self.db_info.task_status.name)"},{"line_number":277,"context_line":"            LOG.error(msg)"},{"line_number":278,"context_line":"            raise exception.UnprocessableEntity(msg)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def delete(self):"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_78339314","line":278,"range":{"start_line":274,"start_character":11,"end_line":278,"end_character":52},"in_reply_to":"7f96bb07_4dba976e","updated":"2018-01-23 07:44:50.000000000","message":"Yes, translations for raising exceptions should be kept. I\u0027ll check all these files for another time.\n\nThanks.","commit_id":"56b4c30a8c4be202311b8086e1e9a9a31f15e0ca"}],"trove/common/profile.py":[{"author":{"_account_id":25067,"name":"yfzhao","email":"dsware@126.com","username":"yfzhao"},"change_message_id":"68550cd9387520a9b4fa137db7b80e19219d98fb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            rpc.TRANSPORT, \"trove\", binary, host)"},{"line_number":35,"context_line":"        notifier.set(_notifier)"},{"line_number":36,"context_line":"        web.enable(CONF.profiler.hmac_keys)"},{"line_number":37,"context_line":"        LOG.warning((\"The OpenStack Profiler is enabled. Using one\""},{"line_number":38,"context_line":"                        \" of the hmac_keys specified in the trove.conf file \""},{"line_number":39,"context_line":"                        \"(typically in /etc/trove), a trace can be made of \""},{"line_number":40,"context_line":"                        \"all requests. Only an admin user can retrieve \""},{"line_number":41,"context_line":"                        \"the trace information, however.\\n\""},{"line_number":42,"context_line":"                        \"To disable the profiler, add the following to the \""},{"line_number":43,"context_line":"                        \"configuration file:\\n\""},{"line_number":44,"context_line":"                        \"[profiler]\\n\""},{"line_number":45,"context_line":"                        \"enabled\u003dfalse\"))"},{"line_number":46,"context_line":"    else:"},{"line_number":47,"context_line":"        web.disable()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_a5875eb3","line":45,"range":{"start_line":37,"start_character":20,"end_line":45,"end_character":40},"updated":"2017-03-23 02:24:03.000000000","message":"\"(\" and \")\" should be deleted, It\u0027s redundance","commit_id":"8c0b2d14bcc11db5b471b66fc6836318e226f9c6"}],"trove/common/rpc/service.py":[{"author":{"_account_id":25067,"name":"yfzhao","email":"dsware@126.com","username":"yfzhao"},"change_message_id":"68550cd9387520a9b4fa137db7b80e19219d98fb","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            self.rpcserver.stop()"},{"line_number":84,"context_line":"        except Exception:"},{"line_number":85,"context_line":"            LOG.info((\"Failed to stop RPC server before shutdown. \"))"},{"line_number":86,"context_line":"            pass"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        super(RpcService, self).stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_2569aef9","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":68},"updated":"2017-03-23 02:24:03.000000000","message":"maybe no need to change here","commit_id":"8c0b2d14bcc11db5b471b66fc6836318e226f9c6"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"91ab32b1f92c3feec1675efab54d5832e5e36c15","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            self.rpcserver.stop()"},{"line_number":84,"context_line":"        except Exception:"},{"line_number":85,"context_line":"            LOG.info((\"Failed to stop RPC server before shutdown. \"))"},{"line_number":86,"context_line":"            pass"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        super(RpcService, self).stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_bc192c24","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":68},"in_reply_to":"1a1ced50_2569aef9","updated":"2017-03-23 08:22:40.000000000","message":"why?","commit_id":"8c0b2d14bcc11db5b471b66fc6836318e226f9c6"}],"trove/common/strategies/cluster/experimental/cassandra/taskmanager.py":[{"author":{"_account_id":25067,"name":"yfzhao","email":"dsware@126.com","username":"yfzhao"},"change_message_id":"68550cd9387520a9b4fa137db7b80e19219d98fb","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                    LOG.debug(\"Waiting for node to finish its \""},{"line_number":240,"context_line":"                              \"cleanup: %s\" % nid)"},{"line_number":241,"context_line":"                    if not self._all_instances_running([nid], cluster_id):"},{"line_number":242,"context_line":"                        LOG.warning((\"Node did not complete cleanup \""},{"line_number":243,"context_line":"                                      \"successfully: %s\") % nid)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"                LOG.debug(\"Cluster configuration finished successfully.\")"},{"line_number":246,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_e57b16bc","line":243,"range":{"start_line":242,"start_character":35,"end_line":243,"end_character":64},"updated":"2017-03-23 02:24:03.000000000","message":"maybe no need to change here","commit_id":"8c0b2d14bcc11db5b471b66fc6836318e226f9c6"}],"trove/common/strategies/cluster/experimental/galera_common/taskmanager.py":[{"author":{"_account_id":25067,"name":"yfzhao","email":"dsware@126.com","username":"yfzhao"},"change_message_id":"68550cd9387520a9b4fa137db7b80e19219d98fb","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                        set(non_deleted_ids))"},{"line_number":278,"context_line":"                )"},{"line_number":279,"context_line":"            try:"},{"line_number":280,"context_line":"                LOG.info((\"Deleting instances (%s)\") % removal_instance_ids)"},{"line_number":281,"context_line":"                utils.poll_until(all_instances_marked_deleted,"},{"line_number":282,"context_line":"                                 sleep_time\u003d2,"},{"line_number":283,"context_line":"                                 time_out\u003dCONF.cluster_delete_time_out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_a55cbe4b","line":280,"range":{"start_line":280,"start_character":25,"end_line":280,"end_character":76},"updated":"2017-03-23 02:24:03.000000000","message":"maybe no need to change here","commit_id":"8c0b2d14bcc11db5b471b66fc6836318e226f9c6"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"91ab32b1f92c3feec1675efab54d5832e5e36c15","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                        set(non_deleted_ids))"},{"line_number":278,"context_line":"                )"},{"line_number":279,"context_line":"            try:"},{"line_number":280,"context_line":"                LOG.info((\"Deleting instances (%s)\") % removal_instance_ids)"},{"line_number":281,"context_line":"                utils.poll_until(all_instances_marked_deleted,"},{"line_number":282,"context_line":"                                 sleep_time\u003d2,"},{"line_number":283,"context_line":"                                 time_out\u003dCONF.cluster_delete_time_out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_1cd96057","line":280,"range":{"start_line":280,"start_character":25,"end_line":280,"end_character":76},"in_reply_to":"1a1ced50_a55cbe4b","updated":"2017-03-23 08:22:40.000000000","message":"why?","commit_id":"8c0b2d14bcc11db5b471b66fc6836318e226f9c6"}],"trove/guestagent/datastore/experimental/db2/manager.py":[{"author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"change_message_id":"afb9ddcd88a815726b5750c031c97b4d020ba162","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                          backup_info[\u0027id\u0027])"},{"line_number":140,"context_line":"            self.status.set_status(ds_instance.ServiceStatuses.FAILED)"},{"line_number":141,"context_line":"            raise"},{"line_number":142,"context_line":"        LOG.info((\"Restored database successfully.\"))"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def create_backup(self, context, backup_info):"},{"line_number":145,"context_line":"        LOG.debug(\"Creating backup.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_038be16d","line":142,"range":{"start_line":142,"start_character":19,"end_line":142,"end_character":27},"updated":"2017-03-28 04:02:50.000000000","message":"\"(\" and \")\" should be deleted, It\u0027s redundance","commit_id":"8c0b2d14bcc11db5b471b66fc6836318e226f9c6"}],"trove/guestagent/datastore/experimental/mongodb/manager.py":[{"author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"change_message_id":"afb9ddcd88a815726b5750c031c97b4d020ba162","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                          backup_info[\u0027id\u0027])"},{"line_number":191,"context_line":"            self.status.set_status(ds_instance.ServiceStatuses.FAILED)"},{"line_number":192,"context_line":"            raise"},{"line_number":193,"context_line":"        LOG.info((\"Restored database successfully.\"))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def create_backup(self, context, backup_info):"},{"line_number":196,"context_line":"        LOG.debug(\"Creating backup.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_23eb8513","line":193,"range":{"start_line":193,"start_character":16,"end_line":193,"end_character":19},"updated":"2017-03-28 04:02:50.000000000","message":"\"(\" and \")\" should be deleted, It\u0027s redundance","commit_id":"8c0b2d14bcc11db5b471b66fc6836318e226f9c6"}]}