)]}'
{"trove/db/sqlalchemy/migrate_repo/versions/016_add_floating_ips_artifacts.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"floating_ips \u003d Table("},{"line_number":32,"context_line":"    \u0027floating_ips\u0027,"},{"line_number":33,"context_line":"    meta,"},{"line_number":34,"context_line":"    Column(\u0027id\u0027, String(length\u003d64), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":35,"context_line":"    Column(\u0027pool_size\u0027, String(length\u003d255)),"},{"line_number":36,"context_line":"    Column(\u0027pool\u0027, String(length\u003d255)),"},{"line_number":37,"context_line":"    Column(\u0027user\u0027, String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3Cs%3D","line":34,"updated":"2013-09-18 05:57:32.000000000","message":"Is this a UUID? if so, shoudln\u0027t it be length\u003d36?","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0027floating_ips\u0027,"},{"line_number":33,"context_line":"    meta,"},{"line_number":34,"context_line":"    Column(\u0027id\u0027, String(length\u003d64), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":35,"context_line":"    Column(\u0027pool_size\u0027, String(length\u003d255)),"},{"line_number":36,"context_line":"    Column(\u0027pool\u0027, String(length\u003d255)),"},{"line_number":37,"context_line":"    Column(\u0027user\u0027, String(length\u003d255)),"},{"line_number":38,"context_line":"    Column(\u0027tenant_id\u0027, String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3Dg%3D","line":35,"updated":"2013-09-18 05:57:32.000000000","message":"pool_size seems to be a numerical value in conf, why is it a string here?","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    meta,"},{"line_number":34,"context_line":"    Column(\u0027id\u0027, String(length\u003d64), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":35,"context_line":"    Column(\u0027pool_size\u0027, String(length\u003d255)),"},{"line_number":36,"context_line":"    Column(\u0027pool\u0027, String(length\u003d255)),"},{"line_number":37,"context_line":"    Column(\u0027user\u0027, String(length\u003d255)),"},{"line_number":38,"context_line":"    Column(\u0027tenant_id\u0027, String(length\u003d255)),"},{"line_number":39,"context_line":"    Column(\u0027created\u0027, DateTime()),"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3C0%3D","line":36,"updated":"2013-09-18 05:57:32.000000000","message":"From what i\u0027m seeing so far, pool \u003d ip.  Can you rename this to IP?\n\nfwiw, I don\u0027t like duplicating info that\u0027s already in Nova in Trove.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"20027368a9f47683287c3172b192e82fbffbc514","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    meta,"},{"line_number":34,"context_line":"    Column(\u0027id\u0027, String(length\u003d64), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":35,"context_line":"    Column(\u0027pool_size\u0027, String(length\u003d255)),"},{"line_number":36,"context_line":"    Column(\u0027pool\u0027, String(length\u003d255)),"},{"line_number":37,"context_line":"    Column(\u0027user\u0027, String(length\u003d255)),"},{"line_number":38,"context_line":"    Column(\u0027tenant_id\u0027, String(length\u003d255)),"},{"line_number":39,"context_line":"    Column(\u0027created\u0027, DateTime()),"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2FybA%3D","line":36,"in_reply_to":"AAAAS3%2F%2F3C0%3D","updated":"2013-09-19 09:34:37.000000000","message":"We are not duplicating anything! We reserving custom pool of IPS for current instance!","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"}],"trove/extensions/floating_ips/models.py":[{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"62bcef5a8e79e4db866c18cc7fcd3cea8308f29f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @property"},{"line_number":47,"context_line":"    def instance_id(self):"},{"line_number":48,"context_line":"        return FloatingIPsInstanceAssociation. \\"},{"line_number":49,"context_line":"            get_instance_id_by_pool_id(self.id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def check_availability(cls, pool_size, context):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FOB0%3D","line":49,"updated":"2013-09-09 19:48:08.000000000","message":"Won\u0027t this be an error?","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"3fa29d7f3a71b36c24af52ff12e589fb6e0faf48","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @property"},{"line_number":47,"context_line":"    def instance_id(self):"},{"line_number":48,"context_line":"        return FloatingIPsInstanceAssociation. \\"},{"line_number":49,"context_line":"            get_instance_id_by_pool_id(self.id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def check_availability(cls, pool_size, context):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNxs%3D","line":49,"in_reply_to":"AAAASn%2F%2FN6M%3D","updated":"2013-09-09 21:04:40.000000000","message":"I may be reading this wrong, but it looks like \"get_instance_id_by_pool_id\" is not a global method and needs to be called like \"FloatingIPsInstanceAssociation.get_instance_id_by_pool_id\".","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dbc2405db9bbffff3d844dc669f19672ecafc9da","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @property"},{"line_number":47,"context_line":"    def instance_id(self):"},{"line_number":48,"context_line":"        return FloatingIPsInstanceAssociation. \\"},{"line_number":49,"context_line":"            get_instance_id_by_pool_id(self.id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def check_availability(cls, pool_size, context):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNuo%3D","line":49,"in_reply_to":"AAAASn%2F%2FNxs%3D","updated":"2013-09-09 21:11:38.000000000","message":"Right, this is how it should be called.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8479b3250b12faef0199641cc5587b801730824f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @property"},{"line_number":47,"context_line":"    def instance_id(self):"},{"line_number":48,"context_line":"        return FloatingIPsInstanceAssociation. \\"},{"line_number":49,"context_line":"            get_instance_id_by_pool_id(self.id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def check_availability(cls, pool_size, context):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FN6M%3D","line":49,"in_reply_to":"AAAASn%2F%2FOB0%3D","updated":"2013-09-09 20:17:00.000000000","message":"why ?","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"62bcef5a8e79e4db866c18cc7fcd3cea8308f29f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            raise e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def get_pool(cls, pool_size, context):"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            pool \u003d RemoteFloatingIPs.create_pool(pool_size, context)"},{"line_number":67,"context_line":"            if len(pool) !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FOBI%3D","line":64,"updated":"2013-09-09 19:48:08.000000000","message":"\u0027get\u0027 implies it will retrieve an object that was already created.\nThis method should be renamed to \u0027create_pool.\u0027","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"3fa29d7f3a71b36c24af52ff12e589fb6e0faf48","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            raise e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def get_pool(cls, pool_size, context):"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            pool \u003d RemoteFloatingIPs.create_pool(pool_size, context)"},{"line_number":67,"context_line":"            if len(pool) !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNw8%3D","line":64,"in_reply_to":"AAAASn%2F%2FN6E%3D","updated":"2013-09-09 21:04:40.000000000","message":"I may be misunderstanding. Are you saying at this point it already exists in the Trove database?","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a65bd02f605be421a86b91589e1a10dbbb21da20","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            raise e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def get_pool(cls, pool_size, context):"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            pool \u003d RemoteFloatingIPs.create_pool(pool_size, context)"},{"line_number":67,"context_line":"            if len(pool) !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FM1Y%3D","line":64,"in_reply_to":"AAAASn%2F%2FNkA%3D","updated":"2013-09-10 04:43:26.000000000","message":"i\u0027m relaying on nova api calls, there is create new ip, which means \u0027allocate\u0027 it and \u0027list pool\u0027, which means list already existed objects.\nSo, i\u0027m suggesting to name this method \u0027define_pool\u0027","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"15ac21a70f5df5c0900d5ff581e4ca05d55e2e2c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            raise e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def get_pool(cls, pool_size, context):"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            pool \u003d RemoteFloatingIPs.create_pool(pool_size, context)"},{"line_number":67,"context_line":"            if len(pool) !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNkA%3D","line":64,"in_reply_to":"AAAASn%2F%2FNto%3D","updated":"2013-09-09 21:50:24.000000000","message":"Because it writes new associations into Trove \"create\" makes sense. If you think that name isn\u0027t good, I\u0027m open to suggestions, but reading the code \"get\" looks like it\u0027s retrieving an object which already existed in Trove.\n\nHow about \"claim_pool\" or something to better imply it is claiming a resource from Nova?","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dbc2405db9bbffff3d844dc669f19672ecafc9da","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            raise e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def get_pool(cls, pool_size, context):"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            pool \u003d RemoteFloatingIPs.create_pool(pool_size, context)"},{"line_number":67,"context_line":"            if len(pool) !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNto%3D","line":64,"in_reply_to":"AAAASn%2F%2FNw8%3D","updated":"2013-09-09 21:11:38.000000000","message":"No, they are allocated in novanetwork. Novaclient recieves list of available floating ips. They are already created. So, in trove, we just getting part of this list and writing associations to trove database, than assigning to instance.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8479b3250b12faef0199641cc5587b801730824f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            raise e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def get_pool(cls, pool_size, context):"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            pool \u003d RemoteFloatingIPs.create_pool(pool_size, context)"},{"line_number":67,"context_line":"            if len(pool) !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FN6E%3D","line":64,"in_reply_to":"AAAASn%2F%2FOBI%3D","updated":"2013-09-09 20:17:00.000000000","message":"No, because this method retrieves already created pool from novanetwork. At this point you are wrong","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"62bcef5a8e79e4db866c18cc7fcd3cea8308f29f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                    tenant\u003dcontext.tenant"},{"line_number":74,"context_line":"                )"},{"line_number":75,"context_line":"            else:"},{"line_number":76,"context_line":"                return"},{"line_number":77,"context_line":"        except exception.FloatingIPsListingError as e:"},{"line_number":78,"context_line":"            LOG.exception(\"Failed to list floating ips\")"},{"line_number":79,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FOBo%3D","line":76,"updated":"2013-09-09 19:48:08.000000000","message":"This is unnecessary.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"62bcef5a8e79e4db866c18cc7fcd3cea8308f29f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            raise e"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @classmethod"},{"line_number":82,"context_line":"    def get_pool_for_instance(cls, pool_size, instance_id, context):"},{"line_number":83,"context_line":"        if pool_size !\u003d 0:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            pool_obj \u003d cls.get_pool(pool_size, context)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FOAQ%3D","line":82,"updated":"2013-09-09 19:48:08.000000000","message":"Should be \u0027create_pool_for_instance\u0027.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"15ac21a70f5df5c0900d5ff581e4ca05d55e2e2c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            raise e"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @classmethod"},{"line_number":82,"context_line":"    def get_pool_for_instance(cls, pool_size, instance_id, context):"},{"line_number":83,"context_line":"        if pool_size !\u003d 0:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            pool_obj \u003d cls.get_pool(pool_size, context)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNj8%3D","line":82,"in_reply_to":"AAAASn%2F%2FN6A%3D","updated":"2013-09-09 21:50:24.000000000","message":"I think \"create_pool_for_instance\" or \"associate_pool_to_instance\" would read better.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a65bd02f605be421a86b91589e1a10dbbb21da20","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            raise e"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @classmethod"},{"line_number":82,"context_line":"    def get_pool_for_instance(cls, pool_size, instance_id, context):"},{"line_number":83,"context_line":"        if pool_size !\u003d 0:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            pool_obj \u003d cls.get_pool(pool_size, context)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FM1U%3D","line":82,"in_reply_to":"AAAASn%2F%2FNj8%3D","updated":"2013-09-10 04:43:26.000000000","message":"previous comment","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8479b3250b12faef0199641cc5587b801730824f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            raise e"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @classmethod"},{"line_number":82,"context_line":"    def get_pool_for_instance(cls, pool_size, instance_id, context):"},{"line_number":83,"context_line":"        if pool_size !\u003d 0:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            pool_obj \u003d cls.get_pool(pool_size, context)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FN6A%3D","line":82,"in_reply_to":"AAAASn%2F%2FOAQ%3D","updated":"2013-09-09 20:17:00.000000000","message":"cool at previous comment )","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"62bcef5a8e79e4db866c18cc7fcd3cea8308f29f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            raise e"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @classmethod"},{"line_number":164,"context_line":"    def detele(cls, floating_ip_id, context):"},{"line_number":165,"context_line":"        client \u003d remote.create_nova_client(context)"},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            client.floating_ips.delete(floating_ip_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FN%2Fk%3D","line":164,"updated":"2013-09-09 19:48:08.000000000","message":"Should be \"delete\".","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8479b3250b12faef0199641cc5587b801730824f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            raise e"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @classmethod"},{"line_number":164,"context_line":"    def detele(cls, floating_ip_id, context):"},{"line_number":165,"context_line":"        client \u003d remote.create_nova_client(context)"},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            client.floating_ips.delete(floating_ip_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FN5w%3D","line":164,"in_reply_to":"AAAASn%2F%2FN%2Fk%3D","updated":"2013-09-09 20:17:00.000000000","message":"true","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"fb565bbf25676fedac2791648eea29e55de8770e","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"},{"line_number":46,"context_line":"    def instance_id(self):"},{"line_number":47,"context_line":"        return FloatingIPsInstanceAssociation. \\"},{"line_number":48,"context_line":"            get_instance_id_by_pool_id(self.id)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2F9WU%3D","line":47,"updated":"2013-09-16 15:34:55.000000000","message":"I\u0027d rather you used an alias than continued this line with \\.\n\n    ipassoc \u003d FloatingIPsInstanceAssociation\n    return ipassoc.get_instance_id_by_pool_id(self.id)","commit_id":"a331da06d866a4a2998553cbdf0c83bb89d3dece"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"a5f8090134a14f99425ef12d7a189f37404a26d3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            raise e"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @classmethod"},{"line_number":63,"context_line":"    def get_pool(cls, pool_size, context):"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            pool \u003d RemoteFloatingIPs.reserve_pool(pool_size, context)"},{"line_number":66,"context_line":"            if len(pool) !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2F8S0%3D","line":63,"updated":"2013-09-16 20:31:02.000000000","message":"I\u0027m willing to compromise on naming this method \"define_pool\" as you suggested.","commit_id":"a331da06d866a4a2998553cbdf0c83bb89d3dece"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                    \u0027user\u0027, \u0027tenant_id\u0027, \u0027created\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"},{"line_number":46,"context_line":"    def instance_id(self):"},{"line_number":47,"context_line":"        association \u003d FloatingIPsInstanceAssociation"},{"line_number":48,"context_line":"        return (association."},{"line_number":49,"context_line":"                get_instance_id_by_pool_id(self.id))"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3Eg%3D","line":46,"updated":"2013-09-18 05:57:32.000000000","message":"Seems like an unlikely lookup.  I may lookup an instance_id by a floating_ip, but unlikely to look it up via the FloatingIP.id field","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def check_availability(cls, pool_size, context):"},{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            if len(RemoteFloatingIPs.list_floatings(context)) \u003e\u003d pool_size:"},{"line_number":55,"context_line":"                return True"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3EE%3D","line":54,"updated":"2013-09-18 05:57:32.000000000","message":"list_floatings will return IPs that are already associated with instances.  I am not sure how this proves availability.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def check_availability(cls, pool_size, context):"},{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            if len(RemoteFloatingIPs.list_floatings(context)) \u003e\u003d pool_size:"},{"line_number":55,"context_line":"                return True"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F20I%3D","line":54,"in_reply_to":"AAAAS3%2F%2F3EE%3D","updated":"2013-09-18 07:12:52.000000000","message":"At this point you are wrong. This method will return list of  available floating ips, so, if len is enough we\u0027ll go deeper.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise e"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @classmethod"},{"line_number":80,"context_line":"    def get_pool_for_instance(cls, pool_size, instance_id, context):"},{"line_number":81,"context_line":"        if pool_size !\u003d 0:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            pool_obj \u003d cls.define_pool(pool_size, context)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3FQ%3D","line":80,"updated":"2013-09-18 05:57:32.000000000","message":"This is really confusing to me.  Why are we defining/fetching a pool for an instance?  When I provision an instance, I may choose to attach a Floating IP to an instance, I never think about allocating a pool for that instance.\n\nMaybe i\u0027m missing something here.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise e"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @classmethod"},{"line_number":80,"context_line":"    def get_pool_for_instance(cls, pool_size, instance_id, context):"},{"line_number":81,"context_line":"        if pool_size !\u003d 0:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            pool_obj \u003d cls.define_pool(pool_size, context)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F2z0%3D","line":80,"in_reply_to":"AAAAS3%2F%2F3FQ%3D","updated":"2013-09-18 07:12:52.000000000","message":"Here we are reserving pool for future assignment. This will protect us from racing at attaching call.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    _data_fields \u003d [\u0027id\u0027, \u0027pool_id\u0027, \u0027instance_id\u0027,"},{"line_number":101,"context_line":"                    \u0027created\u0027, \u0027deleted\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def get_pool_by_id(self):"},{"line_number":104,"context_line":"        return FloatingIPs.find_by(id\u003dself.pool_id,"},{"line_number":105,"context_line":"                                   deleted\u003dFalse)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3EQ%3D","line":103,"updated":"2013-09-18 05:57:32.000000000","message":"Why does this exist in this class, if it\u0027s purely looking up a record from the other table?","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                                   deleted\u003dFalse)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @classmethod"},{"line_number":108,"context_line":"    def get_all_reserved_pools(cls):"},{"line_number":109,"context_line":"        return FloatingIPs.find_all()"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3Gg%3D","line":108,"updated":"2013-09-18 05:57:32.000000000","message":"What does this method have to do with instance association?  Why is it in this class?","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class RemoteFloatingIPs(NovaRemoteModelBase):"},{"line_number":127,"context_line":"    @classmethod"},{"line_number":128,"context_line":"    def list_floatings(cls, context):"},{"line_number":129,"context_line":"        client \u003d remote.create_nova_client(context)"},{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            return client.floating_ips.list()"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3GE%3D","line":128,"updated":"2013-09-18 05:57:32.000000000","message":"this can be more clearly named such as \u0027list_floating_ips\u0027","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class RemoteFloatingIPs(NovaRemoteModelBase):"},{"line_number":127,"context_line":"    @classmethod"},{"line_number":128,"context_line":"    def list_floatings(cls, context):"},{"line_number":129,"context_line":"        client \u003d remote.create_nova_client(context)"},{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            return client.floating_ips.list()"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F2zo%3D","line":128,"in_reply_to":"AAAAS3%2F%2F3GE%3D","updated":"2013-09-18 07:12:52.000000000","message":"yes, it could be.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            pool \u003d []"},{"line_number":141,"context_line":"            reserved_ips \u003d []"},{"line_number":142,"context_line":"            reserved_pools \u003d [floatings[\u0027pool\u0027] for floatings in"},{"line_number":143,"context_line":"                              FloatingIPsInstanceAssociation."},{"line_number":144,"context_line":"                              get_all_reserved_pools()]"},{"line_number":145,"context_line":"            for reserved_pool in reserved_pools:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3F8%3D","line":142,"updated":"2013-09-18 05:57:32.000000000","message":"if \u0027pool\u0027 is really an IP, why are we naming it \u0027pool\u0027, why not name it \u0027ip\u0027 or \u0027floating_ip\u0027?","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            pool \u003d []"},{"line_number":141,"context_line":"            reserved_ips \u003d []"},{"line_number":142,"context_line":"            reserved_pools \u003d [floatings[\u0027pool\u0027] for floatings in"},{"line_number":143,"context_line":"                              FloatingIPsInstanceAssociation."},{"line_number":144,"context_line":"                              get_all_reserved_pools()]"},{"line_number":145,"context_line":"            for reserved_pool in reserved_pools:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F2zg%3D","line":142,"in_reply_to":"AAAAS3%2F%2F3F8%3D","updated":"2013-09-18 07:12:52.000000000","message":"because amount of floating ips for each instance could be more than one.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            for reserved_pool in reserved_pools:"},{"line_number":146,"context_line":"                ips \u003d reserved_pool.split(\u0027 \u0027)"},{"line_number":147,"context_line":"                reserved_ips.extend(ips)"},{"line_number":148,"context_line":"            current_pool \u003d [ip.ip for ip in client.floating_ips.list()]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            free_ips \u003d list(set(current_pool) - set(reserved_ips))"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3GI%3D","line":148,"updated":"2013-09-18 05:57:32.000000000","message":"So the first time this runs, reserved_pools will be empty.  client.floating_ips.list() will return nothing.  How/when are floating IPs getting allocated?","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            for reserved_pool in reserved_pools:"},{"line_number":146,"context_line":"                ips \u003d reserved_pool.split(\u0027 \u0027)"},{"line_number":147,"context_line":"                reserved_ips.extend(ips)"},{"line_number":148,"context_line":"            current_pool \u003d [ip.ip for ip in client.floating_ips.list()]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            free_ips \u003d list(set(current_pool) - set(reserved_ips))"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F2zM%3D","line":148,"in_reply_to":"AAAAS3%2F%2F3GI%3D","updated":"2013-09-18 07:12:52.000000000","message":"Again. client.floating_ips.list() - would never return nothing, in any deployments of nova there alway would be some kind of pool allocated in novanetwork.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                reserved_ips.extend(ips)"},{"line_number":148,"context_line":"            current_pool \u003d [ip.ip for ip in client.floating_ips.list()]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            free_ips \u003d list(set(current_pool) - set(reserved_ips))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            if len(free_ips) \u003e\u003d pool_size:"},{"line_number":153,"context_line":"                pool \u003d [ip for ip"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3Fo%3D","line":150,"updated":"2013-09-18 05:57:32.000000000","message":"What if there are no free IPs when you do floating_ips.list()?  Shouldn\u0027t we also look at the instance_id field that comes back to determine whether it\u0027s attached to an instance?","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                reserved_ips.extend(ips)"},{"line_number":148,"context_line":"            current_pool \u003d [ip.ip for ip in client.floating_ips.list()]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            free_ips \u003d list(set(current_pool) - set(reserved_ips))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            if len(free_ips) \u003e\u003d pool_size:"},{"line_number":153,"context_line":"                pool \u003d [ip for ip"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F2zA%3D","line":150,"in_reply_to":"AAAAS3%2F%2F3Fo%3D","updated":"2013-09-18 07:12:52.000000000","message":"if there is no free floating ips, all logic will bring emty list.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            raise exception.FloatingIPsReservationError(str(e))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @classmethod"},{"line_number":162,"context_line":"    def delete(cls, floating_ip_id, context):"},{"line_number":163,"context_line":"        client \u003d remote.create_nova_client(context)"},{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            client.floating_ips.delete(floating_ip_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3EA%3D","line":162,"updated":"2013-09-18 05:57:32.000000000","message":"Don\u0027t see any client code that actually invokes this.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            raise exception.FloatingIPsReservationError(str(e))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @classmethod"},{"line_number":162,"context_line":"    def delete(cls, floating_ip_id, context):"},{"line_number":163,"context_line":"        client \u003d remote.create_nova_client(context)"},{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            client.floating_ips.delete(floating_ip_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F2yw%3D","line":162,"in_reply_to":"AAAAS3%2F%2F3EA%3D","updated":"2013-09-18 07:12:52.000000000","message":"Yes, this was one for future. So, it could be deleted.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            raise exception.FloatingIPsDeleteError(str(e))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @classmethod"},{"line_number":171,"context_line":"    def remove_from_instance(cls, floating_ip_id, server, context):"},{"line_number":172,"context_line":"        client \u003d remote.create_nova_client(context)"},{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            client.servers.remove_floating_ip(server, floating_ip_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3D8%3D","line":171,"updated":"2013-09-18 05:57:32.000000000","message":"Don\u0027t see any client code that actually invokes this.  I\u0027d imagine we\u0027d want to remove prior to deleting an instance.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            raise exception.FloatingIPsDeleteError(str(e))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @classmethod"},{"line_number":171,"context_line":"    def remove_from_instance(cls, floating_ip_id, server, context):"},{"line_number":172,"context_line":"        client \u003d remote.create_nova_client(context)"},{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            client.servers.remove_floating_ip(server, floating_ip_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F2yo%3D","line":171,"in_reply_to":"AAAAS3%2F%2F3D8%3D","updated":"2013-09-18 07:12:52.000000000","message":"this one will be used in rollback.","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"}],"trove/extensions/floating_ips/service.py":[{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"62bcef5a8e79e4db866c18cc7fcd3cea8308f29f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FN%2Bo%3D","line":17,"updated":"2013-09-09 19:48:08.000000000","message":"There\u0027s no reason to add this file until it has something in it.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8479b3250b12faef0199641cc5587b801730824f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FN5k%3D","line":17,"in_reply_to":"AAAASn%2F%2FN%2Bo%3D","updated":"2013-09-09 20:17:00.000000000","message":"autogenerated code via pycharm","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"3fa29d7f3a71b36c24af52ff12e589fb6e0faf48","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNwI%3D","line":17,"in_reply_to":"AAAASn%2F%2FN5k%3D","updated":"2013-09-09 21:04:40.000000000","message":"Let\u0027s go ahead and take it out.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"}],"trove/instance/models.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"fb565bbf25676fedac2791648eea29e55de8770e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        # The service is only paused during a reboot."},{"line_number":204,"context_line":"        if ServiceStatuses.PAUSED \u003d\u003d self.service_status.status:"},{"line_number":205,"context_line":"            return InstanceStatus.REBOOT"},{"line_number":206,"context_line":"            # If the service status is NEW, then we are building."},{"line_number":207,"context_line":"        if ServiceStatuses.NEW \u003d\u003d self.service_status.status:"},{"line_number":208,"context_line":"            return InstanceStatus.BUILD"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2F9X4%3D","line":206,"updated":"2013-09-16 15:34:55.000000000","message":"I don\u0027t think this should be indented this far, but instead on level with 207.","commit_id":"a331da06d866a4a2998553cbdf0c83bb89d3dece"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"fb565bbf25676fedac2791648eea29e55de8770e","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                        db.server_status \u003d server.status"},{"line_number":675,"context_line":"                    except exception.ComputeInstanceNotFound:"},{"line_number":676,"context_line":"                        db.server_status \u003d \"SHUTDOWN\"  # Fake it..."},{"line_number":677,"context_line":"                    #TODO(tim.simpson): End of hack."},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"                #volumes \u003d find_volumes(server.id)"},{"line_number":680,"context_line":"                status \u003d InstanceServiceStatus.find_by(instance_id\u003ddb.id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2F9XY%3D","line":677,"updated":"2013-09-16 15:34:55.000000000","message":"I think this is to be indented at the same level of 668, 669, and 671.","commit_id":"a331da06d866a4a2998553cbdf0c83bb89d3dece"}],"trove/taskmanager/models.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7b4841f8f65fc19b0ecda95f1ba0d118adfacc29","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            if pool:"},{"line_number":241,"context_line":"                for ip in pool:"},{"line_number":242,"context_line":"                    self._nova_client.servers.add_floating_ip(server, ip)"},{"line_number":243,"context_line":"            LOG.debug(_(\"Updating compute instance %s \""},{"line_number":244,"context_line":"                        \"with floating ips.\") % server.id)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"            server_dict \u003d server._info"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNzc%3D","line":243,"updated":"2013-09-09 20:49:01.000000000","message":"this should be indented over because it would be misleading in the logs to see \u0027updating compute instance with floating ips.\u0027 when its really not. similar to the block like this below.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dbc2405db9bbffff3d844dc669f19672ecafc9da","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            if pool:"},{"line_number":241,"context_line":"                for ip in pool:"},{"line_number":242,"context_line":"                    self._nova_client.servers.add_floating_ip(server, ip)"},{"line_number":243,"context_line":"            LOG.debug(_(\"Updating compute instance %s \""},{"line_number":244,"context_line":"                        \"with floating ips.\") % server.id)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"            server_dict \u003d server._info"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNx4%3D","line":243,"in_reply_to":"AAAASn%2F%2FNzc%3D","updated":"2013-09-09 21:11:38.000000000","message":"Ok, i\u0027ll fix it.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"62bcef5a8e79e4db866c18cc7fcd3cea8308f29f","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            for ip in pool:"},{"line_number":425,"context_line":"                self._nova_client.servers.add_floating_ip(server, ip)"},{"line_number":426,"context_line":"            LOG.debug(_(\"Updating compute instance %s \""},{"line_number":427,"context_line":"                        \"with floating ips.\") % server.id)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        return server"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FN%2FA%3D","line":427,"updated":"2013-09-09 19:48:08.000000000","message":"Lines 240-244, 293-297, and 423-427 should be moved into their own function that gets called from all three points.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8479b3250b12faef0199641cc5587b801730824f","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            for ip in pool:"},{"line_number":425,"context_line":"                self._nova_client.servers.add_floating_ip(server, ip)"},{"line_number":426,"context_line":"            LOG.debug(_(\"Updating compute instance %s \""},{"line_number":427,"context_line":"                        \"with floating ips.\") % server.id)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        return server"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FN5Y%3D","line":427,"in_reply_to":"AAAASn%2F%2FN%2FA%3D","updated":"2013-09-09 20:17:00.000000000","message":"yes, they could.","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7b4841f8f65fc19b0ecda95f1ba0d118adfacc29","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            for ip in pool:"},{"line_number":425,"context_line":"                self._nova_client.servers.add_floating_ip(server, ip)"},{"line_number":426,"context_line":"            LOG.debug(_(\"Updating compute instance %s \""},{"line_number":427,"context_line":"                        \"with floating ips.\") % server.id)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        return server"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FNzM%3D","line":427,"in_reply_to":"AAAASn%2F%2FN5Y%3D","updated":"2013-09-09 20:49:01.000000000","message":"+1","commit_id":"4b0486b19127347d18476f4920d0720834620e02"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"fb565bbf25676fedac2791648eea29e55de8770e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                LOG.debug(_(\"Updating compute instance %s \""},{"line_number":166,"context_line":"                            \"with floating ips.\") % server.id)"},{"line_number":167,"context_line":"        except Exception as e:"},{"line_number":168,"context_line":"            msg \u003d \"Error acttaching floating IP %s \" \\"},{"line_number":169,"context_line":"                  \"to instance: %s\" % (self.id, \u0027 \u0027.join(pool))"},{"line_number":170,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_FLOATING_IP"},{"line_number":171,"context_line":"            self._log_and_raise(e, msg, err)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2F9Yo%3D","line":168,"updated":"2013-09-16 15:34:55.000000000","message":"msg \u003d (\"Error attaching floating IP %s \"\n    \"to instance: %s\") % (self.id, \u0027 \u0027.join(pool))\n\nPlease don\u0027t use \\ to continue lines, there are other ways to do it in Python. And pay mind to \u0027acttaching\u0027 above.","commit_id":"a331da06d866a4a2998553cbdf0c83bb89d3dece"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        try:"},{"line_number":162,"context_line":"            if pool:"},{"line_number":163,"context_line":"                for ip in pool:"},{"line_number":164,"context_line":"                    self._nova_client.servers.add_floating_ip(server, ip)"},{"line_number":165,"context_line":"                LOG.debug(_(\"Updating compute instance %s \""},{"line_number":166,"context_line":"                            \"with floating ips.\") % server.id)"},{"line_number":167,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3Es%3D","line":164,"updated":"2013-09-18 05:57:32.000000000","message":"Are you sure this will work immediately?  From experience, usually the Server has to be in a certain state before floating-ip-attach works.  I would like to see a test to prove this works.\n\nWhat\u0027s the use case for attaching multiple floating IPs to an instance?","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        try:"},{"line_number":162,"context_line":"            if pool:"},{"line_number":163,"context_line":"                for ip in pool:"},{"line_number":164,"context_line":"                    self._nova_client.servers.add_floating_ip(server, ip)"},{"line_number":165,"context_line":"                LOG.debug(_(\"Updating compute instance %s \""},{"line_number":166,"context_line":"                            \"with floating ips.\") % server.id)"},{"line_number":167,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F2yU%3D","line":164,"in_reply_to":"AAAAS3%2F%2F3Es%3D","updated":"2013-09-18 07:12:52.000000000","message":"Different pool from another network","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7971ef05bbe30b8557f77f4235ab6200256e272c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            msg \u003d (\"Error acttaching floating IP %s \""},{"line_number":169,"context_line":"                   \"to instance: %s\" % (self.id, \u0027 \u0027.join(pool)))"},{"line_number":170,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_FLOATING_IP"},{"line_number":171,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            self._create_dns_entry()"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F3D0%3D","line":171,"updated":"2013-09-18 05:57:32.000000000","message":"Lines 161-171 belong in a separate method","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9bea3669cdc04f8fb2a64cd16f10516b08d6b62e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            msg \u003d (\"Error acttaching floating IP %s \""},{"line_number":169,"context_line":"                   \"to instance: %s\" % (self.id, \u0027 \u0027.join(pool)))"},{"line_number":170,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_FLOATING_IP"},{"line_number":171,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            self._create_dns_entry()"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2F2yA%3D","line":171,"in_reply_to":"AAAAS3%2F%2F3D0%3D","updated":"2013-09-18 07:12:52.000000000","message":"agreed","commit_id":"bcef991c12560a472c14072818512bd97ad6151b"}],"trove/tests/fakes/nova.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"fb565bbf25676fedac2791648eea29e55de8770e","unresolved":false,"context_lines":[{"line_number":690,"context_line":""},{"line_number":691,"context_line":"    def list(self):"},{"line_number":692,"context_line":"        lst \u003d []"},{"line_number":693,"context_line":"        for x in xrange(1, 5):"},{"line_number":694,"context_line":"            ip \u003d \u0027%d.%d.%d.%d\u0027 % (x, x, x, x)"},{"line_number":695,"context_line":"            lst.append(FakeFloatingIP(ip))"},{"line_number":696,"context_line":"        return lst"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2F9Zw%3D","line":693,"updated":"2013-09-16 15:34:55.000000000","message":"xrange isn\u0027t necessary here, range will do just fine\n\nIn fact this whole function could be\n\nreturn [FakeFloatingIP(\u0027%d.%d.%d.%d\u0027 % (x, x, x, x)) for x in range(1, 5)]","commit_id":"a331da06d866a4a2998553cbdf0c83bb89d3dece"}],"trove/tests/unittests/floating_ips/test_floating_ips.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"fb565bbf25676fedac2791648eea29e55de8770e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.FakeClient.floating_ips.create \u003d fException"},{"line_number":42,"context_line":"        self.FakeClient.floating_ips.list \u003d fException"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        trove.common.remote.create_nova_client \u003d \\"},{"line_number":45,"context_line":"            lambda c: self._return_mocked_nova_client(c)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2F9b8%3D","line":44,"updated":"2013-09-16 15:34:55.000000000","message":"Please avoid using \\ to continue lines in Python.","commit_id":"a331da06d866a4a2998553cbdf0c83bb89d3dece"}]}
