)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"9e1eddc3dabfe83d9fe436dfad49182b1dad9a7e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix doc generation for Python3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix the Sphinx html_last_updated_fmt for Python3."},{"line_number":10,"context_line":"The html_last_updated_fmt option is interpeted as a"},{"line_number":11,"context_line":"byte string in python3, causing Sphinx build to break."},{"line_number":12,"context_line":"This patch makes it utf-8 string."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9e86ec020c0ad56b9b5c8e47a27b9667e565f036"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff0f0b1f_d6a8118d","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":33},"updated":"2017-05-22 18:12:34.000000000","message":"I\u0027m confused on what you\u0027re talking about here.\n\nHow does the sphinx build break? Maybe a bug report would be useful. I see a lot of projects are merging your patch without questioning.\n\n\nPython 3.5.2 (default, Nov 17 2016, 17:05:23) \n[GCC 5.4.0 20160609] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e git_cmd \u003d [\"git\", \"log\", \"--pretty\u003dformat:\u0027%ad, commit %h\u0027\", \"--date\u003dlocal\",\n...            \"-n1\"]\n\u003e\u003e\u003e import subprocess\n\u003e\u003e\u003e html_last_updated_fmt \u003d subprocess.Popen(\n...         git_cmd, stdout\u003dsubprocess.PIPE).communicate()[0]\n\u003e\u003e\u003e html_last_updated_fmt # byte string\nb\"\u0027Thu Apr 20 09:26:07 2017, commit b64b0e9\u0027\"\n\u003e\u003e\u003e html_last_updated_fmt.decode(\u0027utf-8\u0027) # utf-8\n\"\u0027Thu Apr 20 09:26:07 2017, commit b64b0e9\u0027\"","commit_id":"09928268ff139310813e9101d4fe3a68e858bca6"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"56f0008f103593cb22aece94265f6550536cf682","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix doc generation for Python3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix the Sphinx html_last_updated_fmt for Python3."},{"line_number":10,"context_line":"The html_last_updated_fmt option is interpeted as a"},{"line_number":11,"context_line":"byte string in python3, causing Sphinx build to break."},{"line_number":12,"context_line":"This patch makes it utf-8 string."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9e86ec020c0ad56b9b5c8e47a27b9667e565f036"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_db6084a8","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":33},"in_reply_to":"ff0f0b1f_d6a8118d","updated":"2017-06-13 06:17:37.000000000","message":"Trevor, Did you try to run tox with python3 ENV?\n\n\"\napi-ref runtests: commands[0] | rm -rf api-ref/build\napi-ref runtests: commands[1] | sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html\n/home/daidv/GIT/trove/.tox/api-ref/lib/python3.5/site.py:165: DeprecationWarning: \u0027U\u0027 mode is deprecated\n  f \u003d open(fullname, \"rU\")\nRunning Sphinx v1.6.2\nmaking output directory...\n/home/daidv/GIT/trove/.tox/api-ref/lib/python3.5/site-packages/os_api_ref/__init__.py:21: RemovedInSphinx17Warning: sphinx.util.compat.Directive is deprecated and will be removed in Sphinx 1.7, please use the standard library version instead.\n  from sphinx.util.compat import Directive\n\nWarning, treated as error:\nThe config value `html_last_updated_fmt\u0027 has type `bytes\u0027, expected to [\u0027str\u0027].\n\n\"","commit_id":"09928268ff139310813e9101d4fe3a68e858bca6"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ff0697030468914cd6ef9e5f97e31243dc1f3792","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The html_last_updated_fmt option is interpeted as a"},{"line_number":11,"context_line":"byte string in python3, causing Sphinx build to break."},{"line_number":12,"context_line":"This patch makes it utf-8 string."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9e86ec020c0ad56b9b5c8e47a27b9667e565f036"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_6e55081d","line":13,"updated":"2017-06-14 02:53:38.000000000","message":"should add a related bug here, Closes-Bug:#1693670","commit_id":"09928268ff139310813e9101d4fe3a68e858bca6"}],"api-ref/source/conf.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"d6803ccf62d3f43ab42a12c92b37a9a9ebe815f0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"           \"-n1\"]"},{"line_number":173,"context_line":"try:"},{"line_number":174,"context_line":"    html_last_updated_fmt \u003d subprocess.Popen("},{"line_number":175,"context_line":"        git_cmd, stdout\u003dsubprocess.PIPE).communicate()[0]"},{"line_number":176,"context_line":"except Exception:"},{"line_number":177,"context_line":"    warnings.warn(\u0027Cannot get last updated time from git repository. \u0027"},{"line_number":178,"context_line":"                  \u0027Not setting \"html_last_updated_fmt\".\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_2b783c28","side":"PARENT","line":175,"range":{"start_line":175,"start_character":17,"end_line":175,"end_character":39},"updated":"2017-05-16 19:16:32.000000000","message":"how is the stdout handled? see https://docs.python.org/3/library/subprocess.html#replacing-shell-pipeline","commit_id":"33713436134915b74ed101027eda18b9887d3f16"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"ca9319def9cf6ccdaf0a3becec2ac68c9f99f003","unresolved":false,"context_lines":[{"line_number":171,"context_line":"git_cmd \u003d [\"git\", \"log\", \"--pretty\u003dformat:\u0027%ad, commit %h\u0027\", \"--date\u003dlocal\","},{"line_number":172,"context_line":"           \"-n1\"]"},{"line_number":173,"context_line":"try:"},{"line_number":174,"context_line":"    html_last_updated_fmt \u003d subprocess.check_output(git_cmd)"},{"line_number":175,"context_line":"except Exception:"},{"line_number":176,"context_line":"    warnings.warn(\u0027Cannot get last updated time from git repository. \u0027"},{"line_number":177,"context_line":"                  \u0027Not setting \"html_last_updated_fmt\".\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_2b74b067","line":174,"updated":"2017-06-13 12:17:27.000000000","message":"don\u0027t you need .decode(\u0027utf-8\u0027)?","commit_id":"09928268ff139310813e9101d4fe3a68e858bca6"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"818597bf7b6dad29a20b991a20ad244e641c5d61","unresolved":false,"context_lines":[{"line_number":171,"context_line":"git_cmd \u003d [\"git\", \"log\", \"--pretty\u003dformat:\u0027%ad, commit %h\u0027\", \"--date\u003dlocal\","},{"line_number":172,"context_line":"           \"-n1\"]"},{"line_number":173,"context_line":"try:"},{"line_number":174,"context_line":"    html_last_updated_fmt \u003d subprocess.check_output(git_cmd)"},{"line_number":175,"context_line":"except Exception:"},{"line_number":176,"context_line":"    warnings.warn(\u0027Cannot get last updated time from git repository. \u0027"},{"line_number":177,"context_line":"                  \u0027Not setting \"html_last_updated_fmt\".\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_e9da4815","line":174,"in_reply_to":"7ffa3b31_2b74b067","updated":"2017-06-13 14:11:27.000000000","message":"Yeah he does, this can be tested easily in your interpreter.","commit_id":"09928268ff139310813e9101d4fe3a68e858bca6"}]}
