)]}'
{"trove/guestagent/manager/mysql_service.py":[{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"2d5ceffd04b6bf656f4ca98ebdc659a7b5ccdb62","unresolved":false,"context_lines":[{"line_number":899,"context_line":"        user.name \u003d \"root\""},{"line_number":900,"context_line":"        user.host \u003d \"%\""},{"line_number":901,"context_line":"        user.password \u003d root_password if root_password \\"},{"line_number":902,"context_line":"            else generate_random_password()"},{"line_number":903,"context_line":"        with LocalSqlClient(get_engine()) as client:"},{"line_number":904,"context_line":"            print(client)"},{"line_number":905,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FGEs%3D","line":902,"updated":"2013-09-12 04:28:48.000000000","message":"Would this be more readable like this:\n\nuser.password \u003d root_password or generate_random_password()","commit_id":"bc5152020929c0f33ce450bf86611bc6c15e69e0"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"0a790046859b9cbf8accd218476c74c490414230","unresolved":false,"context_lines":[{"line_number":899,"context_line":"        user.name \u003d \"root\""},{"line_number":900,"context_line":"        user.host \u003d \"%\""},{"line_number":901,"context_line":"        user.password \u003d root_password if root_password \\"},{"line_number":902,"context_line":"            else generate_random_password()"},{"line_number":903,"context_line":"        with LocalSqlClient(get_engine()) as client:"},{"line_number":904,"context_line":"            print(client)"},{"line_number":905,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2F9dA%3D","line":902,"in_reply_to":"AAAASn%2F%2FGEs%3D","updated":"2013-09-16 15:15:33.000000000","message":"Same either way to me, but let\u0027s not use \\ to continue lines please","commit_id":"bc5152020929c0f33ce450bf86611bc6c15e69e0"}],"trove/instance/models.py":[{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"4f974fd0bc47e7678275af8ec9b6f968294baa87","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from datetime import datetime"},{"line_number":21,"context_line":"from novaclient import exceptions as nova_exceptions"},{"line_number":22,"context_line":"from trove.common import cfg, utils"},{"line_number":23,"context_line":"from trove.common import exception"},{"line_number":24,"context_line":"from trove.common.remote import create_dns_client"},{"line_number":25,"context_line":"from trove.common.remote import create_guest_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2F9JE%3D","line":22,"updated":"2013-09-16 16:15:39.000000000","message":"Lets just use openstack commons uuidutils here. Id like to see us git rid of the junky utils wrapper for things like this.","commit_id":"bc5152020929c0f33ce450bf86611bc6c15e69e0"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"2d5ceffd04b6bf656f4ca98ebdc659a7b5ccdb62","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.db_info \u003d db_info"},{"line_number":119,"context_line":"        self.service_status \u003d service_status"},{"line_number":120,"context_line":"        self._root_password \u003d root_password"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @property"},{"line_number":123,"context_line":"    def addresses(self):"},{"line_number":124,"context_line":"        #TODO(tim.simpson): Review whether we should keep this... its a mess."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FGEM%3D","line":121,"updated":"2013-09-12 04:28:48.000000000","message":"I understand that in principle it\u0027s better to use self._root_password for setting \"private\" vars meant for internal use with this class.  However, would you consider leaving it out for the sake of consistency?","commit_id":"bc5152020929c0f33ce450bf86611bc6c15e69e0"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"2d5ceffd04b6bf656f4ca98ebdc659a7b5ccdb62","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @property"},{"line_number":230,"context_line":"    def root_password(self):"},{"line_number":231,"context_line":"        return self._root_password"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class DetailInstance(SimpleInstance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FGEI%3D","line":231,"updated":"2013-09-12 04:28:48.000000000","message":"I understand that in principle it\u0027s better to use self._root_password for setting \"private\" vars meant for internal use with this class. However, would you consider leaving it out for the sake of consistency?","commit_id":"bc5152020929c0f33ce450bf86611bc6c15e69e0"}],"trove/tests/api/root_on_create.py":[{"author":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"change_message_id":"5382fa1ed2bc223b28b1672a887e51c3865ae696","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@test(depends_on_classes\u003d[TestMysqlAccess],"},{"line_number":34,"context_line":"      runs_after\u003d[TestUsers],"},{"line_number":35,"context_line":"      groups\u003d[tests.DBAAS_API, GROUP, tests.INSTANCES])"},{"line_number":36,"context_line":"class TestRootOnCreate(object):"},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":"    Test \u0027CONF.root_on_create\u0027, which if True, creates the root user upon"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAS3%2F%2Fsg4%3D","line":35,"updated":"2013-09-21 07:28:20.000000000","message":"Is it possible not make dependency on others?","commit_id":"f77aab57e15e83258a0f6867878204c686107118"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"96aa3f6b0f2b340e677239883ce6e68318193d65","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@test(depends_on_classes\u003d[TestMysqlAccess],"},{"line_number":34,"context_line":"      runs_after\u003d[TestUsers],"},{"line_number":35,"context_line":"      groups\u003d[tests.DBAAS_API, GROUP, tests.INSTANCES])"},{"line_number":36,"context_line":"class TestRootOnCreate(object):"},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":"    Test \u0027CONF.root_on_create\u0027, which if True, creates the root user upon"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAS3%2F%2FSBg%3D","line":35,"in_reply_to":"AAAAS3%2F%2Fsg4%3D","updated":"2013-09-30 22:48:13.000000000","message":"Im ok w/ making the dependency. This will be very different when we use tempest...","commit_id":"f77aab57e15e83258a0f6867878204c686107118"}]}