)]}'
{"trove/common/remote.py":[{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"204599b1726bb9a10158d688293d32d772f5902d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    return import_class(CONF.remote_dns_client)(context)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"def create_guest_client(context, id, manager\u003dNone):"},{"line_number":180,"context_line":"    return import_class(CONF.remote_guest_client)(context, id, manager)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1f485f77_3d27bf67","line":179,"range":{"start_line":179,"start_character":33,"end_line":179,"end_character":35},"updated":"2017-11-09 12:29:17.000000000","message":"I think we use a different parameter name than the reserved \u0027id\u0027.  This is positional so we could, even if the guest_client is using \u0027id\u0027.","commit_id":"8ae36aed04799d5ac5191cabec177a76c6d3775d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"770764beb287449e9ee48a0b1b45748a1ad9899a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    return import_class(CONF.remote_dns_client)(context)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"def create_guest_client(context, id, manager\u003dNone):"},{"line_number":180,"context_line":"    return import_class(CONF.remote_guest_client)(context, id, manager)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1f485f77_600d8b8f","line":179,"range":{"start_line":179,"start_character":33,"end_line":179,"end_character":35},"in_reply_to":"1f485f77_3d27bf67","updated":"2017-11-09 18:40:02.000000000","message":"Yes - I wanted to switch it to instance_id.","commit_id":"8ae36aed04799d5ac5191cabec177a76c6d3775d"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"204599b1726bb9a10158d688293d32d772f5902d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    return import_class(CONF.remote_guest_client)(context, id, manager)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"def create_nova_client(context, region_name\u003dNone):"},{"line_number":184,"context_line":"    return import_class(CONF.remote_nova_client)(context, region_name)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1f485f77_9d17d3ee","line":183,"range":{"start_line":183,"start_character":32,"end_line":183,"end_character":48},"updated":"2017-11-09 12:29:17.000000000","message":"One downside to this is is it will override the default value for this kwarg to be None, even if the default on the client it imports is different.  Should we use kwargs instead?","commit_id":"8ae36aed04799d5ac5191cabec177a76c6d3775d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"770764beb287449e9ee48a0b1b45748a1ad9899a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    return import_class(CONF.remote_guest_client)(context, id, manager)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"def create_nova_client(context, region_name\u003dNone):"},{"line_number":184,"context_line":"    return import_class(CONF.remote_nova_client)(context, region_name)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1f485f77_20279315","line":183,"range":{"start_line":183,"start_character":32,"end_line":183,"end_character":48},"in_reply_to":"1f485f77_9d17d3ee","updated":"2017-11-09 18:40:02.000000000","message":"Yes - you are right. Will make that change.","commit_id":"8ae36aed04799d5ac5191cabec177a76c6d3775d"}],"trove/guestagent/api.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"894dc378ebb3caa43d5c6503ba3a0363a2121847","unresolved":false,"context_lines":[{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"AGENT_LOW_TIMEOUT \u003d CONF.agent_call_low_timeout"},{"line_number":34,"context_line":"AGENT_HIGH_TIMEOUT \u003d CONF.agent_call_high_timeout"},{"line_number":35,"context_line":"AGENT_SNAPSHOT_TIMEOUT \u003d CONF.agent_replication_snapshot_timeout"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_b7c0247d","side":"PARENT","line":34,"updated":"2017-06-01 01:20:42.000000000","message":"I am not convinced of this group of changes.\n\nThe rationale for this was (in part) that we wanted the timeouts here to be a part of the API, with the goal that at some point these could even be made more dynamic as methods in the API class.\n\nThis set of changes will make that future refactor harder by proliferating the CONF value.","commit_id":"00fde782be276698a5372066bb3fec74509e0fa8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"eae072c34e4d99b958eb5cbcb22c493c2a5f8d90","unresolved":false,"context_lines":[{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"AGENT_LOW_TIMEOUT \u003d CONF.agent_call_low_timeout"},{"line_number":34,"context_line":"AGENT_HIGH_TIMEOUT \u003d CONF.agent_call_high_timeout"},{"line_number":35,"context_line":"AGENT_SNAPSHOT_TIMEOUT \u003d CONF.agent_replication_snapshot_timeout"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_f7d0dc21","side":"PARENT","line":34,"in_reply_to":"df140735_b7c0247d","updated":"2017-06-01 01:39:45.000000000","message":"The only down-side with leaving these at the moment is that they cannot be changed. Since they are loaded before the config is loaded. :p","commit_id":"00fde782be276698a5372066bb3fec74509e0fa8"}],"trove/taskmanager/models.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"46bf506dfe9e734d655628ab26ddc1b4b9403738","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"                return volume.size \u003d\u003d self.new_size"},{"line_number":1702,"context_line":"            utils.poll_until(volume_is_new_size,"},{"line_number":1703,"context_line":"                             sleep_time\u003d2,"},{"line_number":1704,"context_line":"                             time_out\u003dCONF.CONF.volume_time_out)"},{"line_number":1705,"context_line":""},{"line_number":1706,"context_line":"            self.instance.update_db(volume_size\u003dself.new_size)"},{"line_number":1707,"context_line":"        except PollTimeOut:"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_dba9acdf","line":1704,"updated":"2017-05-30 20:34:24.000000000","message":"Ops","commit_id":"900e7543cf5af3394a778a83710dac5240837c80"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"894dc378ebb3caa43d5c6503ba3a0363a2121847","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":83,"context_line":"CONF \u003d cfg.CONF"},{"line_number":84,"context_line":"VOLUME_TIME_OUT \u003d CONF.volume_time_out  # seconds."},{"line_number":85,"context_line":"DNS_TIME_OUT \u003d CONF.dns_time_out  # seconds."},{"line_number":86,"context_line":"RESIZE_TIME_OUT \u003d CONF.resize_time_out  # seconds."},{"line_number":87,"context_line":"REVERT_TIME_OUT \u003d CONF.revert_time_out  # seconds."}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_3742d411","side":"PARENT","line":84,"updated":"2017-06-01 01:20:42.000000000","message":"are there actually code paths where this would get imported before CONF was loaded?","commit_id":"00fde782be276698a5372066bb3fec74509e0fa8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"eae072c34e4d99b958eb5cbcb22c493c2a5f8d90","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":83,"context_line":"CONF \u003d cfg.CONF"},{"line_number":84,"context_line":"VOLUME_TIME_OUT \u003d CONF.volume_time_out  # seconds."},{"line_number":85,"context_line":"DNS_TIME_OUT \u003d CONF.dns_time_out  # seconds."},{"line_number":86,"context_line":"RESIZE_TIME_OUT \u003d CONF.resize_time_out  # seconds."},{"line_number":87,"context_line":"REVERT_TIME_OUT \u003d CONF.revert_time_out  # seconds."}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_77328c12","side":"PARENT","line":84,"in_reply_to":"df140735_3742d411","updated":"2017-06-01 01:39:45.000000000","message":"These are not loaded before the CONF at the moment.","commit_id":"00fde782be276698a5372066bb3fec74509e0fa8"}],"trove/tests/unittests/taskmanager/test_models.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"f692983f92ae32b584efc6faef400c09bcaace84","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            snapshot, mock_flavor)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"class InstanceSecurityGroupRuleTests(BaseFreshInstanceTasksTest):"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def setUp(self):"},{"line_number":417,"context_line":"        super(InstanceSecurityGroupRuleTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f231b9d_d69a0e12","line":414,"updated":"2017-06-16 21:55:52.000000000","message":"These Security Group tests cannot use set_override, as these would be failing from set_override throwing a ValueError. We should probably re-evaluate this code path, as it may not necessarily be relevant any more.","commit_id":"a066505e45a86547dfa59aa0a5df040a2df844cd"}]}