)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"change_message_id":"4676c4c8e3bb8e2be059efbdd5e941f91903c87d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added server_id to my.cnf template logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I82db1e97a366e7c54c2af09b0cba6e7c732562ef"},{"line_number":10,"context_line":"Implements: modify-task-mgr-to-pass-a-server-id-to-my.cnf-template"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAS3%2F%2Fa08%3D","line":10,"updated":"2013-09-27 03:24:48.000000000","message":"link?","commit_id":"1df6d57fef56bde79e5ea0174f6201bae5768596"},{"author":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"change_message_id":"68b34db2a83d3c3d8cd478836547aa156a55470c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added server_id to my.cnf template logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I82db1e97a366e7c54c2af09b0cba6e7c732562ef"},{"line_number":10,"context_line":"Implements: blueprint modify-task-mgr-to-pass-a-server-id-to-my.cnf-template"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAS3%2F%2FXfE%3D","line":10,"updated":"2013-09-28 02:48:26.000000000","message":"still wrong link","commit_id":"101be6d20288c14a0d0494178f8ad648f77dc9c2"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"1b672fc231c2e61938f2b16c6ec8500c4816c733","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added server_id to my.cnf template logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I82db1e97a366e7c54c2af09b0cba6e7c732562ef"},{"line_number":10,"context_line":"Implements: blueprint modify-task-mgr-to-pass-a-server-id-to-my.cnf-template"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAS3%2F%2FXes%3D","line":10,"in_reply_to":"AAAAS3%2F%2FXfE%3D","updated":"2013-09-28 02:58:24.000000000","message":"This is because I named the blue print with a dot.\nI\u0027ll try to see if I can correct this.","commit_id":"101be6d20288c14a0d0494178f8ad648f77dc9c2"}],"trove/common/template.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"b5023fc65fed6c11ff190b11f2215e7487d55919","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            flavor\u003dself.flavor_dict, server_id\u003dunique_id)"},{"line_number":49,"context_line":"        return self.config_contents"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _calculate_unique_id(self, server_id):"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        Returns a positive unique id based off of the server id"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FYfI%3D","line":51,"updated":"2013-09-27 19:55:25.000000000","message":"whats the point of passing the server_id here when its a method of this class? \nIt would matter if this was a static method and thats kinda what it looks like you are trying to do here. I\u0027d suggest making this @staticmethod","commit_id":"101be6d20288c14a0d0494178f8ad648f77dc9c2"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"1b672fc231c2e61938f2b16c6ec8500c4816c733","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            flavor\u003dself.flavor_dict, server_id\u003dunique_id)"},{"line_number":49,"context_line":"        return self.config_contents"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _calculate_unique_id(self, server_id):"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        Returns a positive unique id based off of the server id"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FXeo%3D","line":51,"in_reply_to":"AAAAS3%2F%2FYfI%3D","updated":"2013-09-28 02:58:24.000000000","message":"good point.  I\u0027ll clean it up and make it \u0027private\u0027 and take no args.\nThat way it can\u0027t be used on a different id.","commit_id":"101be6d20288c14a0d0494178f8ad648f77dc9c2"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"0b2e96dac76b3d692a0c3f8cb4508ec66bacf876","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.flavor_dict \u003d flavor_dict"},{"line_number":36,"context_line":"        template_filename \u003d \"%s.config.template\" % service_type"},{"line_number":37,"context_line":"        self.template \u003d ENV.get_template(template_filename)"},{"line_number":38,"context_line":"        self.server_id \u003d server_id"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def render(self):"},{"line_number":41,"context_line":"        \"\"\" Renders the jinja template"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FXac%3D","line":38,"updated":"2013-09-28 04:54:42.000000000","message":"Can we not confuse the nomenclature by using the term server_id for both the instance_id as well as the hashed server_id? \n\nThis can be confusing to someone reading the code.\nLet\u0027s use the term server_id for the actual value of server_id written to the my.cnf (i.e. the value after being hashed and bucketed to an int). For the actual uuid (i.e. for what is being stored as the instance variable in this case), let\u0027s use instance_id, since that\u0027s what it is called in other places in the codebase.\n\nSo the two variables here should probably be named instance_id.","commit_id":"8f4036add9bae39a74b0bbb9336a6723eee8d589"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"7abbaa313de87a829eea7ca51ad66bcfe5ff2968","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.flavor_dict \u003d flavor_dict"},{"line_number":36,"context_line":"        template_filename \u003d \"%s.config.template\" % service_type"},{"line_number":37,"context_line":"        self.template \u003d ENV.get_template(template_filename)"},{"line_number":38,"context_line":"        self.server_id \u003d server_id"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def render(self):"},{"line_number":41,"context_line":"        \"\"\" Renders the jinja template"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FW1A%3D","line":38,"in_reply_to":"AAAAS3%2F%2FXac%3D","updated":"2013-09-28 15:36:20.000000000","message":"Done","commit_id":"8f4036add9bae39a74b0bbb9336a6723eee8d589"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"0b2e96dac76b3d692a0c3f8cb4508ec66bacf876","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        :returns: str -- The rendered configuration file"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        unique_id \u003d self._calculate_unique_id()"},{"line_number":47,"context_line":"        self.config_contents \u003d self.template.render("},{"line_number":48,"context_line":"            flavor\u003dself.flavor_dict, server_id\u003dunique_id)"},{"line_number":49,"context_line":"        return self.config_contents"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FXaU%3D","line":46,"updated":"2013-09-28 04:54:42.000000000","message":"Let\u0027s use the name server_id here, since this hashed, bucketed value is _exactly what\u0027s being written to the my.cnf file as server_id.","commit_id":"8f4036add9bae39a74b0bbb9336a6723eee8d589"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"7abbaa313de87a829eea7ca51ad66bcfe5ff2968","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        :returns: str -- The rendered configuration file"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        unique_id \u003d self._calculate_unique_id()"},{"line_number":47,"context_line":"        self.config_contents \u003d self.template.render("},{"line_number":48,"context_line":"            flavor\u003dself.flavor_dict, server_id\u003dunique_id)"},{"line_number":49,"context_line":"        return self.config_contents"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FW08%3D","line":46,"in_reply_to":"AAAAS3%2F%2FXaU%3D","updated":"2013-09-28 15:36:20.000000000","message":"Done","commit_id":"8f4036add9bae39a74b0bbb9336a6723eee8d589"}],"trove/taskmanager/models.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"a3b385a8c6e52abde25d062dd212d6440309e3cb","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        LOG.debug(\"server.id: %s\" % server.id)"},{"line_number":173,"context_line":"        config \u003d self._render_config(service_type, flavor, server.id)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        if server:"},{"line_number":176,"context_line":"            self._guest_prepare(server, flavor[\u0027ram\u0027], volume_info,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FnS4%3D","line":173,"updated":"2013-09-26 17:31:52.000000000","message":"Any reason to use server.id instead of self.instance.id?  In the case of a user wanting to do Replication, they will have to know what the server_id in my.cnf is.  If we use the instance.id instead, they would be able to calculate the server id.","commit_id":"d94a701896c06b792c49ed76851a6e8ce6b1fae2"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"a3b385a8c6e52abde25d062dd212d6440309e3cb","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        LOG.debug(\"Repairing config.\")"},{"line_number":872,"context_line":"        try:"},{"line_number":873,"context_line":"            LOG.debug(\"ResizeAction: _revert_nova_action: instance_id: %s\""},{"line_number":874,"context_line":"                      % self.instance.id)"},{"line_number":875,"context_line":"            config \u003d self._render_config(self.instance.service_type,"},{"line_number":876,"context_line":"                                         self.old_flavor, self.instance.id)"},{"line_number":877,"context_line":"            config \u003d {\u0027config_contents\u0027: config.config_contents}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FnX8%3D","line":874,"updated":"2013-09-26 17:31:52.000000000","message":"Is this necessary? seems like a duplicate log entry.","commit_id":"d94a701896c06b792c49ed76851a6e8ce6b1fae2"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"0b2e96dac76b3d692a0c3f8cb4508ec66bacf876","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _render_config(self, service_type, flavor, server_id):"},{"line_number":129,"context_line":"        config \u003d template.SingleInstanceConfigTemplate("},{"line_number":130,"context_line":"            service_type, flavor, server_id)"},{"line_number":131,"context_line":"        config.render()"},{"line_number":132,"context_line":"        return config"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FXaQ%3D","line":130,"updated":"2013-09-28 04:54:42.000000000","message":"Same nomenclature comment. Use instance_id in place of server_id.","commit_id":"8f4036add9bae39a74b0bbb9336a6723eee8d589"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"7abbaa313de87a829eea7ca51ad66bcfe5ff2968","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _render_config(self, service_type, flavor, server_id):"},{"line_number":129,"context_line":"        config \u003d template.SingleInstanceConfigTemplate("},{"line_number":130,"context_line":"            service_type, flavor, server_id)"},{"line_number":131,"context_line":"        config.render()"},{"line_number":132,"context_line":"        return config"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FW00%3D","line":130,"in_reply_to":"AAAAS3%2F%2FXaQ%3D","updated":"2013-09-28 15:36:20.000000000","message":"Done","commit_id":"8f4036add9bae39a74b0bbb9336a6723eee8d589"}]}