)]}'
{"trove/extensions/mysql/common.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"02c9bc2f2693767a53020dd80475a3708f3a110a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    for user in users:"},{"line_number":46,"context_line":"        u \u003d guest_models.MySQLUser()"},{"line_number":47,"context_line":"        u.name \u003d user.get(\u0027name\u0027, \u0027\u0027)"},{"line_number":48,"context_line":"        u.host \u003d user.get(\u0027host\u0027, \u0027%\u0027)"},{"line_number":49,"context_line":"        u.password \u003d user.get(\u0027password\u0027, \u0027\u0027)"},{"line_number":50,"context_line":"        dbs \u003d user.get(\u0027databases\u0027, \u0027\u0027)"},{"line_number":51,"context_line":"        if dbs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FnrY%3D","line":48,"updated":"2013-09-23 20:54:19.000000000","message":"If this is added, can\u0027t https://github.com/openstack/trove/blob/master/trove/extensions/mysql/models.py#L85-L86 be removed? Please check, a cursory glance suggests yes, but I didn\u0027t deeply inspect.","commit_id":"51839a95c3ef4d0a4554c2858737cd098e335625"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e0a9aee98f33053b13686c326b1ac51aeb2e5424","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    for user in users:"},{"line_number":46,"context_line":"        u \u003d guest_models.MySQLUser()"},{"line_number":47,"context_line":"        u.name \u003d user.get(\u0027name\u0027, \u0027\u0027)"},{"line_number":48,"context_line":"        u.host \u003d user.get(\u0027host\u0027, \u0027%\u0027)"},{"line_number":49,"context_line":"        u.password \u003d user.get(\u0027password\u0027, \u0027\u0027)"},{"line_number":50,"context_line":"        dbs \u003d user.get(\u0027databases\u0027, \u0027\u0027)"},{"line_number":51,"context_line":"        if dbs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fnjw%3D","line":48,"in_reply_to":"AAAAS3%2F%2FnrY%3D","updated":"2013-09-23 21:25:25.000000000","message":"Yes","commit_id":"51839a95c3ef4d0a4554c2858737cd098e335625"}],"trove/tests/unittests/mysql/test_user_controller.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"32ecb82d80aaf05e8a647be62f431e68b82023a5","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        body_empty_host \u003d {\u0027user\u0027: {"},{"line_number":233,"context_line":"            \u0027name\u0027: \u0027test\u0027,"},{"line_number":234,"context_line":"            \u0027password\u0027: \u0027test\u0027,"},{"line_number":235,"context_line":"            \u0027host\u0027: \u0027%\u0027"},{"line_number":236,"context_line":"        }}"},{"line_number":237,"context_line":"        body_with_host \u003d {\u0027user\u0027: {"},{"line_number":238,"context_line":"            \u0027name\u0027: \u0027test\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FFiY%3D","line":235,"updated":"2013-10-04 16:30:21.000000000","message":"This isn\u0027t empty, it\u0027s the default case.","commit_id":"e88dc0381ed1b265807da4e4180ebfda2672aa36"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"32ecb82d80aaf05e8a647be62f431e68b82023a5","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        body_none_host \u003d {\u0027user\u0027: {"},{"line_number":243,"context_line":"            \u0027name\u0027: \u0027test\u0027,"},{"line_number":244,"context_line":"            \u0027password\u0027: \u0027test\u0027,"},{"line_number":245,"context_line":"            \u0027host\u0027: \"\""},{"line_number":246,"context_line":"        }}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        schema_empty_host \u003d self.controller.get_schema(\u0027update\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FFiQ%3D","line":245,"updated":"2013-10-04 16:30:21.000000000","message":"This isn\u0027t None, it\u0027s empty.","commit_id":"e88dc0381ed1b265807da4e4180ebfda2672aa36"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"32ecb82d80aaf05e8a647be62f431e68b82023a5","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            \u0027name\u0027: \u0027test\u0027,"},{"line_number":244,"context_line":"            \u0027password\u0027: \u0027test\u0027,"},{"line_number":245,"context_line":"            \u0027host\u0027: \"\""},{"line_number":246,"context_line":"        }}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        schema_empty_host \u003d self.controller.get_schema(\u0027update\u0027,"},{"line_number":249,"context_line":"                                                       body_empty_host)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FFiE%3D","line":246,"updated":"2013-10-04 16:30:21.000000000","message":"I\u0027d like to see two more tests:\n\n\u0027host\u0027: None\n\nand one where \u0027host\u0027 is simply not present in the request body.","commit_id":"e88dc0381ed1b265807da4e4180ebfda2672aa36"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"a7bbcb236eb0fa4a206a0e74157a8621e7a379b2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            \u0027name\u0027: \u0027test\u0027,"},{"line_number":244,"context_line":"            \u0027password\u0027: \u0027test\u0027,"},{"line_number":245,"context_line":"            \u0027host\u0027: \"\""},{"line_number":246,"context_line":"        }}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        schema_empty_host \u003d self.controller.get_schema(\u0027update\u0027,"},{"line_number":249,"context_line":"                                                       body_empty_host)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FFgQ%3D","line":246,"in_reply_to":"AAAAS3%2F%2FFgo%3D","updated":"2013-10-04 16:39:20.000000000","message":"So they are. Forgive my oversight, I typically focus on the red and green in these reviews.","commit_id":"e88dc0381ed1b265807da4e4180ebfda2672aa36"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"acc986d501d89c270fb9774cc48c91371a8b374e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            \u0027name\u0027: \u0027test\u0027,"},{"line_number":244,"context_line":"            \u0027password\u0027: \u0027test\u0027,"},{"line_number":245,"context_line":"            \u0027host\u0027: \"\""},{"line_number":246,"context_line":"        }}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        schema_empty_host \u003d self.controller.get_schema(\u0027update\u0027,"},{"line_number":249,"context_line":"                                                       body_empty_host)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FFgo%3D","line":246,"in_reply_to":"AAAAS3%2F%2FFiE%3D","updated":"2013-10-04 16:37:28.000000000","message":"take a look at lines 225-230 - they are about not existed host as part of body.","commit_id":"e88dc0381ed1b265807da4e4180ebfda2672aa36"}]}