)]}'
{"run_tests.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"d9854b181ec691c00a1eac4a518744c809925b2f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        from trove.tests.api import user_access"},{"line_number":141,"context_line":"        from trove.tests.api.mgmt import accounts"},{"line_number":142,"context_line":"        from trove.tests.api.mgmt import admin_required"},{"line_number":143,"context_line":"        from trove.tests.api.mgmt import instances as mgmt_instances"},{"line_number":144,"context_line":"        from trove.tests.api.mgmt import instances_actions as mgmt_ins_act"},{"line_number":145,"context_line":"        from trove.tests.api.mgmt import storage"},{"line_number":146,"context_line":"        from trove.tests.api.mgmt import malformed_json"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Ffx4%3D","line":143,"updated":"2013-09-25 17:59:43.000000000","message":"Another good catch. Great!","commit_id":"8e3bdc4e9ce49bc1ce68c0ae3de82ac020c37bbd"}],"trove/taskmanager/models.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"d9854b181ec691c00a1eac4a518744c809925b2f","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027block_device\u0027: block_device,"},{"line_number":388,"context_line":"                       \u0027device_path\u0027: device_path,"},{"line_number":389,"context_line":"                       \u0027mount_point\u0027: mount_point,"},{"line_number":390,"context_line":"                       \u0027volumes\u0027: volumes}"},{"line_number":391,"context_line":"        return volume_info"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _create_server(self, flavor_id, image_id, security_groups,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FfyQ%3D","line":390,"updated":"2013-09-25 17:59:43.000000000","message":"Where is volumes defined before in this function?\nbuild_volumes is not used except in the debug statement on 380.","commit_id":"8e3bdc4e9ce49bc1ce68c0ae3de82ac020c37bbd"},{"author":{"_account_id":7850,"name":"Kevin Conway","email":"kevinjacobconway@gmail.com","username":"kevinconway"},"change_message_id":"0fe5d10beeb9573a99ee39fb8fee52639697785d","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        mapping \u003d \"%s:%s:%s:%s\" % (v_ref.id, \u0027\u0027, v_ref.size, 1)"},{"line_number":375,"context_line":"        bdm \u003d CONF.block_device_mapping"},{"line_number":376,"context_line":"        block_device \u003d {bdm: mapping}"},{"line_number":377,"context_line":"        build_volumes \u003d [{\u0027id\u0027: v_ref.id,"},{"line_number":378,"context_line":"                          \u0027size\u0027: v_ref.size}]"},{"line_number":379,"context_line":"        LOG.debug(\"block_device \u003d %s\" % block_device)"},{"line_number":380,"context_line":"        LOG.debug(\"volume \u003d %s\" % build_volumes)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffys%3D","line":377,"updated":"2013-09-25 17:58:23.000000000","message":"Which PEP is does this correct?","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d0c6f2386fbcf03f2225941742a0a1dda11b8d0a","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        mapping \u003d \"%s:%s:%s:%s\" % (v_ref.id, \u0027\u0027, v_ref.size, 1)"},{"line_number":375,"context_line":"        bdm \u003d CONF.block_device_mapping"},{"line_number":376,"context_line":"        block_device \u003d {bdm: mapping}"},{"line_number":377,"context_line":"        build_volumes \u003d [{\u0027id\u0027: v_ref.id,"},{"line_number":378,"context_line":"                          \u0027size\u0027: v_ref.size}]"},{"line_number":379,"context_line":"        LOG.debug(\"block_device \u003d %s\" % block_device)"},{"line_number":380,"context_line":"        LOG.debug(\"volume \u003d %s\" % build_volumes)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffvw%3D","line":377,"in_reply_to":"AAAAS3%2F%2Ffys%3D","updated":"2013-09-25 18:05:55.000000000","message":"F811 redefinition of unused","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"f647fb1629812a7a4790b3dbdc5a86873e0c2110","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        mapping \u003d \"%s:%s:%s:%s\" % (v_ref.id, \u0027\u0027, v_ref.size, 1)"},{"line_number":375,"context_line":"        bdm \u003d CONF.block_device_mapping"},{"line_number":376,"context_line":"        block_device \u003d {bdm: mapping}"},{"line_number":377,"context_line":"        build_volumes \u003d [{\u0027id\u0027: v_ref.id,"},{"line_number":378,"context_line":"                          \u0027size\u0027: v_ref.size}]"},{"line_number":379,"context_line":"        LOG.debug(\"block_device \u003d %s\" % block_device)"},{"line_number":380,"context_line":"        LOG.debug(\"volume \u003d %s\" % build_volumes)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffwg%3D","line":377,"in_reply_to":"AAAAS3%2F%2Ffys%3D","updated":"2013-09-25 18:03:07.000000000","message":"Potentially it creates an F841 on line 390 as now it mentions an undefined variable \u0027volumes\u0027","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"f647fb1629812a7a4790b3dbdc5a86873e0c2110","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027block_device\u0027: block_device,"},{"line_number":388,"context_line":"                       \u0027device_path\u0027: device_path,"},{"line_number":389,"context_line":"                       \u0027mount_point\u0027: mount_point,"},{"line_number":390,"context_line":"                       \u0027volumes\u0027: volumes}"},{"line_number":391,"context_line":"        return volume_info"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _create_server(self, flavor_id, image_id, security_groups,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffwc%3D","line":390,"updated":"2013-09-25 18:03:07.000000000","message":"See 377","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"81359b5883a26a5d710c8ea91e267dd308bed2c5","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027block_device\u0027: block_device,"},{"line_number":388,"context_line":"                       \u0027device_path\u0027: device_path,"},{"line_number":389,"context_line":"                       \u0027mount_point\u0027: mount_point,"},{"line_number":390,"context_line":"                       \u0027volumes\u0027: volumes}"},{"line_number":391,"context_line":"        return volume_info"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _create_server(self, flavor_id, image_id, security_groups,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffcg%3D","line":390,"in_reply_to":"AAAAS3%2F%2FfqE%3D","updated":"2013-09-25 19:28:41.000000000","message":"Agreed for this.","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"28ba10c11a2607ad5ed691996a074a35400dfb33","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027block_device\u0027: block_device,"},{"line_number":388,"context_line":"                       \u0027device_path\u0027: device_path,"},{"line_number":389,"context_line":"                       \u0027mount_point\u0027: mount_point,"},{"line_number":390,"context_line":"                       \u0027volumes\u0027: volumes}"},{"line_number":391,"context_line":"        return volume_info"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _create_server(self, flavor_id, image_id, security_groups,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FfqE%3D","line":390,"in_reply_to":"AAAAS3%2F%2Ffu8%3D","updated":"2013-09-25 18:28:23.000000000","message":"I don\u0027t see that \u0027volumes\u0027 was defined in this function since renaming the variable on 377 to \u0027build_volumes\u0027.\nThe only other \u0027volumes\u0027 in scope at this point is the module imported on line 22, and I don\u0027t think that\u0027s correct here.\nI think this line should be\n\n\u0027volumes\u0027: build_volumes}.","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9d56613e08ab9c88b8d975a652858bf9a18d25ab","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027block_device\u0027: block_device,"},{"line_number":388,"context_line":"                       \u0027device_path\u0027: device_path,"},{"line_number":389,"context_line":"                       \u0027mount_point\u0027: mount_point,"},{"line_number":390,"context_line":"                       \u0027volumes\u0027: volumes}"},{"line_number":391,"context_line":"        return volume_info"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _create_server(self, flavor_id, image_id, security_groups,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffu8%3D","line":390,"in_reply_to":"AAAAS3%2F%2Ffwc%3D","updated":"2013-09-25 18:08:40.000000000","message":"For what ??","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"e696c431197756071771869be67acb94b0a1052c","unresolved":false,"context_lines":[{"line_number":703,"context_line":"                if name:"},{"line_number":704,"context_line":"                    LOG.info(\"Deleting file: %s/%s\", cont, name)"},{"line_number":705,"context_line":"                    client.delete_object(cont, name)"},{"line_number":706,"context_line":"                    # Delete the manifest file"},{"line_number":707,"context_line":"        LOG.info(\"Deleting file: %s/%s\", container, filename)"},{"line_number":708,"context_line":"        client.delete_object(container, filename)"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FIQw%3D","line":706,"updated":"2013-10-03 20:18:43.000000000","message":"This is actually a comment for the delete_object after the \u0027if all..\u0027 so this should be de-indented 4 spaces.","commit_id":"0bf696b1abc41c14c48defc094509fb2f81609a5"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b50e444efe405f85cca008c3d58b452efa566be7","unresolved":false,"context_lines":[{"line_number":703,"context_line":"                if name:"},{"line_number":704,"context_line":"                    LOG.info(\"Deleting file: %s/%s\", cont, name)"},{"line_number":705,"context_line":"                    client.delete_object(cont, name)"},{"line_number":706,"context_line":"                    # Delete the manifest file"},{"line_number":707,"context_line":"        LOG.info(\"Deleting file: %s/%s\", container, filename)"},{"line_number":708,"context_line":"        client.delete_object(container, filename)"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FIPs%3D","line":706,"in_reply_to":"AAAAS3%2F%2FIQw%3D","updated":"2013-10-03 20:24:30.000000000","message":"Sure","commit_id":"0bf696b1abc41c14c48defc094509fb2f81609a5"}],"trove/tests/api/flavors.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"d9854b181ec691c00a1eac4a518744c809925b2f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from nose.tools import assert_true"},{"line_number":21,"context_line":"from troveclient import exceptions"},{"line_number":22,"context_line":"from troveclient.flavors import Flavor"},{"line_number":23,"context_line":"from troveclient.flavors import Flavors as cli_flavor"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from proboscis import before_class"},{"line_number":26,"context_line":"from proboscis import test"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Ffy4%3D","line":23,"updated":"2013-09-25 17:59:43.000000000","message":"I don\u0027t see cli_flavor being used anywhere, can you just remove this line?\n\nOn second thought, that may be because line 112 should be refactored to match.\n\nWhich is it?","commit_id":"8e3bdc4e9ce49bc1ce68c0ae3de82ac020c37bbd"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"d9854b181ec691c00a1eac4a518744c809925b2f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if test_config.nova_client is not None:"},{"line_number":109,"context_line":"            return self.nova_client.flavors.list()"},{"line_number":110,"context_line":"        # If we don\u0027t have access to the client the flavors need to be spelled"},{"line_number":111,"context_line":"        # out in the config file."},{"line_number":112,"context_line":"        flavors \u003d [Flavor(Flavors, flavor_dict, loaded\u003dTrue)"},{"line_number":113,"context_line":"                   for flavor_dict in test_config.flavors]"},{"line_number":114,"context_line":"        return flavors"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Ffyw%3D","line":111,"updated":"2013-09-25 17:59:43.000000000","message":"Should this be Flavors, or should this be cli_flavor as you\u0027ve renamed in the imports?","commit_id":"8e3bdc4e9ce49bc1ce68c0ae3de82ac020c37bbd"},{"author":{"_account_id":7850,"name":"Kevin Conway","email":"kevinjacobconway@gmail.com","username":"kevinconway"},"change_message_id":"0fe5d10beeb9573a99ee39fb8fee52639697785d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from nose.tools import assert_true"},{"line_number":21,"context_line":"from troveclient import exceptions"},{"line_number":22,"context_line":"from troveclient.flavors import Flavor"},{"line_number":23,"context_line":"from troveclient.flavors import Flavors as cli_flavor"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from proboscis import before_class"},{"line_number":26,"context_line":"from proboscis import test"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffx8%3D","line":23,"updated":"2013-09-25 17:58:23.000000000","message":"Which PEP does this fix?","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"f647fb1629812a7a4790b3dbdc5a86873e0c2110","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from nose.tools import assert_true"},{"line_number":21,"context_line":"from troveclient import exceptions"},{"line_number":22,"context_line":"from troveclient.flavors import Flavor"},{"line_number":23,"context_line":"from troveclient.flavors import Flavors as cli_flavor"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from proboscis import before_class"},{"line_number":26,"context_line":"from proboscis import test"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffws%3D","line":23,"in_reply_to":"AAAAS3%2F%2Ffx8%3D","updated":"2013-09-25 18:03:07.000000000","message":"Collision with class defined on 92.","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d0c6f2386fbcf03f2225941742a0a1dda11b8d0a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from nose.tools import assert_true"},{"line_number":21,"context_line":"from troveclient import exceptions"},{"line_number":22,"context_line":"from troveclient.flavors import Flavor"},{"line_number":23,"context_line":"from troveclient.flavors import Flavors as cli_flavor"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from proboscis import before_class"},{"line_number":26,"context_line":"from proboscis import test"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffvk%3D","line":23,"in_reply_to":"AAAAS3%2F%2Ffx8%3D","updated":"2013-09-25 18:05:55.000000000","message":"F811 redefinition of unused","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"f647fb1629812a7a4790b3dbdc5a86873e0c2110","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if test_config.nova_client is not None:"},{"line_number":109,"context_line":"            return self.nova_client.flavors.list()"},{"line_number":110,"context_line":"        # If we don\u0027t have access to the client the flavors need to be spelled"},{"line_number":111,"context_line":"        # out in the config file."},{"line_number":112,"context_line":"        flavors \u003d [Flavor(Flavors, flavor_dict, loaded\u003dTrue)"},{"line_number":113,"context_line":"                   for flavor_dict in test_config.flavors]"},{"line_number":114,"context_line":"        return flavors"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffww%3D","line":111,"updated":"2013-09-25 18:03:07.000000000","message":"Should that Flavors be updated to cli_flavor then?","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"81359b5883a26a5d710c8ea91e267dd308bed2c5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if test_config.nova_client is not None:"},{"line_number":109,"context_line":"            return self.nova_client.flavors.list()"},{"line_number":110,"context_line":"        # If we don\u0027t have access to the client the flavors need to be spelled"},{"line_number":111,"context_line":"        # out in the config file."},{"line_number":112,"context_line":"        flavors \u003d [Flavor(Flavors, flavor_dict, loaded\u003dTrue)"},{"line_number":113,"context_line":"                   for flavor_dict in test_config.flavors]"},{"line_number":114,"context_line":"        return flavors"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FfcQ%3D","line":111,"in_reply_to":"AAAAS3%2F%2Ffqk%3D","updated":"2013-09-25 19:28:41.000000000","message":"If it wont make tests fall in some how, i\u0027ll remove it!","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"28ba10c11a2607ad5ed691996a074a35400dfb33","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if test_config.nova_client is not None:"},{"line_number":109,"context_line":"            return self.nova_client.flavors.list()"},{"line_number":110,"context_line":"        # If we don\u0027t have access to the client the flavors need to be spelled"},{"line_number":111,"context_line":"        # out in the config file."},{"line_number":112,"context_line":"        flavors \u003d [Flavor(Flavors, flavor_dict, loaded\u003dTrue)"},{"line_number":113,"context_line":"                   for flavor_dict in test_config.flavors]"},{"line_number":114,"context_line":"        return flavors"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffqk%3D","line":111,"in_reply_to":"AAAAS3%2F%2Ffus%3D","updated":"2013-09-25 18:28:23.000000000","message":"In that case, I don\u0027t know that the import on 23 is necessary as I don\u0027t see \u0027cli_flavor\u0027 used anywhere else in this file.","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9d56613e08ab9c88b8d975a652858bf9a18d25ab","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if test_config.nova_client is not None:"},{"line_number":109,"context_line":"            return self.nova_client.flavors.list()"},{"line_number":110,"context_line":"        # If we don\u0027t have access to the client the flavors need to be spelled"},{"line_number":111,"context_line":"        # out in the config file."},{"line_number":112,"context_line":"        flavors \u003d [Flavor(Flavors, flavor_dict, loaded\u003dTrue)"},{"line_number":113,"context_line":"                   for flavor_dict in test_config.flavors]"},{"line_number":114,"context_line":"        return flavors"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffus%3D","line":111,"in_reply_to":"AAAAS3%2F%2Ffww%3D","updated":"2013-09-25 18:08:40.000000000","message":"no. suppose that they are not connected at all.","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"}],"trove/tests/unittests/instance/test_instance_controller.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"d9854b181ec691c00a1eac4a518744c809925b2f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":109,"context_line":"        self.assertTrue(validator.is_valid(body))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_validate_create_complete_with_restore_error(self):"},{"line_number":112,"context_line":"        body \u003d self.instance"},{"line_number":113,"context_line":"        backup_id_ref \u003d \"invalid-backup-id-ref\""},{"line_number":114,"context_line":"        body[\u0027instance\u0027][\u0027restorePoint\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FfzY%3D","line":111,"updated":"2013-09-25 17:59:43.000000000","message":"That is a very good catch.","commit_id":"8e3bdc4e9ce49bc1ce68c0ae3de82ac020c37bbd"},{"author":{"_account_id":7850,"name":"Kevin Conway","email":"kevinjacobconway@gmail.com","username":"kevinconway"},"change_message_id":"0fe5d10beeb9573a99ee39fb8fee52639697785d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":109,"context_line":"        self.assertTrue(validator.is_valid(body))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_validate_create_complete_with_restore_error(self):"},{"line_number":112,"context_line":"        body \u003d self.instance"},{"line_number":113,"context_line":"        backup_id_ref \u003d \"invalid-backup-id-ref\""},{"line_number":114,"context_line":"        body[\u0027instance\u0027][\u0027restorePoint\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffx0%3D","line":111,"updated":"2013-09-25 17:58:23.000000000","message":"Which PEP does this fix?","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d0c6f2386fbcf03f2225941742a0a1dda11b8d0a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":109,"context_line":"        self.assertTrue(validator.is_valid(body))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_validate_create_complete_with_restore_error(self):"},{"line_number":112,"context_line":"        body \u003d self.instance"},{"line_number":113,"context_line":"        backup_id_ref \u003d \"invalid-backup-id-ref\""},{"line_number":114,"context_line":"        body[\u0027instance\u0027][\u0027restorePoint\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FfvY%3D","line":111,"in_reply_to":"AAAAS3%2F%2Ffx0%3D","updated":"2013-09-25 18:05:55.000000000","message":"F811 redefinition of unused","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"f647fb1629812a7a4790b3dbdc5a86873e0c2110","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":109,"context_line":"        self.assertTrue(validator.is_valid(body))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_validate_create_complete_with_restore_error(self):"},{"line_number":112,"context_line":"        body \u003d self.instance"},{"line_number":113,"context_line":"        backup_id_ref \u003d \"invalid-backup-id-ref\""},{"line_number":114,"context_line":"        body[\u0027instance\u0027][\u0027restorePoint\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Ffw8%3D","line":111,"in_reply_to":"AAAAS3%2F%2Ffx0%3D","updated":"2013-09-25 18:03:07.000000000","message":"It fixes \"otherwise the test defined on 102 wouldn\u0027t run\"","commit_id":"cfb7c57363f0b0b47f3f2b8421108721473902ee"},{"author":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"change_message_id":"7ed2d04ea3703124716fdea6eb8702fb955ba7e6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":109,"context_line":"        self.assertTrue(validator.is_valid(body))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_validate_create_complete_with_restore_error(self):"},{"line_number":112,"context_line":"        body \u003d self.instance"},{"line_number":113,"context_line":"        backup_id_ref \u003d \"invalid-backup-id-ref\""},{"line_number":114,"context_line":"        body[\u0027instance\u0027][\u0027restorePoint\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FVO8%3D","line":111,"updated":"2013-09-30 03:03:31.000000000","message":"which rule?","commit_id":"2e3eb660bef4e9e8fb83998e8a79e1497c50071c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"18ebf1a0dfc2861a127fdf4cf13043cc4099a159","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":109,"context_line":"        self.assertTrue(validator.is_valid(body))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_validate_create_complete_with_restore_error(self):"},{"line_number":112,"context_line":"        body \u003d self.instance"},{"line_number":113,"context_line":"        backup_id_ref \u003d \"invalid-backup-id-ref\""},{"line_number":114,"context_line":"        body[\u0027instance\u0027][\u0027restorePoint\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FPuM%3D","line":111,"in_reply_to":"AAAAS3%2F%2FPxA%3D","updated":"2013-10-01 16:09:09.000000000","message":"Not agreed with you, as you can see, this tests are different and they are exceting as different tests, but they have same name, that is why it causes F811 and none of this tests should be deleted. They should be named correctly.","commit_id":"2e3eb660bef4e9e8fb83998e8a79e1497c50071c"},{"author":{"_account_id":7850,"name":"Kevin Conway","email":"kevinjacobconway@gmail.com","username":"kevinconway"},"change_message_id":"7924e5238152a430443593cad47c7a8a9f9f536b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":109,"context_line":"        self.assertTrue(validator.is_valid(body))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_validate_create_complete_with_restore_error(self):"},{"line_number":112,"context_line":"        body \u003d self.instance"},{"line_number":113,"context_line":"        backup_id_ref \u003d \"invalid-backup-id-ref\""},{"line_number":114,"context_line":"        body[\u0027instance\u0027][\u0027restorePoint\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FPxA%3D","line":111,"in_reply_to":"AAAAS3%2F%2FVCE%3D","updated":"2013-10-01 16:00:34.000000000","message":"The function above appears to be duplicated within the function you have changed.\n\nWhat not just delete the first function and leave this one unchanged? The fact that they shared a name means the first function was not used.","commit_id":"2e3eb660bef4e9e8fb83998e8a79e1497c50071c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1dd07868c28c182dd32db0c9bbe18d2b64bc168e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":109,"context_line":"        self.assertTrue(validator.is_valid(body))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_validate_create_complete_with_restore_error(self):"},{"line_number":112,"context_line":"        body \u003d self.instance"},{"line_number":113,"context_line":"        backup_id_ref \u003d \"invalid-backup-id-ref\""},{"line_number":114,"context_line":"        body[\u0027instance\u0027][\u0027restorePoint\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FVCE%3D","line":111,"in_reply_to":"AAAAS3%2F%2FVO8%3D","updated":"2013-10-01 09:13:36.000000000","message":"F811","commit_id":"2e3eb660bef4e9e8fb83998e8a79e1497c50071c"}]}