)]}'
{"trove/common/strategies/cluster/experimental/mongodb/api.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"508c475a26bc6810f5b429ec849f4879f0b8a78c","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    % {\u0027given\u0027: item.keys(), \u0027expected\u0027: key}"},{"line_number":186,"context_line":"                )"},{"line_number":187,"context_line":"            value \u003d item.get(key, None)"},{"line_number":188,"context_line":"            if valid_values and value[0].encode(\u0027utf-8\u0027) not in valid_values:"},{"line_number":189,"context_line":"                raise exception.TroveError("},{"line_number":190,"context_line":"                    _(\u0027The value %(value)s for key %(key)s is invalid. \u0027"},{"line_number":191,"context_line":"                      \u0027Allowed values are %(valid)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_52c40291","line":188,"range":{"start_line":188,"start_character":37,"end_line":188,"end_character":40},"updated":"2017-07-27 15:44:18.000000000","message":"I think here you are just encoding the first character of the string.","commit_id":"b8da057163709cc29bc4c310322e09e057b4c11a"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"abe629136d8eff140495888b368611ca9755d72f","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    % {\u0027given\u0027: item.keys(), \u0027expected\u0027: key}"},{"line_number":186,"context_line":"                )"},{"line_number":187,"context_line":"            value \u003d item.get(key, None)"},{"line_number":188,"context_line":"            if valid_values and value[0].encode(\u0027utf-8\u0027) not in valid_values:"},{"line_number":189,"context_line":"                raise exception.TroveError("},{"line_number":190,"context_line":"                    _(\u0027The value %(value)s for key %(key)s is invalid. \u0027"},{"line_number":191,"context_line":"                      \u0027Allowed values are %(valid)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_691b89c9","line":188,"range":{"start_line":188,"start_character":37,"end_line":188,"end_character":40},"in_reply_to":"ff346bd7_52c40291","updated":"2017-07-28 01:46:44.000000000","message":"this is the wrong place to be converting this to utf8. If you want to encode as utf8, do that way earlier in the stream and ensure that valid_values is utf8 encoded as well","commit_id":"b8da057163709cc29bc4c310322e09e057b4c11a"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"508c475a26bc6810f5b429ec849f4879f0b8a78c","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                                         required\u003dTrue))"},{"line_number":199,"context_line":"        volume_size \u003d int(_check_option(\u0027volume\u0027, required\u003dTrue)[\u0027size\u0027])"},{"line_number":200,"context_line":"        instance_type \u003d _check_option(\u0027type\u0027, required\u003dTrue,"},{"line_number":201,"context_line":"                                      valid_values\u003d[\u0027replica\u0027,"},{"line_number":202,"context_line":"                                                    \u0027query_router\u0027])"},{"line_number":203,"context_line":"        name \u003d _check_option(\u0027name\u0027)"},{"line_number":204,"context_line":"        related_to \u003d _check_option(\u0027related_to\u0027)"},{"line_number":205,"context_line":"        nics \u003d _check_option(\u0027nics\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_d20b52d3","line":202,"range":{"start_line":201,"start_character":52,"end_line":202,"end_character":66},"updated":"2017-07-27 15:44:18.000000000","message":"Instead of using the encode(\u0027utf-8\u0027) call, alternatively, you could replace these values with u\u0027replica\u0027 and u\u0027query_router\u0027.","commit_id":"b8da057163709cc29bc4c310322e09e057b4c11a"}]}