)]}'
{"trove/common/remote.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3f0f354e8c660dc4a78fae9a288664d7b4163d60","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    client \u003d Client(CONF.nova_client_version,"},{"line_number":98,"context_line":"                    username\u003dcontext.user,"},{"line_number":99,"context_line":"                    password\u003dpassword,"},{"line_number":100,"context_line":"                    endpoint_override\u003durl,"},{"line_number":101,"context_line":"                    project_id\u003dcontext.project_id,"},{"line_number":102,"context_line":"                    project_domain_name\u003dcontext.project_domain_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_1421b49f","line":99,"updated":"2017-07-28 02:00:33.000000000","message":"you need a password with a token? something doesn\u0027t compute here.","commit_id":"51cec406e5b7e94b43da636fff9585ade805b7e4"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"7b834b904d404cb0f003c258b6b08934a942a40e","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    client \u003d Client(CONF.nova_client_version,"},{"line_number":98,"context_line":"                    username\u003dcontext.user,"},{"line_number":99,"context_line":"                    password\u003dpassword,"},{"line_number":100,"context_line":"                    endpoint_override\u003durl,"},{"line_number":101,"context_line":"                    project_id\u003dcontext.project_id,"},{"line_number":102,"context_line":"                    project_domain_name\u003dcontext.project_domain_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_31703c08","line":99,"in_reply_to":"ff346bd7_1421b49f","updated":"2017-07-28 12:24:31.000000000","message":"There are two different callers and flows here.\n1. The Trove user, who who have a context and that context would have an authentication token set on it since they would have authenticated with Keystone before calling Trove.  That flow will use the user\u0027s credentials when calling Nova, hence we keep the auth_token parameter here.\n\n2. The Trove task manager admin context / CONF.nova_proxy_admin_user.  This is the defect flow that is being fixed.  This user has not authenticated to Keystone and does not have an auth token.  Novaclient changed to stop accepting user passwords on this auth_token parameters.  The code fix in this review allows this Trove task manager admin context to continue to log in to Nova by passing the password.  Additionally Keystone has also changed to require user_domain_name during userid/password auth, so that parameter is added.","commit_id":"51cec406e5b7e94b43da636fff9585ade805b7e4"}]}