)]}'
{"trove/instance/service.py":[{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"dee3215ee6191071a6ef478c454b164f72c8c0da","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            users \u003d populate_users(body[\u0027instance\u0027].get(\u0027users\u0027, []),"},{"line_number":290,"context_line":"                                   database_names)"},{"line_number":291,"context_line":"        except ValueError as ve:"},{"line_number":292,"context_line":"            raise exception.BadRequest(message\u003dstr(ve))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        modules \u003d body[\u0027instance\u0027].get(\u0027modules\u0027)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_3cbfe6aa","line":292,"range":{"start_line":292,"start_character":39,"end_line":292,"end_character":46},"updated":"2017-08-16 09:57:39.000000000","message":"To keep consistent with other code style, \u0027message\u0027 maybe change to \u0027msg\u0027.","commit_id":"3fd20a3dbef8254215403abaed8834ec45b326ee"},{"author":{"_account_id":23757,"name":"Mateusz Kowalski","email":"mko@redhat.com","username":"makowals"},"change_message_id":"4faa5c02c7daf033c8db7d6efa9296e91c6656e0","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            users \u003d populate_users(body[\u0027instance\u0027].get(\u0027users\u0027, []),"},{"line_number":290,"context_line":"                                   database_names)"},{"line_number":291,"context_line":"        except ValueError as ve:"},{"line_number":292,"context_line":"            raise exception.BadRequest(message\u003dstr(ve))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        modules \u003d body[\u0027instance\u0027].get(\u0027modules\u0027)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_bc84f6d3","line":292,"range":{"start_line":292,"start_character":39,"end_line":292,"end_character":46},"in_reply_to":"9f436f4f_3cbfe6aa","updated":"2017-08-16 10:00:42.000000000","message":"It cannot, that\u0027s the point of this fix ... If you pass \"msg\" to BadRequest class, it will be ignored afterwards","commit_id":"3fd20a3dbef8254215403abaed8834ec45b326ee"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"79c20d2fc5e5a0b9465d1f2f36c7c582b769fc8b","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            users \u003d populate_users(body[\u0027instance\u0027].get(\u0027users\u0027, []),"},{"line_number":290,"context_line":"                                   database_names)"},{"line_number":291,"context_line":"        except ValueError as ve:"},{"line_number":292,"context_line":"            raise exception.BadRequest(message\u003dstr(ve))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        modules \u003d body[\u0027instance\u0027].get(\u0027modules\u0027)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_2e2a167e","line":292,"range":{"start_line":292,"start_character":39,"end_line":292,"end_character":46},"in_reply_to":"9f436f4f_a2204c9c","updated":"2017-11-06 17:32:13.000000000","message":"Thanks for your contribution.  It would be nice to get the more detailed message surfaced.\n\nHere [1] is an example of safely converting a ValueError to a BadRequest.\n\nCan you do this here?\n\n[1] https://github.com/openstack/trove/blob/master/trove/extensions/mysql/common.py#L39-L44","commit_id":"3fd20a3dbef8254215403abaed8834ec45b326ee"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"e21937ff7d8eb919378772b5116a890e64cfce47","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            users \u003d populate_users(body[\u0027instance\u0027].get(\u0027users\u0027, []),"},{"line_number":290,"context_line":"                                   database_names)"},{"line_number":291,"context_line":"        except ValueError as ve:"},{"line_number":292,"context_line":"            raise exception.BadRequest(message\u003dstr(ve))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        modules \u003d body[\u0027instance\u0027].get(\u0027modules\u0027)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_a2204c9c","line":292,"range":{"start_line":292,"start_character":39,"end_line":292,"end_character":46},"in_reply_to":"9f436f4f_bc84f6d3","updated":"2017-08-16 14:43:35.000000000","message":"I\u0027m sorry. Now I\u0027m know what you mean, modify like this also works\u003craise exception.BadRequest(str(ve))\u003e.\nAre there others exception.BadRequest like msg\u003d** have the same questions?","commit_id":"3fd20a3dbef8254215403abaed8834ec45b326ee"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"cdf0b50bbeb5c3f74d037398deb7aebf93124fa2","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                                   (locality,"},{"line_number":344,"context_line":"                                    \"\u0027, \u0027\".join(locality_domain)))"},{"line_number":345,"context_line":"            if locality not in locality_domain:"},{"line_number":346,"context_line":"                raise exception.BadRequest(msg\u003dlocality_domain_msg)"},{"line_number":347,"context_line":"            if slave_of_id:"},{"line_number":348,"context_line":"                dupe_locality_msg \u003d ("},{"line_number":349,"context_line":"                    \u0027Cannot specify locality when adding replicas to existing \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_00d6a2f2","line":346,"range":{"start_line":346,"start_character":43,"end_line":346,"end_character":46},"updated":"2017-11-22 03:44:43.000000000","message":"this is the same problem.","commit_id":"aea52300edee7b0c33defae30bc8c3ad6f0964ed"},{"author":{"_account_id":23757,"name":"Mateusz Kowalski","email":"mko@redhat.com","username":"makowals"},"change_message_id":"0cb108ea38328b572ae0e3fc0060b841e8a3d071","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                                   (locality,"},{"line_number":344,"context_line":"                                    \"\u0027, \u0027\".join(locality_domain)))"},{"line_number":345,"context_line":"            if locality not in locality_domain:"},{"line_number":346,"context_line":"                raise exception.BadRequest(msg\u003dlocality_domain_msg)"},{"line_number":347,"context_line":"            if slave_of_id:"},{"line_number":348,"context_line":"                dupe_locality_msg \u003d ("},{"line_number":349,"context_line":"                    \u0027Cannot specify locality when adding replicas to existing \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_0192219f","line":346,"range":{"start_line":346,"start_character":43,"end_line":346,"end_character":46},"in_reply_to":"ff82abbf_00d6a2f2","updated":"2017-11-22 07:45:52.000000000","message":"True, but the bug was open only for this one specific instance of the bug. Is this a correct place for fixing this issues across the whole file? If yes, I will do so (but then relevant bug report is a bit incomplete I think ...)","commit_id":"aea52300edee7b0c33defae30bc8c3ad6f0964ed"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"ac95cb9b833d355acfcb0f76e43e63321e874188","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                                   (locality,"},{"line_number":344,"context_line":"                                    \"\u0027, \u0027\".join(locality_domain)))"},{"line_number":345,"context_line":"            if locality not in locality_domain:"},{"line_number":346,"context_line":"                raise exception.BadRequest(msg\u003dlocality_domain_msg)"},{"line_number":347,"context_line":"            if slave_of_id:"},{"line_number":348,"context_line":"                dupe_locality_msg \u003d ("},{"line_number":349,"context_line":"                    \u0027Cannot specify locality when adding replicas to existing \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_045a2f4e","line":346,"range":{"start_line":346,"start_character":43,"end_line":346,"end_character":46},"in_reply_to":"ff82abbf_0192219f","updated":"2017-11-22 09:01:31.000000000","message":"Consider the related bug, it seems fix this as a new patch is fine.\nBesides, I find one more issues in\nhttps://github.com/openstack/trove/blob/master/trove/cluster/service.py#L219","commit_id":"aea52300edee7b0c33defae30bc8c3ad6f0964ed"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"cdf0b50bbeb5c3f74d037398deb7aebf93124fa2","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                dupe_locality_msg \u003d ("},{"line_number":349,"context_line":"                    \u0027Cannot specify locality when adding replicas to existing \u0027"},{"line_number":350,"context_line":"                    \u0027master.\u0027)"},{"line_number":351,"context_line":"                raise exception.BadRequest(msg\u003ddupe_locality_msg)"},{"line_number":352,"context_line":"        region_name \u003d body[\u0027instance\u0027].get(\u0027region_name\u0027, CONF.os_region_name)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        instance \u003d models.Instance.create(context, name, flavor_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_20fac674","line":351,"range":{"start_line":351,"start_character":43,"end_line":351,"end_character":46},"updated":"2017-11-22 03:44:43.000000000","message":"And this too.","commit_id":"aea52300edee7b0c33defae30bc8c3ad6f0964ed"},{"author":{"_account_id":23757,"name":"Mateusz Kowalski","email":"mko@redhat.com","username":"makowals"},"change_message_id":"0cb108ea38328b572ae0e3fc0060b841e8a3d071","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                dupe_locality_msg \u003d ("},{"line_number":349,"context_line":"                    \u0027Cannot specify locality when adding replicas to existing \u0027"},{"line_number":350,"context_line":"                    \u0027master.\u0027)"},{"line_number":351,"context_line":"                raise exception.BadRequest(msg\u003ddupe_locality_msg)"},{"line_number":352,"context_line":"        region_name \u003d body[\u0027instance\u0027].get(\u0027region_name\u0027, CONF.os_region_name)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        instance \u003d models.Instance.create(context, name, flavor_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_c1e9991a","line":351,"range":{"start_line":351,"start_character":43,"end_line":351,"end_character":46},"in_reply_to":"ff82abbf_20fac674","updated":"2017-11-22 07:45:52.000000000","message":"As above ...","commit_id":"aea52300edee7b0c33defae30bc8c3ad6f0964ed"}]}
