)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"a6441e109e6f0a2f991361bc5bd3575564845fb2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wangyao \u003cwangyao@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-04 19:46:33 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add volume size verify for replica based on master"},{"line_number":8,"context_line":"According bug description, replica should has volume size at least"},{"line_number":9,"context_line":"as much as the master. Otherwise it maybe cause exception for replica data."},{"line_number":10,"context_line":"To solve this problem,I added judgement for volume size when create a replica,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4b6375_555cc117","line":7,"updated":"2017-11-06 15:24:30.000000000","message":"Please update the commit message per the commit message guidelines\n\nIn particular you need a blank line between title and description and your lines need to wrap at 72 characters.\n\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"16fed4c80f97e310a87889a8d53b9e0c49a7fe3f"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"cdf159b94500f98b4ae49ffac124600a0579fea4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wangyao \u003cwangyao@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-04 19:46:33 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add volume size verify for replica based on master"},{"line_number":8,"context_line":"According bug description, replica should has volume size at least"},{"line_number":9,"context_line":"as much as the master. Otherwise it maybe cause exception for replica data."},{"line_number":10,"context_line":"To solve this problem,I added judgement for volume size when create a replica,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4b6375_945a30ef","line":7,"in_reply_to":"3f4b6375_555cc117","updated":"2017-11-07 02:33:23.000000000","message":"Thank you for your comments.\nBesides I changed this function as configurable, users can open or close this judgement when create replica by configuration according to their own needs.\nplease review ,thanks","commit_id":"16fed4c80f97e310a87889a8d53b9e0c49a7fe3f"}],"trove/common/cfg.py":[{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"45513aa4db2b3edabc95c7a9eda2cc528294f626","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                \u0027restore. Makes sure the checksum of original backup matches \u0027"},{"line_number":280,"context_line":"                \u0027the checksum of the Swift backup file.\u0027),"},{"line_number":281,"context_line":"    cfg.BoolOpt(\u0027verify_replica_volume_size\u0027, default\u003dTrue,"},{"line_number":282,"context_line":"                help\u003d\u0027Enable verification volume of replica before create.\u0027),"},{"line_number":283,"context_line":"    cfg.StrOpt(\u0027storage_strategy\u0027, default\u003d\u0027SwiftStorage\u0027,"},{"line_number":284,"context_line":"               help\u003d\"Default strategy to store backups.\"),"},{"line_number":285,"context_line":"    cfg.StrOpt(\u0027storage_namespace\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_4373a781","line":282,"range":{"start_line":282,"start_character":22,"end_line":282,"end_character":73},"updated":"2017-11-10 18:45:18.000000000","message":"We need a more descriptive text so the admin/user can choose to enable or disable this without having to look in the code to see how it is used.\n\nHow about \"Enable verification that the replica volume size is less than or equal to the size of the master volume during replica creation.\"","commit_id":"c158f28b2880026b33823a6fedf1664632e2d7a8"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"64c90042a819161f19fd283baca20a29992510e9","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                \u0027restore. Makes sure the checksum of original backup matches \u0027"},{"line_number":280,"context_line":"                \u0027the checksum of the Swift backup file.\u0027),"},{"line_number":281,"context_line":"    cfg.BoolOpt(\u0027verify_replica_volume_size\u0027, default\u003dTrue,"},{"line_number":282,"context_line":"                help\u003d\u0027Enable verification volume of replica before create.\u0027),"},{"line_number":283,"context_line":"    cfg.StrOpt(\u0027storage_strategy\u0027, default\u003d\u0027SwiftStorage\u0027,"},{"line_number":284,"context_line":"               help\u003d\"Default strategy to store backups.\"),"},{"line_number":285,"context_line":"    cfg.StrOpt(\u0027storage_namespace\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_bbd5dbbb","line":282,"range":{"start_line":282,"start_character":22,"end_line":282,"end_character":73},"in_reply_to":"1f485f77_4373a781","updated":"2017-11-12 00:57:01.000000000","message":"Agree with you.","commit_id":"c158f28b2880026b33823a6fedf1664632e2d7a8"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"a44c4941a2760d0e8856db9a28a911064368fe8d","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                \u0027the checksum of the Swift backup file.\u0027),"},{"line_number":281,"context_line":"    cfg.BoolOpt(\u0027verify_replica_volume_size\u0027, default\u003dTrue,"},{"line_number":282,"context_line":"                help\u003d\u0027Enable verification that the replica volume size \u0027"},{"line_number":283,"context_line":"                     \u0027is less than the size of the master volume \u0027"},{"line_number":284,"context_line":"                     \u0027during replica creation.\u0027),"},{"line_number":285,"context_line":"    cfg.StrOpt(\u0027storage_strategy\u0027, default\u003d\u0027SwiftStorage\u0027,"},{"line_number":286,"context_line":"               help\u003d\"Default strategy to store backups.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_11515937","line":283,"range":{"start_line":283,"start_character":25,"end_line":283,"end_character":35},"updated":"2017-11-13 12:48:28.000000000","message":"I think this should be \"less than or equal to\"","commit_id":"17d207e41482fe4cd810b27063b72be9b481745e"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"fe14f0f98d9ac6e3a01a78989ae83fe24fab15c6","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                \u0027the checksum of the Swift backup file.\u0027),"},{"line_number":281,"context_line":"    cfg.BoolOpt(\u0027verify_replica_volume_size\u0027, default\u003dTrue,"},{"line_number":282,"context_line":"                help\u003d\u0027Enable verification that the replica volume size \u0027"},{"line_number":283,"context_line":"                     \u0027is less than the size of the master volume \u0027"},{"line_number":284,"context_line":"                     \u0027during replica creation.\u0027),"},{"line_number":285,"context_line":"    cfg.StrOpt(\u0027storage_strategy\u0027, default\u003d\u0027SwiftStorage\u0027,"},{"line_number":286,"context_line":"               help\u003d\"Default strategy to store backups.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_c72c2349","line":283,"range":{"start_line":283,"start_character":25,"end_line":283,"end_character":35},"in_reply_to":"1f485f77_11515937","updated":"2017-11-13 13:54:40.000000000","message":"I don\u0027t understand why need \"equal to\"? When replica volume size equal to master volume size is allow to create replica.","commit_id":"17d207e41482fe4cd810b27063b72be9b481745e"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"1911a6dea721e365b5bb8afe1ebaf92237f18e42","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                \u0027the checksum of the Swift backup file.\u0027),"},{"line_number":281,"context_line":"    cfg.BoolOpt(\u0027verify_replica_volume_size\u0027, default\u003dTrue,"},{"line_number":282,"context_line":"                help\u003d\u0027Enable verification that the replica volume size \u0027"},{"line_number":283,"context_line":"                     \u0027is less than the size of the master volume \u0027"},{"line_number":284,"context_line":"                     \u0027during replica creation.\u0027),"},{"line_number":285,"context_line":"    cfg.StrOpt(\u0027storage_strategy\u0027, default\u003d\u0027SwiftStorage\u0027,"},{"line_number":286,"context_line":"               help\u003d\"Default strategy to store backups.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_4e03ab74","line":283,"range":{"start_line":283,"start_character":25,"end_line":283,"end_character":35},"in_reply_to":"1f485f77_c72c2349","updated":"2017-11-13 15:21:04.000000000","message":"You are correct that the code is verifying the replica volume is equal to or greater than the master/source volume before allowing the replica creation.\n\nMy confusion came from the message structure, and the message as it currently reads is confusing.  Yes, I also realize you copy/pasted what I wrote in a previous comment so I\u0027m saying what I wrote is now confusing me :)\n\nThe term \"enable verification\" to me, means the condition that\u0027s stated should be the positive/passing condition.  We could also change \"Enable verification\" to simply \"Require \"\n\n\nRequire the replica volume size to be greater than or equal to the size of the master volume during replica creation.","commit_id":"17d207e41482fe4cd810b27063b72be9b481745e"}],"trove/instance/models.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1a228f915927836048d25d204904f2679c91779e","unresolved":false,"context_lines":[{"line_number":955,"context_line":"                        % {\u0027id\u0027: slave_of_id})"},{"line_number":956,"context_line":"                if replica_source.volume_size \u003e volume_size:"},{"line_number":957,"context_line":"                    raise exception.Forbidden("},{"line_number":958,"context_line":"                        _(\"Replica volume size should not be smaller than master\u0027s, \""},{"line_number":959,"context_line":"                          \"replica volume size: %(replica_size)s and master volume size: %(master_size)s.\")"},{"line_number":960,"context_line":"                        % {\u0027replica_size\u0027: volume_size, \u0027master_size\u0027: replica_source.volume_size})"},{"line_number":961,"context_line":"                # load the replica source status to check if"},{"line_number":962,"context_line":"                # source is available"},{"line_number":963,"context_line":"                load_simple_instance_server_status("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_54a43f08","line":960,"range":{"start_line":958,"start_character":21,"end_line":960,"end_character":99},"updated":"2017-11-01 02:13:43.000000000","message":"Lines are too long.","commit_id":"2976fa9aa9f016c689f6ee2bdbaff3d9aae4e87a"}],"trove/tests/unittests/instance/test_instance_models.py":[{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"45513aa4db2b3edabc95c7a9eda2cc528294f626","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        self.assertRaises(exception.Forbidden,"},{"line_number":430,"context_line":"                          Instance.create,"},{"line_number":431,"context_line":"                          None, \u0027name\u0027, 1, \"UUID\", [], [], self.datastore,"},{"line_number":432,"context_line":"                          self.datastore_version, 0.5,"},{"line_number":433,"context_line":"                          None, slave_of_id\u003dself.master.id)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_231e6b0c","line":432,"range":{"start_line":432,"start_character":50,"end_line":432,"end_character":54},"updated":"2017-11-10 18:45:18.000000000","message":"Cinder does not support creation of volumes with non-integer sizes.  The min size is 1.  For this test you\u0027ll likely have to make the master volume size be 2 and this size 1.","commit_id":"c158f28b2880026b33823a6fedf1664632e2d7a8"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"64c90042a819161f19fd283baca20a29992510e9","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        self.assertRaises(exception.Forbidden,"},{"line_number":430,"context_line":"                          Instance.create,"},{"line_number":431,"context_line":"                          None, \u0027name\u0027, 1, \"UUID\", [], [], self.datastore,"},{"line_number":432,"context_line":"                          self.datastore_version, 0.5,"},{"line_number":433,"context_line":"                          None, slave_of_id\u003dself.master.id)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_5b4f07bd","line":432,"range":{"start_line":432,"start_character":50,"end_line":432,"end_character":54},"in_reply_to":"1f485f77_231e6b0c","updated":"2017-11-12 00:57:01.000000000","message":"yes, I\u0027ll change.","commit_id":"c158f28b2880026b33823a6fedf1664632e2d7a8"}]}