)]}'
{"trove/instance/models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bbb4326123e254460ad3e34f2d4d82ba7aa05de2","unresolved":false,"context_lines":[{"line_number":938,"context_line":""},{"line_number":939,"context_line":"        if slave_of_id:"},{"line_number":940,"context_line":"            if databases or users:"},{"line_number":941,"context_line":"                raise exception.Forbidden("},{"line_number":942,"context_line":"                        _(\"Cannot create a replica with users or databases.\"))"},{"line_number":943,"context_line":"            call_args[\u0027replica_of\u0027] \u003d slave_of_id"},{"line_number":944,"context_line":"            call_args[\u0027replica_count\u0027] \u003d replica_count"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_3bb38c9a","line":941,"updated":"2017-08-15 10:44:10.000000000","message":"please create a new error. see earlier (line 935) where we have a specific error. You can define one like that and raise it rather than the generic Forbidden.\n\nOtherwise, this approach appears complete.\n\nOne thought though is that maybe we should see if there\u0027s a way to catch this in the API. Not sure about that.","commit_id":"d8b540e500e10ed9f3ba152e9e0bfdcb5b9c9d88"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"51214f5c255512091db9341991af379123440448","unresolved":false,"context_lines":[{"line_number":938,"context_line":""},{"line_number":939,"context_line":"        if slave_of_id:"},{"line_number":940,"context_line":"            if databases or users:"},{"line_number":941,"context_line":"                raise exception.Forbidden("},{"line_number":942,"context_line":"                        _(\"Cannot create a replica with users or databases.\"))"},{"line_number":943,"context_line":"            call_args[\u0027replica_of\u0027] \u003d slave_of_id"},{"line_number":944,"context_line":"            call_args[\u0027replica_count\u0027] \u003d replica_count"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_f1a08044","line":941,"in_reply_to":"9f436f4f_3bb38c9a","updated":"2017-10-23 01:11:07.000000000","message":"Thanks,I will create a new error.\nCatch this in the API will be more complicated. I think it\u0027s unnecessary.","commit_id":"d8b540e500e10ed9f3ba152e9e0bfdcb5b9c9d88"}]}
