)]}'
{"trove/instance/models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f63fc8f54a875a69be56133a8923b536448b4ed5","unresolved":false,"context_lines":[{"line_number":950,"context_line":"                    id\u003dslave_of_id,"},{"line_number":951,"context_line":"                    deleted\u003dFalse)"},{"line_number":952,"context_line":"                if replica_source.datastore_version_id !\u003d datastore_version.id:"},{"line_number":953,"context_line":"                    raise exception.Forbidden("},{"line_number":954,"context_line":"                        _(\"The datastore_version of replica %(replica_version_id)s \""},{"line_number":955,"context_line":"                          \"should be consistent with master %(master_version_id)s.\")"},{"line_number":956,"context_line":"                        % {\u0027replica_version_id\u0027: datastore_version.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_7b57d4cb","line":953,"updated":"2017-08-15 10:18:13.000000000","message":"you should not be raising Forbidden. Please follow the pattern in the rest of the code and create a custom exception or use one that already exists.","commit_id":"b1dd71f1cbdd01d21aa64f5eba2dfa986c80ca43"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bda68ee1f6e5ed301dd57cbf98058a68fcd4fd14","unresolved":false,"context_lines":[{"line_number":949,"context_line":"                    context,"},{"line_number":950,"context_line":"                    id\u003dslave_of_id,"},{"line_number":951,"context_line":"                    deleted\u003dFalse)"},{"line_number":952,"context_line":"                if replica_source.datastore_version_id !\u003d datastore_version.id:"},{"line_number":953,"context_line":"                    raise exception.ReplicaCreateWithDatastoreError("},{"line_number":954,"context_line":"                        replica_version_id\u003ddatastore_version.id,"},{"line_number":955,"context_line":"                        master_version_id\u003dreplica_source.datastore_version_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_4331c159","line":952,"range":{"start_line":952,"start_character":20,"end_line":952,"end_character":78},"updated":"2017-08-15 16:11:59.000000000","message":"what if mysql version 5.5 wanted to be replicated to redis version 5.5? is just checking version sufficient?","commit_id":"322561e8d70dce97926e0f4c0f857e76580a0f13"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"b9a4ca6dc0550950b1edabd597905e410616789c","unresolved":false,"context_lines":[{"line_number":949,"context_line":"                    context,"},{"line_number":950,"context_line":"                    id\u003dslave_of_id,"},{"line_number":951,"context_line":"                    deleted\u003dFalse)"},{"line_number":952,"context_line":"                if replica_source.datastore_version_id !\u003d datastore_version.id:"},{"line_number":953,"context_line":"                    raise exception.ReplicaCreateWithDatastoreError("},{"line_number":954,"context_line":"                        replica_version_id\u003ddatastore_version.id,"},{"line_number":955,"context_line":"                        master_version_id\u003dreplica_source.datastore_version_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_18a677ac","line":952,"range":{"start_line":952,"start_character":20,"end_line":952,"end_character":78},"in_reply_to":"9f436f4f_4331c159","updated":"2017-08-16 02:05:06.000000000","message":"Thanks for your advise.\nBut please note that I verify by version id not version name, mysql version 5.5 and redis version 5.5 have different version id.","commit_id":"322561e8d70dce97926e0f4c0f857e76580a0f13"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bda68ee1f6e5ed301dd57cbf98058a68fcd4fd14","unresolved":false,"context_lines":[{"line_number":950,"context_line":"                    id\u003dslave_of_id,"},{"line_number":951,"context_line":"                    deleted\u003dFalse)"},{"line_number":952,"context_line":"                if replica_source.datastore_version_id !\u003d datastore_version.id:"},{"line_number":953,"context_line":"                    raise exception.ReplicaCreateWithDatastoreError("},{"line_number":954,"context_line":"                        replica_version_id\u003ddatastore_version.id,"},{"line_number":955,"context_line":"                        master_version_id\u003dreplica_source.datastore_version_id)"},{"line_number":956,"context_line":"                if replica_source.slave_of_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_23ffdd67","line":953,"range":{"start_line":953,"start_character":36,"end_line":953,"end_character":67},"updated":"2017-08-15 16:11:59.000000000","message":"this name isn\u0027t really clear.\n\nI\u0027d draw your attention also to https://review.openstack.org/#/c/119079/15/trove/instance/models.py which was a previous attempt to fix this issue.\n\nThat error message was more descriptive.","commit_id":"322561e8d70dce97926e0f4c0f857e76580a0f13"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"b9a4ca6dc0550950b1edabd597905e410616789c","unresolved":false,"context_lines":[{"line_number":950,"context_line":"                    id\u003dslave_of_id,"},{"line_number":951,"context_line":"                    deleted\u003dFalse)"},{"line_number":952,"context_line":"                if replica_source.datastore_version_id !\u003d datastore_version.id:"},{"line_number":953,"context_line":"                    raise exception.ReplicaCreateWithDatastoreError("},{"line_number":954,"context_line":"                        replica_version_id\u003ddatastore_version.id,"},{"line_number":955,"context_line":"                        master_version_id\u003dreplica_source.datastore_version_id)"},{"line_number":956,"context_line":"                if replica_source.slave_of_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_98b387e9","line":953,"range":{"start_line":953,"start_character":36,"end_line":953,"end_character":67},"in_reply_to":"9f436f4f_23ffdd67","updated":"2017-08-16 02:05:06.000000000","message":"Thanks for your suggest. Agree with you.","commit_id":"322561e8d70dce97926e0f4c0f857e76580a0f13"}]}