)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"7993ade9ad2da8454c9b81892fb089ee140e08d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change the default configuration value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova-network will be deprecated, this change is to change the default "},{"line_number":10,"context_line":"configuration value because Nova network(the current value), is "},{"line_number":11,"context_line":"deprecated"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_2ff1426c","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":20},"updated":"2017-11-02 12:03:18.000000000","message":"is","commit_id":"e329dcce45f13543e4843444a95b308794efbccf"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"7993ade9ad2da8454c9b81892fb089ee140e08d6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change the default configuration value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova-network will be deprecated, this change is to change the default "},{"line_number":10,"context_line":"configuration value because Nova network(the current value), is "},{"line_number":11,"context_line":"deprecated"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I75c0bfc350c8c21d4491d85a3d65a858645620d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_8f01563b","line":10,"updated":"2017-11-02 12:03:18.000000000","message":"Please remove trailing whitespace here and above.","commit_id":"e329dcce45f13543e4843444a95b308794efbccf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"ff165caa3493013ebcf302f7aedba856d0f5f3bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d0dc8f66_7eb4f05f","updated":"2025-03-04 07:35:16.000000000","message":"As the trove already break the upgrade from Victoria release, It\u0027s now safe to change the default network driver. as nova-network was deprecated many years.","commit_id":"a94e7f390df324f93bb4ab948be4eee78b44deae"}],"etc/trove/trove-taskmanager.conf.sample":[{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"324700eca1bb1f1b0b551273f8dd2b0e41761715","unresolved":false,"context_lines":[{"line_number":111,"context_line":"use_nova_server_volume \u003d False"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Config option for filtering the IP address that DNS uses"},{"line_number":114,"context_line":"# For nova-network, set this to the appropriate network label defined in nova"},{"line_number":115,"context_line":"# For neutron, set this to .* since users can specify custom network labels"},{"line_number":116,"context_line":"# You can also optionally specify regex\u0027es to match the actual IP addresses"},{"line_number":117,"context_line":"# ip_regex (white-list) is applied before black_list_regex in the filter chain"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f4b6375_54865cbb","line":114,"range":{"start_line":114,"start_character":1,"end_line":114,"end_character":77},"updated":"2017-11-02 03:19:23.000000000","message":"Do we still need to keep this?","commit_id":"22c80f5ec0ff2f0379cbafe5a26eca7bc04ff289"},{"author":{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},"change_message_id":"ecd071258b2f339691fb2dc4757c31e6aeb0cb44","unresolved":false,"context_lines":[{"line_number":111,"context_line":"use_nova_server_volume \u003d False"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Config option for filtering the IP address that DNS uses"},{"line_number":114,"context_line":"# For nova-network, set this to the appropriate network label defined in nova"},{"line_number":115,"context_line":"# For neutron, set this to .* since users can specify custom network labels"},{"line_number":116,"context_line":"# You can also optionally specify regex\u0027es to match the actual IP addresses"},{"line_number":117,"context_line":"# ip_regex (white-list) is applied before black_list_regex in the filter chain"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f4b6375_347d20b2","line":114,"range":{"start_line":114,"start_character":1,"end_line":114,"end_character":77},"in_reply_to":"3f4b6375_54865cbb","updated":"2017-11-02 03:32:49.000000000","message":"yes, we can delete it","commit_id":"22c80f5ec0ff2f0379cbafe5a26eca7bc04ff289"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"7993ade9ad2da8454c9b81892fb089ee140e08d6","unresolved":false,"context_lines":[{"line_number":111,"context_line":"use_nova_server_volume \u003d False"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Config option for filtering the IP address that DNS uses"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# For neutron, set this to .* since users can specify custom network labels"},{"line_number":116,"context_line":"# You can also optionally specify regex\u0027es to match the actual IP addresses"},{"line_number":117,"context_line":"# ip_regex (white-list) is applied before black_list_regex in the filter chain"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3f4b6375_6f7dfab0","line":114,"updated":"2017-11-02 12:03:18.000000000","message":"I think you need to keep this line because while nova-network is deprecated it can still be used so the description of how to set the property should remain.","commit_id":"e329dcce45f13543e4843444a95b308794efbccf"}],"trove/common/cfg.py":[{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"7993ade9ad2da8454c9b81892fb089ee140e08d6","unresolved":false,"context_lines":[{"line_number":398,"context_line":"                    \u0027Keystone v3 API with big service catalogs).\u0027),"},{"line_number":399,"context_line":"    cfg.StrOpt(\u0027conductor_manager\u0027, default\u003d\u0027trove.conductor.manager.Manager\u0027,"},{"line_number":400,"context_line":"               help\u003d\u0027Qualified class name to use for conductor manager.\u0027),"},{"line_number":401,"context_line":"    cfg.StrOpt(\u0027network_driver\u0027, default\u003d\u0027trove.network.nova.NeutronDriver\u0027,"},{"line_number":402,"context_line":"               help\u003d\"Describes the actual network manager used for \""},{"line_number":403,"context_line":"                    \"the management of network attributes \""},{"line_number":404,"context_line":"                    \"(security groups, floating IPs, etc.).\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_6a196878","line":401,"updated":"2017-11-02 12:03:18.000000000","message":"The py* tests are failing due to this change, and your other test failures (apiexamples, fakemode) are probably also failing due to this change.\n\nI think this change is the correct thing to do if we are going to change the default from nova network to Neutron, so you will have to figure out the correct fixes for the tests as well.","commit_id":"e329dcce45f13543e4843444a95b308794efbccf"}]}