)]}'
{"etc/trove/trove-guestagent.conf.sample":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"b54639be4ecff0487c3b87b150289cee34935cea","unresolved":false,"context_lines":[{"line_number":46,"context_line":"trove_auth_url \u003d http://0.0.0.0:5000/v2.0"},{"line_number":47,"context_line":"swift_url \u003d http://10.0.0.1:8080/v1/AUTH_"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Managers impl for the guestagent"},{"line_number":50,"context_line":"# service_registry_ext \u003d mysql:trove.guestagent.manager.mysql.manager.Manager, percona:trove.guestagent.manager.mysql.manager.Manager"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Root configuration"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAATH%2F%2FdyE%3D","line":49,"updated":"2013-10-15 20:27:47.000000000","message":"Can you change \"Managers impl for the guestagent\" to \"The Manager implementation for each service-type\u0027s guestagent\"?","commit_id":"3af5db4f2fb90a1b0044679890c4897d9f4d494c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"4264eb4e936d04a373f07ca106b08833b3d5bebf","unresolved":false,"context_lines":[{"line_number":46,"context_line":"trove_auth_url \u003d http://0.0.0.0:5000/v2.0"},{"line_number":47,"context_line":"swift_url \u003d http://10.0.0.1:8080/v1/AUTH_"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Managers impl for the guestagent"},{"line_number":50,"context_line":"# service_registry_ext \u003d mysql:trove.guestagent.manager.mysql.manager.Manager, percona:trove.guestagent.manager.mysql.manager.Manager"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Root configuration"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAATH%2F%2Fdss%3D","line":49,"in_reply_to":"AAAATH%2F%2FdyE%3D","updated":"2013-10-15 20:38:30.000000000","message":"yes","commit_id":"3af5db4f2fb90a1b0044679890c4897d9f4d494c"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"b54639be4ecff0487c3b87b150289cee34935cea","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ignore_users \u003d os_admin"},{"line_number":69,"context_line":"ignore_dbs \u003d lost+found, mysql, information_schema"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Strategy information for backups"},{"line_number":72,"context_line":"backup_strategy \u003d InnoBackupEx"},{"line_number":73,"context_line":"backup_namespace \u003d trove.guestagent.strategies.backup.mysql_impl"},{"line_number":74,"context_line":"restore_namespace \u003d trove.guestagent.strategies.restore.mysql_impl"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAATH%2F%2FdwY%3D","line":71,"updated":"2013-10-15 20:27:47.000000000","message":"While you\u0027re already generalizing the hierarchy for the Managers, why not fix Backups as well? backup_strategy + backup_namespace + restore_namespace (+ others) all assume one service-type (namely, MySQL). If you want to do this in another patch-set, I\u0027m more than fine with that, just calling out that the work is very similar in nature.","commit_id":"3af5db4f2fb90a1b0044679890c4897d9f4d494c"}],"trove/guestagent/common/operating_system.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"b54639be4ecff0487c3b87b150289cee34935cea","unresolved":false,"context_lines":[{"line_number":20,"context_line":"DEBIAN \u003d \u0027debian\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_os():"},{"line_number":24,"context_line":"    if os.path.isfile(\"/etc/redhat-release\"):"},{"line_number":25,"context_line":"        return REDHAT"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2Fd0E%3D","line":23,"updated":"2013-10-15 20:27:47.000000000","message":"Although this is a direct port from the existing codebase, I\u0027m not a fan of omitting a sensible default return value. You\u0027re forcing all callers to duplicate the logic of \"if its none, it\u0027s debian\". Please return DEBIAN.","commit_id":"3af5db4f2fb90a1b0044679890c4897d9f4d494c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"4264eb4e936d04a373f07ca106b08833b3d5bebf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"DEBIAN \u003d \u0027debian\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_os():"},{"line_number":24,"context_line":"    if os.path.isfile(\"/etc/redhat-release\"):"},{"line_number":25,"context_line":"        return REDHAT"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FdsU%3D","line":23,"in_reply_to":"AAAATH%2F%2Fd0E%3D","updated":"2013-10-15 20:38:30.000000000","message":"ok, seems good to return DEBIAN","commit_id":"3af5db4f2fb90a1b0044679890c4897d9f4d494c"}],"trove/guestagent/datastore/mysql/manager.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"b1577eadc562d27fdf0b6249e0a2e4a7311df5ae","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF \u003d cfg.CONF"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Manager(periodic_task.PeriodicTasks):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    @periodic_task.periodic_task(ticks_between_runs\u003d3)"},{"line_number":22,"context_line":"    def update_status(self, context):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FLUU%3D","line":19,"updated":"2013-10-21 22:28:06.000000000","message":"While we are doing this refactor, it seems like a good time to create a Manager RPC Interface that becomes the entry point for all datastore_types.  \n\nOne possibility is something like:\n\nin trove/guestagent/manager.py\n\nclass Manager(object):\n    def _get_guest_impl():\n        # return utils.import() class based on service_registry\n\n    def update_status(self, context):\n        _get_guest_impl().update_status(context)","commit_id":"290c78cbada6127bb350c93666d2f0148964d2b6"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d81c569c2e54579365c4e25d5240e504a1bb11d9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF \u003d cfg.CONF"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Manager(periodic_task.PeriodicTasks):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    @periodic_task.periodic_task(ticks_between_runs\u003d3)"},{"line_number":22,"context_line":"    def update_status(self, context):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FKt8%3D","line":19,"in_reply_to":"AAAATH%2F%2FLUU%3D","updated":"2013-10-22 05:38:33.000000000","message":"We have discuss this poing three or more times and we came into suggestion that we are not going to externalize manager interface, because it would not do anything useful.\nhttps://review.openstack.org/#/c/52329/.\n\nWhat a personaly think about creating such interface.\n - Guestagent already stricts API for rpc calls, so you cannot call any of side-away method.\n - Your suggestion would useful only as documentation.\n - We already have pluggability with manageres and it looks very good.\n - New parameters for managers pluggability in config would be confusing for any guy who configuring trove.\n\nSmall conclusion: we do not need it, because we already have restrictions for API call.","commit_id":"290c78cbada6127bb350c93666d2f0148964d2b6"}],"trove/guestagent/manager/mysql/mysql_manager.py":[{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"d87b405fab2df4fe260476a9cbddfe9d54501f74","unresolved":false,"context_lines":[{"line_number":4,"context_line":"from trove.guestagent import dbaas"},{"line_number":5,"context_line":"from trove.guestagent import backup"},{"line_number":6,"context_line":"from trove.guestagent import volume"},{"line_number":7,"context_line":"from trove.guestagent.manager.mysql.mysql_service import MySqlAppStatus"},{"line_number":8,"context_line":"from trove.guestagent.manager.mysql.mysql_service import MySqlAdmin"},{"line_number":9,"context_line":"from trove.guestagent.manager.mysql.mysql_service import MySqlApp"},{"line_number":10,"context_line":"from trove.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FzGI%3D","line":7,"updated":"2013-10-09 17:16:39.000000000","message":"do we need to prefix all these with mysql if they are already in the mysql module?\n\nmanager.mysql.service","commit_id":"d93a147f0fa7446c7ab78330034b913f6dda6189"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"2a887c06968f6bf96d1aee93c1222d22face8049","unresolved":false,"context_lines":[{"line_number":4,"context_line":"from trove.guestagent import dbaas"},{"line_number":5,"context_line":"from trove.guestagent import backup"},{"line_number":6,"context_line":"from trove.guestagent import volume"},{"line_number":7,"context_line":"from trove.guestagent.manager.mysql.mysql_service import MySqlAppStatus"},{"line_number":8,"context_line":"from trove.guestagent.manager.mysql.mysql_service import MySqlAdmin"},{"line_number":9,"context_line":"from trove.guestagent.manager.mysql.mysql_service import MySqlApp"},{"line_number":10,"context_line":"from trove.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FwoE%3D","line":7,"in_reply_to":"AAAATH%2F%2FzFg%3D","updated":"2013-10-10 08:20:43.000000000","message":"I\u0027d rather agree with Michael that mysql.mysql_  looks somewhat redundant. If you plan to support more than one version of mysql-related stuff in the package they may have more describing names.","commit_id":"d93a147f0fa7446c7ab78330034b913f6dda6189"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7e6da8f35ec9ac0b5d8b0019a16dfe3b4f8a5985","unresolved":false,"context_lines":[{"line_number":4,"context_line":"from trove.guestagent import dbaas"},{"line_number":5,"context_line":"from trove.guestagent import backup"},{"line_number":6,"context_line":"from trove.guestagent import volume"},{"line_number":7,"context_line":"from trove.guestagent.manager.mysql.mysql_service import MySqlAppStatus"},{"line_number":8,"context_line":"from trove.guestagent.manager.mysql.mysql_service import MySqlAdmin"},{"line_number":9,"context_line":"from trove.guestagent.manager.mysql.mysql_service import MySqlApp"},{"line_number":10,"context_line":"from trove.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FzFg%3D","line":7,"in_reply_to":"AAAATH%2F%2FzGI%3D","updated":"2013-10-09 17:18:53.000000000","message":"yes, this would help us to avoid import conficts in future, i suppose.","commit_id":"d93a147f0fa7446c7ab78330034b913f6dda6189"}],"trove/guestagent/manager/mysql/service.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"b54639be4ecff0487c3b87b150289cee34935cea","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    global ENGINE"},{"line_number":67,"context_line":"    if ENGINE:"},{"line_number":68,"context_line":"        return ENGINE"},{"line_number":69,"context_line":"        #ENGINE \u003d create_engine(name_or_url\u003durl)"},{"line_number":70,"context_line":"    pwd \u003d get_auth_password()"},{"line_number":71,"context_line":"    ENGINE \u003d sqlalchemy.create_engine(\"mysql://%s:%s@localhost:3306\" %"},{"line_number":72,"context_line":"                                      (ADMIN_USER_NAME, pwd.strip()),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2Fd4g%3D","line":69,"updated":"2013-10-15 20:27:47.000000000","message":"I\u0027d recommend to remove this comment, it provides zero value.","commit_id":"3af5db4f2fb90a1b0044679890c4897d9f4d494c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"4264eb4e936d04a373f07ca106b08833b3d5bebf","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    global ENGINE"},{"line_number":67,"context_line":"    if ENGINE:"},{"line_number":68,"context_line":"        return ENGINE"},{"line_number":69,"context_line":"        #ENGINE \u003d create_engine(name_or_url\u003durl)"},{"line_number":70,"context_line":"    pwd \u003d get_auth_password()"},{"line_number":71,"context_line":"    ENGINE \u003d sqlalchemy.create_engine(\"mysql://%s:%s@localhost:3306\" %"},{"line_number":72,"context_line":"                                      (ADMIN_USER_NAME, pwd.strip()),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FdsM%3D","line":69,"in_reply_to":"AAAATH%2F%2Fd4g%3D","updated":"2013-10-15 20:38:30.000000000","message":"ok, thanks","commit_id":"3af5db4f2fb90a1b0044679890c4897d9f4d494c"}],"trove/tests/unittests/backup/test_backupagent.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"b54639be4ecff0487c3b87b150289cee34935cea","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    f_bfree \u003d 512 * 1024"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"BACKUP_NS \u003d \u0027trove.guestagent.strategies.backup.impl\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class BackupAgentTest(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2Fd1Y%3D","line":141,"updated":"2013-10-15 20:27:47.000000000","message":"In your patch-set, trove/guestagent/strategies/backup/impl.py was moved to trove/guestagent/strategies/backup/mysql_impl.py, so this refers to something that is nonexistent. Upon further review however, BACKUP_NS is never referenced anywhere in the code base, so can you please remove it?","commit_id":"3af5db4f2fb90a1b0044679890c4897d9f4d494c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"4264eb4e936d04a373f07ca106b08833b3d5bebf","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    f_bfree \u003d 512 * 1024"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"BACKUP_NS \u003d \u0027trove.guestagent.strategies.backup.impl\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class BackupAgentTest(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2Fdtw%3D","line":141,"in_reply_to":"AAAATH%2F%2Fd1Y%3D","updated":"2013-10-15 20:38:30.000000000","message":"yes, of course","commit_id":"3af5db4f2fb90a1b0044679890c4897d9f4d494c"}],"trove/tests/unittests/guestagent/test_backups.py":[{"author":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"change_message_id":"27321cdc0275cf6442ef53a68ba1c131fcbde5e3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":"from trove.common import utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"BACKUP_XTRA_CLS \u003d (\"trove.guestagent.strategies.backup.\""},{"line_number":21,"context_line":"                   \"mysql_impl.InnoBackupEx\")"},{"line_number":22,"context_line":"RESTORE_XTRA_CLS \u003d (\"trove.guestagent.strategies.restore.\""},{"line_number":23,"context_line":"                    \"mysql_impl.InnoBackupEx\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FxVM%3D","line":20,"updated":"2013-10-10 03:11:53.000000000","message":"bracket necessary?","commit_id":"d93a147f0fa7446c7ab78330034b913f6dda6189"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9f14d7656252e938f3bb66ff5a7c8f97e0d38950","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":"from trove.common import utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"BACKUP_XTRA_CLS \u003d (\"trove.guestagent.strategies.backup.\""},{"line_number":21,"context_line":"                   \"mysql_impl.InnoBackupEx\")"},{"line_number":22,"context_line":"RESTORE_XTRA_CLS \u003d (\"trove.guestagent.strategies.restore.\""},{"line_number":23,"context_line":"                    \"mysql_impl.InnoBackupEx\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FxBA%3D","line":20,"in_reply_to":"AAAATH%2F%2FxVM%3D","updated":"2013-10-10 05:56:01.000000000","message":"yes, whole line is longet than 79 symbols, so i just don\u0027t want to use \\, instead i\u0027ve used ()","commit_id":"d93a147f0fa7446c7ab78330034b913f6dda6189"}]}
