)]}'
{"trove/common/policy.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"143c56c1d41e46d45471e55fe1d6e8eba05bde1e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        _ENFORCER \u003d policy.Enforcer(CONF)"},{"line_number":218,"context_line":"        _ENFORCER.register_defaults(base_rules)"},{"line_number":219,"context_line":"        _ENFORCER.register_defaults(instance_rules)"},{"line_number":220,"context_line":"        _ENFORCER.load_rules()"},{"line_number":221,"context_line":"    return _ENFORCER"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_fd768b3e","line":220,"range":{"start_line":220,"start_character":7,"end_line":220,"end_character":30},"updated":"2017-10-05 13:39:30.000000000","message":"Isn\u0027t this already done when the _ENFORCER is instantiated?","commit_id":"8ee95947a4c4f864f790c0f3f3070ea5892e8a66"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d302aa6d9652d4399344842ff225df35dea98e70","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        _ENFORCER \u003d policy.Enforcer(CONF)"},{"line_number":218,"context_line":"        _ENFORCER.register_defaults(base_rules)"},{"line_number":219,"context_line":"        _ENFORCER.register_defaults(instance_rules)"},{"line_number":220,"context_line":"        _ENFORCER.load_rules()"},{"line_number":221,"context_line":"    return _ENFORCER"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_2fbd17b7","line":220,"range":{"start_line":220,"start_character":7,"end_line":220,"end_character":30},"in_reply_to":"7f515b1d_55033343","updated":"2017-10-19 20:04:54.000000000","message":"I thought it was loaded regardless - https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L728\n\nSo whenever a service calls `enforce()`, it should pick up the latest rules from config or register the defaults.","commit_id":"8ee95947a4c4f864f790c0f3f3070ea5892e8a66"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"fbc3eb68bb4a965e37f7d88047cbbf8da80058c3","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        _ENFORCER \u003d policy.Enforcer(CONF)"},{"line_number":218,"context_line":"        _ENFORCER.register_defaults(base_rules)"},{"line_number":219,"context_line":"        _ENFORCER.register_defaults(instance_rules)"},{"line_number":220,"context_line":"        _ENFORCER.load_rules()"},{"line_number":221,"context_line":"    return _ENFORCER"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_55033343","line":220,"range":{"start_line":220,"start_character":7,"end_line":220,"end_character":30},"in_reply_to":"7f515b1d_759bcf65","updated":"2017-10-05 14:48:00.000000000","message":"Is this right?","commit_id":"8ee95947a4c4f864f790c0f3f3070ea5892e8a66"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"8c3c1c170aca1f6ac2af1e90a8df242b38bc1de4","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        _ENFORCER \u003d policy.Enforcer(CONF)"},{"line_number":218,"context_line":"        _ENFORCER.register_defaults(base_rules)"},{"line_number":219,"context_line":"        _ENFORCER.register_defaults(instance_rules)"},{"line_number":220,"context_line":"        _ENFORCER.load_rules()"},{"line_number":221,"context_line":"    return _ENFORCER"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_759bcf65","line":220,"range":{"start_line":220,"start_character":7,"end_line":220,"end_character":30},"in_reply_to":"7f515b1d_fd768b3e","updated":"2017-10-05 14:41:02.000000000","message":"Yes, we don\u0027t need reload for when the _ENFORCER is instantiated, but we need to reload for other next time if the config file is changed as I re-comment in Designate patchset.\nhttps://review.openstack.org/#/c/509061/6","commit_id":"8ee95947a4c4f864f790c0f3f3070ea5892e8a66"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"83361f533eae8da5b20fe20559ee40f246d312f1","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        _ENFORCER \u003d policy.Enforcer(CONF)"},{"line_number":218,"context_line":"        _ENFORCER.register_defaults(base_rules)"},{"line_number":219,"context_line":"        _ENFORCER.register_defaults(instance_rules)"},{"line_number":220,"context_line":"        _ENFORCER.load_rules()"},{"line_number":221,"context_line":"    return _ENFORCER"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_aff6a78e","line":220,"range":{"start_line":220,"start_character":7,"end_line":220,"end_character":30},"updated":"2017-10-19 20:08:01.000000000","message":"I left a comment on patch set 1 about this, but this step should get done automatically by an instance of the Enforcer object whenever `enforce()` is called:\n\nhttps://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L728","commit_id":"9a06b802391bdfc498524216e13724977720e8ea"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"d534af792117d244e50744ab025a3561324e4d9e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        _ENFORCER \u003d policy.Enforcer(CONF)"},{"line_number":218,"context_line":"        _ENFORCER.register_defaults(base_rules)"},{"line_number":219,"context_line":"        _ENFORCER.register_defaults(instance_rules)"},{"line_number":220,"context_line":"        _ENFORCER.load_rules()"},{"line_number":221,"context_line":"    return _ENFORCER"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_f7d0f1cb","line":220,"range":{"start_line":220,"start_character":7,"end_line":220,"end_character":30},"in_reply_to":"3f4b6375_6f730f17","updated":"2017-10-19 22:20:42.000000000","message":"I forgot to remove this.\nThanks, I will clean up it later :)","commit_id":"9a06b802391bdfc498524216e13724977720e8ea"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ab2c88c488bb8c9acaa2fd3aa3f9b3ac193c7986","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        _ENFORCER \u003d policy.Enforcer(CONF)"},{"line_number":218,"context_line":"        _ENFORCER.register_defaults(base_rules)"},{"line_number":219,"context_line":"        _ENFORCER.register_defaults(instance_rules)"},{"line_number":220,"context_line":"        _ENFORCER.load_rules()"},{"line_number":221,"context_line":"    return _ENFORCER"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_6f730f17","line":220,"range":{"start_line":220,"start_character":7,"end_line":220,"end_character":30},"in_reply_to":"3f4b6375_aff6a78e","updated":"2017-10-19 20:08:55.000000000","message":"Regardless, I don\u0027t think loading the rules more than one will break anything (just more or less trying to be DRY). We can follow-up in a separate patch, too.","commit_id":"9a06b802391bdfc498524216e13724977720e8ea"}]}