)]}'
{"trove/tests/api/instances_actions.py":[{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"35c97b608e054634b4332877e72de7c6ac457b9a","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        \"\"\"Ruin MySQL\u0027s ability to restart.\"\"\""},{"line_number":223,"context_line":"        server \u003d create_server_connection(self.instance_id)"},{"line_number":224,"context_line":"        cmd \u003d \"sudo cp /dev/null /var/lib/mysql/ib_logfile%d\""},{"line_number":225,"context_line":"        instance_info.dbaas_admin.management.stop(self.instance_id)"},{"line_number":226,"context_line":"        for index in range(2):"},{"line_number":227,"context_line":"            server.execute(cmd % index)"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fo7Y%3D","line":225,"updated":"2013-10-11 21:52:15.000000000","message":"The idea here is if something external kills MySQL the guest agent will detect it has died. The problem with calling stop is the guest agent itself is responsible for killing MySQL and thus can easily be programmed to update the status during the STOP command, so it doesn\u0027t really hit the same test case.","commit_id":"48aea9a75e5f4a6923c49760dc9f20f8f62f2478"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"ef7f451e80b6a893055cd80621260bea5ce9a336","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            cmd \u003d \"sudo rm /var/lib/mysql/ib_logfile%d\""},{"line_number":234,"context_line":"            # We want to stop mysql so that upstart does not keep trying to"},{"line_number":235,"context_line":"            # respawn it and block the guest agent from accessing the logs."},{"line_number":236,"context_line":"            instance_info.dbaas_admin.management.stop(self.instance_id)"},{"line_number":237,"context_line":"            for index in range(2):"},{"line_number":238,"context_line":"                server.execute(cmd % index)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fo40%3D","line":236,"updated":"2013-10-11 22:03:16.000000000","message":"Oh never mind looks like we\u0027re stopping it anyway. Ok, lines 233-238 should become a method named \"rm_logfiles\" which would then be called in \"mess_up_mysql\" in place of the old call to \"fix_mysql\". This would also be advantageous in that the code would read clearly.","commit_id":"48aea9a75e5f4a6923c49760dc9f20f8f62f2478"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"20e48ad573c74702c8c048d7a650a8635d3e5938","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            cmd \u003d \"sudo rm /var/lib/mysql/ib_logfile%d\""},{"line_number":234,"context_line":"            # We want to stop mysql so that upstart does not keep trying to"},{"line_number":235,"context_line":"            # respawn it and block the guest agent from accessing the logs."},{"line_number":236,"context_line":"            instance_info.dbaas_admin.management.stop(self.instance_id)"},{"line_number":237,"context_line":"            for index in range(2):"},{"line_number":238,"context_line":"                server.execute(cmd % index)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FeR4%3D","line":236,"in_reply_to":"AAAATH%2F%2Fo40%3D","updated":"2013-10-15 18:38:22.000000000","message":"Actually, forget it- its more important to at least make this test work. I can fix this later.","commit_id":"48aea9a75e5f4a6923c49760dc9f20f8f62f2478"}]}
