)]}'
{"trove/instance/models.py":[{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"56395956655ab7d35354c7914cc42492cf98e0a5","unresolved":false,"context_lines":[{"line_number":1322,"context_line":"        LOG.debug(\"Configuration has been persisted on the guest.\")"},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"        # Configuration has now been persisted on the instance and can be safely"},{"line_number":1325,"context_line":"        # attached. Update our records to reflect this change irrespective of"},{"line_number":1326,"context_line":"        # results of any further operations."},{"line_number":1327,"context_line":"        self.update_db(task_status\u003dInstanceTasks.RESTART_REQUIRED,"},{"line_number":1328,"context_line":"                       configuration_id\u003dconfiguration.configuration_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_b2b720d9","line":1325,"range":{"start_line":1325,"start_character":10,"end_line":1325,"end_character":12},"updated":"2017-10-31 07:20:26.000000000","message":"I think here should be \u0027detached\u0027. Others look good.","commit_id":"153b5be25a76c2eac181a0161c053f8089241d4a"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"2294dd76a4067430318f6f00b90909257edf9a52","unresolved":false,"context_lines":[{"line_number":1322,"context_line":"        LOG.debug(\"Configuration has been persisted on the guest.\")"},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"        # Configuration has now been persisted on the instance and can be safely"},{"line_number":1325,"context_line":"        # attached. Update our records to reflect this change irrespective of"},{"line_number":1326,"context_line":"        # results of any further operations."},{"line_number":1327,"context_line":"        self.update_db(task_status\u003dInstanceTasks.RESTART_REQUIRED,"},{"line_number":1328,"context_line":"                       configuration_id\u003dconfiguration.configuration_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_3b0d4b3e","line":1325,"range":{"start_line":1325,"start_character":10,"end_line":1325,"end_character":12},"in_reply_to":"3f4b6375_9b39dfa4","updated":"2017-10-31 09:43:44.000000000","message":"Yeah, I checked the code. Sorry for my irresponsible speculation. You are right.","commit_id":"153b5be25a76c2eac181a0161c053f8089241d4a"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"eefdf917dcf2141b4f581548bd40c98600c97964","unresolved":false,"context_lines":[{"line_number":1322,"context_line":"        LOG.debug(\"Configuration has been persisted on the guest.\")"},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"        # Configuration has now been persisted on the instance and can be safely"},{"line_number":1325,"context_line":"        # attached. Update our records to reflect this change irrespective of"},{"line_number":1326,"context_line":"        # results of any further operations."},{"line_number":1327,"context_line":"        self.update_db(task_status\u003dInstanceTasks.RESTART_REQUIRED,"},{"line_number":1328,"context_line":"                       configuration_id\u003dconfiguration.configuration_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_9b39dfa4","line":1325,"range":{"start_line":1325,"start_character":10,"end_line":1325,"end_character":12},"in_reply_to":"3f4b6375_b2b720d9","updated":"2017-10-31 09:32:16.000000000","message":"Thanks review, My thinking is attach has two steps, first save the configuration(write to config file),then apply it(dynamic). So, after update_overrides, it means can safely continue the attach thing.","commit_id":"153b5be25a76c2eac181a0161c053f8089241d4a"}]}