)]}'
{"trove/guestagent/datastore/experimental/redis/service.py":[{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"395eb28e89c10c1ed8c110f8b2676e98aa64c845","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                string_mappings\u003dconfig_value_mappings"},{"line_number":101,"context_line":"            ), requires_root\u003dTrue,"},{"line_number":102,"context_line":"            override_strategy\u003dOneFileOverrideStrategy(revision_dir))"},{"line_number":103,"context_line":"        "},{"line_number":104,"context_line":"        self.admin \u003d self._build_admin_client()"},{"line_number":105,"context_line":"        config_cmd \u003d self.get_config_command_name()"},{"line_number":106,"context_line":"        self.admin.__config_cmd_name \u003d self.admin.set_config_command_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_4112585a","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":8},"updated":"2017-10-31 10:23:04.000000000","message":"remove these spaces please.","commit_id":"792551fa2688fc9e14588f44a18f154615ac931f"},{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"b4b381a51a21dfc065064a7534712145e1ea6a1d","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self.admin \u003d self._build_admin_client()"},{"line_number":105,"context_line":"        config_cmd \u003d self.get_config_command_name()"},{"line_number":106,"context_line":"        self.admin.__config_cmd_name \u003d self.admin.set_config_command_name("},{"line_number":107,"context_line":"            config_cmd)"},{"line_number":108,"context_line":"        self.status \u003d RedisAppStatus(self.admin)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _build_admin_client(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_f42e6841","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":23},"updated":"2017-11-02 03:04:05.000000000","message":"I think this part of the code is a problem, it seems only need self.admin.set_config_command_name (\n             config_cmd)","commit_id":"884e5bb1180d9cb16f5e888a2b7da091b0fcd2e3"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a9380f14dae90b47706a8ca94af0d262c8efd450","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            override_strategy\u003dOneFileOverrideStrategy(revision_dir))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self.admin \u003d self._build_admin_client()"},{"line_number":105,"context_line":"        config_cmd \u003d self.get_config_command_name()"},{"line_number":106,"context_line":"        self.admin.__config_cmd_name \u003d self.admin.set_config_command_name("},{"line_number":107,"context_line":"            config_cmd)"},{"line_number":108,"context_line":"        self.status \u003d RedisAppStatus(self.admin)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _build_admin_client(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_4ec6ce4b","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":23},"updated":"2017-11-02 02:21:41.000000000","message":"This should be done in the initialization of RedisAdmin, generally internal attributes like \u0027__config_cmd_name\u0027 should not be modified directly outside.","commit_id":"884e5bb1180d9cb16f5e888a2b7da091b0fcd2e3"},{"author":{"_account_id":23540,"name":"Janice Chen","email":"chenshujuan@chinac.com","username":"Janice"},"change_message_id":"5316ab81a039d81b4cff153e6bc97c436a3a0e18","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            override_strategy\u003dOneFileOverrideStrategy(revision_dir))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self.admin \u003d self._build_admin_client()"},{"line_number":105,"context_line":"        config_cmd \u003d self.get_config_command_name()"},{"line_number":106,"context_line":"        self.admin.__config_cmd_name \u003d self.admin.set_config_command_name("},{"line_number":107,"context_line":"            config_cmd)"},{"line_number":108,"context_line":"        self.status \u003d RedisAppStatus(self.admin)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _build_admin_client(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_ae9e6204","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":23},"in_reply_to":"3f4b6375_4ec6ce4b","updated":"2017-11-02 02:34:39.000000000","message":"Hi,zhang chao, thanks for your comment. Here RedisAdmin was instantiated in the object \"admin\", so I think it\u0027s ok to assigne a value to instantiate object \"admin\"","commit_id":"884e5bb1180d9cb16f5e888a2b7da091b0fcd2e3"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"25f25a3f98a72a053d1d4701cb7fc1fffe1853f5","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            override_strategy\u003dOneFileOverrideStrategy(revision_dir))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self.admin \u003d self._build_admin_client()"},{"line_number":105,"context_line":"        config_cmd \u003d self.get_config_command_name()"},{"line_number":106,"context_line":"        self.admin.__config_cmd_name \u003d self.admin.set_config_command_name("},{"line_number":107,"context_line":"            config_cmd)"},{"line_number":108,"context_line":"        self.status \u003d RedisAppStatus(self.admin)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _build_admin_client(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_ae3ae2e3","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":23},"in_reply_to":"3f4b6375_ae9e6204","updated":"2017-11-02 03:00:08.000000000","message":"Yes, it\u0027s working, but initializing RedisAdmin with correct config command would be more straightforward.\n\np.s. I missed in the last comment that, it\u0027s wrong to assigning the return value of set_config_command_name to __config_cmd_name, as set_config_command_name is just the change __config_cmd_name of the RedisAdmin object and not having a return value.\n\np.p.s. And one more time, I prefer to setting correct config command in the initialization of RedisAdmin and this is what we have done when we encountered this problem. And thanks for bringing this fix to upstream.","commit_id":"884e5bb1180d9cb16f5e888a2b7da091b0fcd2e3"},{"author":{"_account_id":23540,"name":"Janice Chen","email":"chenshujuan@chinac.com","username":"Janice"},"change_message_id":"bb48cb92a10125e9174bfe033881026f676e83d6","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self.admin \u003d self._build_admin_client()"},{"line_number":105,"context_line":"        config_cmd \u003d self.get_config_command_name()"},{"line_number":106,"context_line":"        self.admin.__config_cmd_name \u003d self.admin.set_config_command_name("},{"line_number":107,"context_line":"            config_cmd)"},{"line_number":108,"context_line":"        self.status \u003d RedisAppStatus(self.admin)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _build_admin_client(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_34740036","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":23},"in_reply_to":"3f4b6375_f42e6841","updated":"2017-11-02 03:07:59.000000000","message":"I see, just need call set_config_command_name(config_cmd).","commit_id":"884e5bb1180d9cb16f5e888a2b7da091b0fcd2e3"}]}