)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"1ede67c66eee225af3dd0b220232225d3f0dfad6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error message while assigning configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While creating a replica of an error instance, the error message in"},{"line_number":10,"context_line":"_validate_can_perform_assign() is inaccurate and confusing. It should"},{"line_number":11,"context_line":"be more clear to show which status it is."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f485f77_0fc27b86","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":27},"updated":"2017-11-10 09:32:00.000000000","message":"assigning configurations for ?","commit_id":"60d195947eac425a6f8796b3f89056a1b47ccc88"}],"trove/instance/models.py":[{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"4054af66dbbb79af0458b8cce04e0d48213cbe13","unresolved":false,"context_lines":[{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"        if status:"},{"line_number":1289,"context_line":"            raise exception.InvalidInstanceState(instance_id\u003dself.id,"},{"line_number":1290,"context_line":"                                                 status_type\u003dstatus_type,"},{"line_number":1291,"context_line":"                                                 status\u003dstatus)"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"    def attach_configuration(self, configuration_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_0fab9bd6","line":1290,"updated":"2017-11-10 09:31:42.000000000","message":"It is better to raise different exception for each check. As it seems to me a bit weird to report *TASK* status in an error for invalid *INSTANCE* state.\n\nAnother approach may be to retain the type \u0027instance\u0027 while changing the reported status when task_status is not InstanceTasks.NONE to something like \"performing task \u003cTASK\u003e\". This way we can use only the InvalidInstanceState exception.\n\nIf we use different exceptions here, then I\u0027d suggest unit tests being added to assertRaises both exceptions.","commit_id":"60d195947eac425a6f8796b3f89056a1b47ccc88"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"bd5f9b4185a681486bc80ca5768a8124412f6522","unresolved":false,"context_lines":[{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"        if status:"},{"line_number":1289,"context_line":"            raise exception.InvalidInstanceState(instance_id\u003dself.id,"},{"line_number":1290,"context_line":"                                                 status_type\u003dstatus_type,"},{"line_number":1291,"context_line":"                                                 status\u003dstatus)"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"    def attach_configuration(self, configuration_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_4faf5394","line":1290,"updated":"2017-11-10 09:48:05.000000000","message":"Same comment as on patch set 1 here.","commit_id":"7deffc408053cbe38a199583fe34d788c43089a5"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"2ea5c43f80c24b79834127ef71e7a34247a25da1","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"        LOG.error(msg)"},{"line_number":1271,"context_line":"        raise exception.UnprocessableEntity(msg)"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"    def validate_can_perform_assign(self):"},{"line_number":1274,"context_line":"        \"\"\""},{"line_number":1275,"context_line":"        Raises exception if a configuration assign cannot"},{"line_number":1276,"context_line":"        currently be performed"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_e1ef3385","line":1273,"updated":"2017-11-10 13:30:26.000000000","message":"This change is not necessary.","commit_id":"1f75e14772f134571acd20acdfd45d434a7e4867"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"b3387c09a9e7d4b2481a58c5db21ea96ae527dae","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                                           \u0027status_type\u0027: status_type,"},{"line_number":1294,"context_line":"                                           \u0027action_status\u0027: status})"},{"line_number":1295,"context_line":"        LOG.error(msg)"},{"line_number":1296,"context_line":"        raise exception.UnprocessableEntity(msg)"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"    def attach_configuration(self, configuration_id):"},{"line_number":1299,"context_line":"        LOG.debug(\"Attaching configuration to instance: %s\", self.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f485f77_a3881b71","line":1296,"range":{"start_line":1296,"start_character":24,"end_line":1296,"end_character":43},"updated":"2017-11-10 18:29:10.000000000","message":"The test cases are failing with RESTART_REQUIRED in many of the buckets. It is likely that the change of exception here triggered it.","commit_id":"fbf720fc5a1e61383c19ea0d0659dd3ec4a8d0dc"}]}
