)]}'
{"trove/common/strategies/cluster/experimental/galera_common/taskmanager.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"438734c983de629cc5941cfaf56d5f06feaf9de9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                # password in the my.cnf will be wrong after the joiner"},{"line_number":108,"context_line":"                # instances syncs with the donor instance."},{"line_number":109,"context_line":"                admin_password \u003d str(utils.generate_random_password())"},{"line_number":110,"context_line":"                for guest in instance_guests:"},{"line_number":111,"context_line":"                    guest.reset_admin_password(admin_password)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"                bootstrap \u003d True"},{"line_number":114,"context_line":"                for instance in instances:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_77d21237","line":111,"range":{"start_line":110,"start_character":16,"end_line":111,"end_character":62},"updated":"2017-11-20 09:17:41.000000000","message":"Maybe you also needs to remove this.","commit_id":"b102593f5a2d38e2a0f9b5358244c6f352696538"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"ea80c7fbdd774d9205c99daf6308b300b0f229db","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"                bootstrap \u003d True"},{"line_number":115,"context_line":"                for instance in instances:"},{"line_number":116,"context_line":"                    guest \u003d self.get_guest(instance)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"                    # render the conf.d/cluster.cnf configuration"},{"line_number":119,"context_line":"                    cluster_configuration \u003d self._render_cluster_config("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_66d7adc1","side":"PARENT","line":116,"range":{"start_line":116,"start_character":51,"end_line":116,"end_character":52},"updated":"2017-11-21 01:24:19.000000000","message":"hi, about the change I have some different thought. \nAgree with you that call self.get_guest from twice to once will get a performance improvement, but I think the origin code is more readable, it treat cluster as a whole, like \"reset_admin_password for the cluster\", \"reder_config for the cluster\", complete for the cluster\".\n\nMaybe we could retain the three for block and use a way that just call self.get_guest() once.","commit_id":"5f458ffc38a2faeb2e0c7eafe38deec167965f83"},{"author":{"_account_id":17812,"name":"chengyang","email":"374519141@qq.com","username":"chengyang"},"change_message_id":"3c190274026729d6f7d159d5449ac5463a2998f2","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"                bootstrap \u003d True"},{"line_number":115,"context_line":"                for instance in instances:"},{"line_number":116,"context_line":"                    guest \u003d self.get_guest(instance)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"                    # render the conf.d/cluster.cnf configuration"},{"line_number":119,"context_line":"                    cluster_configuration \u003d self._render_cluster_config("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_418853c5","side":"PARENT","line":116,"range":{"start_line":116,"start_character":51,"end_line":116,"end_character":52},"in_reply_to":"ff82abbf_66d7adc1","updated":"2017-11-21 02:23:00.000000000","message":"Hi zhanggang, thanks for review.In the original code,reset all instance\u0027s admin password then execute install_cluster function,  but I think there is no need to reset all instance\u0027s passwod first before traverse instance to install_cluster if any instance execute install_cluster failed","commit_id":"5f458ffc38a2faeb2e0c7eafe38deec167965f83"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"96b15f99b27d93a39806129d5a1373ea98f2272b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                    bootstrap \u003d False"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"                LOG.debug(\"Finalizing cluster configuration.\")"},{"line_number":131,"context_line":"                for guest in instance_guests:"},{"line_number":132,"context_line":"                    guest.cluster_complete()"},{"line_number":133,"context_line":"            except Exception:"},{"line_number":134,"context_line":"                LOG.exception(_(\"Error creating cluster.\"))"},{"line_number":135,"context_line":"                self.update_statuses_on_failure(cluster_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_d8fc6a40","line":132,"range":{"start_line":131,"start_character":16,"end_line":132,"end_character":44},"updated":"2017-11-20 13:51:45.000000000","message":"It seems we can also combine this to above.Not sure about this.","commit_id":"022aa317b509fa8228133d6d2a5d1ed308037133"},{"author":{"_account_id":17812,"name":"chengyang","email":"374519141@qq.com","username":"chengyang"},"change_message_id":"b490ac2db06345b568b0bc35317f5baf7aedb401","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                    bootstrap \u003d False"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"                LOG.debug(\"Finalizing cluster configuration.\")"},{"line_number":131,"context_line":"                for guest in instance_guests:"},{"line_number":132,"context_line":"                    guest.cluster_complete()"},{"line_number":133,"context_line":"            except Exception:"},{"line_number":134,"context_line":"                LOG.exception(_(\"Error creating cluster.\"))"},{"line_number":135,"context_line":"                self.update_statuses_on_failure(cluster_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_e11887d4","line":132,"range":{"start_line":131,"start_character":16,"end_line":132,"end_character":44},"in_reply_to":"ff82abbf_d8fc6a40","updated":"2017-11-21 02:12:05.000000000","message":"Hi Yao Wang, I think intention of author is set status to complete \n until all instance complete code above .If combine this to above,  it maybe happen  a instance failed to instance_cluster or reset_admin_password  but  all instance before already set to complete","commit_id":"022aa317b509fa8228133d6d2a5d1ed308037133"}]}