)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"14530db0b0ff3c7c617f52b752f96026a410aeaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df87a7cf_3ab8cc28","updated":"2017-12-04 12:09:37.000000000","message":"Could you add \"Closes-Bug: #1662300\"?","commit_id":"d50042baf7e29cd08d0bf5899888c27bfd5d73bd"}],"trove/common/cfg.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"0ad480c5052ea325c1454840bd5f2174d4f4f8a3","unresolved":false,"context_lines":[{"line_number":371,"context_line":"               help\u003d\"Admin tenant name used to connect to Nova.\", secret\u003dTrue),"},{"line_number":372,"context_line":"    cfg.StrOpt(\u0027nova_proxy_admin_user_domain_name\u0027, default\u003d\u0027Default\u0027,"},{"line_number":373,"context_line":"               help\u003d\"User domain of the admin user used to connect to Nova.\"),"},{"line_number":374,"context_line":"    cfg.StrOpt(\u0027nova_proxy_admin_project_domain_name\u0027, default\u003d\u0027Default\u0027,"},{"line_number":375,"context_line":"               help\u003d\"Project domain of the admin user used to connect to \""},{"line_number":376,"context_line":"                    \"Nova.\"),"},{"line_number":377,"context_line":"    cfg.StrOpt(\u0027network_label_regex\u0027, default\u003d\u0027^private$\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_396f6793","line":374,"updated":"2017-12-05 02:09:16.000000000","message":"I would mark it secret. also, do we really need a new one?","commit_id":"c68562bcaeb386b17fa2924dfadb3018ca6b7b30"},{"author":{"_account_id":18418,"name":"Andy Botting","email":"andy@andybotting.com","username":"andybotting"},"change_message_id":"a119b1daa119ceb210141f8f2ff0b3d679864799","unresolved":false,"context_lines":[{"line_number":371,"context_line":"               help\u003d\"Admin tenant name used to connect to Nova.\", secret\u003dTrue),"},{"line_number":372,"context_line":"    cfg.StrOpt(\u0027nova_proxy_admin_user_domain_name\u0027, default\u003d\u0027Default\u0027,"},{"line_number":373,"context_line":"               help\u003d\"User domain of the admin user used to connect to Nova.\"),"},{"line_number":374,"context_line":"    cfg.StrOpt(\u0027nova_proxy_admin_project_domain_name\u0027, default\u003d\u0027Default\u0027,"},{"line_number":375,"context_line":"               help\u003d\"Project domain of the admin user used to connect to \""},{"line_number":376,"context_line":"                    \"Nova.\"),"},{"line_number":377,"context_line":"    cfg.StrOpt(\u0027network_label_regex\u0027, default\u003d\u0027^private$\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_b9bff7ce","line":374,"in_reply_to":"df87a7cf_396f6793","updated":"2017-12-05 04:17:04.000000000","message":"I\u0027m actually surprised that the other nova_proxy_admin_* fields (except password) are marked as secret. What is the point? I can change this though if you want.\n\nWhen you say, do we really need another one, are you talking about another nova_proxy_admin_ config var? Keystone v3 needs the user/project domain, and we do actually have more than one domain at our site. I\u0027d say yes.","commit_id":"c68562bcaeb386b17fa2924dfadb3018ca6b7b30"}],"trove/common/single_tenant_remote.py":[{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"e2b41afc14027dfdada73e0e8043cac3b4d2f976","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    return ks_session"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def nova_client_trove_admin(context, region_name\u003dNone, compute_url\u003dNone):"},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":"    Returns a nova client object with the trove admin credentials"},{"line_number":76,"context_line":"    :param context: original context from user request"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_daaf6092","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":73},"updated":"2017-12-04 12:22:09.000000000","message":"Although this is not directly related to the purpose of this patch, should this function accept the same parameters with trove.common.remote.nova_client?\n\n    (context, region_name\u003dNone, password\u003dNone)","commit_id":"d50042baf7e29cd08d0bf5899888c27bfd5d73bd"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"e2b41afc14027dfdada73e0e8043cac3b4d2f976","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    return client"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def cinder_client_trove_admin(context\u003dNone):"},{"line_number":100,"context_line":"    \"\"\""},{"line_number":101,"context_line":"    Returns a cinder client object with the trove admin credentials"},{"line_number":102,"context_line":"    :param context: original context from user request"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_1a8f082b","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":44},"updated":"2017-12-04 12:22:09.000000000","message":"ditto\n\n    (context, region_name\u003dNone)","commit_id":"d50042baf7e29cd08d0bf5899888c27bfd5d73bd"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"e2b41afc14027dfdada73e0e8043cac3b4d2f976","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    return client"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def neutron_client_trove_admin(context\u003dNone):"},{"line_number":120,"context_line":"    \"\"\""},{"line_number":121,"context_line":"    Returns a neutron client object with the trove admin credentials"},{"line_number":122,"context_line":"    :param context: original context from user request"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_da88c020","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":45},"updated":"2017-12-04 12:22:09.000000000","message":"ditto\n\n    (context, region_name\u003dNone)","commit_id":"d50042baf7e29cd08d0bf5899888c27bfd5d73bd"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"f461b9ffeed61f128940cdb94ca21b4e5db89b87","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        project_domain_name\u003dCONF.nova_proxy_admin_project_domain_name,"},{"line_number":67,"context_line":"        auth_url\u003dCONF.trove_auth_url)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    ks_session \u003d session.Session(auth\u003dauth)"},{"line_number":70,"context_line":"    return ks_session"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_83f08392","line":69,"updated":"2017-12-04 23:40:45.000000000","message":"It\u0027s probably worth making the session global.\ne.g.\nhttps://github.com/openstack/nova/blob/8e1100f641e0abdf4889129bab986afa25ca35de/nova/api/metadata/vendordata_dynamic.py#L43","commit_id":"54a442eca73c987f392c7855bdbb8718b5d4f3fe"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"69db6dffd2e5a315c8ca0034128a329148a0c18b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    :rtype: novaclient.client.Client"},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    compute_url \u003d compute_url or CONF.nova_compute_url"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    ks_session \u003d get_keystone_session()"},{"line_number":91,"context_line":"    client \u003d NovaClient("}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_de82e2c8","line":88,"updated":"2017-12-05 00:44:12.000000000","message":"compute_url is no longer set, this line should be removed.","commit_id":"7c6393e2b73a5e01bff02cf7e333c80f61765c73"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"69db6dffd2e5a315c8ca0034128a329148a0c18b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    if compute_url and CONF.nova_proxy_admin_tenant_id:"},{"line_number":99,"context_line":"        client.client.endpoint_override \u003d \"%s/%s/\" % ("},{"line_number":100,"context_line":"            normalize_url(compute_url),"},{"line_number":101,"context_line":"            CONF.nova_proxy_admin_tenant_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    return client"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_be691e26","line":100,"updated":"2017-12-05 00:44:12.000000000","message":"compute_url should be changed to CONF.nova_compute_url","commit_id":"7c6393e2b73a5e01bff02cf7e333c80f61765c73"}]}