)]}'
{"integration/scripts/files/elements/ubuntu-xenial-mysql/install.d/30-mysql":[{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"0368a3a4ffea5cc29c736c78bf3b3af9782b790c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"_EOF_"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"if [ -e /etc/init/mysql.conf ]; then"},{"line_number":60,"context_line":"    rm -f /etc/init/mysql.conf"},{"line_number":61,"context_line":"fi"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"systemctl enable mysql"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"df87a7cf_5e209f48","line":60,"updated":"2017-12-08 16:30:21.000000000","message":"Should we save the existing /etc/init/mysql.conf, in case the user would like to refer to it?","commit_id":"2e9ef16ce481ce11c5d6a5e766c5036583d14a5e"},{"author":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"change_message_id":"d612fca02aa3bd491aa78ecf4378338ce9a36be1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"_EOF_"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"if [ -e /etc/init/mysql.conf ]; then"},{"line_number":60,"context_line":"    rm -f /etc/init/mysql.conf"},{"line_number":61,"context_line":"fi"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"systemctl enable mysql"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"df87a7cf_c19cd0c1","line":60,"in_reply_to":"df87a7cf_5e209f48","updated":"2017-12-08 17:00:52.000000000","message":"It was removed in the previous version also.  I just added a qualification that it had to be present to be removed.  I saw an error statement that it didn\u0027t exist on Xenial.","commit_id":"2e9ef16ce481ce11c5d6a5e766c5036583d14a5e"}],"integration/scripts/trovestack":[{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"0368a3a4ffea5cc29c736c78bf3b3af9782b790c","unresolved":false,"context_lines":[{"line_number":535,"context_line":"function set_mysql_pkg() {"},{"line_number":536,"context_line":"    if is_fedora; then"},{"line_number":537,"context_line":"       MYSQL_PKG\u003d\"mysql-community-server\""},{"line_number":538,"context_line":"       MYSQL_VER\u003d\"5.6\""},{"line_number":539,"context_line":"    else"},{"line_number":540,"context_line":"       if [ \"$RELEASE\" \u003d\u003d \"xenial\" ]; then"},{"line_number":541,"context_line":"           MYSQL_PKG\u003d\"mysql-server-5.7\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"df87a7cf_9eb867e5","line":538,"updated":"2017-12-08 16:30:21.000000000","message":"It looks like this change both adds support for Xenial and add supports for 5.7. I wonder whether it should have been split into two changes: 1) xenial 2) 5.7\n\nI am fine with it as it is.","commit_id":"2e9ef16ce481ce11c5d6a5e766c5036583d14a5e"},{"author":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"change_message_id":"f816ed572770e189cbf391b051b316ab02e9fbfe","unresolved":false,"context_lines":[{"line_number":535,"context_line":"function set_mysql_pkg() {"},{"line_number":536,"context_line":"    if is_fedora; then"},{"line_number":537,"context_line":"       MYSQL_PKG\u003d\"mysql-community-server\""},{"line_number":538,"context_line":"       MYSQL_VER\u003d\"5.6\""},{"line_number":539,"context_line":"    else"},{"line_number":540,"context_line":"       if [ \"$RELEASE\" \u003d\u003d \"xenial\" ]; then"},{"line_number":541,"context_line":"           MYSQL_PKG\u003d\"mysql-server-5.7\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"df87a7cf_a4075582","line":538,"in_reply_to":"df87a7cf_50a16893","updated":"2017-12-08 22:01:36.000000000","message":"Xenial does not provide mysql-server-5.6","commit_id":"2e9ef16ce481ce11c5d6a5e766c5036583d14a5e"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"78217cfec7f6c533c092fee97c70a862b06c9ae5","unresolved":false,"context_lines":[{"line_number":535,"context_line":"function set_mysql_pkg() {"},{"line_number":536,"context_line":"    if is_fedora; then"},{"line_number":537,"context_line":"       MYSQL_PKG\u003d\"mysql-community-server\""},{"line_number":538,"context_line":"       MYSQL_VER\u003d\"5.6\""},{"line_number":539,"context_line":"    else"},{"line_number":540,"context_line":"       if [ \"$RELEASE\" \u003d\u003d \"xenial\" ]; then"},{"line_number":541,"context_line":"           MYSQL_PKG\u003d\"mysql-server-5.7\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"df87a7cf_50a16893","line":538,"in_reply_to":"df87a7cf_8125685e","updated":"2017-12-08 21:06:13.000000000","message":"How about mysql 5.6 on Xenial?","commit_id":"2e9ef16ce481ce11c5d6a5e766c5036583d14a5e"},{"author":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"change_message_id":"d612fca02aa3bd491aa78ecf4378338ce9a36be1","unresolved":false,"context_lines":[{"line_number":535,"context_line":"function set_mysql_pkg() {"},{"line_number":536,"context_line":"    if is_fedora; then"},{"line_number":537,"context_line":"       MYSQL_PKG\u003d\"mysql-community-server\""},{"line_number":538,"context_line":"       MYSQL_VER\u003d\"5.6\""},{"line_number":539,"context_line":"    else"},{"line_number":540,"context_line":"       if [ \"$RELEASE\" \u003d\u003d \"xenial\" ]; then"},{"line_number":541,"context_line":"           MYSQL_PKG\u003d\"mysql-server-5.7\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"df87a7cf_8125685e","line":538,"in_reply_to":"df87a7cf_9eb867e5","updated":"2017-12-08 17:00:52.000000000","message":"Xenial provides mysql 5.7 so it has to be specified if xenial is the target.  They are indivisible.  They go with each other.  mysql 5.7 can\u0027t go with Trusty.","commit_id":"2e9ef16ce481ce11c5d6a5e766c5036583d14a5e"}],"trove/guestagent/strategies/restore/mysql_impl.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"989085821041f104cec75dfada4deaa2b234851e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            raise exc"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _start_mysqld_safe_with_init_file(self, init_file, err_log_file):"},{"line_number":76,"context_line":"        # This directory is added and removed by the mysql systemd service"},{"line_number":77,"context_line":"        # as the database is started and stopped. The restore operation"},{"line_number":78,"context_line":"        # takes place when the database is stopped, so the directory does"},{"line_number":79,"context_line":"        # not exist, but it is assumed to exist by the mysqld_safe command"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_abb15049","line":76,"updated":"2017-12-10 23:37:46.000000000","message":"this change implicitly ties the strategy to 5.7, the dependency is buried and someone wanting to use trusty/5.6 is now SOL.","commit_id":"07761294792124a3a709bdcfcdb3d05e8751f1ba"},{"author":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"change_message_id":"bef0774d4ecdbb8dd02d6a3cf5f783b6847f6b98","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            raise exc"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _start_mysqld_safe_with_init_file(self, init_file, err_log_file):"},{"line_number":76,"context_line":"        # This directory is added and removed by the mysql systemd service"},{"line_number":77,"context_line":"        # as the database is started and stopped. The restore operation"},{"line_number":78,"context_line":"        # takes place when the database is stopped, so the directory does"},{"line_number":79,"context_line":"        # not exist, but it is assumed to exist by the mysqld_safe command"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_cbcdb485","line":76,"in_reply_to":"df87a7cf_abb15049","updated":"2017-12-11 00:24:45.000000000","message":"The inverse is also true.  With the pre-existing code, one could use 5.6/Trusty or nothing.  No option to use 5.7.","commit_id":"07761294792124a3a709bdcfcdb3d05e8751f1ba"},{"author":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"change_message_id":"00954d37bb84520879a07e7a1048229e71bb5b81","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            raise exc"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _start_mysqld_safe_with_init_file(self, init_file, err_log_file):"},{"line_number":76,"context_line":"        # This directory is added and removed by the mysql systemd service"},{"line_number":77,"context_line":"        # as the database is started and stopped. The restore operation"},{"line_number":78,"context_line":"        # takes place when the database is stopped, so the directory does"},{"line_number":79,"context_line":"        # not exist, but it is assumed to exist by the mysqld_safe command"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_bc80b8f6","line":76,"in_reply_to":"df87a7cf_cbcdb485","updated":"2017-12-11 05:44:26.000000000","message":"I think I misunderstood your comment.  The code supports 5.6 on Trusty and 5.7 on Xenial, so Trusty users are not impacted.  The only thing that is fixed to 5.7 is the integration and gate tests which run on Xenial.  They have to be fixed to something as the version is not abstracted in the test code.","commit_id":"07761294792124a3a709bdcfcdb3d05e8751f1ba"}]}