)]}'
{"trove/guestagent/datastore/service.py":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"41d17722c24af80d0adda203b4558932293b7203","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"Find and report status of DB on this machine."},{"line_number":180,"context_line":"        The database is updated and the status is also returned."},{"line_number":181,"context_line":"        \"\"\""},{"line_number":182,"context_line":"        status_keep \u003d [instance.ServiceStatuses.RESTART_REQUIRED]"},{"line_number":183,"context_line":"        if self.is_installed and not self._is_restarting and \\"},{"line_number":184,"context_line":"                self.status not in status_keep:"},{"line_number":185,"context_line":"            LOG.debug(\"Determining status of DB server.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_68e68c19","line":182,"range":{"start_line":182,"start_character":64,"end_line":182,"end_character":65},"updated":"2017-12-22 06:43:22.000000000","message":"a suggest that put this logic into a private method like `_is_restart_required` and use `if xxx and xxx and not _is_restart_required seems better.","commit_id":"71ec6dbfa63411a71aca3291049ae5bbe108efea"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"10aac4a15cad4f10eae146ebd800875b1014a778","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"Find and report status of DB on this machine."},{"line_number":180,"context_line":"        The database is updated and the status is also returned."},{"line_number":181,"context_line":"        \"\"\""},{"line_number":182,"context_line":"        status_keep \u003d [instance.ServiceStatuses.RESTART_REQUIRED]"},{"line_number":183,"context_line":"        if self.is_installed and not self._is_restarting and \\"},{"line_number":184,"context_line":"                self.status not in status_keep:"},{"line_number":185,"context_line":"            LOG.debug(\"Determining status of DB server.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_0d724fe4","line":182,"range":{"start_line":182,"start_character":64,"end_line":182,"end_character":65},"in_reply_to":"bf8cb3f7_68e68c19","updated":"2018-01-17 15:48:02.000000000","message":"+1","commit_id":"71ec6dbfa63411a71aca3291049ae5bbe108efea"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"fdf5c1a6d6410bf19c8063a53af7efccdabee70e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"Find and report status of DB on this machine."},{"line_number":180,"context_line":"        The database is updated and the status is also returned."},{"line_number":181,"context_line":"        \"\"\""},{"line_number":182,"context_line":"        status_keep \u003d [instance.ServiceStatuses.RESTART_REQUIRED]"},{"line_number":183,"context_line":"        if self.is_installed and not self._is_restarting and \\"},{"line_number":184,"context_line":"                self.status not in status_keep:"},{"line_number":185,"context_line":"            LOG.debug(\"Determining status of DB server.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_ba1384b8","line":182,"range":{"start_line":182,"start_character":64,"end_line":182,"end_character":65},"in_reply_to":"bf8cb3f7_68e68c19","updated":"2018-02-05 21:05:36.000000000","message":"+1. Could be great doing this.","commit_id":"71ec6dbfa63411a71aca3291049ae5bbe108efea"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"41d17722c24af80d0adda203b4558932293b7203","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            status \u003d self._get_actual_db_status()"},{"line_number":187,"context_line":"            self.set_status(status)"},{"line_number":188,"context_line":"        else:"},{"line_number":189,"context_line":"            LOG.info(_(\"DB server is not installed or is in restart mode, so \""},{"line_number":190,"context_line":"                       \"for now we\u0027ll skip determining the status of DB on \""},{"line_number":191,"context_line":"                       \"this instance.\"))"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_a8b574f0","line":189,"range":{"start_line":189,"start_character":77,"end_line":189,"end_character":78},"updated":"2017-12-22 06:43:22.000000000","message":"If you add another condition in \"if block\", you should change the log info too. So, maybe need more discuss about this change, watch for other\u0027s advise.","commit_id":"71ec6dbfa63411a71aca3291049ae5bbe108efea"}]}