)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"e838d685b97b754d85ae00a1f869bb8d0adfa9e9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Re-attach configuration after resize instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When I resize instance,I find it will call function \"save_configuration\" in guest_agent at last."},{"line_number":10,"context_line":"Save_configuration removes some configurations whitch were configured before."},{"line_number":11,"context_line":"Than, the replica doesn\u0027t work as before.This patch try to fix it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f96bb07_ec23f7a5","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":96},"updated":"2018-01-17 16:31:29.000000000","message":"Subsequent lines should be wrapped at 72 characters.\n[1]https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"f3cb763a7ac99b9449a7dc5ec2be440e48305901"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"ad5864dcbb587da3e1c198062b0f70786c2a91bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f81ecaf9_a99a064f","updated":"2024-10-08 02:17:49.000000000","message":"maybe duplicated with this patch: https://review.opendev.org/c/openstack/trove/+/926042","commit_id":"18f1864cbe5f634658d8dc1becf84f18ba1cfba1"}],"trove/taskmanager/models.py":[{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"e838d685b97b754d85ae00a1f869bb8d0adfa9e9","unresolved":false,"context_lines":[{"line_number":1829,"context_line":"            self._datastore_is_online,"},{"line_number":1830,"context_line":"            sleep_time\u003d2,"},{"line_number":1831,"context_line":"            time_out\u003dCONF.resize_time_out)"},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"        if self.instance.slave_of_id:"},{"line_number":1834,"context_line":"            master \u003d BuiltInstanceTasks.load(self.instance.context,"},{"line_number":1835,"context_line":"                                             self.instance.slave_of_id)"},{"line_number":1836,"context_line":"            self.instance.attach_replica(master)"},{"line_number":1837,"context_line":""},{"line_number":1838,"context_line":"        if self.instance.configuration:"},{"line_number":1839,"context_line":"            self.instance.apply_configuration(self.instance.configuration)"},{"line_number":1840,"context_line":""},{"line_number":1841,"context_line":"    def _assert_datastore_is_offline(self):"},{"line_number":1842,"context_line":"        # Tell the guest to turn off MySQL, and ensure the status becomes"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_cca39bff","line":1839,"range":{"start_line":1832,"start_character":0,"end_line":1839,"end_character":74},"updated":"2018-01-17 16:31:29.000000000","message":"The first feeling is not appropriate to add this here.\nWaiting for others comments.","commit_id":"f3cb763a7ac99b9449a7dc5ec2be440e48305901"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"aa8aa8b32f83ecceb1f9dc2358ba520a7d4239b8","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"            sleep_time\u003d2,"},{"line_number":1831,"context_line":"            time_out\u003dCONF.resize_time_out)"},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"        if self.instance.slave_of_id:"},{"line_number":1834,"context_line":"            master \u003d BuiltInstanceTasks.load(self.instance.context,"},{"line_number":1835,"context_line":"                                             self.instance.slave_of_id)"},{"line_number":1836,"context_line":"            self.instance.attach_replica(master)"},{"line_number":1837,"context_line":""},{"line_number":1838,"context_line":"        if self.instance.configuration:"},{"line_number":1839,"context_line":"            self.instance.apply_configuration(self.instance.configuration)"},{"line_number":1840,"context_line":""},{"line_number":1841,"context_line":"    def _assert_datastore_is_offline(self):"},{"line_number":1842,"context_line":"        # Tell the guest to turn off MySQL, and ensure the status becomes"}],"source_content_type":"text/x-python","patch_set":7,"id":"df7087c5_0ae90319","line":1839,"range":{"start_line":1833,"start_character":0,"end_line":1839,"end_character":74},"updated":"2018-03-08 10:13:56.000000000","message":"It looks like it\u0027s not the proper place here and complete solution for fixing this problem. During the lifecyle of a instance, many operations will apply overrides to the configuration(only enable as a slave and applying configuration are checked in the current patch, many other ops are not considerd, e.g. enable as a master, clusters, root enable/disable for Redis instances, etc).","commit_id":"3eca5b6459a1e3f5ac36fb6ac717c565fdd9589c"},{"author":{"_account_id":26472,"name":"wangjun","email":"wangjun@yovole.com","username":"j.wong"},"change_message_id":"89f66c6ca649e8d0d19064fc636f5bf2ce11b489","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"            sleep_time\u003d2,"},{"line_number":1831,"context_line":"            time_out\u003dCONF.resize_time_out)"},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"        if self.instance.slave_of_id:"},{"line_number":1834,"context_line":"            master \u003d BuiltInstanceTasks.load(self.instance.context,"},{"line_number":1835,"context_line":"                                             self.instance.slave_of_id)"},{"line_number":1836,"context_line":"            self.instance.attach_replica(master)"},{"line_number":1837,"context_line":""},{"line_number":1838,"context_line":"        if self.instance.configuration:"},{"line_number":1839,"context_line":"            self.instance.apply_configuration(self.instance.configuration)"},{"line_number":1840,"context_line":""},{"line_number":1841,"context_line":"    def _assert_datastore_is_offline(self):"},{"line_number":1842,"context_line":"        # Tell the guest to turn off MySQL, and ensure the status becomes"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_305f5c73","line":1839,"range":{"start_line":1833,"start_character":0,"end_line":1839,"end_character":74},"in_reply_to":"df7087c5_0ae90319","updated":"2018-04-10 02:02:02.000000000","message":"It happend in my enviroment when I resized flavor,I think it\u0027s the place to attach configuration after new datastore is applied","commit_id":"3eca5b6459a1e3f5ac36fb6ac717c565fdd9589c"}]}