)]}'
{"trove/guestagent/strategies/storage/swift.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"3fe4f448bd2dc634cf80fb4916da3be0c8808ec3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from trove.guestagent.strategies.storage import base"},{"line_number":20,"context_line":"from trove.openstack.common import log as logging"},{"line_number":21,"context_line":"from trove.common.remote import create_swift_client"},{"line_number":22,"context_line":"from trove.common import cfg, utils"},{"line_number":23,"context_line":"from eventlet.green import subprocess"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATX%2F%2F87I%3D","line":22,"updated":"2013-10-23 19:04:35.000000000","message":"split this into two separate import statements","commit_id":"09569d11cd580b4d23f7474c706216c30352f144"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c383368cd766c55a834e5432dcaf14b182dce876","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class SwiftDownloadIntegrityError(Exception):"},{"line_number":34,"context_line":"    \"\"\"Integrity error while running the Swift Download Command.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class SwiftStorage(base.Storage):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATX%2F%2F9%2BU%3D","line":34,"updated":"2013-10-23 14:46:25.000000000","message":"I suppose exceptions should be stored in common/exception or openstac/common/exceptions (first one is preferable)","commit_id":"09569d11cd580b4d23f7474c706216c30352f144"}],"trove/instance/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c383368cd766c55a834e5432dcaf14b182dce876","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                                                                location,"},{"line_number":469,"context_line":"                                                                checksum):"},{"line_number":470,"context_line":"                        raise exception.RestoreBackupIntegrityError("},{"line_number":471,"context_line":"                            backup_id\u003dbackup_id)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            db_info \u003d DBInstance.create(name\u003dname, flavor_id\u003dflavor_id,"},{"line_number":474,"context_line":"                                        tenant_id\u003dcontext.tenant,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATX%2F%2F988%3D","line":471,"updated":"2013-10-23 14:46:25.000000000","message":"It should be moved into taskmanager.","commit_id":"09569d11cd580b4d23f7474c706216c30352f144"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e0948283971358083a0c3103556a2395c69c28c6","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                                                                location,"},{"line_number":469,"context_line":"                                                                checksum):"},{"line_number":470,"context_line":"                        raise exception.RestoreBackupIntegrityError("},{"line_number":471,"context_line":"                            backup_id\u003dbackup_id)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            db_info \u003d DBInstance.create(name\u003dname, flavor_id\u003dflavor_id,"},{"line_number":474,"context_line":"                                        tenant_id\u003dcontext.tenant,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATX%2F%2F80Y%3D","line":471,"in_reply_to":"AAAATX%2F%2F83c%3D","updated":"2013-10-23 19:17:16.000000000","message":"I agree, but we already discussed this problem, when raise called quota being rolled back, it means that instance should be deleted automaticaly, but if this code would be moved into taskmanager/models.py it  could raise without any harm to qouta.\n\nSmall point: every provisioning/deleting/resizing call in instance/models.py are being ran with qoutas, that is why we moven security group prov. to taskmanager, that is why this validation should be moved there too.","commit_id":"09569d11cd580b4d23f7474c706216c30352f144"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"3fe4f448bd2dc634cf80fb4916da3be0c8808ec3","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                                                                location,"},{"line_number":469,"context_line":"                                                                checksum):"},{"line_number":470,"context_line":"                        raise exception.RestoreBackupIntegrityError("},{"line_number":471,"context_line":"                            backup_id\u003dbackup_id)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            db_info \u003d DBInstance.create(name\u003dname, flavor_id\u003dflavor_id,"},{"line_number":474,"context_line":"                                        tenant_id\u003dcontext.tenant,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATX%2F%2F83c%3D","line":471,"in_reply_to":"AAAATX%2F%2F988%3D","updated":"2013-10-23 19:04:35.000000000","message":"Denis technically this is in taskmanager, as the Fresh instance is a subclass of this. It call _create_resources(). It is a little weird to follow. The whole models mess needs to be refactored and  I think that should be done in a different review.","commit_id":"09569d11cd580b4d23f7474c706216c30352f144"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c383368cd766c55a834e5432dcaf14b182dce876","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                                                                checksum):"},{"line_number":470,"context_line":"                        raise exception.RestoreBackupIntegrityError("},{"line_number":471,"context_line":"                            backup_id\u003dbackup_id)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            db_info \u003d DBInstance.create(name\u003dname, flavor_id\u003dflavor_id,"},{"line_number":474,"context_line":"                                        tenant_id\u003dcontext.tenant,"},{"line_number":475,"context_line":"                                        volume_size\u003dvolume_size,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATX%2F%2F98Y%3D","line":472,"updated":"2013-10-23 14:46:25.000000000","message":"And if you are rising error you would get quota rollback without reporting statuses.","commit_id":"09569d11cd580b4d23f7474c706216c30352f144"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8836ed1797eec5993ec182a7ec618f84419e0b86","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                if not backup_info.check_swift_object_exist(context,"},{"line_number":460,"context_line":"                        verify_checksum\u003dCONF.verify_swift_checksum_on_restore):"},{"line_number":461,"context_line":"                    raise exception.BackupFileNotFound("},{"line_number":462,"context_line":"                        location\u003dbackup_info.location)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"            db_info \u003d DBInstance.create(name\u003dname, flavor_id\u003dflavor_id,"},{"line_number":465,"context_line":"                                        tenant_id\u003dcontext.tenant,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F5AM%3D","line":462,"updated":"2013-10-25 16:18:48.000000000","message":"still pointing on qouta issues caused by current raise","commit_id":"a09bf4efbcd4cc5ba9439d496a353c6e6b3a63e7"}]}
