)]}'
{"integration/scripts/files/elements/ubuntu-postgresql/install.d/30-postgresql":[{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"92aaedbf7e8224514b2d03b34ffb4fe96931f856","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# but the Python interpreter may require it on smaller flavors."},{"line_number":13,"context_line":"# We therefore stick with the heuristic overcommit setting."},{"line_number":14,"context_line":"vm.overcommit_memory\u003d0"},{"line_number":15,"context_line":"vm.nr_hugepages\u003d64"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"_EOF_"},{"line_number":18,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f96bb07_7b531b3a","line":15,"updated":"2018-01-17 19:59:15.000000000","message":"This setting of nr_hugepages did not work on the Power architecture. So we had to comment this line out.","commit_id":"180fcf283c148377ee11855368961571c5ad4ab3"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"844bcb3d988b296053bb302229f35f2df9ccd44e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_EOF_"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"apt-get --allow-unauthenticated -y install postgresql-9.6 postgresql-contrib-9.6 postgresql-server-dev-9.6"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The script will create a postgresql-9.6 image for user to use."},{"line_number":38,"context_line":"# From Postgresql \u003e9.4, pg_rewind is in the main source tree. But, the default location is"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_f842a73d","line":35,"updated":"2018-01-18 18:58:20.000000000","message":"The gate tests indicate that these packages cannot be found for Xenial:\n\n2018-01-18 08:27:09.706 | 2018-01-18 08:27:09.704 | E: Unable to locate package postgresql-9.6\n2018-01-18 08:27:09.707 | 2018-01-18 08:27:09.704 | E: Couldn\u0027t find any package by glob \u0027postgresql-9.6\u0027\n2018-01-18 08:27:09.709 | 2018-01-18 08:27:09.704 | E: Couldn\u0027t find any package by regex \u0027postgresql-9.6\u0027","commit_id":"3ee08ed31f76998a323cb0dc319221b86e8059e2"},{"author":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"change_message_id":"19e7cf717c3581cf71472b897668edea0c71813c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_EOF_"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"apt-get --allow-unauthenticated -y install postgresql-9.6 postgresql-contrib-9.6 postgresql-server-dev-9.6"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The script will create a postgresql-9.6 image for user to use."},{"line_number":38,"context_line":"# From Postgresql \u003e9.4, pg_rewind is in the main source tree. But, the default location is"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_4e30a69f","line":35,"in_reply_to":"7f96bb07_f842a73d","updated":"2018-01-19 04:45:40.000000000","message":"This should be OK.  Manoj and I reviewed this together and it  looked like a temporary network problem.","commit_id":"3ee08ed31f76998a323cb0dc319221b86e8059e2"},{"author":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"change_message_id":"469be8c47b6f7b2562afe280bc72013586fa4d72","unresolved":false,"context_lines":[{"line_number":33,"context_line":"_EOF_"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"apt-get --allow-unauthenticated -y install postgresql-9.6 postgresql-contrib-9.6 postgresql-server-dev-9.6"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The script will create a postgresql-9.6 image for user to use."},{"line_number":38,"context_line":"# From Postgresql \u003e9.4, pg_rewind is in the main source tree. But, the default location is"},{"line_number":39,"context_line":"# /usr/lib/postgresql/\u003cversion\u003e/bin/pg_rewind. So, there need create a symlink from that"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_2e42fa0f","line":36,"updated":"2018-01-19 04:42:30.000000000","message":"I added this line here and was able to create an instance:\n\nsed -i \"s/external_pid_file \u003d.*/external_pid_file \u003d \u0027\\/var\\/run\\/postgresql\\/postgresql.pid\u0027/\"  /etc/postgresql/9.6/main/postgresql.conf\n\nThere were other errors though.  Here\u0027s a couple of scripts that I wrote recently to perform integration and gate testing in a test vm.  You may find them useful.\n\nhttps://github.com/lukebrowning/tools/tree/master/trove","commit_id":"3ee08ed31f76998a323cb0dc319221b86e8059e2"}],"trove/guestagent/datastore/experimental/postgresql/service.py":[{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"92aaedbf7e8224514b2d03b34ffb4fe96931f856","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            \u0027wal_keep_segments\u0027: 8,"},{"line_number":291,"context_line":"            \u0027archive_command\u0027: arch_cmd"},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"        if self.pg_version[1] in (\u00279.4\u0027):"},{"line_number":294,"context_line":"            opts[\u0027checkpoint_segments\u0027] \u003d 8"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        self.configuration_manager.apply_system_override("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_3b2033ac","line":293,"updated":"2018-01-17 19:59:15.000000000","message":"This change implies, that we can support 9.4 as well.","commit_id":"180fcf283c148377ee11855368961571c5ad4ab3"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"2f27b2e06ca48be22e81ac1c672610441bda4c1d","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            \u0027wal_keep_segments\u0027: 8,"},{"line_number":291,"context_line":"            \u0027archive_command\u0027: arch_cmd"},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"        if self.pg_version[1] in (\u00279.4\u0027):"},{"line_number":294,"context_line":"            opts[\u0027checkpoint_segments\u0027] \u003d 8"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        self.configuration_manager.apply_system_override("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_d4331613","line":293,"in_reply_to":"7f96bb07_3b2033ac","updated":"2018-01-18 02:29:16.000000000","message":"My original idea is no longer support \u003c9.4, but still support 9.6, 9.5, 9.4. \nNow, since we have an consensus on meeting that doesn\u0027t support \"too old\" version, this line will be removed.","commit_id":"180fcf283c148377ee11855368961571c5ad4ab3"},{"author":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"change_message_id":"804a6a3d8ba1be428ffc61fac10c7adc97716aa3","unresolved":false,"context_lines":[{"line_number":594,"context_line":"    # Default set of options of an administrative account."},{"line_number":595,"context_line":"    ADMIN_OPTIONS \u003d ("},{"line_number":596,"context_line":"        \u0027SUPERUSER\u0027, \u0027CREATEDB\u0027, \u0027CREATEROLE\u0027, \u0027INHERIT\u0027, \u0027REPLICATION\u0027,"},{"line_number":597,"context_line":"        \u0027LOGIN\u0027"},{"line_number":598,"context_line":"    )"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def __init__(self, user):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_ae412aa8","line":597,"range":{"start_line":597,"start_character":9,"end_line":597,"end_character":15},"updated":"2018-01-19 05:19:33.000000000","message":"You need to add \u0027BYPASSRLS\u0027","commit_id":"3ee08ed31f76998a323cb0dc319221b86e8059e2"}],"trove/guestagent/strategies/replication/experimental/postgresql_impl.py":[{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"92aaedbf7e8224514b2d03b34ffb4fe96931f856","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        # wal_log_hints for pg_rewind is only supported in 9.4+,"},{"line_number":287,"context_line":"        # and trove doesn\u0027t support version\u003c9.4 any more."},{"line_number":288,"context_line":"        opts \u003d {\u0027hot_standby\u0027: \u0027on\u0027,"},{"line_number":289,"context_line":"                \u0027wal_level\u0027: \u0027hot_standby\u0027,"},{"line_number":290,"context_line":"                \u0027wal_log_hints\u0027: \u0027on\u0027}"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        service.configuration_manager.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_bb7443d0","line":289,"updated":"2018-01-17 19:59:15.000000000","message":"In our testing, wal_level had to be set to \u0027replica\u0027 for 9.6.  Apparently \u0027replica\u0027 implies \u0027hot_standby\u0027.","commit_id":"180fcf283c148377ee11855368961571c5ad4ab3"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"2f27b2e06ca48be22e81ac1c672610441bda4c1d","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        # wal_log_hints for pg_rewind is only supported in 9.4+,"},{"line_number":287,"context_line":"        # and trove doesn\u0027t support version\u003c9.4 any more."},{"line_number":288,"context_line":"        opts \u003d {\u0027hot_standby\u0027: \u0027on\u0027,"},{"line_number":289,"context_line":"                \u0027wal_level\u0027: \u0027hot_standby\u0027,"},{"line_number":290,"context_line":"                \u0027wal_log_hints\u0027: \u0027on\u0027}"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        service.configuration_manager.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_b7852c09","line":289,"in_reply_to":"7f96bb07_bb7443d0","updated":"2018-01-18 02:29:16.000000000","message":"According the doc https://www.postgresql.org/docs/9.6/static/runtime-config-wal.html\n\"In releases prior to 9.6, this parameter also allowed the values archive and hot_standby. These are still accepted but mapped to replica.\"\n\u0027host_standby\u0027 is still accepted, but \u0027replica\u0027 is not support in 9.5. \nSince now we only support 9.6, I think this can be change to replica safely","commit_id":"180fcf283c148377ee11855368961571c5ad4ab3"}]}
