)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"0862f868c6b4a7e35a276d04b292f503fe80a03a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ShangXiao \u003cshangxiaobj@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-23 03:34:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Put instructions for the response codes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Put instructions for the http return codes which can be better understanding."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_043b0cc8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":16},"updated":"2018-01-23 03:58:37.000000000","message":"This is not clear, What this patch does is adding fault names to the error response codes.","commit_id":"e203a2974120454e62281cb841d972a115d2cfb5"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"cb9d13621ed87812bdf4b92dcad2db1f9c60eae1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ShangXiao \u003cshangxiaobj@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-24 01:25:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add fault names for the error response codes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add fault names for the http error response codes"},{"line_number":10,"context_line":"which can be better understanding."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f96bb07_f7755099","line":7,"updated":"2018-01-24 02:08:45.000000000","message":"Would be better to add \"[api-ref] \" as a prefix.","commit_id":"3d161ab475c473d9c40289f43aad317d2e80d71c"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"cb9d13621ed87812bdf4b92dcad2db1f9c60eae1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add fault names for the error response codes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add fault names for the http error response codes"},{"line_number":10,"context_line":"which can be better understanding."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5970cb6d40cf5793f024fd5d46b0da8f24bee0d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f96bb07_b7f26805","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":49},"updated":"2018-01-24 02:08:45.000000000","message":"It\u0027s not neccessary to repeat the summary line. It may be better like:\n\"Error response codes with fault names will be easier for understanding.\" ?","commit_id":"3d161ab475c473d9c40289f43aad317d2e80d71c"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"f418c13b246a83c9bd5222fb6a3792faa2e2bc60","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ShangXiao \u003cshangxiaobj@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-24 02:42:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[api-ref]Add fault names for the error response codes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Error response codes with fault names will be easier for understanding."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f96bb07_83103c50","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":9},"updated":"2018-01-24 12:42:40.000000000","message":"It\u0027s better to add a blank space after the \u0027]\u0027.","commit_id":"23b1f2ac5e5e34b9240228ed88aa48bf1dca6b69"}],"api-ref/source/api-versions.inc":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"0862f868c6b4a7e35a276d04b292f503fe80a03a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"},{"line_number":20,"context_line":"Error response codes: Bad Request(400), Unauthorized(401), Forbidden(403), Not Found(404), Method Not Allowed(405),"},{"line_number":21,"context_line":"                      Request Entity Too Large(413), Unprocessable Entity(422), Internal Server Error(500),"},{"line_number":22,"context_line":"                      Not Implemented(501), Service Unavailable(503)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7f96bb07_a449f860","line":22,"range":{"start_line":20,"start_character":22,"end_line":22,"end_character":68},"updated":"2018-01-23 03:58:37.000000000","message":"Theses fault names are not correct, please referring to https://github.com/openstack/trove/blob/master/trove/common/wsgi.py#L468 to get the correct names.\n\nAnd I think it would be good to do corrections to these response codes in this commit too. The api reference looks like  not been well maintained for a while, so we may need to check all api responses, make sure the listed response codes whether returned by the api.\n\nFor example, for the versions api, it should always return a 200 response, other error responses should not be intended, so we may not include those error response codes this reference page.","commit_id":"e203a2974120454e62281cb841d972a115d2cfb5"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"d3a618db8b5f960302d2c3082f9e74a5f77287e2","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"},{"line_number":20,"context_line":"Error response codes: Bad Request(400), Unauthorized(401), Forbidden(403), Not Found(404), Method Not Allowed(405),"},{"line_number":21,"context_line":"                      Request Entity Too Large(413), Unprocessable Entity(422), Internal Server Error(500),"},{"line_number":22,"context_line":"                      Not Implemented(501), Service Unavailable(503)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7f96bb07_18f28f07","line":22,"range":{"start_line":20,"start_character":22,"end_line":22,"end_character":68},"in_reply_to":"7f96bb07_a449f860","updated":"2018-01-23 07:20:02.000000000","message":"\u003e Theses fault names are not correct, please referring to\n \u003e https://github.com/openstack/trove/blob/master/trove/common/wsgi.py#L468\n \u003e to get the correct names.\n \u003e \n \u003e And I think it would be good to do corrections to these response\n \u003e codes in this commit too. The api reference looks like  not been\n \u003e well maintained for a while, so we may need to check all api\n \u003e responses, make sure the listed response codes whether returned by\n \u003e the api.\n \u003e \n \u003e For example, for the versions api, it should always return a 200\n \u003e response, other error responses should not be intended, so we may\n \u003e not include those error response codes this reference page.\n\nAgree, something like badRequest(400) would be fine.","commit_id":"e203a2974120454e62281cb841d972a115d2cfb5"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"cb9d13621ed87812bdf4b92dcad2db1f9c60eae1","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"},{"line_number":20,"context_line":"Error response codes: badRequest(400),unauthorized(401),forbidden(403),itemNotFound(404)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"7f96bb07_d785b4d0","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":88},"updated":"2018-01-24 02:08:45.000000000","message":"Is there any reason these error responses should be kept while the others removed?","commit_id":"3d161ab475c473d9c40289f43aad317d2e80d71c"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"cb9d13621ed87812bdf4b92dcad2db1f9c60eae1","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Normal response codes: 200"},{"line_number":53,"context_line":"Error response codes: badRequest(400),unauthorized(401),forbidden(403),itemNotFound(404)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"7f96bb07_97672c52","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":88},"updated":"2018-01-24 02:08:45.000000000","message":"same here.","commit_id":"3d161ab475c473d9c40289f43aad317d2e80d71c"}],"api-ref/source/configurations.inc":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"0862f868c6b4a7e35a276d04b292f503fe80a03a","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Deletes a configuration group."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Error response codes: Accepted(202), Bad Request(400), Unauthorized(401), Forbidden(403), Not Found(404),"},{"line_number":161,"context_line":"                      Method Not Allowed(405), Request Entity Too Large(413), Unprocessable Entity(422),"},{"line_number":162,"context_line":"                      Internal Server Error(500), Not Implemented(501), Service Unavailable(503)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7f96bb07_64753098","line":160,"range":{"start_line":160,"start_character":22,"end_line":160,"end_character":37},"updated":"2018-01-23 03:58:37.000000000","message":"? 202 should not be considers as an error response.","commit_id":"e203a2974120454e62281cb841d972a115d2cfb5"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"cb9d13621ed87812bdf4b92dcad2db1f9c60eae1","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"Sets new values for a configuration group. Also lets you change the name and description of the configuration group."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"Error response codes: badRequest(400),unauthorized(401),forbidden(403),itemNotFound(404),"},{"line_number":292,"context_line":"badMethod(405),overLimit(413),unprocessableEntity(422),instanceFault(500),notImplemented(501),"},{"line_number":293,"context_line":"serviceUnavailable(503)"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"7f96bb07_97716ce1","line":291,"updated":"2018-01-24 02:08:45.000000000","message":"Need to add \"Normal response codes: 202\" here.","commit_id":"3d161ab475c473d9c40289f43aad317d2e80d71c"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"f418c13b246a83c9bd5222fb6a3792faa2e2bc60","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Deletes a configuration group."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Normal response codes: Accepted(202)"},{"line_number":161,"context_line":"Error response codes: badRequest(400),unauthorized(401),forbidden(403),itemNotFound(404),"},{"line_number":162,"context_line":"badMethod(405),overLimit(413),unprocessableEntity(422),instanceFault(500),notImplemented(501),"},{"line_number":163,"context_line":"serviceUnavailable(503)"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7f96bb07_e36020a8","line":160,"range":{"start_line":160,"start_character":23,"end_line":160,"end_character":36},"updated":"2018-01-24 12:42:40.000000000","message":"To follow the style of existing documents, for \"Normal response codes\", we could just use 200/202, adding an extra \"Accepted\" won\u0027t get any benifit here.","commit_id":"23b1f2ac5e5e34b9240228ed88aa48bf1dca6b69"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"f418c13b246a83c9bd5222fb6a3792faa2e2bc60","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"Sets new values for a configuration group. Also lets you change the name and description of the configuration group."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Normal response codes: Accepted(202)"},{"line_number":293,"context_line":"Error response codes: badRequest(400),unauthorized(401),forbidden(403),itemNotFound(404),"},{"line_number":294,"context_line":"badMethod(405),overLimit(413),unprocessableEntity(422),instanceFault(500),notImplemented(501),"},{"line_number":295,"context_line":"serviceUnavailable(503)"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"7f96bb07_a35698cd","line":292,"range":{"start_line":292,"start_character":23,"end_line":292,"end_character":31},"updated":"2018-01-24 12:42:40.000000000","message":"Same here, and the other pages.","commit_id":"23b1f2ac5e5e34b9240228ed88aa48bf1dca6b69"}],"api-ref/source/database-instance-actions.inc":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"cb9d13621ed87812bdf4b92dcad2db1f9c60eae1","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The database instance is unavailable until the instance restarts."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"If the operation succeeds, it returns the ``Accepted (202)``"},{"line_number":24,"context_line":"response code."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Error response codes: badRequest(400),unauthorized(401),forbidden(403),itemNotFound(404),"},{"line_number":27,"context_line":"badMethod(405),overLimit(413),badMediaType(415),unprocessableEntity(422),instanceFault(500),"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"7f96bb07_3707381f","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":14},"updated":"2018-01-24 02:08:45.000000000","message":"This line is not neccessary, and add the nornal response codes line for 202. This should be done to all other similar api pieces, we shouldn\u0027t just delete 202 from the error response codes.","commit_id":"3d161ab475c473d9c40289f43aad317d2e80d71c"}],"api-ref/source/flavors.inc":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"4b9ef63afc11ee6d965c308897492ef5e0a5beef","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Normal response codes: 200"},{"line_number":27,"context_line":"Error response codes: Bad Request(400), Unauthorized(401), Forbidden(403), File Not Found(404),"},{"line_number":28,"context_line":"                      Method Not Allowed(405), Request Entity Too Large(413),Request Entity Too Large(422),"},{"line_number":29,"context_line":"                      Internal Server Error(500), Not Implemented(501), Service Unavailable(503)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f96bb07_224f1b35","line":27,"range":{"start_line":27,"start_character":93,"end_line":27,"end_character":95},"updated":"2018-01-23 03:21:18.000000000","message":"File Not Found or Not Found?","commit_id":"3d826e9245bdc7abb9bd50e144501e5344598cc6"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"4b9ef63afc11ee6d965c308897492ef5e0a5beef","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Normal response codes: 200"},{"line_number":27,"context_line":"Error response codes: Bad Request(400), Unauthorized(401), Forbidden(403), File Not Found(404),"},{"line_number":28,"context_line":"                      Method Not Allowed(405), Request Entity Too Large(413),Request Entity Too Large(422),"},{"line_number":29,"context_line":"                      Internal Server Error(500), Not Implemented(501), Service Unavailable(503)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f96bb07_42c5878d","line":28,"range":{"start_line":28,"start_character":105,"end_line":28,"end_character":107},"updated":"2018-01-23 03:21:18.000000000","message":"422 Unprocessable Entity","commit_id":"3d826e9245bdc7abb9bd50e144501e5344598cc6"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"4b9ef63afc11ee6d965c308897492ef5e0a5beef","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Normal response codes: 200"},{"line_number":75,"context_line":"Error response codes: Bad Request(400), Unauthorized(401), Forbidden(403), File Not Found(404),"},{"line_number":76,"context_line":"                      Method Not Allowed(405), Request Entity Too Large(413),Request Entity Too Large(422),"},{"line_number":77,"context_line":"                      Internal Server Error(500), Not Implemented(501), Service Unavailable(503)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f96bb07_22babb09","line":76,"range":{"start_line":76,"start_character":102,"end_line":76,"end_character":105},"updated":"2018-01-23 03:21:18.000000000","message":"same","commit_id":"3d826e9245bdc7abb9bd50e144501e5344598cc6"}]}