)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a49fc1a0996f6de15e4496c59c863d5a5ab693ab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Fan Zhang \u003czh.f@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-27 09:30:23 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[api-ref] Add sections for instance backups."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If3a929e9de31dd901c4838e85f91f76941f33d05"},{"line_number":10,"context_line":"Closes-bug: #1663096"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa0c359_fc77e93a","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":43},"updated":"2018-02-27 07:41:50.000000000","message":"I think it\u0027s just use \"backups\", and the same for the new added doc file, as \"backups\" is completely independent API entry (\"List database backups for an instance\" is under the \"instances\" API, but I think it\u0027s fine and in maybe better to be included in this this doc file).","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"}],"api-ref/source/backups.inc":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a5cd8a4d7465490639742df2f720327fb3bbd3a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Database instances backups"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"List, show details, create and delete backups for instances."}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3fa0c359_dfae9f2e","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":26},"updated":"2018-02-27 08:59:47.000000000","message":"As we are going to use \"backups.inc\", the title could change to just \"Backups\" (or \"Backups (backups)\" to follow other sections.","commit_id":"9d9524eff0f6ad572f0356da23af8cccb5bd0a95"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"c3b43b98e7fa8bc1a2f1032e313ae1aacba70021","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Database instances backups"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"List, show details, create and delete backups for instances."}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3fa0c359_021cae11","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":26},"in_reply_to":"3fa0c359_dfae9f2e","updated":"2018-02-27 09:24:10.000000000","message":"Done","commit_id":"9d9524eff0f6ad572f0356da23af8cccb5bd0a95"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a5cd8a4d7465490639742df2f720327fb3bbd3a3","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"   - backupId: backup_id"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3fa0c359_9ffa5741","line":134,"updated":"2018-02-27 08:59:47.000000000","message":"Lacking the accountId path parameter here.","commit_id":"9d9524eff0f6ad572f0356da23af8cccb5bd0a95"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"c3b43b98e7fa8bc1a2f1032e313ae1aacba70021","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"   - backupId: backup_id"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3fa0c359_c2fc86b7","line":134,"in_reply_to":"3fa0c359_9ffa5741","updated":"2018-02-27 09:24:10.000000000","message":"Done","commit_id":"9d9524eff0f6ad572f0356da23af8cccb5bd0a95"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"891e1d2b26ec1dbe7973a4a84dd38bd73fc70ab0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Backups"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"List, show details, create and delete backups for instances."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"List database backups"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_82919e49","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":59},"updated":"2018-02-27 09:37:25.000000000","message":"This could also be removed.","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Backups"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"List, show details, create and delete backups for instances."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"List database backups"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_854f6869","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":59},"in_reply_to":"3fa0c359_82919e49","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"891e1d2b26ec1dbe7973a4a84dd38bd73fc70ab0","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - backup: backup_list"},{"line_number":38,"context_line":"    - created: created"},{"line_number":39,"context_line":"    - datastore: datastore2"},{"line_number":40,"context_line":"    - datastore.type: datastore_type1"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_a2a93a7d","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":12},"updated":"2018-02-27 09:37:25.000000000","message":"\"backups\"","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - backup: backup_list"},{"line_number":38,"context_line":"    - created: created"},{"line_number":39,"context_line":"    - datastore: datastore2"},{"line_number":40,"context_line":"    - datastore.type: datastore_type1"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_45596033","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":12},"in_reply_to":"3fa0c359_a2a93a7d","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"de017444d20786d046d88f18a77c61ea55175006","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    - created: created"},{"line_number":39,"context_line":"    - datastore: datastore2"},{"line_number":40,"context_line":"    - datastore.type: datastore_type1"},{"line_number":41,"context_line":"    - datastore.version: datastore_version1"},{"line_number":42,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":43,"context_line":"    - description: backup_description1"},{"line_number":44,"context_line":"    - id: backup_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_c2f7a659","line":41,"updated":"2018-02-27 09:43:00.000000000","message":"We may need a new parameter for datastore[\u0027version\u0027] here, as in BackupView, this is the \"name\" of the datastore version, but \"datastore_version1\" is \"Name or ID\".\n\nWe could just add a new parameter \"datastore_version_name\".","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"891e1d2b26ec1dbe7973a4a84dd38bd73fc70ab0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - datastore: datastore2"},{"line_number":40,"context_line":"    - datastore.type: datastore_type1"},{"line_number":41,"context_line":"    - datastore.version: datastore_version1"},{"line_number":42,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":43,"context_line":"    - description: backup_description1"},{"line_number":44,"context_line":"    - id: backup_id"},{"line_number":45,"context_line":"    - instance_id: backup_instanceId"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_42e956b5","line":42,"range":{"start_line":42,"start_character":6,"end_line":42,"end_character":23},"updated":"2018-02-27 09:37:25.000000000","message":"\"database.version_id\". Sorry for this, I seemed to be the first one to bring up this in my comment...:(","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - datastore: datastore2"},{"line_number":40,"context_line":"    - datastore.type: datastore_type1"},{"line_number":41,"context_line":"    - datastore.version: datastore_version1"},{"line_number":42,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":43,"context_line":"    - description: backup_description1"},{"line_number":44,"context_line":"    - id: backup_id"},{"line_number":45,"context_line":"    - instance_id: backup_instanceId"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_e5abccd4","line":42,"range":{"start_line":42,"start_character":6,"end_line":42,"end_character":23},"in_reply_to":"3fa0c359_42e956b5","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"de017444d20786d046d88f18a77c61ea55175006","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    - created: created"},{"line_number":93,"context_line":"    - datastore: datastore2"},{"line_number":94,"context_line":"    - datastore.type: datastore_type1"},{"line_number":95,"context_line":"    - datastore.version: datastore_version1"},{"line_number":96,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":97,"context_line":"    - description: backup_description1"},{"line_number":98,"context_line":"    - id: backup_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_42a15646","line":95,"updated":"2018-02-27 09:43:00.000000000","message":"ditto.","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    - created: created"},{"line_number":93,"context_line":"    - datastore: datastore2"},{"line_number":94,"context_line":"    - datastore.type: datastore_type1"},{"line_number":95,"context_line":"    - datastore.version: datastore_version1"},{"line_number":96,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":97,"context_line":"    - description: backup_description1"},{"line_number":98,"context_line":"    - id: backup_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_85868865","line":95,"in_reply_to":"3fa0c359_42a15646","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"891e1d2b26ec1dbe7973a4a84dd38bd73fc70ab0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    - datastore: datastore2"},{"line_number":94,"context_line":"    - datastore.type: datastore_type1"},{"line_number":95,"context_line":"    - datastore.version: datastore_version1"},{"line_number":96,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":97,"context_line":"    - description: backup_description1"},{"line_number":98,"context_line":"    - id: backup_id"},{"line_number":99,"context_line":"    - instance_id: backup_instanceId"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_22fd2a6e","line":96,"range":{"start_line":96,"start_character":6,"end_line":96,"end_character":23},"updated":"2018-02-27 09:37:25.000000000","message":"ditto.","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    - datastore: datastore2"},{"line_number":94,"context_line":"    - datastore.type: datastore_type1"},{"line_number":95,"context_line":"    - datastore.version: datastore_version1"},{"line_number":96,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":97,"context_line":"    - description: backup_description1"},{"line_number":98,"context_line":"    - id: backup_id"},{"line_number":99,"context_line":"    - instance_id: backup_instanceId"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_257bf47b","line":96,"range":{"start_line":96,"start_character":6,"end_line":96,"end_character":23},"in_reply_to":"3fa0c359_22fd2a6e","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"de017444d20786d046d88f18a77c61ea55175006","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    - created: created"},{"line_number":146,"context_line":"    - datastore: datastore2"},{"line_number":147,"context_line":"    - datastore.type: datastore_type1"},{"line_number":148,"context_line":"    - datastore.version: datastore_version1"},{"line_number":149,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":150,"context_line":"    - description: backup_description1"},{"line_number":151,"context_line":"    - id: backup_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_e28502b0","line":148,"updated":"2018-02-27 09:43:00.000000000","message":"ditto.","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    - created: created"},{"line_number":146,"context_line":"    - datastore: datastore2"},{"line_number":147,"context_line":"    - datastore.type: datastore_type1"},{"line_number":148,"context_line":"    - datastore.version: datastore_version1"},{"line_number":149,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":150,"context_line":"    - description: backup_description1"},{"line_number":151,"context_line":"    - id: backup_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_e5942c8f","line":148,"in_reply_to":"3fa0c359_e28502b0","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"891e1d2b26ec1dbe7973a4a84dd38bd73fc70ab0","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    - datastore: datastore2"},{"line_number":147,"context_line":"    - datastore.type: datastore_type1"},{"line_number":148,"context_line":"    - datastore.version: datastore_version1"},{"line_number":149,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":150,"context_line":"    - description: backup_description1"},{"line_number":151,"context_line":"    - id: backup_id"},{"line_number":152,"context_line":"    - instance_id: backup_instanceId"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_e2f66291","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":23},"updated":"2018-02-27 09:37:25.000000000","message":"ditto.","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    - datastore: datastore2"},{"line_number":147,"context_line":"    - datastore.type: datastore_type1"},{"line_number":148,"context_line":"    - datastore.version: datastore_version1"},{"line_number":149,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":150,"context_line":"    - description: backup_description1"},{"line_number":151,"context_line":"    - id: backup_id"},{"line_number":152,"context_line":"    - instance_id: backup_instanceId"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_059278a0","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":23},"in_reply_to":"3fa0c359_e2f66291","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"de017444d20786d046d88f18a77c61ea55175006","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    - created: created"},{"line_number":210,"context_line":"    - datastore: datastore2"},{"line_number":211,"context_line":"    - datastore.type: datastore_type1"},{"line_number":212,"context_line":"    - datastore.version: datastore_version1"},{"line_number":213,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":214,"context_line":"    - description: backup_description1"},{"line_number":215,"context_line":"    - id: backup_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_02834eab","line":212,"updated":"2018-02-27 09:43:00.000000000","message":"ditto.","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    - created: created"},{"line_number":210,"context_line":"    - datastore: datastore2"},{"line_number":211,"context_line":"    - datastore.type: datastore_type1"},{"line_number":212,"context_line":"    - datastore.version: datastore_version1"},{"line_number":213,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":214,"context_line":"    - description: backup_description1"},{"line_number":215,"context_line":"    - id: backup_id"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_a58e2477","line":212,"in_reply_to":"3fa0c359_02834eab","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"891e1d2b26ec1dbe7973a4a84dd38bd73fc70ab0","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    - datastore: datastore2"},{"line_number":211,"context_line":"    - datastore.type: datastore_type1"},{"line_number":212,"context_line":"    - datastore.version: datastore_version1"},{"line_number":213,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":214,"context_line":"    - description: backup_description1"},{"line_number":215,"context_line":"    - id: backup_id"},{"line_number":216,"context_line":"    - instance_id: backup_instanceId"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_a2f05a93","line":213,"range":{"start_line":213,"start_character":6,"end_line":213,"end_character":23},"updated":"2018-02-27 09:37:25.000000000","message":"ditto.","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    - datastore: datastore2"},{"line_number":211,"context_line":"    - datastore.type: datastore_type1"},{"line_number":212,"context_line":"    - datastore.version: datastore_version1"},{"line_number":213,"context_line":"    - datastore.version: datastore_version_id1"},{"line_number":214,"context_line":"    - description: backup_description1"},{"line_number":215,"context_line":"    - id: backup_id"},{"line_number":216,"context_line":"    - instance_id: backup_instanceId"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3fa0c359_c58b3066","line":213,"range":{"start_line":213,"start_character":6,"end_line":213,"end_character":23},"in_reply_to":"3fa0c359_a2f05a93","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2dbbf966fb705929bc36fce181f0abc86f7ac451","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Creates a database backup for instance."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Normal response codes: 200"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403),"},{"line_number":180,"context_line":"itemNotFound(404), badMethod(405), overLimit(413), unprocessableEntity(422),"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"3fa0c359_6511fcaf","line":177,"range":{"start_line":177,"start_character":23,"end_line":177,"end_character":26},"updated":"2018-02-27 10:20:31.000000000","message":"Just found this should be 202, as creating a backup is a async task like deleting.","commit_id":"3269812236d4a24b68e284bfe3d7e7650e206de2"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"2494ad265c6b143e3db0b41b3f87b79990ebb869","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Creates a database backup for instance."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Normal response codes: 200"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403),"},{"line_number":180,"context_line":"itemNotFound(404), badMethod(405), overLimit(413), unprocessableEntity(422),"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"1f9dbf25_fb5b6f51","line":177,"range":{"start_line":177,"start_character":23,"end_line":177,"end_character":26},"in_reply_to":"3fa0c359_6511fcaf","updated":"2018-02-27 11:08:01.000000000","message":"Done","commit_id":"3269812236d4a24b68e284bfe3d7e7650e206de2"}],"api-ref/source/database-instance-backups.inc":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Database instances backups"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"List, show details, create, delete backups for instances."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"List database backups"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_25b9e213","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":57},"updated":"2018-02-13 06:01:06.000000000","message":"I\u0027d prefer the contents below follow the order presented in this sentence, i.e list, create, show...\n\nAnd there\u0027s no content for deleting backups.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"1356fd4b25da06caa30856c8ef2c8f3f60607311","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Database instances backups"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"List, show details, create, delete backups for instances."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"List database backups"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_bd564d29","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":57},"in_reply_to":"3fa0c359_25b9e213","updated":"2018-02-26 12:11:42.000000000","message":"Done","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   - accountId: accountId"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Response Example"},{"line_number":33,"context_line":"----------------"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_055386e3","line":31,"updated":"2018-02-13 06:01:06.000000000","message":"An extra section about response schema should be much better.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"1356fd4b25da06caa30856c8ef2c8f3f60607311","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   - accountId: accountId"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Response Example"},{"line_number":33,"context_line":"----------------"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_80076882","line":31,"in_reply_to":"3fa0c359_055386e3","updated":"2018-02-26 12:11:42.000000000","message":"Done","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":60,"context_line":"   - instanceId: instanceId"},{"line_number":61,"context_line":"   - accountId: accountId"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Response Example"},{"line_number":65,"context_line":"----------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_850d56e9","line":63,"updated":"2018-02-13 06:01:06.000000000","message":"Same here for response schema.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"1356fd4b25da06caa30856c8ef2c8f3f60607311","unresolved":false,"context_lines":[{"line_number":60,"context_line":"   - instanceId: instanceId"},{"line_number":61,"context_line":"   - accountId: accountId"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Response Example"},{"line_number":65,"context_line":"----------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_a02f04f4","line":63,"in_reply_to":"3fa0c359_850d56e9","updated":"2018-02-26 12:11:42.000000000","message":"Done","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":96,"context_line":"   - description: backup_description"},{"line_number":97,"context_line":"   - accountId: accountId"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Request Example"},{"line_number":101,"context_line":"---------------"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_25fc82b3","line":99,"updated":"2018-02-13 06:01:06.000000000","message":"Same here for response schema.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"1356fd4b25da06caa30856c8ef2c8f3f60607311","unresolved":false,"context_lines":[{"line_number":96,"context_line":"   - description: backup_description"},{"line_number":97,"context_line":"   - accountId: accountId"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Request Example"},{"line_number":101,"context_line":"---------------"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_e0ebcca0","line":99,"in_reply_to":"3fa0c359_25fc82b3","updated":"2018-02-26 12:11:42.000000000","message":"Done","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":135,"context_line":"   - backupId: backup_id"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Request Example"},{"line_number":139,"context_line":"---------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. literalinclude:: samples/db-backup-get-request-json-http.txt"},{"line_number":142,"context_line":"   :language: javascript"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_251562e5","line":142,"range":{"start_line":138,"start_character":0,"end_line":142,"end_character":24},"updated":"2018-02-13 06:01:06.000000000","message":"This section is not neccessary, as it\u0027s a simple GET request without any inputs.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"1356fd4b25da06caa30856c8ef2c8f3f60607311","unresolved":false,"context_lines":[{"line_number":135,"context_line":"   - backupId: backup_id"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Request Example"},{"line_number":139,"context_line":"---------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. literalinclude:: samples/db-backup-get-request-json-http.txt"},{"line_number":142,"context_line":"   :language: javascript"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_00fb5878","line":142,"range":{"start_line":138,"start_character":0,"end_line":142,"end_character":24},"in_reply_to":"3fa0c359_251562e5","updated":"2018-02-26 12:11:42.000000000","message":"Done","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":141,"context_line":".. literalinclude:: samples/db-backup-get-request-json-http.txt"},{"line_number":142,"context_line":"   :language: javascript"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Response Example"},{"line_number":146,"context_line":"----------------"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_85db164d","line":144,"updated":"2018-02-13 06:01:06.000000000","message":"Same here for response schema.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"1356fd4b25da06caa30856c8ef2c8f3f60607311","unresolved":false,"context_lines":[{"line_number":141,"context_line":".. literalinclude:: samples/db-backup-get-request-json-http.txt"},{"line_number":142,"context_line":"   :language: javascript"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Response Example"},{"line_number":146,"context_line":"----------------"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_c0f01094","line":144,"in_reply_to":"3fa0c359_85db164d","updated":"2018-02-26 12:11:42.000000000","message":"Done","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a49fc1a0996f6de15e4496c59c863d5a5ab693ab","unresolved":false,"context_lines":[{"line_number":33,"context_line":"-------------------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - created: created"},{"line_number":38,"context_line":"    - datastore: datastore2"},{"line_number":39,"context_line":"    - description: backup_description"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3fa0c359_dc69cd26","line":36,"updated":"2018-02-27 07:41:50.000000000","message":"For listing requests(listing all backups for a tenant and listing all backups for a instance), a top container object should also be stated here, it\u0027s a list of \"backup\" objects:\n\n    \"backups\": [\n        {...},\n        {...},\n        ...\n    ]","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"b20e2963798d5057fe77b71a135f708e720ceb0a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"-------------------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - created: created"},{"line_number":38,"context_line":"    - datastore: datastore2"},{"line_number":39,"context_line":"    - description: backup_description"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3fa0c359_5f492f8c","line":36,"in_reply_to":"3fa0c359_3fec638e","updated":"2018-02-27 09:07:16.000000000","message":"Sorry, \"This commit\" -\u003e \"This comment\".\n\nThe top level container object \"backups\" should also added here, like the \"logs\" parameter in database-instance-logs.inc.","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a5cd8a4d7465490639742df2f720327fb3bbd3a3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"-------------------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - created: created"},{"line_number":38,"context_line":"    - datastore: datastore2"},{"line_number":39,"context_line":"    - description: backup_description"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3fa0c359_3fec638e","line":36,"in_reply_to":"3fa0c359_dc69cd26","updated":"2018-02-27 08:59:47.000000000","message":"This commit has not been addressed yet.","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a49fc1a0996f6de15e4496c59c863d5a5ab693ab","unresolved":false,"context_lines":[{"line_number":35,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - created: created"},{"line_number":38,"context_line":"    - datastore: datastore2"},{"line_number":39,"context_line":"    - description: backup_description"},{"line_number":40,"context_line":"    - id: backup_id"},{"line_number":41,"context_line":"    - instance_id: backup_instanceId"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3fa0c359_fcc5a93e","line":38,"updated":"2018-02-27 07:41:50.000000000","message":"It\u0027s more clear to include subelements of a container object, like:\n\n   - datastore: datastore2\n   - datastore.type: datastore_type\n   - datastore.version: datastore_version1\n   - datastore.version: datastore_version_id1\n\nHower the \"datastore\" in BackupView is slightly different with the one in InstanceView: from trove/backup/views.py, only when \"self.backup.datastore_version_id\" is not None, \"datastore\" will be included in the response, so it\u0027s an optional object, we may need a datastore3 for this (however I didn\u0027t find out when \"self.backup.datastore_version_id\" will be None).","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"}],"api-ref/source/database-instances.inc":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"20027b375d0cc475ef4bcca3c4aec5ecc7359f32","unresolved":false,"context_lines":[{"line_number":510,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"   - name: backup_name"},{"line_number":513,"context_line":"   - instance: instance"},{"line_number":514,"context_line":"   - parent: backup_parentId"},{"line_number":515,"context_line":"   - incremental: backup_incremental"},{"line_number":516,"context_line":"   - description: backup_description"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"3fa0c359_d77f5ba9","line":513,"range":{"start_line":513,"start_character":15,"end_line":513,"end_character":23},"updated":"2018-02-05 09:47:12.000000000","message":"The existing parameter \u0027instance\u0027 in parameters.yaml is an object, this is not correct here, we need a new parameter(something like \u0027instanceID\u0027, but instead this one is in body).\n\nPlease refer to the \"Creates a database instance\" section in database-instances.inc for the usage of the \u0027instance\u0027 parameter.","commit_id":"1b9143881dc7c97d18b4ece5d33ce1b27c187362"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"20027b375d0cc475ef4bcca3c4aec5ecc7359f32","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"   - name: backup_name"},{"line_number":513,"context_line":"   - instance: instance"},{"line_number":514,"context_line":"   - parent: backup_parentId"},{"line_number":515,"context_line":"   - incremental: backup_incremental"},{"line_number":516,"context_line":"   - description: backup_description"},{"line_number":517,"context_line":"   - accountId: accountId"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"3fa0c359_17f863c2","line":514,"range":{"start_line":514,"start_character":5,"end_line":514,"end_character":11},"updated":"2018-02-05 09:47:12.000000000","message":"parent_id","commit_id":"1b9143881dc7c97d18b4ece5d33ce1b27c187362"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"20027b375d0cc475ef4bcca3c4aec5ecc7359f32","unresolved":false,"context_lines":[{"line_number":523,"context_line":".. literalinclude:: samples/db-backup-create-request.json"},{"line_number":524,"context_line":"   :language: javascript"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"Response Example"},{"line_number":528,"context_line":"----------------"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"3fa0c359_9778f3f8","line":526,"updated":"2018-02-05 09:47:12.000000000","message":"Better to have an extra section for \"Response Parameters\" before the \"Response Example\".","commit_id":"1b9143881dc7c97d18b4ece5d33ce1b27c187362"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"   - instanceId: instanceId"},{"line_number":470,"context_line":"   - accountId: accountId"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"Response Example"},{"line_number":474,"context_line":"----------------"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":".. literalinclude:: samples/db-list-cfg-defaults-response.json"},{"line_number":477,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3fa0c359_6567eaea","side":"PARENT","line":477,"range":{"start_line":471,"start_character":0,"end_line":477,"end_character":24},"updated":"2018-02-13 06:01:06.000000000","message":"Unrelated changes.","commit_id":"f0c03c114e93cd580f74d4c31d51760b7a511d29"}],"api-ref/source/index.rst":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2bafc76a5e58c4746a5ee350cf9fd723241f9b64","unresolved":false,"context_lines":[{"line_number":9,"context_line":".. include:: api-versions.inc"},{"line_number":10,"context_line":".. include:: database-instances.inc"},{"line_number":11,"context_line":".. include:: database-instance-actions.inc"},{"line_number":12,"context_line":".. include:: database-instance-backups.inc"},{"line_number":13,"context_line":".. include:: database-instance-logs.inc"},{"line_number":14,"context_line":".. include:: databases.inc"},{"line_number":15,"context_line":".. include:: user-management.inc"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa0c359_ff44bb1b","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":42},"updated":"2018-02-27 08:28:57.000000000","message":"I meant \"backups.inc\" instead of \"database-instance-backups.inc\".","commit_id":"4a52793817288857ad1f034baf1d38da509273ec"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"20027b375d0cc475ef4bcca3c4aec5ecc7359f32","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    It will create a full backup if no existing backup found."},{"line_number":68,"context_line":"  in: body"},{"line_number":69,"context_line":"  required: false"},{"line_number":70,"context_line":"  type: string"},{"line_number":71,"context_line":"backup_name:"},{"line_number":72,"context_line":"  description: |"},{"line_number":73,"context_line":"    Name of the backup."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_b7bc0fbc","line":70,"range":{"start_line":70,"start_character":2,"end_line":70,"end_character":14},"updated":"2018-02-05 09:47:12.000000000","message":"In trove.common.apischema, the type of the \"incremental\" property is boolean_string, which is integer and only accept 0 or 1 in fact. It would be better also update the description with more details about this.","commit_id":"1b9143881dc7c97d18b4ece5d33ce1b27c187362"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":636,"context_line":"  in: body"},{"line_number":637,"context_line":"  required: true"},{"line_number":638,"context_line":"  type: string"},{"line_number":639,"context_line":"volume:"},{"line_number":640,"context_line":"  description: |"},{"line_number":641,"context_line":"    A ``volume`` object."},{"line_number":642,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_e5a0daf6","side":"PARENT","line":639,"updated":"2018-02-13 06:01:06.000000000","message":"Unrelated changes.","commit_id":"f0c03c114e93cd580f74d4c31d51760b7a511d29"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  type: string"},{"line_number":38,"context_line":"flavorId:"},{"line_number":39,"context_line":"  description: |"},{"line_number":40,"context_line":"    The ID for the flavor."},{"line_number":41,"context_line":"  in: path"},{"line_number":42,"context_line":"  required: false"},{"line_number":43,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_a5f412f2","line":40,"updated":"2018-02-13 06:01:06.000000000","message":"Unrelated changes.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  type: string"},{"line_number":44,"context_line":"instanceId:"},{"line_number":45,"context_line":"  description: |"},{"line_number":46,"context_line":"    The ID for the database instance."},{"line_number":47,"context_line":"  in: path"},{"line_number":48,"context_line":"  required: false"},{"line_number":49,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_65da8a78","line":46,"updated":"2018-02-13 06:01:06.000000000","message":"Same here.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":76,"context_line":"backup_incremental:"},{"line_number":77,"context_line":"  description: |"},{"line_number":78,"context_line":"    Create an incremental backup based on the last full by setting this"},{"line_number":79,"context_line":"    parameter to 1 or incremental backup just setting this parameter to 0."},{"line_number":80,"context_line":"    It will create a full backup if no existing backup found."},{"line_number":81,"context_line":"  in: body"},{"line_number":82,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_25b2424a","line":79,"range":{"start_line":79,"start_character":22,"end_line":79,"end_character":40},"updated":"2018-02-13 06:01:06.000000000","message":"?","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    It will create a full backup if no existing backup found."},{"line_number":81,"context_line":"  in: body"},{"line_number":82,"context_line":"  required: false"},{"line_number":83,"context_line":"  type: string"},{"line_number":84,"context_line":"backup_instanceId:"},{"line_number":85,"context_line":"  description: |"},{"line_number":86,"context_line":"    The ID of the instance to create backup for."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_857c7672","line":83,"range":{"start_line":83,"start_character":8,"end_line":83,"end_character":14},"updated":"2018-02-13 06:01:06.000000000","message":"This should be integer from apischema.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  in: body"},{"line_number":82,"context_line":"  required: false"},{"line_number":83,"context_line":"  type: string"},{"line_number":84,"context_line":"backup_instanceId:"},{"line_number":85,"context_line":"  description: |"},{"line_number":86,"context_line":"    The ID of the instance to create backup for."},{"line_number":87,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_05906694","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":18},"updated":"2018-02-13 06:01:06.000000000","message":"This is not neccesary, existing \"instanceId\" could be used here, though another new backup_instanceID should also be fine.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  in: body"},{"line_number":100,"context_line":"  required: false"},{"line_number":101,"context_line":"  type: string"},{"line_number":102,"context_line":"backup_sourceId:"},{"line_number":103,"context_line":"  description: |"},{"line_number":104,"context_line":"    Backup ID of the source backup."},{"line_number":105,"context_line":"  in: body"},{"line_number":106,"context_line":"  required: true"},{"line_number":107,"context_line":"  type: string"},{"line_number":108,"context_line":"characterSet:"},{"line_number":109,"context_line":"  description: |"},{"line_number":110,"context_line":"    A set of symbols and encodings. Default is"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_c5d4be4a","line":107,"range":{"start_line":102,"start_character":0,"end_line":107,"end_character":14},"updated":"2018-02-13 06:01:06.000000000","message":"\"backup_sourceId\" is not used?","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"1356fd4b25da06caa30856c8ef2c8f3f60607311","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  in: body"},{"line_number":100,"context_line":"  required: false"},{"line_number":101,"context_line":"  type: string"},{"line_number":102,"context_line":"backup_sourceId:"},{"line_number":103,"context_line":"  description: |"},{"line_number":104,"context_line":"    Backup ID of the source backup."},{"line_number":105,"context_line":"  in: body"},{"line_number":106,"context_line":"  required: true"},{"line_number":107,"context_line":"  type: string"},{"line_number":108,"context_line":"characterSet:"},{"line_number":109,"context_line":"  description: |"},{"line_number":110,"context_line":"    A set of symbols and encodings. Default is"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_63a58602","line":107,"range":{"start_line":102,"start_character":0,"end_line":107,"end_character":14},"in_reply_to":"3fa0c359_c5d4be4a","updated":"2018-02-26 12:11:42.000000000","message":"Done","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"c4436d1640535a17c0bb3e84a998811e82e90770","unresolved":false,"context_lines":[{"line_number":671,"context_line":"  description: |"},{"line_number":672,"context_line":"    A ``users`` object."},{"line_number":673,"context_line":"  in: body"},{"line_number":674,"context_line":"  required: true"},{"line_number":675,"context_line":"  type: array"},{"line_number":676,"context_line":"values:"},{"line_number":677,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_65e4ca0d","line":674,"updated":"2018-02-13 06:01:06.000000000","message":"Unrelated changes.","commit_id":"227d3dc8c310214d7b3ab8229ffc9794894f1154"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a49fc1a0996f6de15e4496c59c863d5a5ab693ab","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  description: |"},{"line_number":72,"context_line":"    An optional description for the backup."},{"line_number":73,"context_line":"  in: body"},{"line_number":74,"context_line":"  required: false"},{"line_number":75,"context_line":"  type: string"},{"line_number":76,"context_line":"backup_incremental:"},{"line_number":77,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa0c359_7c08b990","line":74,"updated":"2018-02-27 07:41:50.000000000","message":"This is kind of something related to the comment in database-instance-backup.inc, \"required\" maybe different for different API. Here, for the response of the \"backups\" API, \"description\" is always included in BackupView, so it\u0027s a required part.\n\nThis is also true for many other parameters, if a common parameter is not suitable, we need to create a new one (although maybe only the \"required\" property is different).\n\nOf course, we could also say \"required\" is meaningless of response. Would love to hear your opinions.","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2bafc76a5e58c4746a5ee350cf9fd723241f9b64","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  description: |"},{"line_number":72,"context_line":"    An optional description for the backup."},{"line_number":73,"context_line":"  in: body"},{"line_number":74,"context_line":"  required: false"},{"line_number":75,"context_line":"  type: string"},{"line_number":76,"context_line":"backup_incremental:"},{"line_number":77,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa0c359_9fe33735","line":74,"in_reply_to":"3fa0c359_5c2e1dac","updated":"2018-02-27 08:28:57.000000000","message":"I looked through other projects like Nova, Cinder, and brought out my previous comment about this. These project use distinct parameters if they are not the same in request and response.","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"274c059ea6d86384d8169b3c8609c5a4c7fdb088","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  description: |"},{"line_number":72,"context_line":"    An optional description for the backup."},{"line_number":73,"context_line":"  in: body"},{"line_number":74,"context_line":"  required: false"},{"line_number":75,"context_line":"  type: string"},{"line_number":76,"context_line":"backup_incremental:"},{"line_number":77,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa0c359_5c2e1dac","line":74,"in_reply_to":"3fa0c359_7c08b990","updated":"2018-02-27 08:06:52.000000000","message":"Actually, I think `required` in the response is meaningless as you said. This parameters.yaml is for request parameters only IMHO.  My former thought is there is no need to add response parameters at all :)","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a49fc1a0996f6de15e4496c59c863d5a5ab693ab","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  description: |"},{"line_number":104,"context_line":"    ID of the parent backup to perform an incremental backup from."},{"line_number":105,"context_line":"  in: body"},{"line_number":106,"context_line":"  required: false"},{"line_number":107,"context_line":"  type: string"},{"line_number":108,"context_line":"backup_size:"},{"line_number":109,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa0c359_3c379150","line":106,"updated":"2018-02-27 07:41:50.000000000","message":"See the comment about \"required\" of \"backup_description\".","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a49fc1a0996f6de15e4496c59c863d5a5ab693ab","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  description: |"},{"line_number":110,"context_line":"    Size of the backup, the unit is GB."},{"line_number":111,"context_line":"  in: body"},{"line_number":112,"context_line":"  required: false"},{"line_number":113,"context_line":"  type: string"},{"line_number":114,"context_line":"backup_status:"},{"line_number":115,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa0c359_dc3b0d37","line":112,"updated":"2018-02-27 07:41:50.000000000","message":"See the comment about \"required\" of \"backup_description\".","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a49fc1a0996f6de15e4496c59c863d5a5ab693ab","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  description: |"},{"line_number":116,"context_line":"    Status of the backup."},{"line_number":117,"context_line":"  in: body"},{"line_number":118,"context_line":"  required: false"},{"line_number":119,"context_line":"  type: string"},{"line_number":120,"context_line":"characterSet:"},{"line_number":121,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa0c359_9c4585b7","line":118,"updated":"2018-02-27 07:41:50.000000000","message":"See the comment about \"required\" of \"backup_description\".","commit_id":"fc326bd2fcc840535679baffed230f539fe72296"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"891e1d2b26ec1dbe7973a4a84dd38bd73fc70ab0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  type: string"},{"line_number":96,"context_line":"backup_list:"},{"line_number":97,"context_line":"  description: |"},{"line_number":98,"context_line":"    A list of ``backups`` objects."},{"line_number":99,"context_line":"  in: body"},{"line_number":100,"context_line":"  required: true"},{"line_number":101,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa0c359_e2698226","line":98,"range":{"start_line":98,"start_character":16,"end_line":98,"end_character":23},"updated":"2018-02-27 09:37:25.000000000","message":"Should be \u0027backup\u0027(with the ending \u0027s\u0027).","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2dbbf966fb705929bc36fce181f0abc86f7ac451","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  type: string"},{"line_number":96,"context_line":"backup_list:"},{"line_number":97,"context_line":"  description: |"},{"line_number":98,"context_line":"    A list of ``backups`` objects."},{"line_number":99,"context_line":"  in: body"},{"line_number":100,"context_line":"  required: true"},{"line_number":101,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa0c359_65b57cd0","line":98,"range":{"start_line":98,"start_character":16,"end_line":98,"end_character":23},"in_reply_to":"3fa0c359_c5e0102a","updated":"2018-02-27 10:20:31.000000000","message":"Thanks for addressing my comments.\n\nAnother sorry here, I meant to write \"without the ending \u0027s\u0027\", but \"with\" was typed by accident...","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"62b5a7c386e2a2a9b91c3ed18455b04e6f5b18b4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  type: string"},{"line_number":96,"context_line":"backup_list:"},{"line_number":97,"context_line":"  description: |"},{"line_number":98,"context_line":"    A list of ``backups`` objects."},{"line_number":99,"context_line":"  in: body"},{"line_number":100,"context_line":"  required: true"},{"line_number":101,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa0c359_c5e0102a","line":98,"range":{"start_line":98,"start_character":16,"end_line":98,"end_character":23},"in_reply_to":"3fa0c359_e2698226","updated":"2018-02-27 09:59:48.000000000","message":"Done","commit_id":"cfc3381741462064220f822073fc0db96f146462"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2dbbf966fb705929bc36fce181f0abc86f7ac451","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  in: body"},{"line_number":278,"context_line":"  required: true"},{"line_number":279,"context_line":"  type: string"},{"line_number":280,"context_line":"datastore_version_name:"},{"line_number":281,"context_line":"  description: |"},{"line_number":282,"context_line":"    Name of a datastore version."},{"line_number":283,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_4537204f","line":280,"updated":"2018-02-27 10:20:31.000000000","message":"\"datastore_version_name\" should comme after \"datastore_version_id1\".","commit_id":"3269812236d4a24b68e284bfe3d7e7650e206de2"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"2494ad265c6b143e3db0b41b3f87b79990ebb869","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  in: body"},{"line_number":278,"context_line":"  required: true"},{"line_number":279,"context_line":"  type: string"},{"line_number":280,"context_line":"datastore_version_name:"},{"line_number":281,"context_line":"  description: |"},{"line_number":282,"context_line":"    Name of a datastore version."},{"line_number":283,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f9dbf25_3b18f77f","line":280,"in_reply_to":"3fa0c359_4537204f","updated":"2018-02-27 11:08:01.000000000","message":"Yes, definitely.","commit_id":"3269812236d4a24b68e284bfe3d7e7650e206de2"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2dbbf966fb705929bc36fce181f0abc86f7ac451","unresolved":false,"context_lines":[{"line_number":279,"context_line":"  type: string"},{"line_number":280,"context_line":"datastore_version_name:"},{"line_number":281,"context_line":"  description: |"},{"line_number":282,"context_line":"    Name of a datastore version."},{"line_number":283,"context_line":"  in: body"},{"line_number":284,"context_line":"  required: true"},{"line_number":285,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_c570100c","line":282,"range":{"start_line":282,"start_character":4,"end_line":282,"end_character":32},"updated":"2018-02-27 10:20:31.000000000","message":"\"The name of the datastore version.\" may be better to be consistent with the following \"datastore_version_id1\".","commit_id":"3269812236d4a24b68e284bfe3d7e7650e206de2"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"2494ad265c6b143e3db0b41b3f87b79990ebb869","unresolved":false,"context_lines":[{"line_number":279,"context_line":"  type: string"},{"line_number":280,"context_line":"datastore_version_name:"},{"line_number":281,"context_line":"  description: |"},{"line_number":282,"context_line":"    Name of a datastore version."},{"line_number":283,"context_line":"  in: body"},{"line_number":284,"context_line":"  required: true"},{"line_number":285,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f9dbf25_7e2c2d99","line":282,"range":{"start_line":282,"start_character":4,"end_line":282,"end_character":32},"in_reply_to":"3fa0c359_c570100c","updated":"2018-02-27 11:08:01.000000000","message":"OK","commit_id":"3269812236d4a24b68e284bfe3d7e7650e206de2"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"40b46db04de29f1b1ff26615a96aa02b857145bb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  type: string"},{"line_number":96,"context_line":"backup_list:"},{"line_number":97,"context_line":"  description: |"},{"line_number":98,"context_line":"    A list of ``backup(s)`` objects."},{"line_number":99,"context_line":"  in: body"},{"line_number":100,"context_line":"  required: true"},{"line_number":101,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f9dbf25_9eefb9e8","line":98,"updated":"2018-02-27 11:25:40.000000000","message":"I left a appending comment in PS6, would remove the \"(s)\"...","commit_id":"b93245992a5a959281850e1b5fac86ac56a157f8"}]}