)]}'
{"trove/tests/examples/snippets.py":[{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"f24bd7f9b9dbff1de06f27a24c97c083bb5e7a40","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        self.snippet("},{"line_number":509,"context_line":"            \"disable_root_user\","},{"line_number":510,"context_line":"            \"/instances/%s/root\" % json_instance.id,"},{"line_number":511,"context_line":"            \"DELETE\", 204, \"No Content\","},{"line_number":512,"context_line":"            lambda client: client.root.delete(json_instance.id))"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        # restore root for subsequent tests"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_023d90ba","line":511,"range":{"start_line":511,"start_character":21,"end_line":511,"end_character":39},"updated":"2018-03-07 01:55:47.000000000","message":"Thank you for your careful work.But I think 202 \u0027Accepted\u0027 will more appropriate here.","commit_id":"d597bb4714e666c924e8a48ad30ebad71a3b45ed"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"108951cf577509f02ed4960f173bbac41f39d266","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        self.snippet("},{"line_number":509,"context_line":"            \"disable_root_user\","},{"line_number":510,"context_line":"            \"/instances/%s/root\" % json_instance.id,"},{"line_number":511,"context_line":"            \"DELETE\", 204, \"No Content\","},{"line_number":512,"context_line":"            lambda client: client.root.delete(json_instance.id))"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        # restore root for subsequent tests"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_22b534ef","line":511,"range":{"start_line":511,"start_character":21,"end_line":511,"end_character":39},"in_reply_to":"df7087c5_023d90ba","updated":"2018-03-07 02:10:51.000000000","message":"202 \u0027Accepted\u0027 is usually for asynchronous tasks, root_disable use rpc.call(), so it is a synchronous task and 204 \u0027No Content\u0027 is more appropriate.","commit_id":"d597bb4714e666c924e8a48ad30ebad71a3b45ed"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"4e1a9969a647120feae79e60e18c8cae0bb15917","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        self.snippet("},{"line_number":509,"context_line":"            \"disable_root_user\","},{"line_number":510,"context_line":"            \"/instances/%s/root\" % json_instance.id,"},{"line_number":511,"context_line":"            \"DELETE\", 204, \"No Content\","},{"line_number":512,"context_line":"            lambda client: client.root.delete(json_instance.id))"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        # restore root for subsequent tests"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_82668051","line":511,"range":{"start_line":511,"start_character":21,"end_line":511,"end_character":39},"in_reply_to":"df7087c5_22b534ef","updated":"2018-03-07 02:53:12.000000000","message":"I checked the code, you are right. Thanks","commit_id":"d597bb4714e666c924e8a48ad30ebad71a3b45ed"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"3cbd2dc5e282171d177e7d6e73d84405b99d3fb2","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        self.snippet("},{"line_number":509,"context_line":"            \"disable_root_user\","},{"line_number":510,"context_line":"            \"/instances/%s/root\" % json_instance.id,"},{"line_number":511,"context_line":"            \"DELETE\", 204, \"No Content\","},{"line_number":512,"context_line":"            lambda client: client.root.delete(json_instance.id))"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        # restore root for subsequent tests"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_8d88f171","line":511,"range":{"start_line":511,"start_character":21,"end_line":511,"end_character":39},"in_reply_to":"df7087c5_82668051","updated":"2018-03-07 03:04:52.000000000","message":":) Thanks for reviewing.","commit_id":"d597bb4714e666c924e8a48ad30ebad71a3b45ed"}]}