)]}'
{"trove/extensions/account/models.py":[{"author":{"_account_id":4954,"name":"Paul Marshall","email":"paul.marshall@rackspace.com","username":"paulvmarshall"},"change_message_id":"287b05af4b5cbb3667282096db95d981cbf311c3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.id \u003d server[\u0027id\u0027]"},{"line_number":33,"context_line":"        self.status \u003d server[\u0027status\u0027]"},{"line_number":34,"context_line":"        self.name \u003d server[\u0027name\u0027]"},{"line_number":35,"context_line":"        self.host \u003d server.get(\u0027host\u0027) or server[\u0027hostId\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @staticmethod"},{"line_number":38,"context_line":"    def list_from_account_server_list(servers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FNjQ%3D","line":35,"updated":"2013-11-12 20:10:05.000000000","message":"I don\u0027t think that really makes this any safer since those are set from Nova, right? Besides, if a server has id, name, and status keys but no hostId key (not just an empty one like Nova should add), we have problems that setting host to None would just mask anyway IMO :)","commit_id":"1e7a4c0da45cc85dd7ab18eb9aeefaebb34574c1"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"ea431ebe23eb84dd1d8983ee200059e995fe1b13","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.id \u003d server[\u0027id\u0027]"},{"line_number":33,"context_line":"        self.status \u003d server[\u0027status\u0027]"},{"line_number":34,"context_line":"        self.name \u003d server[\u0027name\u0027]"},{"line_number":35,"context_line":"        self.host \u003d server.get(\u0027host\u0027) or server[\u0027hostId\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @staticmethod"},{"line_number":38,"context_line":"    def list_from_account_server_list(servers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FSMo%3D","line":35,"updated":"2013-11-11 18:04:39.000000000","message":"lets make this a little safer with \n`server.get(\u0027hostId\u0027)`","commit_id":"1e7a4c0da45cc85dd7ab18eb9aeefaebb34574c1"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"cb22f791449f15a596d3bca525cd39abf05e172d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.id \u003d server[\u0027id\u0027]"},{"line_number":33,"context_line":"        self.status \u003d server[\u0027status\u0027]"},{"line_number":34,"context_line":"        self.name \u003d server[\u0027name\u0027]"},{"line_number":35,"context_line":"        self.host \u003d server.get(\u0027host\u0027) or server[\u0027hostId\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @staticmethod"},{"line_number":38,"context_line":"    def list_from_account_server_list(servers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FAXs%3D","line":35,"in_reply_to":"AAAATn%2F%2FEi4%3D","updated":"2013-11-15 19:54:57.000000000","message":"Seconding Paul and Joe. \"hostId\" will always be there so if you check you\u0027ll never get the \"host\" keyword instead.","commit_id":"1e7a4c0da45cc85dd7ab18eb9aeefaebb34574c1"},{"author":{"_account_id":2559,"name":"Joe Cruz","email":"jcruz7@gmail.com","username":"jcruz7"},"change_message_id":"79eaffb3757ae3232883e193c92a6d20a902964d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.id \u003d server[\u0027id\u0027]"},{"line_number":33,"context_line":"        self.status \u003d server[\u0027status\u0027]"},{"line_number":34,"context_line":"        self.name \u003d server[\u0027name\u0027]"},{"line_number":35,"context_line":"        self.host \u003d server.get(\u0027host\u0027) or server[\u0027hostId\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @staticmethod"},{"line_number":38,"context_line":"    def list_from_account_server_list(servers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FEi4%3D","line":35,"in_reply_to":"AAAATn%2F%2FNjQ%3D","updated":"2013-11-14 20:13:15.000000000","message":"Yeah the reason for not using get for \u0027hostId\u0027 is exactly what Paul says.  I retrieved \u0027hostId\u0027 just like the 3 above attributes (\u0027id\u0027,\u0027status\u0027,\u0027name\u0027) which should be included for trunk Nova","commit_id":"1e7a4c0da45cc85dd7ab18eb9aeefaebb34574c1"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"05b7a1197373d9eb0d6d5cda3c3ce5c04f355947","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.id \u003d server[\u0027id\u0027]"},{"line_number":33,"context_line":"        self.status \u003d server[\u0027status\u0027]"},{"line_number":34,"context_line":"        self.name \u003d server[\u0027name\u0027]"},{"line_number":35,"context_line":"        self.host \u003d server.get(\u0027host\u0027) or server[\u0027hostId\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @staticmethod"},{"line_number":38,"context_line":"    def list_from_account_server_list(servers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FRtg%3D","line":35,"in_reply_to":"AAAATn%2F%2FSMo%3D","updated":"2013-11-11 21:09:28.000000000","message":"agreed","commit_id":"1e7a4c0da45cc85dd7ab18eb9aeefaebb34574c1"}]}