)]}'
{"tox.ini":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"dc595cccb421610bcbd29191d535fef202af8d8b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"sitepackages \u003d True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[testenv:pep8]"},{"line_number":31,"context_line":"basepython \u003d python3"},{"line_number":32,"context_line":"commands \u003d"},{"line_number":33,"context_line":"    flake8"},{"line_number":34,"context_line":"    doc8 {posargs}"}],"source_content_type":"text/x-properties","patch_set":14,"id":"3f79a3b5_9e9d6159","line":31,"updated":"2018-08-29 18:06:38.000000000","message":"Since we want to use python3 in each testing environment, maybe we should set \"basepython\" in \"[testenv]\" section to be used as default?","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3ba49b67fbc348b048dbb4f03ba6aeda59c24c19","unresolved":false,"context_lines":[{"line_number":28,"context_line":"sitepackages \u003d True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[testenv:pep8]"},{"line_number":31,"context_line":"basepython \u003d python3"},{"line_number":32,"context_line":"commands \u003d"},{"line_number":33,"context_line":"    flake8"},{"line_number":34,"context_line":"    doc8 {posargs}"}],"source_content_type":"text/x-properties","patch_set":14,"id":"3f79a3b5_0c036bc0","line":31,"in_reply_to":"3f79a3b5_9e9d6159","updated":"2018-08-29 18:57:41.000000000","message":"Please see the commit message for the reason we do not want to do this.","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"}],"trove/cmd/common.py":[{"author":{"_account_id":28646,"name":"Dariusz Krol","email":"d.krol@samsung.com","username":"dkrol"},"change_message_id":"4655e0b7c9261b982600ab69c3e02e6e6fe6f8e1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    # Initialize localization support (the underscore character)."},{"line_number":19,"context_line":"    # Unicode flag is passed only for python2, because literal strings are"},{"line_number":20,"context_line":"    # unicode by default in Python3"},{"line_number":21,"context_line":"    import gettext"},{"line_number":22,"context_line":"    import six"},{"line_number":23,"context_line":"    if six.PY3:"},{"line_number":24,"context_line":"        gettext.install(\u0027nova\u0027)"},{"line_number":25,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_716036a6","line":22,"range":{"start_line":21,"start_character":4,"end_line":22,"end_character":14},"updated":"2018-08-23 12:24:01.000000000","message":"According to pep8:\nImports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants.\n\nIs there any rationale not to follow this rule?","commit_id":"cc58c4cb84c22aeeacdc9f8633bc815a81c237e5"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"178da68e6176cd27aaa08cd5ff484f5ed3eb18ce","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    # Initialize localization support (the underscore character)."},{"line_number":19,"context_line":"    # Unicode flag is passed only for python2, because literal strings are"},{"line_number":20,"context_line":"    # unicode by default in Python3"},{"line_number":21,"context_line":"    import gettext"},{"line_number":22,"context_line":"    import six"},{"line_number":23,"context_line":"    if six.PY3:"},{"line_number":24,"context_line":"        gettext.install(\u0027nova\u0027)"},{"line_number":25,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_5e609ea5","line":22,"range":{"start_line":21,"start_character":4,"end_line":22,"end_character":14},"in_reply_to":"3f79a3b5_716036a6","updated":"2018-08-23 19:28:53.000000000","message":"You are right but there was already imported gettext modeule in this place (see diff between patchsets base..3).\n\nAnyway, gettext should not be initialized here anymore.\nIt has been removed in change: https://github.com/openstack/trove/commit/87fd1c4b0ec1f0788c0e0478acf80e7e280c16a4\n\nI have rebased this change, but I left this piece of code unnecessarily during resolving conficts.\n\nRemoved it in a separate patchset.","commit_id":"cc58c4cb84c22aeeacdc9f8633bc815a81c237e5"}],"trove/common/base_wsgi.py":[{"author":{"_account_id":28713,"name":"Przemysław Godek","email":"p.godek@partner.samsung.com"},"change_message_id":"f6731475af34a1edb908b5fcccc168b89bf6dd37","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                _dtime \u003d obj - datetime.timedelta(microseconds\u003dobj.microsecond)"},{"line_number":456,"context_line":"                return _dtime.isoformat()"},{"line_number":457,"context_line":"            return obj"},{"line_number":458,"context_line":"#            return six.text_type(obj)"},{"line_number":459,"context_line":"        return jsonutils.dump_as_bytes(data, default\u003dsanitizer)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_ecb77384","line":458,"updated":"2018-09-06 08:47:21.000000000","message":"Do we need this line ?","commit_id":"8f750c1d3e5b33b59209c713b45e21bd56987be6"},{"author":{"_account_id":28713,"name":"Przemysław Godek","email":"p.godek@partner.samsung.com"},"change_message_id":"6fd22ae611ed5089e9b0d8ed99533f79ab34f0c6","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                _dtime \u003d obj - datetime.timedelta(microseconds\u003dobj.microsecond)"},{"line_number":456,"context_line":"                return _dtime.isoformat()"},{"line_number":457,"context_line":"            return obj"},{"line_number":458,"context_line":"#            return six.text_type(obj)"},{"line_number":459,"context_line":"        return jsonutils.dump_as_bytes(data, default\u003dsanitizer)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_5716ee5a","line":458,"in_reply_to":"3f79a3b5_148074f7","updated":"2018-09-10 08:48:32.000000000","message":"I mean line above ( with comment )","commit_id":"8f750c1d3e5b33b59209c713b45e21bd56987be6"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"7da02c68ef3d3e218ea57c2abec6d22529d18447","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                _dtime \u003d obj - datetime.timedelta(microseconds\u003dobj.microsecond)"},{"line_number":456,"context_line":"                return _dtime.isoformat()"},{"line_number":457,"context_line":"            return obj"},{"line_number":458,"context_line":"#            return six.text_type(obj)"},{"line_number":459,"context_line":"        return jsonutils.dump_as_bytes(data, default\u003dsanitizer)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_9a17cdef","line":458,"in_reply_to":"3f79a3b5_5716ee5a","updated":"2018-09-10 09:05:34.000000000","message":"Removed.","commit_id":"8f750c1d3e5b33b59209c713b45e21bd56987be6"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"6a0c4cbd93c6e32a953c2214b75e4ac2e45ae5ac","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                _dtime \u003d obj - datetime.timedelta(microseconds\u003dobj.microsecond)"},{"line_number":456,"context_line":"                return _dtime.isoformat()"},{"line_number":457,"context_line":"            return obj"},{"line_number":458,"context_line":"#            return six.text_type(obj)"},{"line_number":459,"context_line":"        return jsonutils.dump_as_bytes(data, default\u003dsanitizer)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_148074f7","line":458,"in_reply_to":"3f79a3b5_ecb77384","updated":"2018-09-10 07:53:39.000000000","message":"Yes. JSONDictSerializer is used for serializer in WebOb which expects bytes, not string.","commit_id":"8f750c1d3e5b33b59209c713b45e21bd56987be6"}],"trove/common/wsgi.py":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"dc595cccb421610bcbd29191d535fef202af8d8b","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        serializer \u003d {\u0027application/json\u0027: JSONDictSerializer(),"},{"line_number":631,"context_line":"                      }[content_type]"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        content \u003d serializer.serialize(self.content)"},{"line_number":634,"context_line":"        self.wrapped_exc.body \u003d content"},{"line_number":635,"context_line":"        self.wrapped_exc.content_type \u003d content_type"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_3ee20da2","line":633,"updated":"2018-08-29 18:06:38.000000000","message":"This is another place where we use JSONDictSerializer. Maybe we should encode in \"serialize\" method?\n\nAlso, check if encoding is necessary since JSONDictSerializer already returns bytes:\n\n class JSONDictSerializer(DictSerializer):\n     \"\"\"Default JSON request body serialization.\"\"\" \n\n     def default(self, data):\n         return jsonutils.dump_as_bytes(data)","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"687215cb38206d5c9292c8a1fc17b3d2cef728e1","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        serializer \u003d {\u0027application/json\u0027: JSONDictSerializer(),"},{"line_number":631,"context_line":"                      }[content_type]"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        content \u003d serializer.serialize(self.content)"},{"line_number":634,"context_line":"        self.wrapped_exc.body \u003d content"},{"line_number":635,"context_line":"        self.wrapped_exc.content_type \u003d content_type"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_9da9b525","line":633,"in_reply_to":"3f79a3b5_3ee20da2","updated":"2018-08-31 12:56:43.000000000","message":"There is a little mess with serialization methods.\n\nAs serializer, the trove.common.base_wsgi.JSONDictSerializer is used, not trove.common.wsgi.JSONDictSerializer as it looks at first glance (it is overridden by global variable).\ntrove.common.base_wsgi.JSONDictSerializer calls jsonutils.dumps, not jsonutils.dump_as_bytes. This is why we need to excplice convert string bo byte.\n\nI have removed serializer from trove.common.wsgi as it is not used at all, and changed dumps to dump_as_bytes in trove.common.base_wsgi.","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"}],"trove/guestagent/datastore/experimental/postgresql/service.py":[{"author":{"_account_id":28646,"name":"Dariusz Krol","email":"d.krol@samsung.com","username":"dkrol"},"change_message_id":"4655e0b7c9261b982600ab69c3e02e6e6fe6f8e1","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        :type user:               PostgreSQLUser"},{"line_number":839,"context_line":"        \"\"\""},{"line_number":840,"context_line":"        # Postgresql requires that you revoke grants before dropping the user"},{"line_number":841,"context_line":"        databases \u003d list(self.list_access(context, user.name, None))"},{"line_number":842,"context_line":"        for db in databases:"},{"line_number":843,"context_line":"            db_schema \u003d models.PostgreSQLSchema.deserialize(db)"},{"line_number":844,"context_line":"            self.revoke_access(context, user.name, None, db_schema.name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f1cf667c","line":841,"range":{"start_line":841,"start_character":20,"end_line":841,"end_character":25},"updated":"2018-08-23 12:24:01.000000000","message":"Why is it necessary to explicitly create a list? Isn\u0027t an iterable already?","commit_id":"cc58c4cb84c22aeeacdc9f8633bc815a81c237e5"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"178da68e6176cd27aaa08cd5ff484f5ed3eb18ce","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        :type user:               PostgreSQLUser"},{"line_number":839,"context_line":"        \"\"\""},{"line_number":840,"context_line":"        # Postgresql requires that you revoke grants before dropping the user"},{"line_number":841,"context_line":"        databases \u003d list(self.list_access(context, user.name, None))"},{"line_number":842,"context_line":"        for db in databases:"},{"line_number":843,"context_line":"            db_schema \u003d models.PostgreSQLSchema.deserialize(db)"},{"line_number":844,"context_line":"            self.revoke_access(context, user.name, None, db_schema.name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_62de263f","line":841,"range":{"start_line":841,"start_character":20,"end_line":841,"end_character":25},"in_reply_to":"3f79a3b5_f1cf667c","updated":"2018-08-23 19:28:53.000000000","message":"Actually it is. But it\u0027s not seen as itarable element by pylint - not-an-iterable (E1133).\nExplicit conversion to list tells pylint what a type in fact is it.","commit_id":"cc58c4cb84c22aeeacdc9f8633bc815a81c237e5"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"dc595cccb421610bcbd29191d535fef202af8d8b","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        :type user:               PostgreSQLUser"},{"line_number":839,"context_line":"        \"\"\""},{"line_number":840,"context_line":"        # Postgresql requires that you revoke grants before dropping the user"},{"line_number":841,"context_line":"        databases \u003d list(self.list_access(context, user.name, None))"},{"line_number":842,"context_line":"        for db in databases:"},{"line_number":843,"context_line":"            db_schema \u003d models.PostgreSQLSchema.deserialize(db)"},{"line_number":844,"context_line":"            self.revoke_access(context, user.name, None, db_schema.name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_5e7b49bd","line":841,"updated":"2018-08-29 18:06:38.000000000","message":"Why do we need \"list\" initializer?","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"687215cb38206d5c9292c8a1fc17b3d2cef728e1","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        :type user:               PostgreSQLUser"},{"line_number":839,"context_line":"        \"\"\""},{"line_number":840,"context_line":"        # Postgresql requires that you revoke grants before dropping the user"},{"line_number":841,"context_line":"        databases \u003d list(self.list_access(context, user.name, None))"},{"line_number":842,"context_line":"        for db in databases:"},{"line_number":843,"context_line":"            db_schema \u003d models.PostgreSQLSchema.deserialize(db)"},{"line_number":844,"context_line":"            self.revoke_access(context, user.name, None, db_schema.name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_dd5ded48","line":841,"in_reply_to":"3f79a3b5_5e7b49bd","updated":"2018-08-31 12:56:43.000000000","message":"pylint doesn\u0027t see it as itarable element - not-an-iterable (E1133).\nExplicit conversion to list tells pylint what a type in fact is it.\nOther way is ignore E1133 warnings in these lines.","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"}],"trove/guestagent/datastore/experimental/redis/service.py":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"dc595cccb421610bcbd29191d535fef202af8d8b","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            group_size \u003d 200"},{"line_number":366,"context_line":"            # Create list of slots represented in strings"},{"line_number":367,"context_line":"            # eg. [\u002710\u0027, \u002711\u0027, \u002712\u0027, \u002713\u0027]"},{"line_number":368,"context_line":"            slots \u003d list(map(str, range(first_slot, last_slot + 1)))"},{"line_number":369,"context_line":"            while slots:"},{"line_number":370,"context_line":"                cmd \u003d ([\u0027redis-cli\u0027, \u0027cluster\u0027, \u0027addslots\u0027]"},{"line_number":371,"context_line":"                       + slots[0:group_size])"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_3e576d29","line":368,"updated":"2018-08-29 18:06:38.000000000","message":"Why do we need \"list\" initializer?","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"687215cb38206d5c9292c8a1fc17b3d2cef728e1","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            group_size \u003d 200"},{"line_number":366,"context_line":"            # Create list of slots represented in strings"},{"line_number":367,"context_line":"            # eg. [\u002710\u0027, \u002711\u0027, \u002712\u0027, \u002713\u0027]"},{"line_number":368,"context_line":"            slots \u003d list(map(str, range(first_slot, last_slot + 1)))"},{"line_number":369,"context_line":"            while slots:"},{"line_number":370,"context_line":"                cmd \u003d ([\u0027redis-cli\u0027, \u0027cluster\u0027, \u0027addslots\u0027]"},{"line_number":371,"context_line":"                       + slots[0:group_size])"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_9d7e95ad","line":368,"in_reply_to":"3f79a3b5_3e576d29","updated":"2018-08-31 12:56:43.000000000","message":"pylint doesn\u0027t see it as itarable element - not-an-iterable (E1133).\nExplicit conversion to list tells pylint what a type in fact is it.\nOther way is ignore E1133 warnings in these lines.","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"}],"trove/guestagent/datastore/mysql_common/service.py":[{"author":{"_account_id":28713,"name":"Przemysław Godek","email":"p.godek@partner.samsung.com"},"change_message_id":"f6731475af34a1edb908b5fcccc168b89bf6dd37","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        # way than MySQL and PXC, which manifests itself as"},{"line_number":574,"context_line":"        # an invalid packet sequence.  Handle it as well."},{"line_number":575,"context_line":"        except pymysql_err.InternalError as ex:"},{"line_number":576,"context_line":"            if \"Packet sequence number wrong\" in str(ex):"},{"line_number":577,"context_line":"                raise exc.DisconnectionError()"},{"line_number":578,"context_line":"            else:"},{"line_number":579,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_ec13f363","line":576,"range":{"start_line":576,"start_character":9,"end_line":576,"end_character":57},"updated":"2018-09-06 08:47:21.000000000","message":"Don\u0027t we have other option than relying on Exception message ? Maybe it is good opportunity to do it right way.","commit_id":"8f750c1d3e5b33b59209c713b45e21bd56987be6"},{"author":{"_account_id":28713,"name":"Przemysław Godek","email":"p.godek@partner.samsung.com"},"change_message_id":"6fd22ae611ed5089e9b0d8ed99533f79ab34f0c6","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        # way than MySQL and PXC, which manifests itself as"},{"line_number":574,"context_line":"        # an invalid packet sequence.  Handle it as well."},{"line_number":575,"context_line":"        except pymysql_err.InternalError as ex:"},{"line_number":576,"context_line":"            if \"Packet sequence number wrong\" in str(ex):"},{"line_number":577,"context_line":"                raise exc.DisconnectionError()"},{"line_number":578,"context_line":"            else:"},{"line_number":579,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_ba15e93f","line":576,"range":{"start_line":576,"start_character":9,"end_line":576,"end_character":57},"in_reply_to":"3f79a3b5_b470a042","updated":"2018-09-10 08:48:32.000000000","message":"Ok. Let\u0027s create task for resolving such ugly handling","commit_id":"8f750c1d3e5b33b59209c713b45e21bd56987be6"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"6a0c4cbd93c6e32a953c2214b75e4ac2e45ae5ac","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        # way than MySQL and PXC, which manifests itself as"},{"line_number":574,"context_line":"        # an invalid packet sequence.  Handle it as well."},{"line_number":575,"context_line":"        except pymysql_err.InternalError as ex:"},{"line_number":576,"context_line":"            if \"Packet sequence number wrong\" in str(ex):"},{"line_number":577,"context_line":"                raise exc.DisconnectionError()"},{"line_number":578,"context_line":"            else:"},{"line_number":579,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_b470a042","line":576,"range":{"start_line":576,"start_character":9,"end_line":576,"end_character":57},"in_reply_to":"3f79a3b5_ec13f363","updated":"2018-09-10 07:53:39.000000000","message":"I agree this implementation is a little lit ugly, but refactoring is not the goal of this task.","commit_id":"8f750c1d3e5b33b59209c713b45e21bd56987be6"}],"trove/tests/api/mgmt/malformed_json.py":[{"author":{"_account_id":28713,"name":"Przemysław Godek","email":"p.godek@partner.samsung.com"},"change_message_id":"f6731475af34a1edb908b5fcccc168b89bf6dd37","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            else:"},{"line_number":76,"context_line":"                databases \u003d \"u\u0027%s\u0027\" % databases"},{"line_number":77,"context_line":"                users \u003d \"u\u0027%s\u0027\" % users"},{"line_number":78,"context_line":"            assert_contains("},{"line_number":79,"context_line":"                str(e),"},{"line_number":80,"context_line":"                [\"Validation error:\","},{"line_number":81,"context_line":"                 \"instance[\u0027databases\u0027] %s is not of type \u0027array\u0027\" % databases,"},{"line_number":82,"context_line":"                 \"instance[\u0027users\u0027] %s is not of type \u0027array\u0027\" % users,"},{"line_number":83,"context_line":"                 \"instance[\u0027volume\u0027] 3 is not of type \u0027object\u0027\"])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @test"},{"line_number":86,"context_line":"    def test_bad_database_data(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_4f47794d","line":83,"range":{"start_line":78,"start_character":0,"end_line":83,"end_character":65},"updated":"2018-09-06 08:47:21.000000000","message":"Same as already suggested, relying on exception message does not look right way.\n\nBelow also the same issue","commit_id":"8f750c1d3e5b33b59209c713b45e21bd56987be6"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"6a0c4cbd93c6e32a953c2214b75e4ac2e45ae5ac","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            else:"},{"line_number":76,"context_line":"                databases \u003d \"u\u0027%s\u0027\" % databases"},{"line_number":77,"context_line":"                users \u003d \"u\u0027%s\u0027\" % users"},{"line_number":78,"context_line":"            assert_contains("},{"line_number":79,"context_line":"                str(e),"},{"line_number":80,"context_line":"                [\"Validation error:\","},{"line_number":81,"context_line":"                 \"instance[\u0027databases\u0027] %s is not of type \u0027array\u0027\" % databases,"},{"line_number":82,"context_line":"                 \"instance[\u0027users\u0027] %s is not of type \u0027array\u0027\" % users,"},{"line_number":83,"context_line":"                 \"instance[\u0027volume\u0027] 3 is not of type \u0027object\u0027\"])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @test"},{"line_number":86,"context_line":"    def test_bad_database_data(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_b41ae0c3","line":83,"range":{"start_line":78,"start_character":0,"end_line":83,"end_character":65},"in_reply_to":"3f79a3b5_4f47794d","updated":"2018-09-10 07:53:39.000000000","message":"This is actually what this test do. It checks exception massage.\nAnyway, changing these tests is unrelevant for this change.","commit_id":"8f750c1d3e5b33b59209c713b45e21bd56987be6"}],"trove/tests/util/client.py":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"dc595cccb421610bcbd29191d535fef202af8d8b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return flavor, flavor_href"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def __getattr__(self, item):"},{"line_number":102,"context_line":"        if item \u003d\u003d \"__setstate__\":"},{"line_number":103,"context_line":"            raise AttributeError(item)"},{"line_number":104,"context_line":"        if hasattr(self.real_client, item):"},{"line_number":105,"context_line":"            return getattr(self.real_client, item)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_9e1fa16f","line":102,"updated":"2018-08-29 18:06:38.000000000","message":"Could you elaborate more on this? Why it is necessary?","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"687215cb38206d5c9292c8a1fc17b3d2cef728e1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return flavor, flavor_href"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def __getattr__(self, item):"},{"line_number":102,"context_line":"        if item \u003d\u003d \"__setstate__\":"},{"line_number":103,"context_line":"            raise AttributeError(item)"},{"line_number":104,"context_line":"        if hasattr(self.real_client, item):"},{"line_number":105,"context_line":"            return getattr(self.real_client, item)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_3d3c21e0","line":102,"in_reply_to":"3f79a3b5_9e1fa16f","updated":"2018-08-31 12:56:43.000000000","message":"In general there was raised \"RecursionError: maximum recursion depth exceeded\" exception when calling copy.deepcopy.\nThat was happening because Classes can use the same interfaces to control copying that they use to control pickling - https://docs.python.org/3/library/copy.html\nThat causes an infinite recursion loop.\n\nMore details here: https://stackoverflow.com/questions/47299243/recursionerror-when-python-copy-deepcopy","commit_id":"664f5a3c6e3cd258ccf0e19192ad302095be7b92"}]}
